Change-Id: I67d74072c776c32a1f91df94c621efe180baf5dc
Reviewed-on: https://gerrit.libreoffice.org/37481Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

* support of string arrays in the VBA AutoFilter
* tests:
  - reading string arrays
  - skip Criteria2 when Criteria1 is an array
  - use only last element of Criteria2 array

Change-Id: I8faf6af8c4fbf9b654885b31210ef77bae3a39af
Reviewed-on: https://gerrit.libreoffice.org/37515Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

and

coverity#1406100 Dereference null return value
coverity#1406099 Dereference null return value
coverity#1406098 Dereference null return value
coverity#1406097 Dereference null return value

Change-Id: I26d5c0f2e69dc049a87a607ca28586dc575a8ca3

that didn't work

This reverts commit 9905eb90.

Change-Id: Ia8d183fbf1c80964eabc10f1e363333133a4181c

Change-Id: I99211e2dc016fb97b6744799b35e05acd7470464

Change-Id: I52ad9ac6d43881a02c4817ea7527761105a12786
Reviewed-on: https://gerrit.libreoffice.org/37529Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

found by temporarily marking Reference as SAL_WARN_UNUSED.

Change-Id: I18809b62654467f890016adcc92576980ced393b
Reviewed-on: https://gerrit.libreoffice.org/37511Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Also
- rename SetOfByte to SdrLayerIDSet
- add asserts in SdrLayerAdmin::GetUniqueLayerID so that we don't
  allocate overlapping SdrLayerID values
- add a new constant SDRLAYERPOS_NOTFOUND to be returned from
  SdrLayerAdmin::GetLayerPos

Change-Id: I3bb3489f9338e3d02c4040bcbd811744699941c8
Reviewed-on: https://gerrit.libreoffice.org/37467Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I870ea69135ae293b00b9ae52f254d3f7f205a109
Reviewed-on: https://gerrit.libreoffice.org/37524Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I07aa1d2452dcdd891782707ae6928027e03f00e8
Reviewed-on: https://gerrit.libreoffice.org/37523Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I0d586b34323ad6e320974d8467520fcee116bd00

Was there any platform predefining it?

Change-Id: I4c155c00272b426c0d2b1b1ec0184cc223f9e38c
Reviewed-on: https://gerrit.libreoffice.org/37461Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

Calling InerpretTail during Hide rows by SfxHintId::ScDataChanged
broadcast

Change-Id: Ie78170bb6d49933a49d828a18637cb410796dc06
Reviewed-on: https://gerrit.libreoffice.org/37509Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

- Solves issue described in the bug where the legend calculation
  was not correct if using custom legend placing and the buttons
  were added to the legend (like in a pivot chart).
- Place the legend buttons horizontally if the legend is placed
  at the top or bottom (wide legend expansion), so the space is
  used more efficiently.
- Fix automatic placing of the legend when we have buttons at the
  bottom of the chart so that we don't cover them with the legend.
- It can happen that the button click is triggered when we resize
  the legend, so make sure we trigger only when mouse-down and
  mouse-up are on button.

Change-Id: I6a60e7885f7a2ddd6424b1cdfc22e8b046c89dd4
Reviewed-on: https://gerrit.libreoffice.org/37518Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I2762de031dc1b926e85630fe03bf7c1dbe936569
Reviewed-on: https://gerrit.libreoffice.org/37517Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

See commit 8fe8bd6c (Related: fdo#61594
SwWW8ImplReader::StartApo: don't always start a frame, 2013-05-13) for
the context, this is one more case where having a multi-page floattable
as a multi-page one is a better option.

The additional condition is that in case there is a break right after
the table, then always import the table as a non-floating one, as there
won't be any wrapping anyway (due to the break).

Change-Id: I3dd4174226cfc1e825c00607221feeed51b7133f
Reviewed-on: https://gerrit.libreoffice.org/37513Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

have another guess as fixing

    emit.cpp:1472: assertion failure: emit-ast.cpp:1123: assertion failed: Ran out of fields in aggregate initializer

Change-Id: I814c12c350cd1dbd58c25ada3a376477b5809c06

...which had been like that at least since
7b0b5cdf "initial import".

Change-Id: I16e3cc14ed459c5833f2bfa6ead3bec4e819db31
Reviewed-on: https://gerrit.libreoffice.org/37184Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

A new callback has been introduced for notifying the client:
LOK_CALLBACK_CELL_ADDRESS

Change-Id: I40b38a3cb8fb658c3f00332d56cfcbaf98e13771
Reviewed-on: https://gerrit.libreoffice.org/37357Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>

Problem:
Start/open a document in CS Writer, and enable track changes.

- Type a few characters.
- Delete a couple of them with backspace or delete.

=> The deleted characters are still shown in the document (but not in
the tracking comment).

Findings:
In SwViewShell::ImplEndAction pRegion is 0, so no call to
SwRootFrame::Paint->vcl::Window::Invalidate occurs.
That is due to the fact that the call to SwLayAction::Action() does
not lead to populating *pRegion with rectangles
(SwViewShellImp::AddPaintRect).
In fact we stop at SwLayAction::TurboAction_ since pCnt->IsValid()
returns true and so SwLayAction::PaintContent() is never invoked.
SwFrame::IsValid() returns: mbValidPos && mbValidSize &&
mbValidPrtArea.
Here SwFrame::mbValidSize is the one that makes the difference: it is
true in Online and false in Desktop. (In our case the other 2 data
members are always true).
The reason is that the computation of the text range
(SwShellCursor::FillRects) in SwRedlineTable::LOKRedlineNotification,
which occurs just before collecting paint rectangles, leads to invoke
SwContentFrame::MakeAll which in turns set SwFrame::mbValidSize to
true.

Solution:
Call SwFrame::InvalidateSize() on any frame on which MakeAll is
invoked soon after we finish to compute the text range in
SwRedlineTable::LOKRedlineNotification.

Change-Id: Id5e29b06c044f14207722e67d6f5facbf786ffa6
Reviewed-on: https://gerrit.libreoffice.org/37508Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: I109f95a55875b7795fc366825b3a6bb2e897d676

See commit 8b77e279

Change-Id: I5f9d4a566377f8e7a59f12b138cc612e710efbdf
Reviewed-on: https://gerrit.libreoffice.org/37356Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Ic1e953b5bcae6124ee6ce7d141ddac11a94b2a8b
Reviewed-on: https://gerrit.libreoffice.org/37464Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I204178ed4cf0fd3f43043cf1dfde85bb27002fee
Reviewed-on: https://gerrit.libreoffice.org/37498Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Created new show/hide all comments button for calc by
ShowAnnotations command. Unifyied writer, calc and impress's
ShowAnnotations slot.

Change-Id: I27149d09ee1763b84258c5e0c890a9628c8874c0
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/36697Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: Ibd529c5db35f2ca64372629ab1fe0ecd08e2ea01

In a formula like ='ExtRef1' & 'ExtRef2', or ='LocalValue' & 'ExtRef1'
empty string became an operand in concat operation if the referenced
external cell was a non-string one.

Change-Id: I7b0ac5de68349eae85afe48f377e30cab76e3fbf
Reviewed-on: https://gerrit.libreoffice.org/37469Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

Project: dictionaries  e46b2a46dd51843bc388a6355bb54eafbbf864b9

Remove executable flag on txt files

Change-Id: Ie2874c2178a61b02de378a574bd8a963b9c54163
Reviewed-on: https://gerrit.libreoffice.org/37510Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ib8ce5b83d711e4425bb9f441b8d495a05af820bf
Reviewed-on: https://gerrit.libreoffice.org/37501Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I573c8c82998935e4853a3ee3f635845d450e32fe

otherwise the query will call make_unique to make this a unique
copy of the underlying shared font which is a waste if the
contents are going to be the same and the if branch contents
are skipped.

I was tempted to call the Font accessors like GetLanguage, etc.
but a bunch of the accessors have two versions, a const and non-const
one which behave differently so that looks like another rats nest

This relates to the changes of

commit 188439aa
Date:   Fri Apr 22 23:43:52 2016 +0200

    tdf#62525 vcl: use cow_wrapper for font

Change-Id: Ic0661fccb414b3636308975e265fe5751476e1b8
Reviewed-on: https://gerrit.libreoffice.org/37502Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Since this canSign/canEncrypt is fundamentally busted in gpgme,
outright limit all keys we're looking at to those with secrets.

Change-Id: Ib3dfbc8ef661430efc3a8c17f2f3166af8225a56
Reviewed-on: https://gerrit.libreoffice.org/37471Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I5760af990e62cff357cdd2b80db0b129a96a857e
Reviewed-on: https://gerrit.libreoffice.org/37491Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I85fc05d53c2d53a4922d8322331247ed3ca21361
Reviewed-on: https://gerrit.libreoffice.org/37493Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Ifa287b96f47b5e61eb43289a20a1102ed37c6722
Reviewed-on: https://gerrit.libreoffice.org/37492Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I0fe20381756dcc891c60fbf03f3cfd91719cdc61
Reviewed-on: https://gerrit.libreoffice.org/37490Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

double quote to prevent word splitting

Change-Id: Ice4380cc390487277a359b8db3f2fae3603b7747
Reviewed-on: https://gerrit.libreoffice.org/37466Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I96043623a5b0e26ddc44de5c71743f3b0d8e1e50

Change-Id: I8f2abf0d338d01453f273b279e34c882de461b00