- 07 Kas, 2018 23 kayıt (commit)
-
-
Noel Grandin yazdı
regression from commit 9ec8bf8f add SvStream::TellEnd the problem is that in this stack trace sot/source/sdstor/stgelem.hxx:130 sot/source/sdstor/stgdir.cxx:300 sot/source/sdstor/stg.cxx:245 sot/source/sdstor/storage.cxx:187 tools/source/stream/stream.cxx:1908 sw/source/filter/ww8/ww8scan.cxx:6267 The StgEntry returns a size of 0. If we do something else to the SotStorageStream first, then it materialises a temporary stream, and that stream returns a valid size. Also implement suggestions from mike kaganski: IMO, it would be more robust to implement this new function as virtual (instead of the remainingSize()), and reimplement the latter as non-virtual one using the new one and doing the necessary correction. Change-Id: Id1462d918570a684ec67099c30181436a27d3c6a Reviewed-on: https://gerrit.libreoffice.org/62984 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Miklos Vajna yazdı
Fails with commit ac27f4e7 (tdf#117137: DOCX import: don't try to set grab-bag as UNO prop, 2018-04-21) reverted. Change-Id: Ice5f9831234ba7ba72a730ea6e33648a339a2a88 Reviewed-on: https://gerrit.libreoffice.org/62998Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
-
Noel Grandin yazdı
tb72 fails this regularly Change-Id: I4c5fb8f4955e8479c31d0a3b67123b34ecc889aa Reviewed-on: https://gerrit.libreoffice.org/62993 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Michael Weghorn yazdı
Change-Id: Ie35a1f526d449989cadbbda4bf87e4b96cbcb8ef Reviewed-on: https://gerrit.libreoffice.org/63012 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
-
Miklos Vajna yazdı
Allows not spelling out the test names 3 times. Change-Id: I394bd4c796cb2bc65cacd9f61bd37162db48a810 Reviewed-on: https://gerrit.libreoffice.org/62976 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
-
Miklos Vajna yazdı
Added upstream as <https://cgit.freedesktop.org/libreoffice/cppunit/commit/?id=48145587c4c2dc4f1e07d83073e136336c81ce79>. Change-Id: If3adbad3187e3d2b4319be7b295b41d5b7e9c08d Reviewed-on: https://gerrit.libreoffice.org/62975 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
-
Caolán McNamara yazdı
Change-Id: I826088ed85f2503e41315aacc72947a41dc9cd26 Reviewed-on: https://gerrit.libreoffice.org/62992 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Noel Grandin yazdı
Change-Id: I188d9e9b53e00acfbae3c7acd54de28f084c4b3f Reviewed-on: https://gerrit.libreoffice.org/62985 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Caolán McNamara yazdı
Change-Id: I27e822ac2432eb2746ed9181cee158012e54252e
-
Andrea Gelmini yazdı
Change-Id: Id6f5edca053048540b57fd9871aabd1c71f9b64f Reviewed-on: https://gerrit.libreoffice.org/62902Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
-
Mark Dobo yazdı
+simplifying variable assignment Change-Id: I2f43783d6e58c16f9200d44f7f34b05974ee0772 Reviewed-on: https://gerrit.libreoffice.org/62970Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
-
Noel Grandin yazdı
regression from commit f74b8882 simplify PlusHdl logic restore the structure of the original code here, which is completely opaque to me Change-Id: I7b9e5732bd7ed0a92627503ea3c7d2d320a8a33b Reviewed-on: https://gerrit.libreoffice.org/62989 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
andreas kainz yazdı
Change-Id: I13309fa47130455a0f58b027b7815e3c24019d40 Reviewed-on: https://gerrit.libreoffice.org/62982 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
-
Noel Grandin yazdı
code originally from vmiklos, copied from dev-tools repo Change-Id: Iadc2388fec888dde38cb4d59c78691dc1ea94c09 Reviewed-on: https://gerrit.libreoffice.org/62983 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Icc3cb8118b225c9b19b451b2a6463c844ef4162d Reviewed-on: https://gerrit.libreoffice.org/62459 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
-
Tomaž Vajngerl yazdı
Change-Id: If164d0edc9343b1db5ee96a2da46c9436ddbc73f Reviewed-on: https://gerrit.libreoffice.org/62776 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I61e32f6ecaf72d51528af4b067d651a17691d4b1 Reviewed-on: https://gerrit.libreoffice.org/62986 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Vasily Melenchuk yazdı
Change-Id: I43d14025c48878c5bc035d492623f4fc52426e5e Reviewed-on: https://gerrit.libreoffice.org/62752 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
-
Arkadiy Illarionov yazdı
Use range-based loop or replace with STL functions Change-Id: Ib4a0da0c452dbfa00a1d7ec79f9570e41eda0d41 Reviewed-on: https://gerrit.libreoffice.org/62893 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I0751c9d3f379a3621bdc7ccce6a0d58c701a0261 Reviewed-on: https://gerrit.libreoffice.org/62955 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I06bcf6b33af5c6eddb614f1f0ce1b2713876b162 Reviewed-on: https://gerrit.libreoffice.org/62954 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I3068b18f5cff024a48a8f8c68d69cadad30fe4d5 Reviewed-on: https://gerrit.libreoffice.org/62953 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Rizal Muttaqin yazdı
Change-Id: I5e9a4095ce3e114cfb6818264f669c7ac6207ad5 Reviewed-on: https://gerrit.libreoffice.org/62960Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins
-
- 06 Kas, 2018 17 kayıt (commit)
-
-
andreas kainz yazdı
Change-Id: I14634cda6d1edcf81ef665d48dd27cabd752571c Reviewed-on: https://gerrit.libreoffice.org/62981 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
-
Markus Mohrhard yazdı
Change-Id: Ie7d728cd36c93d5f398266ee65be0e1bf14a0c97 Reviewed-on: https://gerrit.libreoffice.org/62974 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
-
Johnny_M yazdı
Change-Id: Id4eee662715246bf58653287fed5ecb954e88dfc Reviewed-on: https://gerrit.libreoffice.org/62836 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
-
Johnny_M yazdı
Change-Id: I9f895b7d0a2317a8518dfa7e51e437e54dfb0c13 Reviewed-on: https://gerrit.libreoffice.org/62844 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
-
Lionel Elie Mamane yazdı
Unless the underlying column is not nullable and has no default value this is only a guess, form designer can change it Change-Id: Ifa403e00b21fdaf86aef383503d54879b25ac62b Reviewed-on: https://gerrit.libreoffice.org/62969Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
-
Sophia Schröder yazdı
* Update helpcontent2 from branch 'master' - related: tdf#121173: double space cleanups ..and some more improvements (hopefully) Change-Id: I17e6656ff0f0274c342b62e72405d396437c8964 Reviewed-on: https://gerrit.libreoffice.org/62923 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
-
Jan Holesovsky yazdı
Change-Id: I47e67b680a6abdb66020b295f55ee6a73b7b5608 Reviewed-on: https://gerrit.libreoffice.org/62956 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
-
Tomaž Vajngerl yazdı
As the certificate chain can be added after the document was opened, we need to trigger signature verification every time the LOK API method getSignatureState is called. In addition update the tests so that they check the status of a document that's not signed, a document that was signed but the certificate chain is not available so the verification fails and later adding the certificate chain and the verification returns an OK status. Change-Id: I44578d0cece5bfc4a2e43fbbcd68b5ea1ccbc38b Reviewed-on: https://gerrit.libreoffice.org/62276 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
-
Tor Lillqvist yazdı
It was used to initialise a virtual device pixel buffer to an "interesting" pattern, in case actual rendering to it failed. But it hasn't been needed in a while. And similar code can always be added temporarily if needed, no need to keep permanently, even in #ifdef DBG_UTIL. Change-Id: I650afcb811b903ce3d6d50b9f1eb38c83be68df5 Reviewed-on: https://gerrit.libreoffice.org/62962 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
-
Xisco Fauli yazdı
Regression from 9348b322 Change-Id: Ibf9d6b65f0dbcc3a751e3ac5f3dbc28d908d6c25 Reviewed-on: https://gerrit.libreoffice.org/62952Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
-
andreas kainz yazdı
Change-Id: Iad363da3955625c696de843d0a859904e189376c Reviewed-on: https://gerrit.libreoffice.org/62792 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
-
Samuel Mehrbrodt yazdı
Change-Id: I720d7d4920ae9c2f5d74ad827e1e214a62fe81a9 Reviewed-on: https://gerrit.libreoffice.org/62947 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6ca0168abc71b4d9b6d332dc0fd8a3c779fdaa87 Reviewed-on: https://gerrit.libreoffice.org/62524 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
-
Andras Timar yazdı
Change-Id: I3258268b12cb0914a5e8d1c9b57d7891e83080c6 Reviewed-on: https://gerrit.libreoffice.org/62951Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
-
Andras Timar yazdı
Change-Id: I2b9ea77b48673af3575a3142feea5bed84f75d74 Reviewed-on: https://gerrit.libreoffice.org/62950Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
-
Patrick Jaap yazdı
Do not move graphic nodes in SwXText::convertToTextFrame() since it is not reasonable (they are anchored to something that already moved) and hence it causes errors. A static function checks wether the current node is a graphic. A small change in writerfilter was done since a unit test failed: The condition "m_nAnchorType != 0" was removed since it is not reasonable at this place. Change-Id: I8f27985f6f6c8329483370a7b8baaf9949513f1b Reviewed-on: https://gerrit.libreoffice.org/60860 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
-
Noel Grandin yazdı
by avoiding taking the mutex Also reduce the code that the mutex covers to the minimum necessary. Change-Id: I115c8a447ec17f4800c39557e8de0bc8c669b47b Reviewed-on: https://gerrit.libreoffice.org/62936Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
-