V668 There is no sense in testing the 'pProc' pointer against null, as the
     memory was allocated using the 'new' operator. The exception will be
     generated in the case of memory allocation error.

Change-Id: Iec65fd44fa947a2402da33510c29730a46c2e1a4
Reviewed-on: https://gerrit.libreoffice.org/62424
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ifc9fcc718b318c439484a6cc98a4e71c8d445fd8
Reviewed-on: https://gerrit.libreoffice.org/62417Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
Tested-by: Jenkins

Change-Id: Idb60b43bd04ab9e7c75c144ebf2b1626e13d34b6
Reviewed-on: https://gerrit.libreoffice.org/62418
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: I88bd4777e973b43edfc7e6d1123cef5c6bb2d7ea
Reviewed-on: https://gerrit.libreoffice.org/62423
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

V519 The 'aToken.aText' variable is assigned values twice successively.
     Perhaps this is a mistake. Check lines: 1147, 1163.

Change-Id: I9bcb9a302a182932d7b15f25ee64005158d50a46
Reviewed-on: https://gerrit.libreoffice.org/62422
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V519 The 'mbDesignMode' variable is assigned values twice successively.
     Perhaps this is a mistake. Check lines: 731, 737.

Change-Id: I20cb70e050f194e7ab02de92dff4db35cade7386
Reviewed-on: https://gerrit.libreoffice.org/62421
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I51a82ce5fc09d44ebc6f7c06c67b475ee2adf68b
Reviewed-on: https://gerrit.libreoffice.org/62419Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins

V519 The 'm_nFetchDirectionPropertyHandle' variable is assigned values twice
     successively. Perhaps this is a mistake. Check lines: 489, 493.

It was this way since 2000 (commit d3329bac)

Change-Id: Ia6ade4355bbfac799f8b32069f27a0c439300030
Reviewed-on: https://gerrit.libreoffice.org/62414
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ifc170a45e25b3fd5b7f561cc50afb6452bb359bd
Reviewed-on: https://gerrit.libreoffice.org/62420
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

* Update translations from branch 'master'
  - update translations for master
    
    and force-fix errors using pocheck
    
    Change-Id: Ib2c4218faaa153151595024d052cc93d32037d4b
    

Change-Id: Ib73d09b648c0663de57e4b205e7154d6af1366f8
Reviewed-on: https://gerrit.libreoffice.org/62412
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

V524 It is odd that the body of 'GetRef2' function is fully equivalent
     to the body of 'GetRef1' function.

Was that way since 2007 (commit 6002b499)

Change-Id: Iff75ebafd13ce47c23c80be8bc6b5995954b524f
Reviewed-on: https://gerrit.libreoffice.org/62415Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Now with storage capabilities too

Change-Id: Iaf9050b38ce356d80c26f339caf61267c1fb3c3b
Reviewed-on: https://gerrit.libreoffice.org/62360Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins

V519 The 'hResult' variable is assigned values twice successively.
     Perhaps this is a mistake. Check lines: 1097, 1098.

Change-Id: Ib6f9c3467578ebc68b3a15f8dbea4054af45707d
Reviewed-on: https://gerrit.libreoffice.org/62411Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

V519 The 'aNewTextBoundingBox.Y2' variable is assigned values twice
     successively. Perhaps this is a mistake. Check lines: 409, 411.

I have tried to check if that could possibly be a typo, and X1 was meant,
but it seems to be not the case here (doing that, or putting anything to
X1 instead of 0, just displaces the notes in the presenter console wrong
vertically).

Change-Id: Ie686b69bddc193568c1b5c0d18b9b7bf547313d1
Reviewed-on: https://gerrit.libreoffice.org/62410
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V519 The 'xFontCharMap' variable is assigned values twice successively.
     Perhaps this is a mistake. Check lines: 1673, 1674.

Change-Id: I008c268bd2440e489d4cd50f94b4f04129589448
Reviewed-on: https://gerrit.libreoffice.org/62408Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

in writer and calc

Change-Id: I36458c27027748c790a5e6ef768fcd19986b656d
Reviewed-on: https://gerrit.libreoffice.org/62336
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Thanks for the suggestion Miklos

Change-Id: Ie37259a1f05919fa50194afde7171efbe5473771
Reviewed-on: https://gerrit.libreoffice.org/62409
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: I9265425a215609ef6bf4298ba39c8399f215ce27
Reviewed-on: https://gerrit.libreoffice.org/62406
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

As described in the QMenuBar documentation,
a single ampersand in a menu item text is used to
set the shortcut for the menu, while "&&" is used to
get a real ampersand character.

Change-Id: Idf510641c8919ff8223114413851cb3ee7d7b4a2
Reviewed-on: https://gerrit.libreoffice.org/62405
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

Change-Id: I4b6a2eb32ff155855bb9e5d1638f7239252278f3
Reviewed-on: https://gerrit.libreoffice.org/62301
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

introduced with 4d7dd4e1

Change-Id: I118b6185fc01b2234d2a20da76b0e19929f9812a

According to Qt doc, setScreen by itself is ineffective and this
additional step is needed. It still wouldn't work w/ dual screen
on older KDE Plasma (<= 5.12) but tests positively in GNOME and
Plasma 5.13.5

Change-Id: I080b6f93aa3c21411f606ade6df42e9bc3f6f299
Reviewed-on: https://gerrit.libreoffice.org/62351Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>

Both horizontal size and position looks sane now.

Change-Id: I6f040e4f0ff49be74420fafc4bcc5e899b6e94f7
Reviewed-on: https://gerrit.libreoffice.org/62397Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: I2b75dce78ad8a955aa6f94ea5d225a79ae0e2dc6
Reviewed-on: https://gerrit.libreoffice.org/62392
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Finally the "parent text" of the test document now has correct width.

Change-Id: I05c552dda66ad91f19cfc335b464549920269f69
Reviewed-on: https://gerrit.libreoffice.org/62395Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: Ie0b476164b370f58e0b220cee56ed52896753ade
Reviewed-on: https://gerrit.libreoffice.org/62394
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

This prevents overwriting the existing logfile by
using the same logger as unopkg does.

Change-Id: Iaad4c5b99a4f428d3a4ad8a046c88404aecb5652
Reviewed-on: https://gerrit.libreoffice.org/62393
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I159b7e85f53e33c5359cca83aa958387d888f6a2
Reviewed-on: https://gerrit.libreoffice.org/62391
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ifbc2b127998e037be3f014bebf8721bef15ef53b
Reviewed-on: https://gerrit.libreoffice.org/62385
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

(ASCII and typographical) and for enclosing quotes of string literals.

Change-Id: I3caf3b707afa1fb41ba3afe9ff12ebce7ce63847
Reviewed-on: https://gerrit.libreoffice.org/62384
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Change-Id: I57dfc006d849918179a2398ef22be7585cb0993f

So match can be checked with IFNA(REGEX(...);...) and
IF(ISNA(REGEX(...);FALSE();TRUE())

Change-Id: I2b75dce78ad8a955aa6f94ea5d225a79ae0e2dc5
Reviewed-on: https://gerrit.libreoffice.org/62386Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I444c43b9d549977039f25bec2b5bf666c3e15e0e
Reviewed-on: https://gerrit.libreoffice.org/62041
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

<https://ci.libreoffice.org//job/lo_ubsan/1082/>:
> ==26422==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x604000accc72 at pc 0x2ae43e63f4b6 bp 0x2ae43e600510 sp 0x2ae43e600508
> READ of size 1 at 0x604000accc72 thread T70 (cppu_threadpool)
>     #0 0x2ae43e63f4b5 in Guess::Guess(char const*) /lingucomponent/source/languageguessing/guess.cxx:95:28
>     #1 0x2ae43e667f2f in SimpleGuesser::GetManagedLanguages(char) /lingucomponent/source/languageguessing/simpleguesser.cxx:169:19
>     #2 0x2ae43e668420 in SimpleGuesser::GetAvailableLanguages() /lingucomponent/source/languageguessing/simpleguesser.cxx:179:12
>     #3 0x2ae43e64a18e in LangGuess_Impl::getEnabledLanguages() /lingucomponent/source/languageguessing/guesslang.cxx:229:24
[...]
> 0x604000accc72 is located 0 bytes to the right of 34-byte region [0x604000accc50,0x604000accc72)
> allocated by thread T70 (cppu_threadpool) here:
[...]
>     #7 0x2ae43e65350a in std::string::operator+=(char const*) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/bits/basic_string.h:3355:16
>     #8 0x2ae43e667e6e in SimpleGuesser::GetManagedLanguages(char) /lingucomponent/source/languageguessing/simpleguesser.cxx:168:21
>     #9 0x2ae43e668420 in SimpleGuesser::GetAvailableLanguages() /lingucomponent/source/languageguessing/simpleguesser.cxx:179:12
>     #10 0x2ae43e64a18e in LangGuess_Impl::getEnabledLanguages() /lingucomponent/source/languageguessing/guesslang.cxx:229:24
[...]

shows, during UITest_librelogo, the Guess ctor making wrong assumptions about
the structure of guess_str and skipping over the terminating NUL.  Locally I
could see that while most inputs do have the expected syntax of starting with
"[" and containing two "-", one input is indeed just "[haw-utf8" without a
second "-".

I don't know where the strings passed into the Guess ctor in the two places in
lingucomponent/source/languageguessing/simpleguesser.cxx ultimately come from,
and what their guaranteed syntax and their semantics is.  So from the existing
code and the non--well-formed "[haw-utf8" sample (where the second segment shall
apparently designate an encoding, not a country), construct rules how to
robustly parse any input into potential language/country/encoding parts.  (What
is obvious from the call sites is that for one each input will start with "[",
and for another the item to parse need neither be "]"- nor NUL-terminated.)

(Guess::encoding_str and the local enc variable have effectively been unused
ever since the code's introduction in 07628119
"INTEGRATION: CWS languageguessing".  Guess::encoding_str, but not the local
enc variable, got later removed with b275246c
"loplugin:unusedfields in formula..registry".)

Change-Id: Icbedc05ed5b119ee4efbc3118cc17076a4d80c74
Reviewed-on: https://gerrit.libreoffice.org/62390
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I9230421a98ea5d1ec61bf1500b24949635db68d3
Reviewed-on: https://gerrit.libreoffice.org/62387
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>

and fix a handful of small leaks in the process

Change-Id: I876e12ff5305f9dda84532d4182fb91657d6fa0c
Reviewed-on: https://gerrit.libreoffice.org/62389
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

look for any kind of types, not just POD types, helps to find
smart pointer fields that are only assigned nullptr

Change-Id: I2d887e98db012f03b646e1023985bcc196285abc
Reviewed-on: https://gerrit.libreoffice.org/62382
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I36d3e874aac2d57d4e6f24a0e89c9836704bb7a6
Reviewed-on: https://gerrit.libreoffice.org/62383
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This will write log messages as plain text (no timestamp and other stuff
like PlainTextFormatter).
Warnings and errors will be prefixed accordingly.

Change-Id: Id82512d7dd3907a4c7cd69a963a375966189dc20
Reviewed-on: https://gerrit.libreoffice.org/62370
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>