In two cases we need to traverse and gather all ImageURL properties
and get the URL string and store the graphic content to a storage
(like we do in xmloff filter). ImageURL property can now only store
external URL and Graphic stores the embedded XGraphic, so this was
changed to look into Graphic property first and then ImageURL.

We also don't gather URL sting anymore so they need to be loaded
to XGraphic when gathering them.

Change-Id: I5f3f4be2b403b9589d72b8733df0c97109f2b65d
Reviewed-on: https://gerrit.libreoffice.org/51308Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

In addition change from map to unordered_map.

Change-Id: Ief33d6ebd7e42606ab20fcf9fc91020b1ef9aab6
Reviewed-on: https://gerrit.libreoffice.org/51306Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Ic81bf1a5ce45394e098366d0f4af53845ba0da87
Reviewed-on: https://gerrit.libreoffice.org/51307Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Ib24d9c434f1f19fe7bca51235f6c6125d5c97a7c
Reviewed-on: https://gerrit.libreoffice.org/51305Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I52e134532ab70e765b6ccd929f189be84f9c9a90
Signed-off-by: Mert Tümer <merttumer7@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/51286Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I50a3b26cc4a6b6c82aee0d0175c01fae85050b85
Reviewed-on: https://gerrit.libreoffice.org/51304Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ic69e561a0ce458c7e8bc5bdf10b932426f137957
Reviewed-on: https://gerrit.libreoffice.org/51303Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ic628811e7efd15cb85e0d0336ce9173e0fb1349a
Reviewed-on: https://gerrit.libreoffice.org/51300Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>

"Time Stamp Authority:" labels 'tsa', not 'reason'.

Change-Id: I60c007b04591a534323d0a86bb19475f27953107
Reviewed-on: https://gerrit.libreoffice.org/51290Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>

This is needed for proper accessibility labelling.

Change-Id: I11830d16816a471c1531012a18be81e5f8d136a9
Reviewed-on: https://gerrit.libreoffice.org/51287Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: Id52c9efdc42f2813600d2ec048687eeb9fd57c49
Reviewed-on: https://gerrit.libreoffice.org/51299Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>

The pSpecialPos is set for the StartTag case (#i75130#) and I surmise
we only care about it if we are a smarttag

Change-Id: Ic764bbf31a7784ab021f306f74a08473c8dd0a77
Reviewed-on: https://gerrit.libreoffice.org/51281Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I77425c04612b52b9202774339961e22e3e84ddd3
Reviewed-on: https://gerrit.libreoffice.org/51271Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I3cdc41b937e6c974ab6f953b7a9a834328905b17
Reviewed-on: https://gerrit.libreoffice.org/51238Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Not only by hitting the (invisble) frame or the text content.

Change-Id: I125f76a102611b628411d8c5acf70e3ed9e5e8fe
Reviewed-on: https://gerrit.libreoffice.org/51276Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I40cd0538b573c2d090f56424e1110b938981a878
Reviewed-on: https://gerrit.libreoffice.org/51292Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: Ifc64d9a3b5c93b83fa238737375e7a58b2ae86db
Reviewed-on: https://gerrit.libreoffice.org/51262Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

Change-Id: Ie9b4fc71c7f262f896b69bbf4747f08e160447d7
Reviewed-on: https://gerrit.libreoffice.org/51275Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

work-around gdb bug, and deal with different representations of
std::unique_ptr in different versions of libc++.

Change-Id: I02a1f49c07dbcd70e13ef6be48e20b510bf5e3fa

after
    commit 00431a8a
    Date:   Tue Mar 13 11:57:33 2018 +0200
    loplugin:useuniqueptr in SvxEntries

Change-Id: Ia115454522b87db93cefcbd89ca5d965f9b431c7

https://wiki.openoffice.org/wiki/Writer/MSInteroperability/PageBorder
discusses implementation differences between ODF model and MS formats
wrt dealing with page margins and distances to borders.

This patch corrects import from DOCX, so that the border distance and
width doesn't add to the margin size imported from file anymore. It
takes care to preserve size from page edge to text (the most important
size that affects document layout). When borders go outside of range
valid for ODF, the margin is set to keep text area intact, and the
border is placed as close to intended position as possible.

Export code now also properly handles border width. Also, an improved
heuristic implemented to better export cases unsupported by Word, so
that the result would look closer to ODF original. We still write
correct sizes to OOXML, so that when reopened by LO, the borders will
be in correct places; but as Word cannot handle sizes more than 31 pt,
it will show borders shifted.

This prevents from adding border widths and distances to page margins
at each opening of DOCX, saving back the changed value, increasing
the margins each time.

Change-Id: Ia978ab119dd661949d6c321aea91397f28d205b0
Reviewed-on: https://gerrit.libreoffice.org/51267Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

only the requested footnote numbers, allowing grammar
checking of automatic references with affixes, articles etc.

Expanded fields get also a starting ZWSP character
for more precise grammar checking.

(Partial revert of commit d477ff4a)

Change-Id: I78ab02cc8cf98d665e7f9ddc740879c203f2f7e4
Reviewed-on: https://gerrit.libreoffice.org/51228Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: László Németh <nemeth@numbertext.org>

Breaks Android tinderbox

This reverts commit 31e939c9.

Change-Id: Id565c9ef8330c0b3bce2c678facb7605dcf3e356

Change-Id: Ibe23377c7752d9ce97c7b100af4b2759b3ce946f
Reviewed-on: https://gerrit.libreoffice.org/51241Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

...to 048a32d9 "use unique_ptr for pImpl in
tools/", exploiting intimate knowledge of libstdc++ internals as was already
done in 51bb6892 "fix BigPtrArray pretty
printer".

Due to <https://sourceware.org/bugzilla/show_bug.cgi?id=22968> "ptype does not
find inner C++ class type without -readnow", at least for me only works when gdb
is invoked with -readnow.

Change-Id: I365733f3c661eea2f19a9b85015aa5d50e63e6a4

Adding a timeout seems to help Windows a lot to actually bring
the browser into the front, especially when it was closed before.

Still no 100% success rate, but much improved now.

Change-Id: I62affee4b837e0a60b1aac2a20be6fe7c3f9d2e0
Reviewed-on: https://gerrit.libreoffice.org/51132Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I3ce653c0d9e517229dbbe32cc8d3ec3c206e364d
Reviewed-on: https://gerrit.libreoffice.org/51273Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I017dc2e5270d86b2168faf3f9240eeded1fc3533
Reviewed-on: https://gerrit.libreoffice.org/51272Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This is used in parsing of meta Contexts across different
modules. This also involved moving to XFastParser for
parsing xml filters in sw, sd, starmath.

Change-Id: Ic663aaac6cb20ee8ce5b97cae87c93220f5a2929
Reviewed-on: https://gerrit.libreoffice.org/42989Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I7c780be3e2740fd9b03c39ebe16935d61caf4f7e
Reviewed-on: https://gerrit.libreoffice.org/51257Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I321a731585879374cc13a992dd3afaa23b8712e0
Reviewed-on: https://gerrit.libreoffice.org/51269Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Namespace prefix was missing here.

Change-Id: Id746d47713b22e2efd5d679c2325b32a0bee8a09
Reviewed-on: https://gerrit.libreoffice.org/51270Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ib5a1da6666ff3a136c05374f10b7ca138c14492d

...in efcb9a70 "use sw::WriterMultiListener
instead of SwDepend in SwPageDesc", causing

> /sw/source/core/layout/pagedesc.cxx:198:74: runtime error: upcast of misaligned address 0xbebebebebebebebe for type 'SwTextFormatColl', which requires 8 byte alignment
> 0xbebebebebebebebe: note: pointer points here
> <memory cannot be printed>
>     #0 0x2b06bea9116b in SwPageDesc::GetRegisterFormatColl() const /sw/source/core/layout/pagedesc.cxx:198:74

during e.g. CppunitTest_sw_odfimport of ASan+UBSan builds.

Change-Id: If50a920ca5dafdce6c1a3e2fbf540488685e641a

Project: help  781da1e8175459f27cca84bed2ca209b3e030067

tdf#99611 improve function AND() documentation

Added details on handling non logical arguments in
Calc logical functions.

Change-Id: I416fbe9443777a7a7bdfa9d3f61bdf072aff476b
Reviewed-on: https://gerrit.libreoffice.org/51176Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Project: dictionaries  3bc3ffdb0b622cc07b5d959225a9f2223afdf145

Hungarian grammar checking rules v1.6.3

Change-Id: I2c898690f12edc0ad4c83dc6395813e21a724f64
Reviewed-on: https://gerrit.libreoffice.org/51227Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

Easier to see what's going on inside the LOK dialog.

Change-Id: I59974200af3d2356b7c27eb3dd4032a59c00dbed
Reviewed-on: https://gerrit.libreoffice.org/51263Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>

Previous fix 25cd8436 like any
other before it have some regressions, so reverted.

The root of most problems: fix for tdf#104141
d148340b, where mask drawing
was implemented in bitmap drawing code.

So instead of guessing for type of bitmap, mask is drawn with
DrawBitmapEx resolving all known problems (tdf#114726, tdf#115297,
tdf#113918 and tdf#104141).

Change-Id: Ie00f7552d667e237b3c0f9505ee09cb51e85c43c
Reviewed-on: https://gerrit.libreoffice.org/50828Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ib64bac119e463b56a8cb86a2dcd77c9f07699844
Reviewed-on: https://gerrit.libreoffice.org/51252Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Project: help  770c0c1746b5c0b94dc07d5f1d6c2c04802c8540

tdf#116296 remove produt version from help path

Part two.
Part 1 is in sfx2 module

Remove product version from offline help path but keep
in online help.

Product version is kept for online because a help server can have more
than one helponline version.

Change-Id: I1d4ba12a7d6472defd4210c79349e35ccaf32d8d
Reviewed-on: https://gerrit.libreoffice.org/51126Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>