Skip to content

C
core
Dal (branch)/etiket değiştir
  1. 31 May, 2018 34 kayıt (commit)
  3. 30 May, 2018 6 kayıt (commit)
    • Tor Lillqvist's avatar
      Bin leftover misleading comment · 9112d183
      Tor Lillqvist yazdı 
      Change-Id: I594258303469a1f5b9490b824fdc304a5a780784
      9112d183
    • Olivier Hallot's avatar
      Updated core · 97d3aecd
      Olivier Hallot yazdı 
      Project: help  fc875c6ab3763e36008fd872b3670d953f18ba9d

Fix default cases in switches

Change-Id: I40f6c8e5a6fd0a0ff1d3e6205de449f14598212b
Reviewed-on: https://gerrit.libreoffice.org/55107Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarOlivier Hallot <olivier.hallot@libreoffice.org>
      97d3aecd
    • Olivier Hallot's avatar
      Updated core · 4d2966b5
      Olivier Hallot yazdı 
      Project: help  a0b4db5f17e58f656d527b807e09ed02b04c2827

tdf#58134 Some Options settings cannot be reset

Add warnings in help pages when some options cannot be reset.

This patch does not close the bug, which in some cases is a
bug in the dialog controller.

Change-Id: Ie6d0019a9c6611c2ad8784f593ceefa5748bf56b
Reviewed-on: https://gerrit.libreoffice.org/55103Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarOlivier Hallot <olivier.hallot@libreoffice.org>
      4d2966b5
    • Tor Lillqvist's avatar
      We want just one SwVbaGlobals and SwVbaApplication for all Automation clients · 3f3b7b38
      Tor Lillqvist yazdı 
      I think. Anyway, if it turns out we do want one per client, easy to
revert this. (And it isn't very common to have several Automation
clients connected at the same time anyway, surely.)

There will still additionally be one SwVbaGlobals (and
SwVbaApplication) per open document with a StarBasic interpreter,
though. I think.

Change-Id: I5f7dbfd65b5decb152c1192298bc85dcf6027d64
Reviewed-on: https://gerrit.libreoffice.org/55094Reviewed-by: 's avatarTor Lillqvist <tml@collabora.com>
Tested-by: 's avatarTor Lillqvist <tml@collabora.com>
      3f3b7b38
    • Tor Lillqvist's avatar
      Work in progress related to invoking events in Automation clients · f7e0297b
      Tor Lillqvist yazdı 
      XConnectable interfaces need a second IID, for the interface "itself",
not the coclass. (I am sure there is some catchy short term for that,
I just can't find it right now.)

Allow several simultaneous sinks for a SwVbaApplication. Not sure in
what case such would be needed, but you never know about 3rd-party
client code, and it's trivial to handle anyway, so why not.

Lots of FIXMEs still. There is likely also a lot of leaks. But at
least an event handler in a simple VBScript script does get invoked.

Note that the changed and added code in extensions/source/ole is
totally unaware of what outgoing ("event") interfaces Writer or Calc
implements, it is all handled generically through the UNO interfaces I
added recently.

One particular thing that needs doing is to actually make Writer (and
Calc) raise this kind of events when necessary. The current code to
invoke events handlers in StarBasic (including StarBasic code running
in "VBA" compaibility) is very much tied to having StarBasic running
(not surprisingly), which of course is not at all the case when it is
an Automation client that is manipulating a Writer or Calc instance
and wants events.

There is demonstration-only code in SwVbaApplication::Documents() to
raise the "Quit" event. (I would have put that in the SwVbaApplication
destructor but that doesn't seem to get called.) That should of course
go away once we invoke other relevant events in appropriate places.
And the "Quit" event needs to be invoked when the application is
quitting.

The whole callback mechanism with IConnectionPoint etc is still partly
a mystery to me. It is entirely possible that even if this now works
for a simple VBScript client, it won't work for (for instance) a VB6
client that might exercise the APIs of the COM interfaces we provide
in a different way.

Add XSinkCaller, for something that perhaps calls one or several
XSinks.

Change-Id: Ica03344010e374542f4aceff5ec032c78579f937
Reviewed-on: https://gerrit.libreoffice.org/55093Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarTor Lillqvist <tml@collabora.com>
      f7e0297b
    • Noel Grandin's avatar
      dont use GetMask in GeoTexSvxBitmapEx · 63e65d17
      Noel Grandin yazdı 
      part of the process of making Bitmap's internals be private to vcl

Change-Id: I3784c14be1572d4df64b9cbdb5adcebdd1b274fd
Reviewed-on: https://gerrit.libreoffice.org/55050Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarMichael Meeks <michael.meeks@collabora.com>
Tested-by: 's avatarMichael Meeks <michael.meeks@collabora.com>
      63e65d17