- 05 Agu, 2018 13 kayıt (commit)
-
-
Zdeněk Crhonek yazdı
Change-Id: I87f9822110d9e15115ef4e0fc6ef23823a6bbcf0 Reviewed-on: https://gerrit.libreoffice.org/58620 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
-
Caolán McNamara yazdı
Change-Id: I794c54867b83d738a075f9fa0dbd31fe62de49b9 Reviewed-on: https://gerrit.libreoffice.org/58610 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I9c346fd09603d086542f7f3cb355c7e5acc3378e Reviewed-on: https://gerrit.libreoffice.org/58609 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I68e1569835a1e981f57aabf2565f3eb2c619d296 Reviewed-on: https://gerrit.libreoffice.org/58608 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I59ce652b1a3271fc1f95d76c6a42902db8b1bc68 Reviewed-on: https://gerrit.libreoffice.org/58607 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I83664684ac75d534b529438332d9aeee17e6dcf3 Reviewed-on: https://gerrit.libreoffice.org/58606 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: Ic00eae935f81cab692b614abee9d30992fc7b176 Reviewed-on: https://gerrit.libreoffice.org/58605 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Mike Kaganski yazdı
Regression from commit db04be03 Change-Id: I530c00f6357b4822654add6e5f2eecb3252b88ae Reviewed-on: https://gerrit.libreoffice.org/58612 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
-
Jochen Nitschke yazdı
Change-Id: I7aa3e47db67072c06f4de4c219710325cfdb748e Reviewed-on: https://gerrit.libreoffice.org/58613 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Zdeněk Crhonek yazdı
Change-Id: I20266ea50a7e413e0c8297fd6817c0a97205802d Reviewed-on: https://gerrit.libreoffice.org/58604 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
-
Andrea Gelmini yazdı
Change-Id: I2ea9b44f180a44efb0bfd37d4273009cf3f44480 Reviewed-on: https://gerrit.libreoffice.org/58591Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
-
Rizal Muttaqin yazdı
Change-Id: If205caee24425b15588556f81c4e871bb1992865 Reviewed-on: https://gerrit.libreoffice.org/58603 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
-
Adolfo Jayme Barrientos yazdı
Microsoft has never referred to desktop shortcuts as “start links”. This change aligns our installer with almost every other installer out there. Change-Id: Ib5779e6cd44e719e52d1afeb6a44c7dc8f3624dc
-
- 04 Agu, 2018 18 kayıt (commit)
-
-
Jens Carl yazdı
Change-Id: I1e26c36bcd5057e3f4dbe13745725e52717ac8fe Reviewed-on: https://gerrit.libreoffice.org/58599 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
-
Caolán McNamara yazdı
e.g. on converting moz858095-2.svg to odg Change-Id: I1a222f1745cff9c4cb225f6c0c216072fb17b4f7 Reviewed-on: https://gerrit.libreoffice.org/58587Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: Ieb3854af97a7c5cbe5679de09925f6802757ebf1 Reviewed-on: https://gerrit.libreoffice.org/58567 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Jens Carl yazdı
Change-Id: I8603a7e219c90095ee971c806f9dd21c1ba9f701 Reviewed-on: https://gerrit.libreoffice.org/58596 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
-
Mike Kaganski yazdı
Also make the functions constexpr. Due to slight changes in floating-point arithmetics (90.0 instead of 180.0, M_PI2 instead of M_PI resp.), results might differ in last digits (usually 17th decimal digit). This has lead to need to tweak char2dump's PieChartTest unit test. Change-Id: I20323dd7dab27e4deb408ea4181e390cc05e7cd3 Reviewed-on: https://gerrit.libreoffice.org/58583 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
-
Caolán McNamara yazdı
Change-Id: Iaf671453d513689deb651261c5bba813305fb234 Reviewed-on: https://gerrit.libreoffice.org/58590 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Jens Carl yazdı
Change-Id: I0d6bbd0814d07a440e1a186c7673ba561df6472e Reviewed-on: https://gerrit.libreoffice.org/58592 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
-
Jens Carl yazdı
Change-Id: I19258e12eab781e7835c362326d6f969228ae56f Reviewed-on: https://gerrit.libreoffice.org/58593 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
-
Caolán McNamara yazdı
for those cases where we are doing relatively simple catching and rethrowing e.g. catch in one thread and throw in main thread. Change-Id: I6192017c4ec99dd671a9582f7b004096b0fc4525 Reviewed-on: https://gerrit.libreoffice.org/58588 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I9662478b41486f1fb12ffd83b5046afd48289ed7
-
Rizal Muttaqin yazdı
Change-Id: I622ee6ca7ef1a4fba7bdd8a57e9b76dc54c08fe0 Reviewed-on: https://gerrit.libreoffice.org/58586 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
-
Andrea Gelmini yazdı
Change-Id: Iaaf12d276fb890e5ac860e79c5dc196d7e8680d8 Reviewed-on: https://gerrit.libreoffice.org/58435Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
-
Andrea Gelmini yazdı
Change-Id: I7f90b7672665be0d8d5e47c6456433b06f88d5e0 Reviewed-on: https://gerrit.libreoffice.org/58553Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
-
Caolán McNamara yazdı
used since... commit dacc1b40 Date: Sat Jul 28 16:33:22 2018 +0100 ofz#9597 rethrown IOException not caught by catch IOException the adjustedPtr seems to be as expected, but the type_info not. Presumably these are thrown as 'dependent exceptions' (?) https://github.com/gcc-mirror/gcc/blob/master/libstdc%2B%2B-v3/libsupc%2B%2B/eh_type.cc#L42 Change-Id: Ibd736abe941bb1d5facdb88139b3a0e6cf32cf1f Reviewed-on: https://gerrit.libreoffice.org/58477 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Adolfo Jayme Barrientos yazdı
* Update helpcontent2 from branch 'master' - Remove repeated word Change-Id: I71bf44d3f962c830f6057ced2f0930724f1a394b
-
heiko tietze yazdı
Change-Id: I87517885b5adf4a2fc43630769bb52342c936786 Reviewed-on: https://gerrit.libreoffice.org/58467 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
-
Andrea Gelmini yazdı
Change-Id: I5ffa6366875d29c8a8bc8273057205c221e04a64 Reviewed-on: https://gerrit.libreoffice.org/58581 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
-
Mike Kaganski yazdı
Change-Id: I33848d0b973999f486bb980e78b51e3d109ed1bf Reviewed-on: https://gerrit.libreoffice.org/58582 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
-
- 03 Agu, 2018 9 kayıt (commit)
-
-
Stephan Bergmann yazdı
...as seen with valgrind during CppunitTest_sw_odfexport (see below). It looks like the if ( !IsEmptyPage() ) //#59184# unnecessary for empty pages optimization in SwPageFrame::DestroyImpl (which was there ever since at least 84a3db80 "initial import") was wrong, preventing the call to pImp->GetLayAction().SetAgain(); that would cause SwLayAction::IsShortCut (sw/source/core/layout/layact.cxx) to quit early from an IsAgain() call, before accessing prPage again that has meanwhile been destroyed from within its pContent->Calc(pRenderContext); call. The same failure started to show in ASan+UBSan builds only now after integration of <https://gerrit.libreoffice.org/#/c/58263/> "the custom SAL allocator is no longer used", for reasons I explained in a comment there: "For FORCE_SYSALLOC (which was esp. set for ASan/UBSan builds), alloc_mode was always left at AllocMode::UNSET (as determine_alloc_mode was never called in FORCE_SYSALLOC blocks), so rtl_cache_alloc (which only checked alloc_mode for AllocMode::SYSTEM, but never called determine_alloc, and wasn't entirely short- circuited under FORCE_SYSALLOC) actually called into the legacy, supposed-dead slab allocator code. That's apparently how some use-after-free bug in sw got hidden from ASan+UBSan builds in the past, and only now starts to show up (<https://ci.libreoffice.org/job/lo_ubsan/989/>)." The valgrind failure log: [...] > testFdo58949::Import_Export_Import finished in: 191975ms > File tested,Execution Time (ms) > warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height > warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height > warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height > warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height > warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height > warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height > warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height > warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height > warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height > warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height > ==12555== Invalid read of size 8 > ==12555== at 0x2AFDAA7C: SwFrame::GetPrev() (/sw/source/core/inc/frame.hxx:649) > ==12555== by 0x2B6A4F7A: SwLayAction::IsShortCut(SwPageFrame*&) (/sw/source/core/layout/layact.cxx:1071) > ==12555== by 0x2B6A342D: SwLayAction::InternalAction(OutputDevice*) (/sw/source/core/layout/layact.cxx:473) > ==12555== by 0x2B6A2E46: SwLayAction::Action(OutputDevice*) (/sw/source/core/layout/layact.cxx:340) > ==12555== by 0x2BE0F8A2: SwViewShell::ImplEndAction(bool) (/sw/source/core/view/viewsh.cxx:281) > ==12555== by 0x2AF7A6C0: SwViewShell::EndAction(bool) (/sw/inc/viewsh.hxx:595) > ==12555== by 0x2AF68B50: SwCursorShell::EndAction(bool, bool) (/sw/source/core/crsr/crsrsh.cxx:258) > ==12555== by 0x2C464281: SwView::OuterResizePixel(Point const&, Size const&) (/sw/source/uibase/uiview/viewport.cxx:1124) > ==12555== by 0x2A29D78F: SfxViewFrame::DoAdjustPosSizePixel(SfxViewShell*, Point const&, Size const&, bool) (/sfx2/source/view/viewfrm.cxx:1604) > ==12555== by 0x2A2A390E: SfxViewFrame::Resize(bool) (/sfx2/source/view/viewfrm.cxx:2395) > ==12555== by 0x2A2AF1A7: SfxFrameViewWindow_Impl::Resize() (/sfx2/source/view/viewfrm2.cxx:73) > ==12555== by 0x1A8C2A64: vcl::Window::ImplCallResize() (/vcl/source/window/event.cxx:523) > ==12555== by 0x1AA2AF8D: vcl::Window::Show(bool, ShowFlags) (/vcl/source/window/window.cxx:2277) > ==12555== by 0x2A282069: SfxBaseController::ConnectSfxFrame_Impl(SfxBaseController::ConnectSfxFrame) (/sfx2/source/view/sfxbasecontroller.cxx:1250) > ==12555== by 0x2A2815BA: SfxBaseController::attachFrame(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) (/sfx2/source/view/sfxbasecontroller.cxx:550) > ==12555== by 0x2A265C78: (anonymous namespace)::SfxFrameLoader_Impl::impl_createDocumentView(com::sun::star::uno::Reference<com::sun::star::frame::XModel2> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, comphelper::NamedValueCollection const&, rtl::OUString const&) (/sfx2/source/view/frmload.cxx:594) > ==12555== by 0x2A26374F: (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) (/sfx2/source/view/frmload.cxx:711) > ==12555== by 0x36E8A2A1: framework::LoadEnv::impl_loadContent() (/framework/source/loadenv/loadenv.cxx:1149) > ==12555== by 0x36E84F2A: framework::LoadEnv::startLoading() (/framework/source/loadenv/loadenv.cxx:383) > ==12555== by 0x36E83979: framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/framework/source/loadenv/loadenv.cxx:169) > ==12555== by 0x36EDDEB8: framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/framework/source/services/desktop.cxx:619) > ==12555== by 0x36EDDF6A: non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/framework/source/services/desktop.cxx:0) > ==12555== by 0x2D456C63: unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/unotest/source/cpp/macros_test.cxx:50) > ==12555== by 0x295BCC30: SwModelTestBase::loadURL(rtl::OUString const&, char const*, char const*) (/sw/qa/extras/inc/swmodeltestbase.hxx:762) > ==12555== by 0x295BC7E9: SwModelTestBase::load(rtl::OUString const&, char const*, char const*) (/sw/qa/extras/inc/swmodeltestbase.hxx:717) > ==12555== by 0x295BC660: SwModelTestBase::executeImportTest(char const*, char const*) (/sw/qa/extras/inc/swmodeltestbase.hxx:264) > ==12555== by 0x295E4B5F: testStylePageNumber::Import() (/sw/qa/extras/odfexport/odfexport.cxx:686) [...] > ==12555== Address 0x28ddde10 is 160 bytes inside a block of size 280 free'd > ==12555== at 0x4C2FDAC: free (/builddir/build/BUILD/valgrind-3.13.0/coregrind/m_replacemalloc/vg_replace_malloc.c:530) > ==12555== by 0x519E494: rtl_freeMemory (/sal/rtl/alloc_global.cxx:51) > ==12555== by 0x519DCDB: rtl_cache_free (/sal/rtl/alloc_cache.cxx:172) > ==12555== by 0x19BB090A: FixedMemPool::Free(void*) (/tools/source/memtools/mempool.cxx:49) > ==12555== by 0x2B68B89D: SwPageFrame::operator delete(void*, unsigned long) (/sw/source/core/inc/pagefrm.hxx:111) > ==12555== by 0x2B6DA2E8: SwPageFrame::~SwPageFrame() (/sw/source/core/layout/pagechg.cxx:301) > ==12555== by 0x2B74E763: SwFrame::DestroyFrame(SwFrame*) (/sw/source/core/layout/ssfrm.cxx:384) > ==12555== by 0x2B6E18D3: SwRootFrame::RemovePage(SwPageFrame**, SwRemoveResult) (/sw/source/core/layout/pagechg.cxx:1414) > ==12555== by 0x2B6E145D: (anonymous namespace)::doInsertPage(SwRootFrame*, SwPageFrame**, SwFrameFormat*, SwPageDesc*, bool, SwPageFrame**) (/sw/source/core/layout/pagechg.cxx:1270) > ==12555== by 0x2B6E0CA0: SwFrame::InsertPage(SwPageFrame*, bool) (/sw/source/core/layout/pagechg.cxx:1324) > ==12555== by 0x2B65373D: SwFrame::GetNextLeaf(MakePageType) (/sw/source/core/layout/flowfrm.cxx:997) > ==12555== by 0x2B65331A: SwFrame::GetLeaf(MakePageType, bool) (/sw/source/core/layout/flowfrm.cxx:818) > ==12555== by 0x2B657637: SwFlowFrame::MoveFwd(bool, bool, bool) (/sw/source/core/layout/flowfrm.cxx:1876) > ==12555== by 0x2B657133: SwFlowFrame::CheckMoveFwd(bool&, bool, bool) (/sw/source/core/layout/flowfrm.cxx:1796) > ==12555== by 0x2B634109: SwContentFrame::MakeAll(OutputDevice*) (/sw/source/core/layout/calcmove.cxx:1322) > ==12555== by 0x2B62CEF4: SwFrame::PrepareMake(OutputDevice*) (/sw/source/core/layout/calcmove.cxx:343) > ==12555== by 0x2B770166: SwFrame::Calc(OutputDevice*) const (/sw/source/core/layout/trvlfrm.cxx:1799) > ==12555== by 0x2B6A4F11: SwLayAction::IsShortCut(SwPageFrame*&) (/sw/source/core/layout/layact.cxx:1065) > ==12555== by 0x2B6A342D: SwLayAction::InternalAction(OutputDevice*) (/sw/source/core/layout/layact.cxx:473) > ==12555== by 0x2B6A2E46: SwLayAction::Action(OutputDevice*) (/sw/source/core/layout/layact.cxx:340) > ==12555== by 0x2BE0F8A2: SwViewShell::ImplEndAction(bool) (/sw/source/core/view/viewsh.cxx:281) [...] Change-Id: I57ebbab536ca41554e4681477cf1dea62abbc688 Reviewed-on: https://gerrit.libreoffice.org/58550 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Mike Kaganski yazdı
Also rename svx angle normalization functions in include/svx/svdtrans.hxx, that deal with 100ths of degree, to avoid confusion: NormAngle180 -> NormAngle18000; NormAngle360 -> NormAngle36000. Some places were fixed that previously returned inclusive ranges (i.e., both 0 and 360), see changes in these files: chart2/source/view/main/PlottingPositionHelper.cxx chart2/source/view/main/PolarLabelPositionHelper.cxx chart2/source/view/main/ShapeFactory.cxx filter/source/graphicfilter/idxf/dxf2mtf.cxx sw/source/core/graphic/grfatr.cxx (the latter now matches the comment in the function). Change-Id: I9f274bbb4168360d60dceff02aeba6332c519a59 Reviewed-on: https://gerrit.libreoffice.org/58556 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
-
Caolán McNamara yazdı
Change-Id: I7e340e15c95cdfa8b185f61fad7e14bd00babf21 Reviewed-on: https://gerrit.libreoffice.org/58555 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Dennis Francis yazdı
Change-Id: I3958c139141a9e717256a638d319e0bb5879e6a4 Reviewed-on: https://gerrit.libreoffice.org/58565 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>
-
Noel Grandin yazdı
no need for header only classes to have an Impl Change-Id: I66236e3f9137320cfe39d4312cf7682c1d808815 Reviewed-on: https://gerrit.libreoffice.org/58561 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
no need for header-only classes to have Impl's Change-Id: I65b7f84ebd9eec67ad8be694b7752da59af39a9d Reviewed-on: https://gerrit.libreoffice.org/58560 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Christian Lohmaier yazdı
* Update translations from branch 'master' - update translations for master Change-Id: If7b8b1685d00503ee3d1e84b978c8f59359a73b5
-
Mike Kaganski yazdı
Change-Id: Idb8d16f59823d9065b82d6312def36601457af1a Reviewed-on: https://gerrit.libreoffice.org/58546 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
-
Caolán McNamara yazdı
and make NotifyFreeObj a virtual method of SvxMSDffClientData, finding the sc case where the client data was neither SvxMSDffImportData nor ProcessData. make the sc case a XclImpDrawObjClientData whose NotifyFreeObj is a noop Change-Id: I07422e7a3415114674bb1e3c1ef120299adf2dc8 Reviewed-on: https://gerrit.libreoffice.org/58551Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-