stage 1 of replacing usage of various checks for the windows platform
with the compiler-defined '_WIN32' macro

Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f
Reviewed-on: https://gerrit.libreoffice.org/22390Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

and

coverity#1352449 Use of untrusted scalar value

I suspect this will fix the warning, given that "Casting narrower unsigned
pBuffer[i] to wider signed type short effectively tests its lower bound", so
if we pass it though as-is we probably quieten these

Change-Id: I2ece08f7301f5d548d905d221e5a6af0da51a2bb

Change-Id: I354f29592e6bd036d9a548c7c2c3a3722c8c9450

Change-Id: I6f2ff99c919851b21ce120c40286c133bf65c778

Change-Id: Ief68b26be0a0890ffdfa02a5904ba9d2cb364c65

Change-Id: I39ed18b55657e375b1c22f97c49a0e43aedce4f5

extensionDb is always the same

Change-Id: I57b59f09b3f55757844a6aab6c6698857da2e15b

Change-Id: I6159d6a9be17ceaffaa3e3a905abf87a8cf434ed

Change-Id: I68b88accb5518292af0b3c3418609c93371bf9cf

and

coverity#1352646 Uncaught exception
coverity#1352647 Uncaught exception

Change-Id: Ic96e93d219476eeb458ddab6372368f91bbd0398

Change-Id: I377c6b6817a432d1e9d740c7d43233f5b98cd2f6

Change-Id: I5491ba0bc44a9ce8844b31126835671c5d5abcaa
Reviewed-on: https://gerrit.libreoffice.org/22386Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Ib77f2e008473a18460e7783b20ef3237ff885d57
Reviewed-on: https://gerrit.libreoffice.org/22387Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: I44e4f3086f642adccdff8dcf82298e5f4e9cb282
Reviewed-on: https://gerrit.libreoffice.org/22305Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

When lokit is destroyed, the Desktop service
is still alive. So in order to avoid debug
assertion "Desktop disposed before terminating it",
terminate to quit application.

Change-Id: Id1391cde516915d915e5321799436e92b444e935
Reviewed-on: https://gerrit.libreoffice.org/22359Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Project: help  9f126548f1640b34521037502dc7a1bc0d0d3094

tdf#86866 describe AutoCorrect Options dialog btns

In Help, describe AutoCorrect Options "Ok, Cancel, Reset"
buttons (all tabs of dialog)

Added an embed tag with definition of OK, Cancel and reset buttons

Change-Id: Ie0d55a06ebe0a94c965b25d048567b164f1697cc
Reviewed-on: https://gerrit.libreoffice.org/22361Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

Change-Id: I21faf2034c6253226637bfb65deb869d0c4eda07

Project: help  8259390d2d978d37dc73e8e2cb0f1fcd0299afdf

tdf#95281 Help page for the SKEWP function

Write help page for SKEWP spreadsheet function

Change-Id: Ib7fc372bc2be4c55663a6ab58f488aa204631d20
Reviewed-on: https://gerrit.libreoffice.org/22322Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

Project: help  e53a0d788c6a34d9375e33adc2e9946e2348ad23

tdf#95282 Help page for the COLOR function

Write help page for COLOR spreadsheet functions

Change-Id: I2a34cb2b1f25f3d0013a93dff320b70d76a1f4d6
Reviewed-on: https://gerrit.libreoffice.org/22300Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

Because the writerfilter::ooxml::OOXMLFastContextHandlerShape
constructor only sent the input stream (and not the full media
descriptor) to oox::shape::ShapeContextHandler, it's startFastElement()
tried to reconstruct a media descriptor from just the input stream. As a
result, the base URL of the document got lost at the time the
oox::drawingml::BlipContext constructor tried to call getAbsoluteUrl(),
to convert the relative URL to an absolute one.

Fix the problem by sending not only the input stream, but the full media
descriptor to the shape importer. As a bonus that makes code simpler,
too.

Change-Id: I1f06c04d0745aa7e2e06d4848cf454790d5073ca

Change-Id: I45865bdce1957bb4f970e069241e1bb7714b4f4c

Change-Id: I112dec3253c6eb41dd18bd5cdbcc5a488e4d268c

Change-Id: I370973066604fc04201431a67d3752cc63a60e6d

Change-Id: I7df457dfa3f1d36641c577f353a50e03c37cb09b
Reviewed-on: https://gerrit.libreoffice.org/22382Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I654151d662d579533f89cbc13af1e10cb8944edf
Reviewed-on: https://gerrit.libreoffice.org/22383Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

In the preinit stage, the VCL initialization is done by the parent process
and when the lo_startmain thread de-initialize the VCL, some services are
disposed early, and it causes segmentation violation.

So it is ensured that pointers to service objetcs is set nullptr after
deleting.

Change-Id: I65ecfc2d2694a981ec2986988efabdfd28d0cce4

Change-Id: I8dafbf99638fd24828327ce4493bfbbf1b9d2c6d

conditional expression of the form '!A ? B : true' (with A of type
'bool' and B of type 'bool') can literally be simplified as 'A || B'.

Change-Id: I46bee836425bf1c76def23e30dca9ddd9e791b42

In the preinit stage, the VCL is initialized in the parent process
and when the lo_startmain thread is started, the thread initialize
VCL again.

It is not necessary to initialize twice.

Change-Id: I819cf0125afe7760c3f4d91c420d36a3a383902c

Change-Id: I768b45818eaa0138d033bfcf6fd6e94459e44c0b

In the preinit stage, the preInitBootstrap is called to load
implementations for each service registered by the service manager.

All service requests are: initial Component Context and the process
service factory is set.

However, some services require that VCL is properly initialized.

Change-Id: Ib116e3da172b860f2df4d672f6181b5de0b7e6b2

Change-Id: Ie6f6d769b611c8440ddab802545e6bdc482d1476

Should fix the build for Android.

Change-Id: Iabba9da8755805ad4d9d21d7a6b4b22e3fa6418f

Change-Id: I96bda48eb553f467fcf5d7120561d2160647e3bb

Change-Id: I849e2e945a31ab37c9a24969d6e1decd69170380

Fails when the relevant part of XSecController::exportOOXMLSignature()
is commented out, i.e. the member function just writes a <Signature> XML
element, no child elements.

Change-Id: I526c1170c8ada71f111a1ad56d74af1a4102dbce
Reviewed-on: https://gerrit.libreoffice.org/22375Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I9cc99c3108bae582d0da9645ba75947cced904fc

Change-Id: I933266695bfa88eb6665c7d2968176d74b640172

Change-Id: I3a4097abe5887f0859ea11ac2025cf52689dc4e4

Parsing unit test checks that the xml values are parsed correctly
and that the DriverInfo structure is populated with the expected
values.

Evaluate unit test checks that blacklisting / whitelisting
logic blocks OS/vendor/driver/device as expected.

Change-Id: Ib1b0926606f0835207c324193bbe19ba83f86bdc
Reviewed-on: https://gerrit.libreoffice.org/22371Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>