Skip to content

C
core
Dal (branch)/etiket değiştir
  1. 14 Haz, 2018 20 kayıt (commit)
  3. 13 Haz, 2018 20 kayıt (commit)
    • Maxim Monastirsky's avatar
      wayland: Make popup menus not show off-screen · c3e552ac
      Maxim Monastirsky yazdı 
      Depends on gtk 3.22 for gtk_menu_popup_at_rect.

Had to rework the toolbar context menu to not execute async,
as otherwise it just closes immediately. (Basically it's same
as rhbz#1342823, except that I couldn't find a way to feed
gtk_menu_popup_at_rect with the correct timestamp).

Change-Id: I779d8803c80314d93a342f1294c7280f1adf4c98
Reviewed-on: https://gerrit.libreoffice.org/55772Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarMaxim Monastirsky <momonasmon@gmail.com>
      c3e552ac
    • Maxim Monastirsky's avatar
      Correctly mirror autofilter in rtl ui, tdf#117175 related · 2bfc4cef
      Maxim Monastirsky yazdı 
      Change-Id: I9b4e13bd0c95b5cba76a04dadaa70087bbed8e9c
Reviewed-on: https://gerrit.libreoffice.org/55773Reviewed-by: 's avatarMaxim Monastirsky <momonasmon@gmail.com>
Tested-by: 's avatarMaxim Monastirsky <momonasmon@gmail.com>
      2bfc4cef
    • Caolán McNamara's avatar
      weld SvxCharPositionPage · 23fa8a6e
      Caolán McNamara yazdı 
      Change-Id: I2084702798e5b01eae5905dc54ad8413e6d5fae6
Reviewed-on: https://gerrit.libreoffice.org/55759Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      23fa8a6e
    • Caolán McNamara's avatar
      weld SvxCharTwoLinesPage · d97ac904
      Caolán McNamara yazdı 
      Change-Id: I54a8963cd8b12f5fd51bf6b3bb791a4a15fbd13d
Reviewed-on: https://gerrit.libreoffice.org/55762Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      d97ac904
    • Caolán McNamara's avatar
      WaE: Wmaybe-uninitialized · 65c324f9
      Caolán McNamara yazdı 
      Change-Id: I44c0f768106b721051a3a8e9ea3446da76da6fd2
Reviewed-on: https://gerrit.libreoffice.org/55761Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      65c324f9
    • David Tardon's avatar
      drop unneeded define · d5d7f94f
      David Tardon yazdı 
      Change-Id: Icced4a3f9a7ad4cbcc908412e577b4dfb85fc6eb
Reviewed-on: https://gerrit.libreoffice.org/55757Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarDavid Tardon <dtardon@redhat.com>
      d5d7f94f
    • David Tardon's avatar
      drop unneeded define · 2821e958
      David Tardon yazdı 
      Change-Id: Idb825a2c96089c53c2734783e0bad02ba3c0f592
Reviewed-on: https://gerrit.libreoffice.org/55755Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarDavid Tardon <dtardon@redhat.com>
      2821e958
    • David Tardon's avatar
      drop unneeded define · 6a8eae61
      David Tardon yazdı 
      Change-Id: I3a61e345593959c47b62ba2da97abafca24ee0e8
Reviewed-on: https://gerrit.libreoffice.org/55754Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarDavid Tardon <dtardon@redhat.com>
      6a8eae61
    • Stephan Bergmann's avatar
      Avoid -fsanitize=null · 6a501515
      Stephan Bergmann yazdı 
      ...during JunitTest_sw_unoapi_4:

[...]
> checking: [sw.SwXTextViewCursor::com::sun::star::style::CharacterProperties] is iface: [com.sun.star.beans.XPropertySet] testcode: [ifc.style._CharacterProperties]
> LOG> Execute: CharFontName
> LOG> try to set:
> LOG> old = Liberation Serif
> LOG> new = Times New Roman
> LOG> Property CharFontName is void
> LOG> Property 'CharFontName' OK
> LOG> result = Times New Roman
> Method CharFontName finished with state OK
> LOG> CharFontName: COMPLETED.OK
>
[...]
>
> LOG> Execute: CharCombinePrefix
> LOG> try to set:
> LOG> old =
> LOG> new = New
> sw/source/core/text/inftxt.cxx:1794:69: runtime error: reference binding to null pointer of type 'const SwWrongList'
>  #0 in SwTextSlot::SwTextSlot(SwTextSizeInfo const*, SwLinePortion const*, bool, bool, rtl::OUString const&) at sw/source/core/text/inftxt.cxx:1794:47 (instdir/program/../program/libswlo.so +0x826da0a)
>  #1 in SwExpandPortion::Paint(SwTextPaintInfo const&) const at sw/source/core/text/porexp.cxx:66:16 (instdir/program/../program/libswlo.so +0x8391b43)
>  #2 in SwBlankPortion::Paint(SwTextPaintInfo const&) const at sw/source/core/text/porexp.cxx:199:22 (instdir/program/../program/libswlo.so +0x8395368)
>  #3 in SwDoubleLinePortion::PaintBracket(SwTextPaintInfo&, long, bool) const at sw/source/core/text/pormulti.cxx:365:16 (instdir/program/../program/libswlo.so +0x8449ab3)
>  #4 in SwTextPainter::PaintMultiPortion(SwRect const&, SwMultiPortion&, SwMultiPortion const*) at sw/source/core/text/pormulti.cxx:1580:51 (instdir/program/../program/libswlo.so +0x8467d46)
>  #5 in SwTextPainter::DrawTextLine(SwRect const&, SwSaveClip&, bool) at sw/source/core/text/itrpaint.cxx:396:17 (instdir/program/../program/libswlo.so +0x83764cc)
>  #6 in SwTextFrame::PaintSwFrame(OutputDevice&, SwRect const&, SwPrintData const*) const at sw/source/core/text/frmpaint.cxx:697:23 (instdir/program/../program/libswlo.so +0x822f5ab)
>  #7 in SwLayoutFrame::PaintSwFrame(OutputDevice&, SwRect const&, SwPrintData const*) const at sw/source/core/layout/paintfrm.cxx:3421:21 (instdir/program/../program/libswlo.so +0x7c70a12)
>  #8 in SwLayoutFrame::PaintSwFrame(OutputDevice&, SwRect const&, SwPrintData const*) const at sw/source/core/layout/paintfrm.cxx:3421:21 (instdir/program/../program/libswlo.so +0x7c70a12)
>  #9 in SwRootFrame::PaintSwFrame(OutputDevice&, SwRect const&, SwPrintData const*) const at sw/source/core/layout/paintfrm.cxx:3136:24 (instdir/program/../program/libswlo.so +0x7c5032e)
>  #10 in SwViewShell::ImplEndAction(bool) at sw/source/core/view/viewsh.cxx:413:49 (instdir/program/../program/libswlo.so +0x95cd0ca)
>  #11 in SwViewShell::EndAction(bool) at sw/inc/viewsh.hxx:594:9 (instdir/program/../program/libswlo.so +0x5f5b0a5)
>  #12 in SwCursorShell::EndAction(bool, bool) at sw/source/core/crsr/crsrsh.cxx:256:18 (instdir/program/../program/libswlo.so +0x5ef26ee)
>  #13 in SwRootFrame::EndAllAction(bool) at sw/source/core/layout/pagechg.cxx:1875:52 (instdir/program/../program/libswlo.so +0x7bfe2ce)
>  #14 in UnoActionContext::~UnoActionContext() at sw/source/core/unocore/unoobj2.cxx:261:25 (instdir/program/../program/libswlo.so +0x9110434)
>  #15 in SwUnoCursorHelper::SetCursorAttr(SwPaM&, SfxItemSet const&, SetAttrMode, bool) at sw/source/core/unocore/unoobj2.cxx:369:1 (instdir/program/../program/libswlo.so +0x911327a)
>  #16 in SwUnoCursorHelper::SetPropertyValues(SwPaM&, SfxItemPropertySet const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, SetAttrMode) at sw/source/core/unocore/unoobj.cxx:1839:17 (instdir/program/../program/libswlo.so +0x90e0bff)
>  #17 in SwUnoCursorHelper::SetPropertyValue(SwPaM&, SfxItemPropertySet const&, rtl::OUString const&, com::sun::star::uno::Any const&, SetAttrMode) at sw/source/core/unocore/unoobj.cxx:1760:5 (instdir/program/../program/libswlo.so +0x90dfb0e)
>  #18 in SwXTextViewCursor::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&) at sw/source/uibase/uno/unotxvw.cxx:1441:5 (instdir/program/../program/libswlo.so +0xafac835)
>  #19 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5 (instdir/program/libgcc3_uno.so +0xba96d)
>  #20 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13 (instdir/program/libgcc3_uno.so +0xb6855)
>  #21 in unoInterfaceProxyDispatch at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:420:13 (instdir/program/libgcc3_uno.so +0xb4663)
>  #22 in binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const at binaryurp/source/incomingrequest.cxx:236:13 (instdir/program/libbinaryurplo.so +0x209ede)
>  #23 in binaryurp::IncomingRequest::execute() const at binaryurp/source/incomingrequest.cxx:79:26 (instdir/program/libbinaryurplo.so +0x205f10)
>  #24 in request at binaryurp/source/reader.cxx:85:9 (instdir/program/libbinaryurplo.so +0x2966d3)
>  #25 in cppu_threadpool::JobQueue::enter(long, bool) at cppu/source/threadpool/jobqueue.cxx:107:17 (instdir/program/libuno_cppu.so.3 +0x17e863)
>  #26 in cppu_threadpool::ORequestThread::run() at cppu/source/threadpool/thread.cxx:165:31 (instdir/program/libuno_cppu.so.3 +0x1977bb)
>  #27 in threadFunc at include/osl/thread.hxx:185:15 (instdir/program/libuno_cppu.so.3 +0x1a0347)
>  #28 in osl_thread_start_Impl(void*) at sal/osl/unx/thread.cxx:234:9 (instdir/program/libuno_sal.so.3 +0x2e6479)
>  #29 in start_thread at /usr/src/debug/glibc-2.27-56-g50df56ca86/nptl/pthread_create.c:463:7 (/lib64/libpthread.so.0 +0x7593)
>  #30 in __GI___clone at /usr/src/debug/glibc-2.27-56-g50df56ca86/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:95 (/lib64/libc.so.6 +0xfa00e)
>
> LOG> Exception occurred while testing property 'CharCombinePrefix'
> Method CharCombinePrefix finished with state FAILED
> com.sun.star.lang.DisposedException: java_remote_bridge com.sun.star.lib.uno.bridges.java_remote.java_remote_bridge@4eb7f003 is disposed
> 	at com.sun.star.lib.uno.bridges.java_remote.java_remote_bridge.checkDisposed(java_remote_bridge.java:688)
> 	at com.sun.star.lib.uno.bridges.java_remote.java_remote_bridge.sendRequest(java_remote_bridge.java:602)
> 	at com.sun.star.lib.uno.bridges.java_remote.ProxyFactory$Handler.request(ProxyFactory.java:145)
> 	at com.sun.star.lib.uno.bridges.java_remote.ProxyFactory$Handler.invoke(ProxyFactory.java:129)
> 	at com.sun.proxy.$Proxy24.getPropertyValue(Unknown Source)
> 	at lib.MultiPropertyTest$PropertyTester.testProperty(MultiPropertyTest.java:210)
> 	at lib.MultiPropertyTest.testProperty(MultiPropertyTest.java:461)
> 	at lib.MultiPropertyTest.testProperty(MultiPropertyTest.java:470)
> 	at lib.MultiPropertyTest.invokeTestMethod(MultiPropertyTest.java:83)
> 	at lib.MultiMethodTest.callMethod(MultiMethodTest.java:365)
> 	at lib.MultiMethodTest.executeMethod(MultiMethodTest.java:353)
> 	at lib.MultiMethodTest.run(MultiMethodTest.java:217)
> 	at base.java_fat.executeInterfaceTest(java_fat.java:447)
> 	at base.java_fat.executeTest(java_fat.java:187)
> 	at org.openoffice.Runner.run(Runner.java:175)
> 	at org.openoffice.test.UnoApiTest.test(UnoApiTest.java:41)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
> 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> 	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> 	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> 	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> 	at org.junit.runners.Suite.runChild(Suite.java:128)
> 	at org.junit.runners.Suite.runChild(Suite.java:27)
> 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> 	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> 	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> 	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
> 	at org.junit.runner.JUnitCore.runMain(JUnitCore.java:77)
> 	at org.junit.runner.JUnitCore.main(JUnitCore.java:36)
> LOG> CharCombinePrefix: COMPLETED.FAILED
[...]

(And, as suggested by mst, made a similar change a few lines further up, even if
that never showed up to be null at least during `make check`.)

Change-Id: Iac1d2ba7b7bb940b6b185754141407cc31ed6319
Reviewed-on: https://gerrit.libreoffice.org/55749Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarMichael Stahl <Michael.Stahl@cib.de>
      6a501515
    • László Németh's avatar
      tdf#115007 NatNum12 "spell out" formats in dates · 958c2324
      László Németh yazdı 
      to support variants of preposition, suffixation,
article or their combination. For example, Catalan
"de març"/"d'abril", English "1st of May"/"First of
May" or Hungarian "május 1-je/május 2-a".

When the date format contains more than a date keyword,
it needs to specify in NatNum12 argument which date
element needs special formatting by using libnumbertext:

'[NatNum12 ordinal-number]D'              -> "1st"
'[NatNum12 D=ordinal-number]D" of "MMMM'  -> "1st of April"
'[NatNum12 D=ordinal]D" of "MMMM'         -> "first of April"
'[NatNum12 YYYY=year,D=ordinal]D" of "MMMM", "YYYY' ->
"first of April, nineteen ninety"

Note: set only for YYYY, MMMM, M, DDDD, D and NNN/AAAA
in date formats. It's possible to extend this for other
keywords and date + time combinations, as required.

Note 2: default l10n date formats can use the new NatNum12 date
formats, see FormatElement in i18npool/source/localedata/
XML files and FormatElement specification:
https://opengrok.libreoffice.org/xref/core/i18npool/source/localedata/data/locale.dtd#223

Change-Id: I598849f1492f4012e83cef9293773badbff16206
Reviewed-on: https://gerrit.libreoffice.org/55613Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarLászló Németh <nemeth@numbertext.org>
      958c2324
    • Mike Kaganski's avatar
      tdf#116537: use page #s excluding empty pages when they are ignored · cc46e7b9
      Mike Kaganski yazdı 
      Since commit 3c1a343f,
SwDoc::CalculatePagesForPrinting expects that PageRange contains
page numbers that don't include empty pages' numbers, when the
org.openoffice.Office.Writer/Print/EmptyPages is false.

Change-Id: I4057d6e36765707affbd5f3a4507ae03f4a27171
Reviewed-on: https://gerrit.libreoffice.org/55756Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      cc46e7b9
    • heiko tietze's avatar
      tdf#118110 - Mouse wheel should work with the shapes desk · dc5a7f14
      heiko tietze yazdı 
      scrollwindow removed

Change-Id: Id38dd75120effe63314fb3665417c728f3822712
Reviewed-on: https://gerrit.libreoffice.org/55748Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarHeiko Tietze <tietze.heiko@gmail.com>
      dc5a7f14
    • Caolán McNamara's avatar
      WaE: Wmaybe-uninitialized · 24b31f83
      Caolán McNamara yazdı 
      Change-Id: I48e0d84ec0307f9895b5148f9522df8f0c02ac6c
Reviewed-on: https://gerrit.libreoffice.org/55758Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      24b31f83
    • Jens Carl's avatar
      tdf#45904 Move remaining _XCellRangeReferrer Java tests to C++ · 600987b4
      Jens Carl yazdı 
      Move remaining _XCellRangeReferrer tests to C++ and partly fix #i84656.

Change-Id: I77cc8550888f460a6ae265816907a19a81cbe871
Reviewed-on: https://gerrit.libreoffice.org/55732Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarJens Carl <j.carl43@gmx.de>
      600987b4
    • Gabor Kelemen's avatar
      tdf#42949 Fix IWYU warnings in chart2/source/controller/inc/[I-V]* · 0554e742
      Gabor Kelemen yazdı 
      Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
A bit of fallout management as well.

Change-Id: Ie058eac6608d7c6dc2cfb29f1081b6684a4412ac
Reviewed-on: https://gerrit.libreoffice.org/55541Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarJochen Nitschke <j.nitschke+logerrit@ok.de>
      0554e742
    • Zdeněk Crhonek's avatar
      uitest-Word Count;tdf#68347 tdf#91100 tdf#58050 tdf#56975 tdf#56975 · 5db29ca0
      Zdeněk Crhonek yazdı 
      Change-Id: I76685155ca0d9f19a787c8cda13c1fa5afde8250
Reviewed-on: https://gerrit.libreoffice.org/50304Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarZdenek Crhonek <zcrhonek@gmail.com>
      5db29ca0
    • Zdeněk Crhonek's avatar
      uitest Calc-statistics- Moving average · 8f43ffc8
      Zdeněk Crhonek yazdı 
      Change-Id: I0e442ca3787c1b71c919dbf2d4da75eabfaca47f
Reviewed-on: https://gerrit.libreoffice.org/55747Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarZdenek Crhonek <zcrhonek@gmail.com>
      8f43ffc8
    • Stephan Bergmann's avatar
      Don't create std::string from nullptr · 98db90e2
      Stephan Bergmann yazdı 
      ...which violates the ctor's preconditions, so is UB.  Also, the "XML Help
Document Type Definition" appendix of
<http://documentation.openoffice.org/online_help/OOo2HelpAuthoring.pdf> states
that "branch" and "id" attributes are #REQUIRED for the "bookmark" element.

(There's probably further cases in the surrounding code where a std::string is
created from a potentially null argument, which would benefit from similar
fixes.)

Change-Id: I414576d13de784de1290951bcdd5e3ecb51f9cb8
Reviewed-on: https://gerrit.libreoffice.org/55735Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      98db90e2
    • Caolán McNamara's avatar
      valgrind: use OUString::operator to access into string · 39e75712
      Caolán McNamara yazdı 
      address some out of bounds oddness seen with
rtl_ustr_getlength_heap_buffer_overflow.sample

Change-Id: I5a9772de9607644f43e74174f73053d292ca7cc0
Reviewed-on: https://gerrit.libreoffice.org/55722Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      39e75712
    • Adolfo Jayme Barrientos's avatar
      Updated core · 011b7c54
      Adolfo Jayme Barrientos yazdı 
      Project: help  279e341d56686a5e381fbc53faec3395e4cd451a

Helponline: Allow for system typeface to be used

Change-Id: Ic3868b0bcdbb978f450666b4f98e53587b5e7f85
Reviewed-on: https://gerrit.libreoffice.org/55728Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarOlivier Hallot <olivier.hallot@libreoffice.org>
      011b7c54