1. 21 Eyl, 2016 15 kayıt (commit)
  2. 20 Eyl, 2016 3 kayıt (commit)
  3. 21 Eyl, 2016 1 kayıt (commit)
  4. 20 Eyl, 2016 21 kayıt (commit)
    • Henry Castro's avatar
      sc draw: emit LOK_CALLBACK_GRAPHIC_VIEW_SELECTION when view is created · 0b5c4d38
      Henry Castro yazdı
      In multiple view environment, when a new view is created ensure to
      notify other views graphic view selections.
      
      Change-Id: If75f9525af6e851e096b6d273957b94882c441cf
      Reviewed-on: https://gerrit.libreoffice.org/29094Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.co.uk>
      Tested-by: 's avatarMiklos Vajna <vmiklos@collabora.co.uk>
      0b5c4d38
    • Miklos Vajna's avatar
      lokdocview: guard against int overflow · 28447258
      Miklos Vajna yazdı
      If a too large rectangle is parsed, the width or the height may be
      larger than std::numeric_limits<int>::max(), in that case just set
      width/height to that max value, instead of allowing an overflow.
      
      Change-Id: Ic01319b01a3f9286501c346ea765868be57466a1
      28447258
    • Stephan Bergmann's avatar
      cid#1371314: Add move semantics · 11aa8ac4
      Stephan Bergmann yazdı
      Change-Id: I995cbdb2b6adc707abe5f1a179e94251641120bc
      11aa8ac4
    • Michael Stahl's avatar
      tdf#101536 sw: do load Insert Index dialog's document ReadOnly · b7faef01
      Michael Stahl yazdı
      Turns out SwOneExampleFrame is used for different things, so load doc
      read-only only if it's an existing document.
      
      (regression from 6a8407d8)
      
      Change-Id: I0a1ab0725ed9dccca23742c9d83cd9635a188edf
      b7faef01
    • Jan-Marek Glogowski's avatar
      tdf#101359 Really walk the document mark list · ccb979c5
      Jan-Marek Glogowski yazdı
      In both functions we want to walk the current mark list and
      act on the MarkType::BOOKMARK, so mimic the behaviour of
      PopulateTable in HaveBookmarksChanged.
      
      My previous commit 96454829
      is broken and just works out of luck...
      
      Change-Id: I2f53b775208cad7e83992d1ae4fb67a41588cb92
      ccb979c5
    • Stephan Bergmann's avatar
      Fix "ubsan: 9 is not a valid value for type ´SvxNumType´" once again · 5e0edd5f
      Stephan Bergmann yazdı
      ...after 1658bd23 "loplugin:unusedenumvalues"
      broke it again after 992fba98 "ubsan: 9 is not a
      valid value for type ´SvxNumType´" had fixed it the last time.
      
      This time, acknowledge that SvxNumType can apparently take on rather arbitrary
      sal_Int16 values from the css::style::NumberingTypes constants, and make it an
      alias for sal_Int16 (whether or not keeping such a trivial alias is good or bad
      overall).
      
      Or is the bug elsewhere, and values of type SvxNumType should really only take
      on the restricted set of values originally encoded by the enum?  At least the
      below UBSan backtrace (from CppunitTest_sw_rtfexport) suggests otherwise, but
      then again there's also an SvxExtNumType enum (include/editeng/svxenum.hxx),
      encompassing more parts of css::style::NumberingTypes.  Oh, my.
      
      > svx/source/items/pageitem.cxx:49:25: runtime error: load of value 9, which is not a valid value for type 'SvxNumType'
      >  #0 0x2aafdaebe669 in SvxPageItem::SvxPageItem(SvxPageItem const&) svx/source/items/pageitem.cxx:49:25
      >  #1 0x2aafdaebf194 in SvxPageItem::Clone(SfxItemPool*) const svx/source/items/pageitem.cxx:59:16
      >  #2 0x2aaf7fab9b7c in SfxItemPool::Put(SfxPoolItem const&, unsigned short) svl/source/items/itempool.cxx:632:40
      >  #3 0x2aaf7fc4794a in SfxItemSet::Put(SfxPoolItem const&, unsigned short) svl/source/items/itemset.cxx:467:56
      >  #4 0x2aaf7fb96635 in SfxItemSet::Put(SfxPoolItem const&) include/svl/itemset.hxx:131:42
      >  #5 0x2aaf7fb89539 in SfxItemPropertySet::setPropertyValue(SfxItemPropertySimpleEntry const&, com::sun::star::uno::Any const&, SfxItemSet&) const svl/source/items/itemprop.cxx:256:14
      >  #6 0x2aaf9ef1a5d4 in void SwXStyle::SetPropertyValue<(unsigned short)1>(SfxItemPropertySimpleEntry const&, SfxItemPropertySet const&, com::sun::star::uno::Any const&, SwStyleBase_Impl&) sw/source/core/unocore/unostyle.cxx:1596:14
      >  #7 0x2aaf9ef3c72f in SwXStyle::SetStyleProperty(SfxItemPropertySimpleEntry const&, SfxItemPropertySet const&, com::sun::star::uno::Any const&, SwStyleBase_Impl&) sw/source/core/unocore/unostyle.cxx:2013:9
      >  #8 0x2aaf9ef8103d in SwXPageStyle::SetPropertyValues_Impl(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) sw/source/core/unocore/unostyle.cxx:3025:17
      >  #9 0x2aaf9ef821ee in SwXPageStyle::setPropertyValues(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) sw/source/core/unocore/unostyle.cxx:3053:9
      >  #10 0x2ab00730d08b in writerfilter::dmapper::SectionPropertyMap::ApplyProperties_(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&) writerfilter/source/dmapper/PropertyMap.cxx:1489:24
      >  #11 0x2ab00731cede in writerfilter::dmapper::SectionPropertyMap::CloseSectionGroup(writerfilter::dmapper::DomainMapper_Impl&) writerfilter/source/dmapper/PropertyMap.cxx:1331:13
      >  #12 0x2ab006b9ede2 in writerfilter::dmapper::DomainMapper::lcl_endSectionGroup() writerfilter/source/dmapper/DomainMapper.cxx:2823:30
      >  #13 0x2ab0071db9f9 in writerfilter::LoggedStream::endSectionGroup() writerfilter/source/dmapper/LoggedResources.cxx:101:5
      >  #14 0x2ab006712a3b in writerfilter::rtftok::RTFDocumentImpl::sectBreak(bool) writerfilter/source/rtftok/rtfdocumentimpl.cxx:633:18
      >  #15 0x2ab0067a8c13 in writerfilter::rtftok::RTFDocumentImpl::popState() writerfilter/source/rtftok/rtfdocumentimpl.cxx:2789:13
      >  #16 0x2ab006a26134 in writerfilter::rtftok::RTFTokenizer::resolveParse() writerfilter/source/rtftok/rtftokenizer.cxx:105:33
      >  #17 0x2ab0067194f9 in writerfilter::rtftok::RTFDocumentImpl::resolve(writerfilter::Stream&) writerfilter/source/rtftok/rtfdocumentimpl.cxx:740:27
      >  #18 0x2ab0075ebae7 in RtfFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) writerfilter/source/filter/RtfFilter.cxx:147:20
      >  #19 0x2aafcf2873a5 in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) sfx2/source/doc/objstor.cxx:2261:30
      >  #20 0x2aafcf22d4d2 in SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:764:23
      >  #21 0x2aafcf4a4d09 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) sfx2/source/doc/sfxbasemodel.cxx:1841:36
      >  #22 0x2aafcfde31b3 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) sfx2/source/view/frmload.cxx:698:28
      >  #23 0x2aaffef07028 in framework::LoadEnv::impl_loadContent() framework/source/loadenv/loadenv.cxx:1110:37
      >  #24 0x2aaffeeead5a in framework::LoadEnv::startLoading() framework/source/loadenv/loadenv.cxx:379:20
      >  #25 0x2aaffeee3919 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/loadenv/loadenv.cxx:165:14
      >  #26 0x2aafff10ddac in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/services/desktop.cxx:596:12
      >  #27 0x2aafff10e11a in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/services/desktop.cxx:582:64
      >  #28 0x2aafab4c3938 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) unotest/source/cpp/macros_test.cxx:50:60
      >  #29 0x2aaf90aee900 in SwModelTestBase::loadURL(rtl::OUString const&, char const*) sw/qa/extras/inc/swmodeltestbase.hxx:621:23
      >  #30 0x2aaf90aed267 in SwModelTestBase::load(char const*, char const*) sw/qa/extras/inc/swmodeltestbase.hxx:610:16
      >  #31 0x2aaf90aec404 in SwModelTestBase::executeImportTest(char const*) sw/qa/extras/inc/swmodeltestbase.hxx:222:13
      >  #32 0x2aaf90cf4d31 in testTdf65642::Import() sw/qa/extras/rtfexport/rtfexport.cxx:1013:1
      >  #33 0x2aaf90cf62af in CppUnit::TestCaller<testTdf65642>::runTest() workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:166:6
      >  #34 0x2aaf4ee5d7dd in CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5
      >  #35 0x2aaf680c4cd6 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) test/source/vclbootstrapprotector.cxx:36:14
      >  #36 0x2aaf4ee17a87 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
      >  #37 0x2aaf5ea4a8a6 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12
      >  #38 0x2aaf4ee17a87 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
      >  #39 0x2aaf5abd5ef4 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:65:16
      >  #40 0x2aaf4ee17a87 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
      >  #41 0x2aaf4ed8c2ef in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12
      >  #42 0x2aaf4ee17a87 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
      >  #43 0x2aaf4ee14101 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:77:18
      >  #44 0x2aaf4eede065 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:181:28
      >  #45 0x2aaf4ee5a929 in CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13
      >  #46 0x2aaf4ee60ad3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30
      >  #47 0x2aaf4ee5fa3d in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
      >  #48 0x2aaf4ee60ad3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30
      >  #49 0x2aaf4ee5fa3d in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
      >  #50 0x2aaf4ef1eeb6 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27
      >  #51 0x2aaf4eedbe79 in CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:148:9
      >  #52 0x2aaf4ef20440 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14
      >  #53 0x52b642 in (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:305:20
      >  #54 0x52604d in sal_main() sal/cppunittester/cppunittester.cxx:455:20
      >  #55 0x524192 in main sal/cppunittester/cppunittester.cxx:362:1
      >  #56 0x2aaf50b3c730 in __libc_start_main (/lib64/libc.so.6+0x20730)
      >  #57 0x437658 in _start (workdir/LinkTarget/Executable/cppunittester+0x437658)
      
      Change-Id: Id170860cbff9f4cae5c87cb5cfc70ffe3bc8c9c5
      5e0edd5f
    • Markus Mohrhard's avatar
      d09bfe6b
    • Miklos Vajna's avatar
      tdf#102308 sw: improve redline timestamp precision · d9dca1ee
      Miklos Vajna yazdı
      It's not clear why it was like this since the initial import, but at
      least not clearing seconds is already an improvement.
      
      Change-Id: Ic452256d4ab47e6779ec71fe6576eacb5b74fb43
      d9dca1ee
    • Michael Stahl's avatar
      tdf#101164 sw: Insert Database Columns dialog: expect selection · bb0e9dd5
      Michael Stahl yazdı
      ... as bookmarks, not raw row indexes.  Bookmarks is what
      FmXGridPeer::getSelection() / FmGridControl::getSelectionBookmarks()
      always produce, and it's unclear to me if there even is a case where
      something other than a bookmark ends up pasted into Writer.
      
      The only case where dbaccess creates a selection that doesn't contain
      bookmarks is in SbaGridControl::implTransferSelectedRows() if no rows
      are selected but i haven't figured out how to reach that state.
      
      (regression in OOo 3.3)
      
      Change-Id: Ib45787bc002447338df775102790843f2cb1dd3b
      bb0e9dd5
    • Michael Stahl's avatar
      tdf#101164 sw: Insert Database Columns dialog: ensure one of ... · 984790f1
      Michael Stahl yazdı
      ... the radio buttons is active by default, in case there's no
      configuration to read the state from yet.
      
      Change-Id: If1c0462eb5cb9ea5177f1d5a8953b34fabd0829c
      984790f1
    • Michael Stahl's avatar
      o3tl: replace yet another sal_Size with std::size_t · 14bcb68c
      Michael Stahl yazdı
      Change-Id: I3f6a401d6d5ed7b44a71dc8bda559dcc4d57ee32
      14bcb68c
    • Noel Grandin's avatar
      fix build · 3f736b99
      Noel Grandin yazdı
      by reverting part of commit b18e1bc6
      "loplugin:unusedfields"
      
      Change-Id: I69274b54f65e22ec15a053b54af84635d245f51b
      3f736b99
    • Stephan Bergmann's avatar
      CPPUNIT_ASSERT_EQUAL disambiguation · 0a6c8bde
      Stephan Bergmann yazdı
      Change-Id: I31d30627badb08469f7e0fd3ded957df78b58275
      0a6c8bde
    • Noel Grandin's avatar
      tdf#102223 EDITING Deleting all content from a cell changes font formatting · 5865af09
      Noel Grandin yazdı
      The code in question was added in:
        commit 48ea88c8
        Author: Rüdiger Timm <rt@openoffice.org>
        Date:   Wed Mar 12 09:02:20 2008 +0000
        INTEGRATION: CWS impresstables2 (1.1.2); FILE ADDED
      
      So hard to tell what its original purpose was. Probably trying to clean
      up the model, but had the unintended side effect of removing styles.
      
      Change-Id: I7d774706c22cf72e914b356df9bbc5947ee2c1a5
      Reviewed-on: https://gerrit.libreoffice.org/28950Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      Tested-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      5865af09
    • Noel Grandin's avatar
      loplugin:unusedfields · b18e1bc6
      Noel Grandin yazdı
      Change-Id: I852e98b16fdcb88b04e39d11e3101d502c918c24
      Reviewed-on: https://gerrit.libreoffice.org/29078Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      Tested-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      b18e1bc6
    • Caolán McNamara's avatar
      Related: rhbz#1362451 avoid recursive ownerchanged handling during ownerchange · 8a382d4a
      Caolán McNamara yazdı
      Change-Id: Id9c12b7ce6458348890d7c7ff7fdb2cd37c4601c
      8a382d4a
    • Tomaž Vajngerl's avatar
      tdf#102295: remove mutex - use atomic for watchdog timings · 3e826f88
      Tomaž Vajngerl yazdı
      Change-Id: I6587bad8b7906faeae39735343278b10be78c05b
      3e826f88
    • Stephan Bergmann's avatar
      Related cid#1371287: Work around missing OStringBuffer move semantics · e1954f5b
      Stephan Bergmann yazdı
      ...by adding more assign op overloads instead
      
      Change-Id: I3686d6c29adc47b1a8c48be4260614fd53589c8b
      e1954f5b
    • Stephan Bergmann's avatar
      Related cid#1371289: Work around missing OUStringBuffer move semantics · 95ee4cab
      Stephan Bergmann yazdı
      ...by adding more assign op overloads instead
      
      Change-Id: I2d2e1b7f19d1b57528707ed5a5cce94b5fa5c2d0
      95ee4cab
    • Stephan Bergmann's avatar
      Related cid#1371287: Improve code to not depend on missing move assignment · 7e965ee6
      Stephan Bergmann yazdı
      Change-Id: I0397812ed7b728e03199d64929c42292fc9b1502
      7e965ee6
    • Stephan Bergmann's avatar
      cid#1371306: Add move semantics · 2bd18402
      Stephan Bergmann yazdı
      Change-Id: Id669a84742cc4ffa3bb9f225af7fa4d218999681
      2bd18402