Change-Id: I5063ae048ee940f9fd88925882df7ba8dc0daf09
Reviewed-on: https://gerrit.libreoffice.org/67786Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Fails with commit e8b9572b (sw btlr
writing mode: implement initial layout, 2019-02-12) reverted.

Change-Id: Ic68ef53a8b5bf86678d7e67c9960501f23341268
Reviewed-on: https://gerrit.libreoffice.org/67776Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: I924f5d8505f2c2132c79304e19cf89a8ef466ae4
Reviewed-on: https://gerrit.libreoffice.org/67771
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: I1980cfd444e4ccee6574878fb6d6dd507bc972d5
Reviewed-on: https://gerrit.libreoffice.org/67673
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

An easy way would be to just extend aXML_WritingDirection_Enum, but then
we would write the new attribute value to a non-extension namespace.

So special case the new attribute value during both import and export
(and only for table cells as a start).

Change-Id: I431bf99693c4a3452e91f241bd2f0fcfc72c68fd
Reviewed-on: https://gerrit.libreoffice.org/67770Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

CertificateViewer, CertificateViewerGeneralTP,
CertificateViewerDetailsTP, CertificateViewerCertPathTP

Change-Id: I5792b673f17b3cd465ff17444776066139877ec1
Reviewed-on: https://gerrit.libreoffice.org/67756
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

(and fix one comment)

Change-Id: I1e2e72427b6021194b2010535e01b9ca69e4a029
Reviewed-on: https://gerrit.libreoffice.org/67760
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I4c6ffc89a21f46dea8775d4ec9aacc4f7ca71d94
Reviewed-on: https://gerrit.libreoffice.org/67764
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I7e5ed3c72fef12d31b5500acffff622b5f4129de
Reviewed-on: https://gerrit.libreoffice.org/66931
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: Ib8adefd90141007c0422b4c15ba9c2cc5f707f3f
Reviewed-on: https://gerrit.libreoffice.org/67762
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...from <https://github.com/flathub/org.libreoffice.LibreOffice/>:

commit ab8032d1e660db5e77ec7b64ac1d02e27941dfc5
Merge: d1aa013 42b6543
Author: stbergmann <sbergman@redhat.com>
Date:   Wed Feb 13 10:01:33 2019 +0100

    Merge pull request #73 from flathub/fix-quoting

    fix quoting

commit 42b6543ee833e5610465118bbea310ab87807d48
Author: Stephan Bergmann <sbergman@redhat.com>
Date:   Tue Feb 12 16:34:08 2019 +0100

    fix quoting

commit d1aa013fb631191174f6eb4d390ad5ea0b68a053
Merge: 35de93f dd48ab6
Author: stbergmann <sbergman@redhat.com>
Date:   Tue Feb 12 10:33:21 2019 +0100

    Merge pull request #69 from flathub/dotty-app-IDs

    rename sub-app .desktop files so they are strict sub-IDs

commit dd48ab67b00859a36c3f40a08112afb6078deecc
Author: Robert McQueen <rob@endlessm.com>
Date:   Fri Jun 1 12:27:05 2018 +0100

    rename sub-app .desktop files so they are strict sub-IDs

    The org.libreoffice.LibreOffice-foo names are not actually sub-IDs of
    org.libreoffice.LibreOffice which means that Flatpak will not export the
    additional components in the appstream. Change the - to . so that the
    sub-apps are correctly within the org.libreoffice.LibreOffice namespace
    rather than a mere prefix match. Set the X-Flatpak-RenamedFrom list
    in the .desktop files to include both the original upstream names
    and the - delimited old IDs that we used previous in the Flatpak.

    https://github.com/flathub/org.libreoffice.LibreOffice/issues/36

Change-Id: Ida8d5dc8ea38362f77ffb0cf58d3c998b69bd587
Reviewed-on: https://gerrit.libreoffice.org/67737Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I4c9259b5ba984c190b8e2601ed8f01a9e13ec1dc
Reviewed-on: https://gerrit.libreoffice.org/67661
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I3956de64c100e47ce180b1096df343eca6a87a4f
Reviewed-on: https://gerrit.libreoffice.org/67763
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

which is our new baseline (as discussed in ESC call 2019-02-07)

Change-Id: Ie94e2af4e9231fc355961cdf3d9241b1c5748943
Reviewed-on: https://gerrit.libreoffice.org/67750
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I81fdc1d3f2142e3ce47fba36281f8674c67ba0a4
Reviewed-on: https://gerrit.libreoffice.org/67759
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

When rechecking make sure to add
-I/$SRCDIR/workdir/YaccTarget/unoidl/source/
to the IWYU cmd to get correct results

Change-Id: Ie3c97d2152ebba80d7c84607bf82b9bed2790eae
Reviewed-on: https://gerrit.libreoffice.org/67520
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

We should restrict this to this case since the anchor of objects in the
body may appear on another page when the object is moved around.

In constrast, objects in header and footer should not appear on other pages,
so we still disable the "off-page positioning" for them.

Horizontal off-page positioning should be disabled in any case.

See also
tdf#112443 and tdf#120839

Change-Id: I056c74526f38c302ba49297f9f84ec0e958d2cec
Reviewed-on: https://gerrit.libreoffice.org/67088
Tested-by: Jenkins
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Just remove this update fields call, they are updated anyway.

Change-Id: Iaed1b6e7e1be8138ecb48e7557cc09ec0eeebda3
Reviewed-on: https://gerrit.libreoffice.org/67754
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I321d2b4994f8a65f0671790381e5ce8d87429581
Reviewed-on: https://gerrit.libreoffice.org/67589
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

since it is just a wrapper around PointerStyle

Change-Id: I51f065e0d4ad8bd91f5c84c5819048c720a19267
Reviewed-on: https://gerrit.libreoffice.org/67711
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

in SetAlwaysOnTop set window flags only, don't show the widget yet
(it'll be shown later, when it can be painted in full)

Change-Id: I5e855f1ebba1eb9985744ece055a0f141e965940
Reviewed-on: https://gerrit.libreoffice.org/67739Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>

From documentimport.cxx to validat.cxx
Use range-based loop or replace with STL functions

Change-Id: I59fb3ed20598e497b5653245f070298181da1331
Reviewed-on: https://gerrit.libreoffice.org/67587
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

It was added with 60f200ca "git-hooks: Copy them
from the build repo", but I don't see its purpose, and it caused trouble for me
now when trying to commit <https://gerrit.libreoffice.org/67672> "Merge in
Flatpak improvements".

Change-Id: I922b5be87549793466f99db8b12be6081e683292
Reviewed-on: https://gerrit.libreoffice.org/67674
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

As found out in 98c0b208 "Make Firebird the
(unconditional) default for new databases":  "(Curiously,
ODsnTypeCollection::getEmbeddedDatabase would read a DefaultEmbeddedDatabase
value from the configuration before resorting to the hardcoded default, but
`git log -SDefaultEmbeddedDatabase` makes it look like there has never been any
code to actually write that setting.)"

Digging deeper, the story appears to be as follows:  First, "INTEGRATION: CWS
hsqldb" commits in 2004 had addded the EmbeddedDatabases group (and accompanying
templates) to officecfg/registry/schema/org/openoffice/Office/DataAccess.xcs
(ee11cb63), corresponding values (for HSQLDB)
to officecfg/registry/data/org/openoffice/Office/DataAccess.xcu
(60c5f0af), and code to read those values
(lcl_getEmbeddedDatabase in dbaccess/source/ui/misc/dsntypes.cxx;
ODsnTypeCollection::getEmbeddedDatabaseURL et al in
dbaccess/source/ui/misc/dsntypes.cxx; all
a68938bc).  This looks like it actually worked.

Then, "INTEGRATION: CWS dba24b" commits in 2007 removed the EmbeddedDatabases
configuration data from
officecfg/registry/data/org/openoffice/Office/DataAccess.xcu
(473a3ccf, "during #i80930#: The approach to
read the concrete type of the embedded DB from the configuration does not work,
there are enough places where we silently assume 'embedded == embedded HSQLDB'")
and removed the code reading it (79bbd382), but
left the EmbeddedDatabases schema data in
officecfg/registry/schema/org/openoffice/Office/DataAccess.xcs untouched.

Then, b88a62cc "CWS-TOOLING: integrate CWS
dbaperf2" in 2009 reintroduced code that attempts to read the configuration data
as ODsnTypeCollection::getEmbeddedDatabase
(dbaccess/source/core/misc/dsntypes.cxx).  The reason for that may be
"2009-05-06 14:22:21 +0200 oj  r271589 : #i101587# use config for the drivers"
as listed in the commit message.  The code added as
ODsnTypeCollection::getEmbeddedDatabase back then remained effectively unchanged
until today, but looks fundamentally broken:  It starts out with trying to read
an /org.openoffice.Office.DataAccess/EmbeddedDatabases/DefaultEmbeddedDatabase/
Value property that can never be present per the schema (an
/org.openoffice.Office.DataAccess/EmbeddedDatabases/DefaultEmbeddedDatabase
property could be); so no data is ever actually read from the configuration by
ODsnTypeCollection::getEmbeddedDatabase.  (And the commit also didn't add back
any configuration data to
officecfg/registry/data/org/openoffice/Office/DataAccess.xcu that could have
been read in the first place, nor any code to generate such data
programmatically.)

So remove the broken code to read configuration data from
ODsnTypeCollection::getEmbeddedDatabase (which means it can be a static member
function now) and also remove the obviously unused EmbeddedDatabases group (and
accompanying templates) from
officecfg/registry/schema/org/openoffice/Office/DataAccess.xcs.

Change-Id: Icc9b34075b9b7e960df6c236d3595b7fabe71f9d
Reviewed-on: https://gerrit.libreoffice.org/67494
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ie5c5f6296e54b1118f1182766473f3f70eb37385
Reviewed-on: https://gerrit.libreoffice.org/67722Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Mostly just clean up with pylint, and changing variable
names to comply with the style guide.

Change-Id: I7298fbbcf394de19acf66d10447676d7d822d6f0
Reviewed-on: https://gerrit.libreoffice.org/66198Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Export the data label separator XML tag and
the separated character to OOXML.

Change-Id: I9b3bcb588e42a42494107ebde70f4a72492cfac4
Reviewed-on: https://gerrit.libreoffice.org/67753
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Both of Draw's "Insert - Snap Guide..." and "Shape - Duplicate..." dialogs have
MetricSpinButtons with ranges set programmatically in the dialogs' ctors.
Computing the ranges' min and max values was done via SetMetricValue, which does
any necessary unit conversions and then sets the MetricSpinButton's current
value, which is then read back out in the dialog ctors (again, doing any
necessary unit conversions) and finally set as the min or max range value.

However, setting a MetricSpinButton's current value clamps it to the min and max
range values that are currently in effect (i.e., before they have been set
programmatically), so the corresponding .ui files specified very large initial
values for those.  Large enough so that any actually set current values will not
artificially be clamped, but also so large that
weld::MetricSpinButton::ConvertValue, which indirectly gets called during the
above computations and converts from sal_Int64 to int, would produce Clang
-fsanitize=implicit-signed-integer-truncation warnings (e.g., "implicit
conversion from type 'sal_Int64' (aka 'long') of value -56692913386 (64-bit,
signed) to type 'int' changed the value to -858338538 (32-bit, signed)" from
within the CopyDlg ctor).

So don't use SetMetricValue to compute the min/max range values.  That way, the
MetricSpinButton's current value is not set before the computed min/max range
values are actually set, so the .ui file doesn't need to contain any static
min/max range values.  Also, both dialogs call SetFieldUnit, which also sets the
MetricSpinButtons' increment values, so those don't need to be set statically in
the .ui files, either.

Change-Id: I191cfc3837278530e0c3a87e00708c4c76a76361
Reviewed-on: https://gerrit.libreoffice.org/67734
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

... for My Documents and My Templates.

It seems customary to name XDG_*_DIR in all uppercase.  This also
fixes buffer overrun IIUC, as osl_readLine() does not return the
newline delimiter.

Change-Id: If85ca7e6abe663e29d36b65a08d358d3d7d27c4b
Reviewed-on: https://gerrit.libreoffice.org/67741
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iede1d3321e909329cb0754a26e5b4bee4bb60316
Reviewed-on: https://gerrit.libreoffice.org/67752
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Id16726ad6f0cd5aeae0b55c817d02b315506e863
Reviewed-on: https://gerrit.libreoffice.org/67747
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Fix various cases which trigger this warning:

warn:legacy.osl:10975:10975:sw/source/core/txtnode/swfont.cxx:427: Unsupported direction

Which means that we tried to work with a VCL direction of 900, without
passing around the btlr flag accordingly.

Change-Id: I96374fc949f60e8324c5a84de48b710b6461bafb
Reviewed-on: https://gerrit.libreoffice.org/67746
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Checkboxes moved above the listbox

Change-Id: I8f4ef437815741e26032f47c952c32d3e5d7db56
Reviewed-on: https://gerrit.libreoffice.org/67712
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I38b916d217af05359754925f2ae68351486aa399
Reviewed-on: https://gerrit.libreoffice.org/67639
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

... image resolution: introduce local method to:
* use indexed getToken
* avoid getting all tokens in advance
* reduce calls to non-trivial getString method

Change-Id: Ib47c2e9bb5788132328fbda1b1dce05e495ad3ed
Reviewed-on: https://gerrit.libreoffice.org/67638
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: Ibd9d23b914645fdf52403c6c9d90a4058f2cf406
Reviewed-on: https://gerrit.libreoffice.org/67637
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: Iac7b4caf58706e153981be7994cba1929520f44c
Reviewed-on: https://gerrit.libreoffice.org/67636
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: I070cd4903a1aae0c5b22f0991ebf274b8dc09974
Reviewed-on: https://gerrit.libreoffice.org/67632
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: Ib018761e35841a5128a2ef1a7318ce7fac448e5c
Reviewed-on: https://gerrit.libreoffice.org/67630
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: I393c53d7501afc6cd75a4c463031db94574b4ec7
Reviewed-on: https://gerrit.libreoffice.org/67629
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>