- 07 Nis, 2013 5 kayıt (commit)
-
-
Luboš Luňák yazdı
Change-Id: I97d91a758dd82d64768d75c1d2ddd279de5f6034
-
Luboš Luňák yazdı
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
-
Chris Sherlock yazdı
Change-Id: I6378c79f77ab897bf5a4e39c00944037beeef328 Reviewed-on: https://gerrit.libreoffice.org/3220Reviewed-by: Andras Timar <atimar@suse.com> Tested-by: Andras Timar <atimar@suse.com>
-
Tor Lillqvist yazdı
Acquire the yield mutex in the VirtualDevice destructor only in a dbgutil build on OS X. (I added that acquire yesterday to fix an assertion when exiting on OS X.) Seems to fix a hang in "make subsequentcheck" on Linux. No idea what is going on exactly, sigh. Change-Id: Ifcb1897720998d0725a8db0d5f8c75848c6a30f7
-
Tor Lillqvist yazdı
Change-Id: Ifa07f9b5613b4a75c5b72178cb276b9c0b495a62
-
- 06 Nis, 2013 35 kayıt (commit)
-
-
Tor Lillqvist yazdı
Change-Id: I8766ba5258f923d47474fa77e14eb7fbff530ffc
-
Tor Lillqvist yazdı
Change-Id: Id0fdba93a5d3a46a79cebea8839bdfd467ef4f6f
-
Tor Lillqvist yazdı
Change-Id: I42991d7a9c9e0bd4a023739051393935efa5c29f
-
Tor Lillqvist yazdı
The LayoutManager for some reason has both a ToolbarLayoutManager pointer field, and a uno::Reference to an aspect (or whatever term one should use) of the same ToolbarLayoutManager. (I.e. esssentially two fields for the same thing. Why it doesn't create such variables where needed instead I don't know.) Anyway, for some reason there were lots of instances where a local variable was initialised with this second field but then never used. I removed those. (Surely just copying the field into a local variable doesn't have any interesting side effect that would explain this pattern?) Change-Id: Ibdfbd9476c39d3e83b58e81469b94d9a87444ca8
-
Tor Lillqvist yazdı
Change-Id: I1afd93fc9a56e85a30991bce9ca2350764cf1ec2
-
Tor Lillqvist yazdı
It seems to be the type_info most commonly looked up dynamically, even the only one in an initial test. I think it is a good idea to avoid dlsym() if possible. Change-Id: I0379c534e10efefafdd253ee651f6c74e4aa47d5
-
Tor Lillqvist yazdı
Change-Id: If0a6296c9b226c479413b475788d0c11d6ee7318
-
Tor Lillqvist yazdı
Otherwise we get an assertion failure in a dbgutil build from the DBG_TESTSOLARMUTEX() in OutputDevice::ImplReleaseGraphics() when quitting, at least in 64-bit LO on OS X. Change-Id: Ieb54e6b58033279f807fe91f4f6139018f643903
-
Tor Lillqvist yazdı
The end result is still not satisfactory but it is getting closer. Oh how nice it would have been to have some clean useful documentation for how the text layout machinery works. The number of entry points in the low-level "backends" (like CoreTextLayout) is quite small, so I doubt it would have required lots of text to document the "protocol" used between the upper layers and the layout machinery. Now one just have to use educated guessing aided by lots of debugging printout. But this is true for most of the codebase, of course. Change-Id: I791f190819a187418865279f6a5b4aa598e01d3c
-
Tor Lillqvist yazdı
Change-Id: I184c8c69f4a9afdb0019193b09f61c65e47d36ae
-
Tor Lillqvist yazdı
Change-Id: I89040b62c0961be160fcfaa793e48326fa7a584c
-
Tor Lillqvist yazdı
Change-Id: I9373647e5d710acb26c9818e6d06d4bfb862a7df
-
Tor Lillqvist yazdı
CTLineGetImageBounds() does not include space taken by trailing whitespace in the line. Change-Id: I403906daed952bac58fa11634beb6c7faa39b9b3
-
Tor Lillqvist yazdı
But like there, I don't know if it actually is needed or not. Change-Id: I25bf5d8cf160b56ee4deb47ab9774313eb9590c8
-
Tor Lillqvist yazdı
Change-Id: I6f185b4f55418e44956f9dd51e1e300f553ac355
-
Tor Lillqvist yazdı
Change-Id: Ie98d242777cec92db6512f53fe102ecc65dc469c
-
Tor Lillqvist yazdı
Change-Id: I06121b065f360ecfeddb25c9e1487f4849e453a2
-
Tor Lillqvist yazdı
Change-Id: Ib875973d31f71bab75973f683621118eb9cb927b
-
Tor Lillqvist yazdı
Change-Id: I144c93d0bdd8758dcdf490f29051c8dcaea500d8
-
Caolán McNamara yazdı
Change-Id: Ide7c37c9738ca640e7d80ede904ad8d7702e5a34
-
Miklos Vajna yazdı
Change-Id: Ic6e39b81c04d5e416d1a000def39b3a127fa7940
-
Caolán McNamara yazdı
Change-Id: I0e28425c25e07abe65c4162025fa35a4abe14121
-
Miklos Vajna yazdı
Change-Id: Id1720a55bf7984e2b1316fbfadb0d12ae7fd6b4d
-
Chr. Rossmanith yazdı
Change-Id: I3cd2129d98c3d936d8ec31f89554b37f12427c1c
-
Caolán McNamara yazdı
Change-Id: Ib6339c29f6820e75ff99aeb0547145597771d584
-
David Tardon yazdı
Change-Id: I73ce022d064c7ccfeb71f5560f112aac3d777bf7
-
David Tardon yazdı
Change-Id: Ife833566122da25c366938c9c2d127fca0903bb7
-
David Tardon yazdı
Change-Id: I52d2ed4b0454233da21e9040dd324772247113c1
-
David Tardon yazdı
Change-Id: Iac1d8d0646bff131b1ade79bb47a914b350f31f2
-
David Tardon yazdı
$(lastword $(MAKEFILE_LIST)) is not what is expected if the makefile includes other makefile as the first step (as some do). See UnpackedTarball.mk, where I already tried to workaround the problem. Change-Id: Ib713a698f52ba16f46fbbc4c50b43edd69c9a472
-
Caolán McNamara yazdı
Change-Id: I47af280e24bff248e6404ec18c1afef8c461b40b
-
Caolán McNamara yazdı
Change-Id: I8f290b1551663b7e967c6d77e8836a1f3d655834
-
Eike Rathke yazdı
Change-Id: I9fb66679725bb61ffcd5abc0f45a08e9e1960e6a
-
Tor Lillqvist yazdı
Change-Id: I3891441fee41dd56ff183c833b17d926722b8f91
-
Tor Lillqvist yazdı
Change-Id: I6497550e8f55f9ba08b0c4f20de0ea04be45d617
-