Change-Id: I190323ce910224f883c4370b2c752644a5a35edd
Reviewed-on: https://gerrit.libreoffice.org/42626Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Fixes the "Multiple timers in queue" assertion by effectively
removing it.

When debugging it became obvious, that PostMessage returns, even
if the message was not yet added to the message queue.

The assert happens, because we start the timer in the Scheduler
before Invoke(), so it fires, if we block in Invoke(), and then
reset the timer after Invoke, if there were changes to the Task
list.

In this case it fires during Invoke(), the message is added. We
restart the timer, first by stopping it (we wait in
DeleteTimerQueueTimer, to be sure the timer function has either
finished or was not run). And the try to remove the message with
PeekMessageW, which doesn't remove the posted message.

Then the timer is restarted, and when the event is processed, we
end up with an additional timer event, which was asserted.

As a fix this adds a (microsecond) timestamp to the timer message,
which is validated in the WinProc function. So if we stop the
timer too fast, the event is ignored based on the timestamp.

And while at it, the patch moves timer related variables from
SalData into WinSalTimer.

Change-Id: Ib840a421e8bd040d40f39473e1d44491e5b332bd
Reviewed-on: https://gerrit.libreoffice.org/42575Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I3bdc875963c413996ffb6403c44968447dbb3131
Reviewed-on: https://gerrit.libreoffice.org/42629Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I51700733fda3a08570085ed6745961cd1680eabd
Reviewed-on: https://gerrit.libreoffice.org/42588Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I452909cc1f0529ecb24b1f705a86a0a8bc1a3c9f

Change-Id: I045ed919daeefca612d7908dd7de50c36536c9a0
Reviewed-on: https://gerrit.libreoffice.org/42608Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/42627Tested-by: Jenkins <ci@libreoffice.org>

Fails without commit 54ad8ad0 (EPUB
export: initial table support, 2017-08-22).

Change-Id: Ie8d793a8851dba894c57f2071e1b4717fa1e17af
Reviewed-on: https://gerrit.libreoffice.org/42590Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Ic57418f3191cc3c30a348db3e784d4cfbeffae79
Reviewed-on: https://gerrit.libreoffice.org/42576Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>

Change-Id: I399f8266bf543aa7b31d7833bd27aa7bec8a6708

Change-Id: Ie041595ba604d4563d7ff356eee18ff3e50fef41
Reviewed-on: https://gerrit.libreoffice.org/42628Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>

And while moving it, get rid of the 'drawinglyer::tools' subnamespace.
Less potential confusion with the global 'tools' namespace.

Change-Id: Iab3c25be0cec7f3d182228d122837e9f2ac9a529
Reviewed-on: https://gerrit.libreoffice.org/42619Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

Change-Id: Ic15590a13bd3770ee5dd7db76b21c830a4fe73e2
Reviewed-on: https://gerrit.libreoffice.org/42587Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I038421749ed6f20d74984beb2e703ffa43a09ff3
Reviewed-on: https://gerrit.libreoffice.org/42620Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ibdb3144c0510ed723a01ca28d7cdcd6b21caec54
Reviewed-on: https://gerrit.libreoffice.org/42596Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

This reverts commit cd2725de.

Norbert's list of CI performance issues includes
"2/ clang plugin build should not be serialized (forced -j1)"

Change-Id: Ib77f951a31adc20f6a9f88e8b51632bd81273327
Reviewed-on: https://gerrit.libreoffice.org/42595Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I6a5779cee379b82d81cc73a0d0c154e6caa51424
Reviewed-on: https://gerrit.libreoffice.org/42613Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>

Change-Id: Id3a3fd5317aef2acdc30605f816c2656990a94b6

Removed __arm reference

Change-Id: I194d79ccb5ba2117e0f468080813bf8de1ada84a

Change-Id: I26680ecdb5f0db4f27180c221de062341af0265c
Reviewed-on: https://gerrit.libreoffice.org/42611Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

- tracking the error state in a bool
- which gets pushed by reference to subfunctions
- and signals back error state from a bazzilion different location
- in a long operation that is not grouped into one undo
- and then haphazardly triggers an indiscriminate Undo
- and in addition throws an excpetion

More likely than not leaves the client with an undefined half-reverted
state, which an impossible situation to properly recover. This either
has to be done properly or not at all.

Change-Id: I677f87e78c32f4d93c8d21e9df7130a2595da891
Reviewed-on: https://gerrit.libreoffice.org/42510Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

It uses random-access iterators, so just use O(1) increments

Change-Id: I9f80789d0bc03184d346c6814fd015bc06876acd
Reviewed-on: https://gerrit.libreoffice.org/42606Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ide8a97eae6e2fdc7d2dcccba1480ac55a9b555bc
Reviewed-on: https://gerrit.libreoffice.org/42593Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9024b8b614a4de83a4d927e1918f6d4904a7fccb
Reviewed-on: https://gerrit.libreoffice.org/42592Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

(just in case)

Change-Id: I7ba2967c1cef81a3f6604077d876c8b993f7f16a
Reviewed-on: https://gerrit.libreoffice.org/42609Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Fails without commit 28102e47 (EPUB
export: handle inline images, 2017-08-17).

Change-Id: Ie96430e9b2d988574464d359111619fc18109566
Reviewed-on: https://gerrit.libreoffice.org/42589Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I2e42f6b0f3835400bca008cca31129fc03a76359
Reviewed-on: https://gerrit.libreoffice.org/42607Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I30f371ad301eede82ddcece4d91ffcd32e164115
Reviewed-on: https://gerrit.libreoffice.org/42598Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Thanks to Maxim Monastirsky for the suggestion!

Change-Id: I6ab799848f80f785fd24905c0a540885c41afb86
Reviewed-on: https://gerrit.libreoffice.org/42494Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Fails when EPUBExportDialog::VersionSelectHdl() does not take the
version from the VCL widget.

Change-Id: I8f77643ffbd7766ecec7bc2e148259765ab635b8
Reviewed-on: https://gerrit.libreoffice.org/42600Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

clang-cl reported "error: comparison of integers of different signs: 'DWORD'
(aka 'unsigned long') and 'HRESULT' (aka 'long') [-Werror,-Wsign-compare]"

Change-Id: I568f03bd863ba63e30143483d9573042f3506de7
Reviewed-on: https://gerrit.libreoffice.org/42597Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

...imported from XLS

Change-Id: I45bc4a0182e6a62471bc02ac1bca31f9735e6566
Reviewed-on: https://gerrit.libreoffice.org/42508Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Updated the copyright date from 2014 to 2017

Change-Id: I9d2e6502c97bfa732ab636c9d47221a55d3cde56
Reviewed-on: https://gerrit.libreoffice.org/42547Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Since SbaTableQueryBrowser::implSelect returns a bool to indicate if everything is ok,
should return false when we entered in a catch

Change-Id: I9ae3ff3bf082278edb16a9b91701d6cf457e7179
Reviewed-on: https://gerrit.libreoffice.org/42564Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: If107d2ac01b7be91be34ff753b52f307a6e10f58

there are only "Descriptors".

Patch by: me

(cherry picked from commit ccc4532f)

Change-Id: Ifd4f34c7b1ba64b449222dc864a38df80f4c6727
Reviewed-on: https://gerrit.libreoffice.org/42535Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I2432bff8e1c102b83f0b7aff1303a03539ce0350
Reviewed-on: https://gerrit.libreoffice.org/42580Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I8bdf8a4c04256ad665960dd6f0d71d032156a34b

Change-Id: Iff59d3049ba40b4338ef8eec67d08a96b0834d2b
Reviewed-on: https://gerrit.libreoffice.org/42578Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I2b68f5640471ea827c09af1b5a319fb526a53b4b
Reviewed-on: https://gerrit.libreoffice.org/42579Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I674cad57ce30a885e126d3bcc921f8fcb53dc36d
Reviewed-on: https://gerrit.libreoffice.org/42577Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>