Change-Id: I1ddf3fe0e5fad265ae14712a23469b684253079d
Reviewed-on: https://gerrit.libreoffice.org/63241
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I4a3614461740bc921ef99d71e2d057f5a17a75a9

Change-Id: I3d160c71ac4874a66f036e3d91910e00cf47836d

Change-Id: I67e8e9e2ecd7ec89d51bd9597b54be53c3203d46

Change-Id: If4dcd0a3f316bd9812ffb12b8e64489d25ce89ca

Change-Id: I336924c43b6680c3742ca8c83801cbff3f346968

Change-Id: I74669145a1341ff2a715cdec32676dfdd290d1f3

Change-Id: I56aa03bd727b8cdea38de7948a4dad4532ee214c

Change-Id: I04279faaf11bd1249bcea0d07d60facefb5186d8

Change-Id: I6c367b00024e96aa4eef5490b3b296617851016f

Change-Id: I5e03fceb83a22b590a62b605c4ada279b937730a

Change-Id: Ifc509b3c31f6dbfd4d620aa451fd85b82b0ddb90

Change-Id: I0ffcbbfe2380755ff21532b314961c317ce0c69d

Change-Id: Ia71e4822ce863a296c7c0eb137c164538f9a0d27

Change-Id: I810172d045860f49819b9e25de8a2d5fe5f80dd8

Change-Id: I0a0068649fd688f311e1ba4865a51406c4ffd672

Change-Id: Ic5397601267f1953379a13a3e1ac69813d363045

Change-Id: I769660ab1832e76ed7ac272d0d2c973d14171c06

Change-Id: Ic72837cbb345a26faf3fd7cbf8739ddb6dc76cf9

Change-Id: Ibaa2835e73dc42a7296e4749fdfbd05e282e04eb

Change-Id: I8009565c5ae2580d0cdbf3b323b95d61c25c0dcd

Change-Id: I1f6468e1050924b0c6f6971ad6276932a3c91f75

regression from
	commit 87c06415
    clang-tidy performance-unnecessary-copy-init in sc

Change-Id: I49a7099c0a5e9e684008d2e799f9ee94f867d786
Reviewed-on: https://gerrit.libreoffice.org/63239
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I8d90c3c9547bc2f36e9ccb3c2ba96b2a29012e07
Reviewed-on: https://gerrit.libreoffice.org/63222Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Change-Id: I0d7a64459de283dc10448e0086c66bedbf132553
Reviewed-on: https://gerrit.libreoffice.org/63133
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V547 Expression 'mpTargetSlideSorter != nullptr' is always false.

The code wasn't used since commit 4b83a7fe
(initially, mpTargetSlideSorter pointer was compared to a pSlideSorter
parameter, which was always nullptr since commit above; then commit
f946e905 removed the const parameter).

Change-Id: I70047ae3e7ef39419be0012e375856d8a50d5793
Reviewed-on: https://gerrit.libreoffice.org/63229
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V547 Expression 'pUnits' is always true.

Change-Id: I2bd31fcc31c36b43d14ff2a10a7143b9fbe86b3d
Reviewed-on: https://gerrit.libreoffice.org/63228
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

A legacy callout from toolbar 'Text', not a custom shape, is a
rectangle with an additional tail. Currently only the end of
the tail is dragable. The error was, that all points of the tail
had got markers and that the markers had got a wrong point reference.

Change-Id: I900b1294aaeefc0f46547c6db009a3c750955460
Reviewed-on: https://gerrit.libreoffice.org/63120
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

Full circle and ellipse have eight handles, all other legacy circle
kinds have two additional handles for to modify start and end angle.
The error was, that the loop was not adapted at its start, but at its
end, and the values 8 and 10 were interchanged.

Change-Id: I13204382a21f1b7900f0eafa18960e401e5a0c9d
Reviewed-on: https://gerrit.libreoffice.org/63103
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

Text box and rectangle have the same kind and number of handles in
'Edit Point' mode. Only that a text box has an additional handle for
its blinking frame. The error was, that this special one was not
skipped for a rectangle.

Change-Id: Iae7af3eb196e61e32ecd5a39ba0ec553bbdaaa48
Reviewed-on: https://gerrit.libreoffice.org/63070
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

A polygon consists of line segments without controls and curve
segments with two controls. Where two segments meet, can only be
'line to line', 'line to curve' or 'curve to curve'. So for a
handle which marks a meeting point of two segments, there are 0
or 1 control before and 0 or 1 control after. Thus a loop is not
needed and makes the code harder to read. Therefore I have
removed the loop.

Change-Id: I48bcdbdf028542e08b3f5ed3f66907f2993e26bd
Reviewed-on: https://gerrit.libreoffice.org/63036
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

Change-Id: I0b3c407331bfa1fa0c5003250d327d4f26de3643
Reviewed-on: https://gerrit.libreoffice.org/63235
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V555 The expression '(curpos - bufpos) > 0' will work as 'curpos != bufpos'.

Change-Id: I432c10c9c5ecc99293ec3f03f6e1a660e1c47e28
Reviewed-on: https://gerrit.libreoffice.org/63236
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V547 Expression 'Oep <= Osp' is always false.

Some of the conditions in the type detection code weren't reachable.
Also moved the code from class member to static function.

Change-Id: Iaf9dbe8ab15a1970b5cd580cf5d868715a234d02
Reviewed-on: https://gerrit.libreoffice.org/63230
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V547 Expression 'pFormat' is always true.

Change-Id: I11a32f903a08296fb9e6732032b7c7f00cb8aced
Reviewed-on: https://gerrit.libreoffice.org/63233
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V547 Expression '!pGroupInfo->m_pModule' is always false

The chunk of code updating module pointers was always doing nothing
since the beginning (commit 997cf427
from 2004), because the line to load the module was commented out.
So just remove it now.

Change-Id: I8db38e795662bba6b3b4693e7ba8a869a97acdd2
Reviewed-on: https://gerrit.libreoffice.org/63232
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

... which is apparently not needed anymore for #i41635. The revert allows
to properly skip "deselect" accessible event when there's no selection
previously.

Also removed the other identical correction, which was added in commit
4883fd31.

Change-Id: I87c629d679b5c253a3864061074bfde77507fb12
Reviewed-on: https://gerrit.libreoffice.org/63231
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I637ba12d0c1b7baa8f7f4be456e6101594eb934a
Reviewed-on: https://gerrit.libreoffice.org/63227
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I38d02cb771363f5012a18f41c5bf5c6fe728bd49
Reviewed-on: https://gerrit.libreoffice.org/62261
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I7340a561e0df0c781fd834388deb4b9f83800f9b
Reviewed-on: https://gerrit.libreoffice.org/63221
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>