1. 17 Ara, 2018 12 kayıt (commit)
  2. 16 Ara, 2018 15 kayıt (commit)
    • Caolán McNamara's avatar
      crashtesting: clamp languagetype param value · 71762113
      Caolán McNamara yazdı
      e.g. MSVR-34956-mergedlo_utl_ConfigManager-PoC5.rtf
      
      Change-Id: I8bc7d7aa2a188b284750b22716009b835d27c669
      Reviewed-on: https://gerrit.libreoffice.org/65229Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      71762113
    • Caolán McNamara's avatar
      crashtesting: assert on import of ooo121169-1.ppt · e6aaa946
      Caolán McNamara yazdı
      Change-Id: I3b57bdd9a29ef41900bbb244daa27bf6d8c673c7
      Error: comparison doesn't meet irreflexive requirements, assert(!(a < a)).
      Reviewed-on: https://gerrit.libreoffice.org/65228Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      e6aaa946
    • Stephan Bergmann's avatar
      Add back still-relevant part of external/graphite/ubsan.patch · a7603be5
      Stephan Bergmann yazdı
      ...which had been removed completely with
      6b847089 "graphite: update to 1.3.12".  See
      <https://ci.libreoffice.org/job/lo_ubsan/1137/>:
      
      > /workdir/UnpackedTarball/graphite/src/gr_face.cpp:98:16: runtime error: downcast of address 0x60f00008c3b0 which does not point to an object of type 'gr_face'
      > 0x60f00008c3b0: note: object is of type 'graphite2::Face'
      >  2a 00 00 61  d0 17 e7 ff 99 2b 00 00  36 00 be be be be be be  88 d8 0e 00 d0 61 00 00  80 38 05 00
      >               ^~~~~~~~~~~~~~~~~~~~~~~
      >               vptr for 'graphite2::Face'
      >     #0 0x2b99fdaae105 in gr_make_face_with_ops /workdir/UnpackedTarball/graphite/src/gr_face.cpp:98:16
      >     #1 0x2b99fdaaeabe in gr_make_face /workdir/UnpackedTarball/graphite/src/gr_face.cpp:107:12
      >     #2 0x2b99fdfd6dc7 in _hb_graphite2_shaper_face_data_create /workdir/UnpackedTarball/harfbuzz/src/hb-graphite2.cc:114:18
      >     #3 0x2b99fdfd62f0 in hb_graphite2_shaper_face_data_ensure /workdir/UnpackedTarball/harfbuzz/src/hb-graphite2.cc:37:1
      >     #4 0x2b99fddb6a10 in hb_shape_plan_create_cached2 /workdir/UnpackedTarball/harfbuzz/src/./hb-shaper-list.hh:35:1
      >     #5 0x2b99fddb1478 in hb_shape_full /workdir/UnpackedTarball/harfbuzz/src/hb-shape.cc:133:33
      >     #6 0x2b99fc5867df in GenericSalLayout::LayoutText(ImplLayoutArgs&, SalLayoutGlyphs const*) /vcl/source/gdi/CommonSalLayout.cxx:440:23
      >     #7 0x2b99fb2345e4 in OutputDevice::ImplLayout(rtl::OUString const&, int, int, Point const&, long, long const*, SalLayoutFlags, vcl::TextLayoutCache const*, SalLayoutGlyphs const*) const /vcl/source/outdev/text.cxx:1310:36
      >     #8 0x2b99fb236220 in OutputDevice::GetTextArray(rtl::OUString const&, long*, int, int, vcl::TextLayoutCache const*, SalLayoutGlyphs const*) const /vcl/source/outdev/text.cxx:960:45
      >     #9 0x2b99fb235c56 in OutputDevice::GetTextWidth(rtl::OUString const&, int, int, vcl::TextLayoutCache const*, SalLayoutGlyphs const*) const /vcl/source/outdev/text.cxx:881:19
      >     #10 0x2b99fd105281 in ImplFontMetricData::ImplInitTextLineSize(OutputDevice const*) /vcl/source/font/fontmetric.cxx:325:30
      >     #11 0x2b99fb1c128c in OutputDevice::ImplNewFont() const /vcl/source/outdev/font.cxx:1062:38
      >     #12 0x2b99fb1bd46c in OutputDevice::GetFontFeatures(std::__debug::vector<vcl::font::Feature, std::allocator<vcl::font::Feature> >&) const /vcl/source/outdev/font.cxx:171:10
      >     #13 0x2b9a1a3c8607 in FontFeatureTest::testGetFontFeatures() /vcl/qa/cppunit/FontFeatureTest.cxx:58:5
      >     #14 0x2b9a1a401f2c in void std::__invoke_impl<void, void (FontFeatureTest::*&)(), FontFeatureTest*&>(std::__invoke_memfun_deref, void (FontFeatureTest::*&)(), FontFeatureTest*&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/invoke.h:73:14
      >     #15 0x2b9a1a401b0f in std::__invoke_result<void (FontFeatureTest::*&)(), FontFeatureTest*&>::type std::__invoke<void (FontFeatureTest::*&)(), FontFeatureTest*&>(void (FontFeatureTest::*&)(), FontFeatureTest*&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/invoke.h:95:14
      >     #16 0x2b9a1a40195c in void std::_Bind<void (FontFeatureTest::* (FontFeatureTest*))()>::__call<void, 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/functional:467:11
      >     #17 0x2b9a1a401533 in void std::_Bind<void (FontFeatureTest::* (FontFeatureTest*))()>::operator()<void>() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/functional:549:17
      >     #18 0x2b9a1a400340 in std::_Function_handler<void (), std::_Bind<void (FontFeatureTest::* (FontFeatureTest*))()> >::_M_invoke(std::_Any_data const&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/std_function.h:316:2
      >     #19 0x2b9a1a40259c in std::function<void ()>::operator()() const /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/std_function.h:706:14
      >     #20 0x2b9a1a3ff580 in CppUnit::TestCaller<FontFeatureTest>::runTest() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175:7
      >     #21 0x2b99d930dab8 in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5
      >     #22 0x2b99f39cf332 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:49:14
      >     #23 0x2b99d92de5fa in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
      >     #24 0x2b99e850d672 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12
      >     #25 0x2b99d92de5fa in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
      >     #26 0x2b99e5130312 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16
      >     #27 0x2b99d92de5fa in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
      >     #28 0x2b99d9273d82 in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12
      >     #29 0x2b99d92de5fa in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
      >     #30 0x2b99d92d7f02 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18
      >     #31 0x2b99d93705e5 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:28
      >     #32 0x2b99d930c135 in CppUnit::TestCase::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13
      >     #33 0x2b99d930ff12 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30
      >     #34 0x2b99d930f0ed in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
      >     #35 0x2b99d930ff12 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30
      >     #36 0x2b99d930f0ed in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
      >     #37 0x2b99d939eb32 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27
      >     #38 0x2b99d936f075 in CppUnit::TestResult::runTest(CppUnit::Test*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:9
      >     #39 0x2b99d939fa80 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14
      >     #40 0x543813 in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:316:20
      >     #41 0x54027d in sal_main() /sal/cppunittester/cppunittester.cxx:466:20
      >     #42 0x53f26e in main /sal/cppunittester/cppunittester.cxx:373:1
      >     #43 0x2b99daec8444 in __libc_start_main (/lib64/libc.so.6+0x22444)
      >     #44 0x42f454 in _start (/workdir/LinkTarget/Executable/cppunittester+0x42f454)
      >
      > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /workdir/UnpackedTarball/graphite/src/gr_face.cpp:98:16 in
      >
      > Error: a unit test failed, please do one of:
      >
      > make CppunitTest_vcl_fontfeature CPPUNITTRACE="gdb --args"
      >     # for interactive debugging on Linux
      > make CppunitTest_vcl_fontfeature VALGRIND=memcheck
      >     # for memory checking
      > make CppunitTest_vcl_fontfeature DEBUGCPPUNIT=TRUE
      >     # for exception catching
      >
      > You can limit the execution to just one particular test by:
      >
      > make CPPUNIT_TEST_NAME="testXYZ" ...above mentioned params...
      >
      > /home/tdf/lode/jenkins/workspace/lo_ubsan/solenv/gbuild/CppunitTest.mk:113: recipe for target '/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/CppunitTest/vcl_fontfeature.test' failed
      
      Change-Id: Iccb72ec8a4c507478858ceb5af32b75f5ae53a45
      Reviewed-on: https://gerrit.libreoffice.org/65226
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      a7603be5
    • Caolán McNamara's avatar
      drop scroll-wheel moves notebook page workaround · ee8881b7
      Caolán McNamara yazdı
      now that the double-decker monstrosity is in place
      
      Change-Id: I8bc8f98d0cfd2bf4506bbc61632c1e7b0f9cd3f1
      Reviewed-on: https://gerrit.libreoffice.org/65181
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      ee8881b7
    • andreas kainz's avatar
      nb groupedbar_compact fix table layout to sync with others · b3f4cf6b
      andreas kainz yazdı
      Change-Id: Iac5a3144f9790457c2ccbe0fb916b66421443a6c
      Reviewed-on: https://gerrit.libreoffice.org/65216
      Tested-by: Jenkins
      Reviewed-by: 's avatarandreas_kainz <kainz.a@gmail.com>
      b3f4cf6b
    • Julien Nabet's avatar
      tdf#122136: select first element if there's at least one · 8626e81d
      Julien Nabet yazdı
      See bt from https://bugs.documentfoundation.org/attachment.cgi?id=147594
      
      Change-Id: Ibf031b8024aa4952e2d3263a445cafdb3c031390
      Reviewed-on: https://gerrit.libreoffice.org/65220
      Tested-by: Jenkins
      Reviewed-by: 's avatarJulien Nabet <serval2412@yahoo.fr>
      8626e81d
    • sabri unal's avatar
      Update git submodules · 40328178
      sabri unal yazdı
      * Update dictionaries from branch 'master'
        - Related: tdf#121610 Do dictionary option titles Title Case
          
          Change-Id: I3ab12669bec1265ad06288a122661c5b77733e1b
          Reviewed-on: https://gerrit.libreoffice.org/64916Reviewed-by: 's avatarAdolfo Jayme Barrientos <fitojb@ubuntu.com>
      Tested-by: 's avatarAdolfo Jayme Barrientos <fitojb@ubuntu.com>
          
      40328178
    • Stanislav Horacek's avatar
      Update git submodules · a1c90cc6
      Stanislav Horacek yazdı
      * Update helpcontent2 from branch 'master'
        - update description of customization dialogs
          
          Change-Id: I0d79cadf06f97e937c91908f5ffe7083c1a83291
          Reviewed-on: https://gerrit.libreoffice.org/65205
          Tested-by: Jenkins
      Reviewed-by: 's avatarAdolfo Jayme Barrientos <fitojb@ubuntu.com>
          
      a1c90cc6
    • Sumit Chauhan's avatar
      tdf#121638 , Different angle shown between sidebar & size and position dialog · 294c3822
      Sumit Chauhan yazdı
      Bug solved , Changed the nTmp = 360+nTmp ,if nTmp <0.
      
      Change-Id: I855e634540c55ab91e8bbe5824014d304d87c8e9
      Reviewed-on: https://gerrit.libreoffice.org/65211
      Tested-by: Jenkins
      Reviewed-by: 's avatarHeiko Tietze <tietze.heiko@gmail.com>
      294c3822
    • Stephan Bergmann's avatar
      Fix o3tl::string_view streaming operator << · 0d2ac93f
      Stephan Bergmann yazdı
      (The unnecessary os.setstate(std::ios_base::failbit) was due to a misreading of
      C++17 [ostream.formatted.reqmts]/1.)
      
      Change-Id: I7d8285230cb316c7af45c76029e9629517d05d56
      Reviewed-on: https://gerrit.libreoffice.org/65217
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      0d2ac93f
    • Roman Kuznetsov's avatar
      tdf#119217 Deleting of unnecessary empty space in Document in use dialog · 9bc346dc
      Roman Kuznetsov yazdı
      Change-Id: I5d965f683520289c5f2466c5429c6fe8b574200a
      Reviewed-on: https://gerrit.libreoffice.org/65086
      Tested-by: Jenkins
      Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      9bc346dc
    • Mike Kaganski's avatar
      tdf#121987 follow-up: never fail MSU install; warn instead. · 0b6884b9
      Mike Kaganski yazdı
      This replaces commit 53058090. Now
      not only failure to start WU service, but also other errors during
      MSU installation won't break installation. E.g., running WU service
      as Guest does not prevent the service from starting; but installing
      updates fail, which makes previous solution incomplete.
      
      Instead, show a warning in those rare cases when an error happens,
      and continue. It will allow users to see the reason if they see
      "api-ms-win-*.dll missing" message later after installation. Of
      course, some small percentage of these warnings will be false, e.g.
      those on Windows 10. But those false messages must be really small
      minority, because only when (1) the installation fails (2) on a
      system with the component already present, such a message would be
      false. And it will not prevent the installation.
      
      This will not block unattended installations, since in those cases,
      MsiProcessMessage() will do nothing.
      
      Change-Id: I3a9e681e9d6701d092bd5c18bb4b68b4f77170f3
      Reviewed-on: https://gerrit.libreoffice.org/64874
      Tested-by: Jenkins
      Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      0b6884b9
    • Zdeněk Crhonek's avatar
      uitest for bug tdf#119954 · 7e7e203c
      Zdeněk Crhonek yazdı
      Change-Id: Id9dbd53f2902f484f9d1209953ff2ad58d77936c
      Reviewed-on: https://gerrit.libreoffice.org/65199
      Tested-by: Jenkins
      Reviewed-by: 's avatarZdenek Crhonek <zcrhonek@gmail.com>
      7e7e203c
    • Stanislav Horacek's avatar
      Update git submodules · d32e6d0c
      Stanislav Horacek yazdı
      * Update helpcontent2 from branch 'master'
        - fix small typo
          
          Change-Id: Ice019261f62cc4ade55ede48f492373877954d06
          Reviewed-on: https://gerrit.libreoffice.org/65215
          Tested-by: Jenkins
      Reviewed-by: 's avatarJulien Nabet <serval2412@yahoo.fr>
          
      d32e6d0c
    • Michael Weghorn's avatar
      SalGtk{File,}Picker.hxx: Add missing includes · 19d9ac10
      Michael Weghorn yazdı
      Since 'XComponentContext' and 'DECL_STATIC_LINK' are used,
      add the corresponding includes.
      
      Otherwise a successful build depends on the header being
      included after other headers that make sure that compilation
      still works.
      
      An error could be provoked e.g. by moving the
      '#include <gtk/fpicker/SalGtkFilePicker.hxx>' in
      'vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx' above all
      other existing includes.
      
      Change-Id: Ib23f8b714fb971238eab28a8d4d02414a0b13812
      Reviewed-on: https://gerrit.libreoffice.org/65208
      Tested-by: Jenkins
      Reviewed-by: 's avatarMichael Weghorn <m.weghorn@posteo.de>
      19d9ac10
  3. 15 Ara, 2018 10 kayıt (commit)
  4. 14 Ara, 2018 3 kayıt (commit)