Change-Id: Ia337bffa45a1949567f70586db480d92bb55b238
Reviewed-on: https://gerrit.libreoffice.org/49936Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I3d0657bcfcb9fca0d7f8c27499c159ddc5ccf47d
Reviewed-on: https://gerrit.libreoffice.org/49935Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I83e1536a1d45fffbf4fc5ddb611e382568ebf26c
Reviewed-on: https://gerrit.libreoffice.org/49934Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I0919b8e2c58dbe26154e4a7c7c77e8e63f665842
Reviewed-on: https://gerrit.libreoffice.org/49933Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ib9e3d20680cba684fea8b586a5ca4c5835ca6b42
Reviewed-on: https://gerrit.libreoffice.org/49932Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I4c91ce6eb47f2802313fed22357e5c960cea50b2
Reviewed-on: https://gerrit.libreoffice.org/49931Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I53e7e4ab0a1533266ce97d5a093a1742808b6215
Reviewed-on: https://gerrit.libreoffice.org/49930Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I5687d54bf2566898116c697f5a760cc0989ac0f6
Reviewed-on: https://gerrit.libreoffice.org/49955Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I8ddc1c04a76475d63a39dc21d36cda7a7aa26b9e
Reviewed-on: https://gerrit.libreoffice.org/49921Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

Change-Id: Ib6f2334a3f6f3f5c217a71e2967a69e354b0a473
Reviewed-on: https://gerrit.libreoffice.org/49956Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I62541dc48b7e9d5a906f32791437a86a8283a7bf
Reviewed-on: https://gerrit.libreoffice.org/49952Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ie0c082a4b43355e935594f2dda694edfc9cdf315
Reviewed-on: https://gerrit.libreoffice.org/49950Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ia144192a1374615c50fb3574f7a229926e43d7cb
Reviewed-on: https://gerrit.libreoffice.org/49951Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I44f7af1b44badce6ed09eeca0bb19760b5f22aa9
Reviewed-on: https://gerrit.libreoffice.org/49942Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I342e925a5dbc178962f720f1efc9ee001d235718
Reviewed-on: https://gerrit.libreoffice.org/49941Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

This leads to deadlocks if one thread is using the process factory
while holding the SolarMutex and another thread is calling the
BackingComp::getTypes method.

Change-Id: Ib4750aa1ebbfbf4f8dcd09ec2a218202450f4928
Reviewed-on: https://gerrit.libreoffice.org/49940Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I796d4ea0034ddae0427418f0d53a00c3dfa66871
Reviewed-on: https://gerrit.libreoffice.org/49939Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Ief98b93502c3c69f84e7de47393718370a839208
Reviewed-on: https://gerrit.libreoffice.org/49926Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>

...in SdXMLImport::SetConfigurationSettings (xmloff/source/draw/sdxmlimp.cxx) to
work with instances of sd::DocumentSettings (defined in
sd/source/ui/unoidl/UnoDocumentSettings.cxx, derived from
DocumentSettingsSerializer), at least on platforms using the strict by-address
RTTI equality check form (e.g., macOS).

(Cross-casts like this are not detected by loplugin:dyncastvisibility.)

Change-Id: I3f8712f9c64852cc8cb17c0c25211963360f117c
Reviewed-on: https://gerrit.libreoffice.org/49884Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I9513f6516cd665c395f865ea204531bf8efb10b1
Reviewed-on: https://gerrit.libreoffice.org/49883Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...now that it's empty after a1eff310
"tdf#114206 remove duplication of strings in startmodulecommands.xcu"

Change-Id: I46bd0e86a274b65919a4a3f4a4036a7858520376
Reviewed-on: https://gerrit.libreoffice.org/49879Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I63f94f4bb3865d0c2d211567588343e08878342c
Reviewed-on: https://gerrit.libreoffice.org/49282Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

m_xAktItemSet -> m_xCurrentItemSet
m_bAktAND_fNumberAcross -> m_bCurrentAND_fNumberAcross

in ww8par

Change-Id: I1f78120008530b17d2eab508c8649798fc7bedea
Note: Other occurrences of "Akt" will be done separately
Reviewed-on: https://gerrit.libreoffice.org/49905Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Icc48efc2f6c085ccf0754620dc1cbf5132a7f824
Reviewed-on: https://gerrit.libreoffice.org/49551Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

Change-Id: I43abef3fe4a177f9f7867fe86e18beac812c626b
Reviewed-on: https://gerrit.libreoffice.org/49923Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I3225398aa3d56f76a5e8a60aecb671665d94a717
Reviewed-on: https://gerrit.libreoffice.org/49920Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

In 193ec57c the comment not to change this bool was kept accidentally,
but memcpy was removed in that commit so this is no longer an issue.

Change-Id: I772d60bb940b3327f195707524b124d034f50f64
Reviewed-on: https://gerrit.libreoffice.org/49852Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Follow-up to 0e687595.
Props to Regina and Heiko.

Change-Id: I4a5b71230639edf8c22d9e21c29fa31b4a561e75

This is under the ongoing work to get rit of all usage of
GraphicObject URLs

Change-Id: I900e435ac36a4012ec36a2f0c1d909982c82660a
Reviewed-on: https://gerrit.libreoffice.org/49895Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Icc5742cc3b4e44ce6f7daa460af16a3c4aba82c8
Reviewed-on: https://gerrit.libreoffice.org/49894Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

This is an alternative to GetEmbeddedGraphicObjectStream which
uses URL as parameter and will be removed soon.

Change-Id: I3c7431bdeed0bd4ed3c7f48517a52846d0944ed2
Reviewed-on: https://gerrit.libreoffice.org/49893Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Ie7947abdf2e8e951c94006aae259ed1d84558b73
Reviewed-on: https://gerrit.libreoffice.org/49892Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Ice60d52c65f2e9071bb37f14a30f2eacbb9a159a
Reviewed-on: https://gerrit.libreoffice.org/49891Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Use fakeroot to call tar when creating the tar.gz archives
holding the desktop-integration parts to have root:root
as owner of the files inside those.

Change-Id: Idcdcb4dd398f330773671266dafb354711b0f093
Reviewed-on: https://gerrit.libreoffice.org/49827Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

'tar' must be run as root or faked to be run as root,
to make sure that file ownerships and permissions inside
the created tar archives are as desired (root:root).

Have fakeroot take care about creating an appropriate
environment rather than using the custom "libgetuid",
to no longer have to care about tar internals by ourselves.

This fixes the problem that file ownerships are incorrect
when tar version >= 1.24 is used for

* tar archives holding all the generated deb/rpm packages
  (created in 'download.pm')
* tar archives created by using the
  '--with-pacakage-format=archive' autogen option
  (created in 'simplepackage.pm')

Change-Id: Id20ccce4d002ff95c75292eda8080ca299eee3a5
Reviewed-on: https://gerrit.libreoffice.org/49682Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

The command to create Debian packages must be run
as root or faked to be run as root.
The 'fakeroot' makes sure the command is run in an environment
faking root privileges for file manipulation.

This makes sure that file ownerships and permissions inside the
created deb packages are correct.

Using fakeroot instead of the custom "libgetuid" makes it
unnecessary to care about internals of the underlying tools
(like tar) and changes in those by ourselves.

Change-Id: I2cbb203ab84f740377e535c1051c2b879779b164
Reviewed-on: https://gerrit.libreoffice.org/49597Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I793dd301a04435c79a97819497b9d34fa49e298b
Reviewed-on: https://gerrit.libreoffice.org/49697Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

This patch is sponsored by ULAKBIM/PARDUS project.
Signed-off-by: Mert Tümer <merttumer7@gmail.com>

Change-Id: I7ee137b2332f799e4301cc3507df4a7b86af74b9
Reviewed-on: https://gerrit.libreoffice.org/47806Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: Id271001411ae34269451008ca54ab5855aae7da5
Reviewed-on: https://gerrit.libreoffice.org/49305Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Ieff91dfd8195f1a5b8267753183e34e154a0c29a
Reviewed-on: https://gerrit.libreoffice.org/49913Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>