slightly less restrictive check when calling functions

Change-Id: I35e268ac611797b1daa83777cda02288a635aa32
Reviewed-on: https://gerrit.libreoffice.org/47259Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ie61537af3dd30e47cc5a9ab925e636686c0325f4
Reviewed-on: https://gerrit.libreoffice.org/47291Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Project: help  7c78c30b297d368b94ab82f761c032b59f225c06

Fix typos

Change-Id: I7ef82f8d2896f3687be1aacfd08b8cf0d0d6e105
Reviewed-on: https://gerrit.libreoffice.org/47273Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Project: help  1228aaeb66e050dfacd1ac57ec785bc2e13997df

Fix typo

Change-Id: I180510136adc14ff60f1474fbcf2365af7d5821e
Reviewed-on: https://gerrit.libreoffice.org/47274Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: I313f3a56fd99e7fb29e6f729cfe13e99adf1fed6
Reviewed-on: https://gerrit.libreoffice.org/47289Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Fixes the loplugin:stringconstant complains when using a unicode
vendor name.

Change-Id: Ib15e558585fe388f734da469e728909a48686ef0
Co-authored-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/47278Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I1fd91cca4aec91700f7db233b420fe27752d659b
Reviewed-on: https://gerrit.libreoffice.org/47272Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I10167618b66ad7662b001333244bc8188b71c783
Reviewed-on: https://gerrit.libreoffice.org/47270Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...introduced with 26be5f21 "unotools: don't go
belly-up if temp dir is wrong or empty".  At least Flatpak builds can create a
/not/found/dir directory just fine.

Change-Id: I73115ac99498ac584be77153ef66bba3036392c3
Reviewed-on: https://gerrit.libreoffice.org/47267Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I44f94ea59e2b7a7f9fb5c2c74268fbe4601936b3
Reviewed-on: https://gerrit.libreoffice.org/47258Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: I2ba866c408dbf49f1655cc08cc5d0df840eaf01e
Reviewed-on: https://gerrit.libreoffice.org/47271Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

We know that ISC_TIME is simply in units of
seconds/ISC_TIME_SECONDS_PRECISION.

Change-Id: I2896f53c2d32a773c535e19f55dd1314abd18ec9
Reviewed-on: https://gerrit.libreoffice.org/47266Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I1f759bf914e4a61fc943098f04661789d374ffdb
Reviewed-on: https://gerrit.libreoffice.org/47256Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: I2c7378e5226c1ce45a89b97ddce93bc0e6e96a33
Reviewed-on: https://gerrit.libreoffice.org/47257Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Here, we can just initialize the iterators with the right increment
instead of using while loops to increment them

Change-Id: I08b51ba11398dbb705d3ed83bfbf46df0deb7f21
Reviewed-on: https://gerrit.libreoffice.org/47224Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ia3d0c08fe29ead82195bb1088e577a1383d9b508
Reviewed-on: https://gerrit.libreoffice.org/47250Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Matthias Freund <matti_lx@secure.mailbox.org>

Change-Id: Ida13b0649f0b6b1bb25f906ca9ad3a891b45739d
Reviewed-on: https://gerrit.libreoffice.org/47262Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: I4b6ea89ae2072f4389a696ea3c96d8f7a5731e7a
Reviewed-on: https://gerrit.libreoffice.org/47246Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I4484ac461761e4c46364b4f473c7e62f8ec72103
Reviewed-on: https://gerrit.libreoffice.org/47243Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

no need to access them via methods

Change-Id: If0d1a65d6f56ce2fc585749d974ba13c9f2749b2
Reviewed-on: https://gerrit.libreoffice.org/47245Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I2b367a451c03b42120c7599158cc05b8c99e1697
Reviewed-on: https://gerrit.libreoffice.org/47216Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>

in document to open Go to Page dialog

Change-Id: I9782fa9a2d9c3d541e09bad4f721c9b2417f29d5
Reviewed-on: https://gerrit.libreoffice.org/47247Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>

Change-Id: I3f7f4b7ecfd53a918318c2091a0756ba327c98ba
Reviewed-on: https://gerrit.libreoffice.org/47057Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: If8f042c6ef02c204f8946900e9ea8b99f06a631c
Reviewed-on: https://gerrit.libreoffice.org/47240Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ie151389d318e39757b4050a2949281613fc521f6
Reviewed-on: https://gerrit.libreoffice.org/47239Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Matthias Freund <matti_lx@secure.mailbox.org>

Change-Id: I1e8b8ae65d9989683dde8f642f3c19355d10a571
Reviewed-on: https://gerrit.libreoffice.org/47238Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

remove default-able copy-ctors/assignments

Change-Id: I40255393899275a5825ffef4df3f08c6ce5348c2
Reviewed-on: https://gerrit.libreoffice.org/47140Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

* use line spacing also for the first line
* correct spacing in case of > 100% proportional spacing

* impedit2.cxx only code readability change

Change-Id: I24832e7dc2fa8cfbb2f9cdfe7062eaaaa63f1729
Reviewed-on: https://gerrit.libreoffice.org/46925Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>

There's no TINYINT or equivalent so let's do the same as setShort

Change-Id: Ia1154ee068b02f40e7efa21571036d8b49844859
Reviewed-on: https://gerrit.libreoffice.org/47234Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I5dc9c66ce17f6401fbc9683cf8b10bf62755a166
Reviewed-on: https://gerrit.libreoffice.org/47236Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I487cfe96e9fe65f9be39b2488880410bc7b4baea
Reviewed-on: https://gerrit.libreoffice.org/47228Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ibf8285efae7c570452954feb41a1a36bf44504a4
Reviewed-on: https://gerrit.libreoffice.org/47235Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The maximum size of a VARCHAR column in Firebird is 32765 bytes [sic].
We use the UTF8 character set and that means 8190 characters as each
character might take four bytes. The maximum size of a row in Firebird
is 64 KB [sic].

Avoids errors when creating sample tables using the wizard using just
the default values. If the varchar column lengths are under 8190 but
the total row size is too large you do get a relatively helpful error
message "new record size of <N> bytes is too big", but if you try use
a too large size for a varchar column, just some "SQL error code =
-204", "Impmentation limit exceeded", etc.

Change-Id: I17c2bed4fc098f4e159822f6f81242aae274da7b
Reviewed-on: https://gerrit.libreoffice.org/47232Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Readd comment explaining why we allocate a large buffer for
GetEnvironmentVariableW which was removed in commit
f78a2bcc:

    re-base on ALv2 code. Includes:
        Patch contributed by Herbert Duerr:
        #i118662# remove berkeleyDB from module xmlhelp (author=orwitt)
        http://svn.apache.org/viewvc?view=revision&revision=1213188
        #i119141# remove ISCII converter for now
        http://svn.apache.org/viewvc?view=revision&revision=1306246
        make exceptions for cppunittester verbose
        http://svn.apache.org/viewvc?view=revision&revision=1174831

        Patches contributed by Pedro Giffuni:
        Avoid some uses of non portable #!/bin/bash in shell scripts.
        http://svn.apache.org/viewvc?view=revision&revision=1235297

        Patch contributed by Oliver-Rainer Wittmann
        88652: applied patch, remove unicows deps
        http://svn.apache.org/viewvc?view=revision&revision=1177585

    drop OS/2 code, remove in-line assembler ARM atomics,
    and obsolete armarch header.

Change-Id: I75a222393e202e40d78f10fc97f5eb4aad2df743
Reviewed-on: https://gerrit.libreoffice.org/47018Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

It's the length of the OUString that we just made from the
OUStringBuffer that we want.

Fixes a problem where the code would try to execute an erronoeus SQL
statement like:

')EATE TABLE "Tasks" ("Notes" VARCHAR(32765),"TaskID" INTEGER,"EndDate" DATE,"StartDate" DATE,"Description" VARCHAR(65000),'

Too lazy to file a bug for this, the error should be obvious by just
reading the code.

Change-Id: I473cd8a7a9791700ca8b6467a84f4bad5dee4d55
Reviewed-on: https://gerrit.libreoffice.org/47230Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Idcc291dba5cb6d86e29d00f6b34905f6693f7540
Reviewed-on: https://gerrit.libreoffice.org/47207Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

see bt https://bugs.documentfoundation.org/attachment.cgi?id=138757

Change-Id: I493bf47b1541262a5ea78b541bc1f47f93cc73df
Reviewed-on: https://gerrit.libreoffice.org/47219Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>

Change-Id: Iabd06fbda15d2f83f6ee0cdd37b268910d380476

mostly to make my passstuffbyref loplugin happier

Change-Id: I148b6b418100de860dfc49aaec6c544d0fe14c72
Reviewed-on: https://gerrit.libreoffice.org/47225Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I2e4103bb496ed3d0677d036e2f8cec76d001d682
Reviewed-on: https://gerrit.libreoffice.org/47222Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>