Change-Id: I460e813e20a691c53738373376d3363f553bbab2
Reviewed-on: https://gerrit.libreoffice.org/42636Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iabab71ee076227bc38447ec109afaea1e53a86a6
Reviewed-on: https://gerrit.libreoffice.org/42643Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I8c2131f31e98e1cf6c790d446ddd84b17507d0ee
Reviewed-on: https://gerrit.libreoffice.org/42679Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>

Change-Id: I970201eb99c56db3ac5fefb9e113c0bb3b8c754b
Reviewed-on: https://gerrit.libreoffice.org/42678Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I5e830e91ae7c773ad3945550c640a190b6504796

~SwDDETable() accesses its boxes' start node but that follows the
SwTableNode and SwNodes::RemoveNode() counts backwards so the
box nodes are all dead.  This was always broken but spontaneously
started to crash today.

Because dtors don't have parameters, resort to a little subterfuge
to ensure ~SwDDETable() finds out where it is.

Change-Id: Id681005989dd1e9f2611e8c99841927a7c5f6bfa

Change-Id: Idf5239e2037dcfa808e016a726f5a980d862ede6
Reviewed-on: https://gerrit.libreoffice.org/42669Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

... now that we use the proper dialog that sets the proper filter
properties.

Change-Id: Iabc3e4b2c13b60bccc0b596a851109df32fe535c
Reviewed-on: https://gerrit.libreoffice.org/42668Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

It's unnecessary to call if a replacement was already done and might
even harm, though unlikely. (e.g. file extension "web")

Change-Id: I6615c9a31178770429b523e0ee878661f1b2b6e8
Reviewed-on: https://gerrit.libreoffice.org/42667Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: Ie0b13c0ed4657200b6c92ae66ea25093e35a6c8f
Reviewed-on: https://gerrit.libreoffice.org/42666Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

And using namespace css is sufficient, it's actually good to see some
namespace..

Change-Id: I8cd3418e04769bb2fd1c632d6d671b368aae06b3
Reviewed-on: https://gerrit.libreoffice.org/42665Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: Id09d9b21b2e6c018dd199a1911a9125c118abec2
Reviewed-on: https://gerrit.libreoffice.org/42658Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: I632a26c5f149fabbe3a4a1186bfbe822fff0ea24
Reviewed-on: https://gerrit.libreoffice.org/42656Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: I52847249b3e17a31f6c6bf76af7bfe91a414d072
Reviewed-on: https://gerrit.libreoffice.org/42657Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: I458655d52992e40c2330ec10628fcea0fdc00f76
Reviewed-on: https://gerrit.libreoffice.org/42655Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: I50852360a29b4d5fd08277fcb2198f7956f9ebe0
Reviewed-on: https://gerrit.libreoffice.org/42654Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: I66fc0e39a7a35969b937253c88326516949ea7e7
Reviewed-on: https://gerrit.libreoffice.org/42653Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Commit cf48347e didn't take into
account commit 632edfab landed
before it.

Change-Id: I108027a460943b14194adcff4af2a41b7720f3be
Reviewed-on: https://gerrit.libreoffice.org/42677Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

also add google maven repo, since

"The support libraries are now available through Google's Maven
repository. We no longer support downloading the libraries through the
SDK Manager, and that functionality will be removed soon.."
https://developer.android.com/topic/libraries/support-library/setup.html

Change-Id: Ica0a2542903f60c7bffa1daa2409b60422bde88f

Change-Id: I69d4157aaf6570cecd51ea59df20556914942e06
Reviewed-on: https://gerrit.libreoffice.org/42565Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I95b90128e93f0d88ed73601bcc5a7ca9279d4cf1
Reviewed-on: https://gerrit.libreoffice.org/42560Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

so it doesn't get removed again from sal/inc/pch/precompiled_sal.hxx
(see commit 4af9612f).

Also make necessary changes to some of the files that start to fail
building after running bin/update_pch.sh, so that the patch is
self-contained and leaves the tree in fully functional state.

tools namespace had to be prepended with :: to disambiguate from
drawinglayer::tools

vcl/inc/window.h includes were amended, because ExtTextInputAttr is
from vcl/commandevent.hxx, and enum class ShowTrackFlags is from
vcl/window.hxx

Change-Id: I47179622350754cba2f95d26a1bafd3dfbbc935b
Reviewed-on: https://gerrit.libreoffice.org/42559Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Move this to class GenericUnixSalData, which is deleted on shutdown.

Change-Id: I6366c12f255bfeca737b22259c3f58ffa2c6222c
Reviewed-on: https://gerrit.libreoffice.org/42632Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I7b41d9ec673cfb96f51b5008540df63fe78a7581
Reviewed-on: https://gerrit.libreoffice.org/42639Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I79f7390dda9c087ae4bc5af9855b72e888e284a1
Reviewed-on: https://gerrit.libreoffice.org/42641Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

DemoApp::xMSF doesn't need to be a member.

Change-Id: I3b2d0d4c58ab04e0a82b31938c5f64b274ca004e

VisualBackendTestApp::xMSF doesn't need to be a member.

Change-Id: I307ba56377b822a148db809c16b8ff05708d0ca7

class PPDContext actually looks harmless but it has an out-of-line
destructor so the plugin can't see that it's harmless, so use
default destructor instead.

Change-Id: I921a4cdaeb5c8fe286615162b9e9c2a8db47b300
Reviewed-on: https://gerrit.libreoffice.org/42633Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Move this to struct ImplSVWinData, which is deleted on shutdown.

Change-Id: Ie604c2105f1176858b4050fb34d37cf376f8f82a
Reviewed-on: https://gerrit.libreoffice.org/42631Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Ic64e5eaa6b524403e46f9907499b0b853792a971
Reviewed-on: https://gerrit.libreoffice.org/42640Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

There's even 2 of these; move them to struct ImplSVData
which is deleted on shutdown.

Change-Id: I8040cd6f9f31c0a1ab48987a490395f316d52220
Reviewed-on: https://gerrit.libreoffice.org/42630Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I51aa0a1155c468aa5d360c63f6f7c8d347078bf1
Reviewed-on: https://gerrit.libreoffice.org/42638Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

When compiling for the simulator it is like compiling
for macosx (64bit) but with other libraries, therefore
the bridge should be like the macosx.

Change-Id: I59f1442a5c77d09ad0bc4bf31c2432fc32ef725e

Change-Id: I8001df3ac89b81bffab871404efc90b6606e3eb3
Reviewed-on: https://gerrit.libreoffice.org/42637Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Welcome back autogen.lastrun. I just don't have the energy to convince
tinderbox maintainers to fix their scripts. Oh well.

This reverts commit 7496c833.

Change-Id: I06e0923980b98b37b06ab45d8db68424b01d4f71
Reviewed-on: https://gerrit.libreoffice.org/42645Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>

Change-Id: Ia088b86ed001e528042855690a1e9a9d07865beb
Reviewed-on: https://gerrit.libreoffice.org/42050Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>

Change-Id: I3b5593cd5b397e0297f67e2bc1b0d1ff6a3a9582
Reviewed-on: https://gerrit.libreoffice.org/41953Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>

Change-Id: I46b92baf88661d49da2905699b9639522c0940d8
Reviewed-on: https://gerrit.libreoffice.org/42418Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

When loading a ODT template via HTTP, it crashes LO with an
lang::IllegalArgumentException in LockFileCommon::ResolveLinks.
This happens when closing the loaded template, as LO tries to
remove a not-existing lock. aDocURL at this point is empty, so
HasError() is true.

As stated in the comment, we don't need a lock for documents
created from templates, as this opens an internal copy of the
document, so don't mark the teplate document as locked.

Change-Id: Ide60020b6287aa67861dbcc8ec1b94f37896b7ef
Reviewed-on: https://gerrit.libreoffice.org/42485Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>