which is worrying, copy the other missing maSwapInfo too which should be safe
to do.

in the assignment operator, we don't copy any of those three fields at all, which
is inconsistent

save and restore the context and context flags on the piece where we overwrite
ourself via *this = tempobj

Change-Id: I06a7d491f95dcb113a3c705ceeb41f576ab0a514

seems to me that this hackery is to avoid the swapfile
getting pulled out from underneath it during swapin

Change-Id: I6b58d7e31731db8edc4026460beabc667204dcae
Reviewed-on: https://gerrit.libreoffice.org/33620Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

In theory it would still leak without this if the map mode is set
multiple times.

Change-Id: Ie862f4d59e45b92ff75dffb787ef256337f47f84
Reviewed-on: https://gerrit.libreoffice.org/33602Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>

same things, with less code

Change-Id: Ied67277f1a48b58aba094f3ca650c08133e95d68
Reviewed-on: https://gerrit.libreoffice.org/33619Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: Ic6fb995a76a30b60b597005e714de03d43c36a7c

... the dialogs that pop up on assert() and abort() to stderr, which
should work better in CI builds.

Change-Id: I80ec95bae6cc21b8ac27f68ca93aa6c6cce707f4

Change-Id: Idf7d63672e8b330499e53c1395dedb92d25bb76a

... and put the sidebar in a scrolled window

Change-Id: I57e982c849ed0c4dda4e8f5fdbcb0b85e46da36c

Change-Id: I282390f7319de2e24564e0122e8c0081235a0ef5

Change-Id: I82040893added83ff13395db3917b230ef6b01d5

Change-Id: I6762baac6c387d968dc6ee94d3494907c817214c

Change-Id: Ie97eac46fde075bd74c7adb583b8be979f3af829

Change-Id: Ieedb50a4d376c1214ea23b56c8cab19c96c159d0
Reviewed-on: https://gerrit.libreoffice.org/33615Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>

Change-Id: Id9bd288080fdd5ed4dfaee77b697954ad7bc2458

Pass --enable-tiled-annotations to gtktiledviewer on command line
to turn comments on again, by default they are turned off now.

Change-Id: I40e93ab683ec9538e088ae9aa83cda2eaaf9939e
Reviewed-on: https://gerrit.libreoffice.org/33622Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>

Change-Id: Icf5bb78859668bfb5c43efc3e5fa9afce8458f41
Reviewed-on: https://gerrit.libreoffice.org/33621Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>

Change-Id: Iba5289abf96b15e833cb85e96d4e60b2285271be

and use helper function IsInvalidItem() more

Change-Id: Ifd651a336a7bd4ef4f945219d765afb827465438
Reviewed-on: https://gerrit.libreoffice.org/33611Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

Change-Id: I94a1ea4cb81e2b7383c3e7c56314d08eea754434

so we can find where its been dragged from in order to remove it from that
source, rather than relying that it comes from the previously focused listbox

Change-Id: Ie6aa1a311b46e5e9ee96cab05e0705b794b5eb0b
Reviewed-on: https://gerrit.libreoffice.org/33575Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: Ide131a586d0d282993dfbf53a783f02d48860647

Change-Id: I3a39b7adc44a61f1bd4379c2a46e559ad12e7184

i.e. failure to swap in does not mean that mbSwapOut is true afterwards, and
mpSwapFile is discarded. It means the whole thing is thrown away.

Change-Id: I73704866d77078c73d053047a7d2ef6499a3e69d

Change-Id: I55cfacfd66ed31c8ec209d8deed7746ce917f8ba

Change-Id: I69f31a94f3e57b3488c576f8d8e0569f459a2117

57558f61 "#i108938# - commented out unused
member fuction."

Change-Id: I4972d0ff98f8fa21de4fa6506bc1bcbc7088f6d3

Change-Id: I5902c7a677b8b0d3d2891a5f793e5f8e457f25fa

...which was listed as explicitly not copiled with
24a129b9 "make it obvious some files are
intentionally not compiled ( temporarily )" but not removed completely with
09abd826 "remove uncompiled source files" (which
removed the other files from the first commit's list)

Change-Id: I232fa73680a2fbc64c6b57b85a626695b86d5f7a

... not only SbxINTEGER, SbxLONG, SbxSINGLE and SbxDOUBLE.

Change-Id: I75d892f5ae60ef1b18bd86e64777dea746e35a1f

Change-Id: I5bed51a3c03e2d55b9b7508d854cd486a35ea90e

Change-Id: I61971dfe3a2630ba33c029ce7865bd7077e235cc
Reviewed-on: https://gerrit.libreoffice.org/33613Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>

Change-Id: Ic6aaa3066923d62f197bc2b0e02e8049c9d7cd2c
Reviewed-on: https://gerrit.libreoffice.org/33612Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>

Change-Id: Ic5b636d5c77b3afff96fc6e4486041153dea9b2a

... instead of just checking if its a root comment or reply one.

Change-Id: I2539e6893ee69bfe12911807504df49edf422be2
Reviewed-on: https://gerrit.libreoffice.org/33470Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>

Change-Id: I298183b295c68c4a39cb1f6fffe4b89b4eaee0f3
Reviewed-on: https://gerrit.libreoffice.org/33469Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>

Change-Id: I1c3560ab4609c64da7a77e9a65febeb569ec1a3c
Reviewed-on: https://gerrit.libreoffice.org/33468Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>

Project: help  3e23a5bbb9a0de726b6739f0d60f187648c1dbf4

Fix text box in help page since box redesign

The search options are now under the "replace" box.

Change-Id: I65e704703501715c1e9417686fb2d1c9dcb074c8
Reviewed-on: https://gerrit.libreoffice.org/33579Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>

has been only active in instdir so far

Change-Id: I1028d1acb2186347448a1f86aaa864c3ba88f75d
Reviewed-on: https://gerrit.libreoffice.org/33584Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I3a7aa394792c47c6c5a3a553174d177e66ade617
Reviewed-on: https://gerrit.libreoffice.org/33582Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

As suggested in
https://lists.freedesktop.org/archives/libreoffice/2017-January/076768.html

Change-Id: I2562064ae906eb8b2d507ec971762625692a4bbf
Reviewed-on: https://gerrit.libreoffice.org/33608Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>