Change-Id: I9f986b89128c36e62cbfeedf500a116f40de74cc
Reviewed-on: https://gerrit.libreoffice.org/72939
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ia9adea465427a492ed0062c28e3e6dc09cc77673
Reviewed-on: https://gerrit.libreoffice.org/72927
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ieff9c7c7904b19b4202415b860b7a372503f46b6
Reviewed-on: https://gerrit.libreoffice.org/72926
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I22ec1ef8914262d20824b0d6d41a694820bac1b7
Reviewed-on: https://gerrit.libreoffice.org/72925
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Revert LO 6.3 bugfix d9a6eab1
because LO has changed the behaviour of implicit sections
when Protect Forms is enabled.  Now they are editable,
making the Protect Form compatibility option nearly useless.
(tdf#122201 commit d9a6eab1
which was backported to LO 6.2). Since implicit sections are
now editable in LO, they should export as editable.
See tdf#124451 for a one-sided discussion about this.

Since many people may have used this switch as a simple way
to create a protected form in the past, document this change
and point to sections as the way to set protection natively.

Protect Form is now only good for protecting the form field
itself from being deleted while the user is filling out the form,
and that is true only for legacy sw::mark::IFieldmark form fields
which have no UI in LO for adding them (.doc compatibility forms).

Change-Id: I938f015fe63c22e831654e96de77b5809bb924ff
Reviewed-on: https://gerrit.libreoffice.org/71716
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: Id54e7c4fb977a41e6a4a20d51543c45a9283480a
Reviewed-on: https://gerrit.libreoffice.org/72879
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Regression from:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3ff0c23b54ba4e7a534693ba25a3ffb27d1c18e1

+ some slight simplification

Change-Id: Ifa9d4d7d27e80217f778f3625ef4437828600dd3
Reviewed-on: https://gerrit.libreoffice.org/72922
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

This is useful for the Online, where we want to insert the text box
directly into the document so that it is visible right away.

Change-Id: I09ab2efba758aac077fa37ddfd20b1486b35b3ef
Reviewed-on: https://gerrit.libreoffice.org/72912
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

...from SvtValueItemAcc to unrelated ValueItemAcc in ~SvtValueSetItem.  The
Svt* classes had been copied from the non-Svt* ones in
4883fd31 "weld ScTabBgColorDlg", but this
static_cast had apparently been missed when copying ~SvtValueSetItem from
~ValueSetItem (and the originally copied SvtValueItemAcc::ParentDestroyed had
later been removed with d4d03761
"loplugin:unusedmethods").  But the static_cast in ~ValueSetItem would never
have been necessary in the first place (though that needs partial reversal of
508c95f1 "improve passstuffbyref return
analysis", which had unhelpfully changed ValueSetItem::GetAccessible to return a
reference).

Change-Id: If1c9bb617ac4ad3c24371729504f9082594c048f
Reviewed-on: https://gerrit.libreoffice.org/72914
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ic35c9898624f0c13b6d64725808e765a64c17081
Reviewed-on: https://gerrit.libreoffice.org/71937
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: I15bea9555422f96380d08e607b173b81d00b9ab1

...to svx::a11y::AccFrameSelector (which are unrelated final classes).  UBSan
Calc "Format - Cells... - Borders - Line Arrangement - User-defined:" and
clicking into the top-right corner of the widget caused

> svx/source/dialog/frmsel.cxx:972:50: runtime error: downcast of address 0x60f0003dfa80 which does not point to an object of type 'a11y::AccFrameSelector'
> 0x60f0003dfa80: note: object is of type 'svx::a11y::AccFrameSelectorChild'
>  e1 03 80 0d  90 4f c2 88 ce 7f 00 00  02 00 00 00 be be be be  00 00 00 00 00 00 00 00  00 00 00 00
>               ^~~~~~~~~~~~~~~~~~~~~~~
>               vptr for 'svx::a11y::AccFrameSelectorChild'
>  #0 in svx::FrameSelector::SelectBorder(svx::FrameBorderType) at svx/source/dialog/frmsel.cxx:972:50
>  #1 in svx::FrameSelector::MouseButtonDown(MouseEvent const&) at svx/source/dialog/frmsel.cxx:1114:21
[...]

The code was like that ever since 60f11adb
"Integrate branch of IAccessible2", which had presumably confused
AccFrameSelector and AccFrameSelectorChild here (while there'd apparently not
been a deeper need for the static_casts anyway).

Change-Id: I1f52629143dcfc84e57e9539a428fb0f51fdc72e
Reviewed-on: https://gerrit.libreoffice.org/72910
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

in
	commit d6865e5c
	Date:   Fri May 24 11:52:30 2019 +0200
    use std::unordered_map in RTFTokenizer

Change-Id: I5197eae86c4611d1598dbb60bae4962ad0576ecd
Reviewed-on: https://gerrit.libreoffice.org/72906
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

so pass in the shared_ptr we already have (and enforce that we pass in
the right one)

Change-Id: Ic481b5ec17c34ed9cba50586dedb6184505dee24
Reviewed-on: https://gerrit.libreoffice.org/72908
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Id05f65543eeb06526535ce9eaee354b4789e2069
Reviewed-on: https://gerrit.libreoffice.org/72883
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

it is just obfuscating the code

Change-Id: I72491d4861d06bd032bb014314c18605967aa3c9
Reviewed-on: https://gerrit.libreoffice.org/72824
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Hyperlink at numeric data lost after export.

tdf79972.xlsx: Test file from Excel 2016.

Change-Id: I6064724e6e38325386c4dfc8f1e9d93cce041975
Reviewed-on: https://gerrit.libreoffice.org/72894Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
Tested-by: Jenkins

of a paragraph after a tracked deletion in Hide Changes
mode (including hiding the numbering completely).

We add the numbering of the paragraph to the first node
of the deletion, so Hide Changes mode will show the
actual text content correctly.

Note: file saving already makes the same changes in the
deletion without this workaround, too.

Change-Id: I09d3ad2c05bfd6c7f9f65cfe21a4bade2ac18a14
Reviewed-on: https://gerrit.libreoffice.org/72784
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Under ASan, clicking into the Calc "input line" control (in the toolbars) caused

> ==26138==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x616000107a4c at pc 0x7fc890d792cb bp 0x7fff4cab6d90 sp 0x7fff4cab6d88
> READ of size 1 at 0x616000107a4c thread T0
>  #0 in Edit::IsPassword() const at include/vcl/edit.hxx:285:38
>  #1 in vcl::Window::getDefaultAccessibleRole() const at vcl/source/window/accessibility.cxx:327:73
[...]
> 0x616000107a4c is located 116 bytes to the right of 600-byte region [0x616000107780,0x6160001079d8)
> allocated by thread T0 here:
>  #0 in operator new(unsigned long) at /data/sbergman/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cc:105:3
>  #1 in VclPtr<ScInputBarGroup> VclPtr<ScInputBarGroup>::Create<vcl::Window*&, ScTabViewShell*&>(vcl::Window*&, ScTabViewShell*&) at include/vcl/vclptr.hxx:129:42
>  #2 in lcl_chooseRuntimeImpl(vcl::Window*, SfxBindings const*) at sc/source/ui/app/inputwin.cxx:157:12

This looks like it got broken with cca4d9ab
"convert WB_PASSWORD to a bool field on Edit" assuming that a Window of type
CALCINPUTLINE derives from Edit, even though ScInputBarGroup does not.

Change-Id: I1457c6cd07477ee0fa868c3949105aa96116a366
Reviewed-on: https://gerrit.libreoffice.org/72893
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

The problem was that in case the shape text has an explicit language
set, then the shape language will have no effect on shape text language;
need to clear those attributes explicitly.

The const_cast<> for the EditTextObject should be OK, since we change
the shape's item set anyway, so we don't omit any needed notifications.

Change-Id: I721e3f0aefa103a6bfa320a671da2ee1e039fa38
Reviewed-on: https://gerrit.libreoffice.org/72904Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: Ie4f1362510636006cae8a680b3ad2bbfa93e854b
Reviewed-on: https://gerrit.libreoffice.org/70449
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

does not need a separate thread

Change-Id: I47bf2b255a331f4ec3ea24ad3a5d4c3ca398557e
Reviewed-on: https://gerrit.libreoffice.org/72901
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Perhaps it fixes build with Chinese Windows.

Change-Id: I6541b6b7bdca140eaf6940436d5c629e7e8c3d91
Reviewed-on: https://gerrit.libreoffice.org/72896
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: I04adf5850fff872d27a8ddc344523de281448a80
Reviewed-on: https://gerrit.libreoffice.org/72895
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Introduced in commit a4066c77 ("Fix documented 'soffice
--accept' parameter syntax").

Change-Id: Iaa8e821abeb8bdbce36091c4d0264f658c677a76
Reviewed-on: https://gerrit.libreoffice.org/72905Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>

As in, really disable, so that they do not even show. This moreover
avoids tons of D9025 warnings from MSVC about overriding -W4 with -w.

Change-Id: Ia2e72fd72d883d91bdd89e467ee42f259e2ae033
Reviewed-on: https://gerrit.libreoffice.org/72899
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

to speed up

    make sw.check

Using a --enable-dbgutil --enable-optimised build, this takes my runtime
from 6m03 to 3m43

Change-Id: I79d2345c361d99d4a1c4402a4b7008bbb59b8184
Reviewed-on: https://gerrit.libreoffice.org/72902Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Jenkins

Change-Id: Ic89a07a6ac3103da77fae8d28f4295fd17c35f89
Reviewed-on: https://gerrit.libreoffice.org/69602
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

...from SvLBoxItem to SvLBoxString.  In a UBSan build, hovering the mouse over
the Navigator dialog in Calc caused

> sc/source/ui/navipi/content.cxx:727:39: runtime error: downcast of address 0x6030012a2820 which does not point to an object of type 'SvLBoxString'
> 0x6030012a2820: note: object is of type 'SvLBoxContextBmp'
>  15 02 80 76  50 8c 29 97 22 7f 00 00  00 be be be be be be be  10 d1 3a 01 40 60 00 00  00 00 00 00
>               ^~~~~~~~~~~~~~~~~~~~~~~
>               vptr for 'SvLBoxContextBmp'
>  #0 in ScContentTree::RequestHelp(HelpEvent const&) at sc/source/ui/navipi/content.cxx:727:39
>  #1 in ImplHandleMouseHelpRequest(vcl::Window*, Point const&) at vcl/source/window/winproc.cxx:183:25
>  #2 in ImplHandleMouseEvent(VclPtr<vcl::Window> const&, MouseNotifyEvent, bool, long, long, unsigned long, unsigned short, MouseEventModifiers) at vcl/source/window/winproc.cxx:729:13
>  #3 in ImplHandleSalMouseMove(vcl::Window*, SalMouseEvent const*) at vcl/source/window/winproc.cxx:2003:12
[...]

Change-Id: Iea5cda6e3be5c759eb71ad3100dc9b1870bda460
Reviewed-on: https://gerrit.libreoffice.org/72897
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

This patch makes multi selected chapter promote demote results the same
as when each selection is promoted or demoted individualy. Multi
selected chapter promotions (moved up) are done in tree list order from
top to bottom. Multi select chapter demotions (moved down) are done in
tree list order from bottom to top.

Change-Id: Iee238fd2bc84521a6eacf6688b94fa0be1e32f67
Reviewed-on: https://gerrit.libreoffice.org/71270
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

The shapes 'gear6' and 'gear9' need very special methods to
calculate the adjustment value from the handle position. Inserting
these methods shifts the other cases one level down, therefore the
patch looks large. The gear6 and gear9 shapes do not fit to the
common test pattern, so they are not included in the unit test.

Change-Id: I809e92d87118303332be87512062c431f235d859
Reviewed-on: https://gerrit.libreoffice.org/72796
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

Change-Id: I1ac3c3f5da3322d33c130cbd5de77c564b1e66ed
Reviewed-on: https://gerrit.libreoffice.org/72892
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

e.g. copy-DnD with Ctrl held down. This is qt5 remix of tdf#109227

Change-Id: Ib0794c7468cc04d3d50686952305717e10c90c9a
Reviewed-on: https://gerrit.libreoffice.org/72878
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I6b39bd25e243ab0f39847f6feb0b767d7358bf0f
Reviewed-on: https://gerrit.libreoffice.org/72635
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

...by 28bff4bd "convert nsRedlineType_t to
scoped enum", causing an invalid read in SwRedlineData::operator == during
CppunitTest_sw_uwriter.

Change-Id: I4e124532c84fa19e6e29e6d17ed48e34ccaa4042
Reviewed-on: https://gerrit.libreoffice.org/72887
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

The "BT" flag was not clear, so if the fly frame was first tbrl, then
switched to btlr, then this was changed back, the result was not tbrl
but tblr.

Change-Id: I9a258e64e7a6e5849edd5a6a21a6182f642e44ab
Reviewed-on: https://gerrit.libreoffice.org/72881
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

...since 6250b856 "implement new more user
friendly data provider dlg"

Change-Id: Ia3d6667700c01e42b323c0b949efde1783ebf946
Reviewed-on: https://gerrit.libreoffice.org/72884
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

This reverts commit 2b0cb3cf.
As per tdf#125371 there are changes in existing documents in cells that are re-calculated on file-open. IMO this needs to be fixed before this patch can be re-applied. As such there is no question on the changed settings in the Options.

Change-Id: Ib748cc520d4d475097cd5fd7e5500456b34f0789
Reviewed-on: https://gerrit.libreoffice.org/72860
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

Change-Id: Ifdd3df50b98641785a4b1d258092efe531e98e7d
Reviewed-on: https://gerrit.libreoffice.org/72870
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ie931fbec18b6b32b1f0f817df0e8a8ca31ca415a
Reviewed-on: https://gerrit.libreoffice.org/72864
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>