as in interim measure for SfxTabDialogs we throw
away the TabPage if its not suitable for reuse

Change-Id: Ic5776ca3d2a8cb6bf41f33df01b211f81c62a842
Reviewed-on: https://gerrit.libreoffice.org/43134Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iad0f0ded624e95448421c19a04535c2511b66a02

Change-Id: Ida4d8abe50885d10288169024b597fa946d1c26b
Reviewed-on: https://gerrit.libreoffice.org/43438Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...that are included from various source directories.  Change done in
preparation of loplugin:includeform.

Change-Id: I186ab7581ee7896c54a600e5cde8721a97b26425
Reviewed-on: https://gerrit.libreoffice.org/43444Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

nobody is setting a custom delta

Change-Id: I5dd9ac691fb226697eb8cb2b6b0b673552a4f049
Reviewed-on: https://gerrit.libreoffice.org/43437Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...that are included from various source directories.  Change done in
preparation of loplugin:includeform.

Change-Id: Ie46f4b940ceeb34fd8883dc17f56a072f625ee3a
Reviewed-on: https://gerrit.libreoffice.org/43442Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

instead of manual ref counting

Change-Id: I6b88b72dd28183feca46fc04841a2e8f19e5c47a
Reviewed-on: https://gerrit.libreoffice.org/43421Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

instead of manual ref counting

Change-Id: I04bdb5b34921da9ab08a55a95b99ff1635a9cda6
Reviewed-on: https://gerrit.libreoffice.org/43420Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

instead of manual ref-counting

Change-Id: I26e55ec7803e60f090f093b5584faec74ebbb8bb
Reviewed-on: https://gerrit.libreoffice.org/43419Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I5df10fe7477e05424eb5e8a3544073a264568aac
Reviewed-on: https://gerrit.libreoffice.org/43409Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and enhance ScCompressedArray with an iterator to avoid
O(n^2) "for" loops.

Change-Id: I7d8fda8306b0a5c73bf373b3991e1c07271bc9d9
Reviewed-on: https://gerrit.libreoffice.org/43387Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Idf76887a49561475587329c304329007034610a1
Reviewed-on: https://gerrit.libreoffice.org/43436Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

Change-Id: I0988401a9aa7afc25ea3a50883e4d3a5cfbe9d44

Change-Id: I282fc52f0b91b65a5e40a5e13b46fb65a1783176
Reviewed-on: https://gerrit.libreoffice.org/43428Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

Instead of throwing, since we don't want to display
empty properties in the header/footer.

Change-Id: I6ac205b7ac64ed61487472e0334260bacc2503df
Reviewed-on: https://gerrit.libreoffice.org/43427Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

Change-Id: I543d4bc41d06712cef81b8b0853144625f0b9940
Reviewed-on: https://gerrit.libreoffice.org/43413Reviewed-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Regression from

    commit 0ac1e2ad
    Date:   Wed Aug 2 09:39:43 2017 +0100

        Resolves: ofz#2833 null deref

and similar for date+time

    commit 42b894f8
    Date:   Sat Aug 5 19:15:36 2017 +0100

        ofz#2867 null deref

Effectively revert the code changes of those, leaving the test
case files intact, and "do the right thing" (switching two lines,
to

    nPos = nPos + sStrArray[i].getLength();
    i++;

nPos actually had always to be incremented by the length of the
*current* string position but was used after only as an error
position indicator, meaningless if there was no error.

Change-Id: I9bc4e5e56d70a275d26df0b72ed6a19e9297e0fa

/usr/include/c++/7/bits/stl_algo.h:4866:
Error: comparison doesn't meet irreflexive requirements, assert(!(a < a)).

... when using "Window->New Window" in Impress.

Change-Id: I885a59cf378b7020d549580c2fc1cf121c6a59bd

The problem was in SwFrame::GetNextSctLeaf(): it called WrongPageDesc()
to find out if pLayLeaf is a container that is on an acceptable page,
but it was too aggressive, and discarded a split table cell that was in
a follow table (so later it'll be moved to a next page), but on the same
page.

The result was that a new page was created, but later in
::doInsertPage() we noticed this unnecessary page and removed it. The
effect of that was that the in-progress layout action's m_bIsAgain flag
was set to true, restart the layout again and again.

Given that in-table split sections never need to create a new page frame
for the follow section (the cell does this for us already), just don't
discard pLayLeaf when WrongPageDesc() finds it and we're in the split
section-in-table case.

Change-Id: Iea98a26c14fc1fb3154378eab24daa2fd6e84459
Reviewed-on: https://gerrit.libreoffice.org/43429Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Likely a copy/paste error, imported from OOo.

Change-Id: I29713309164170e86f8e793e2f15a601ce2b5da7
Reviewed-on: https://gerrit.libreoffice.org/43431Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>

The prelink library depend on all static libraries,
there are no such gbuild variable, so instead we build
it unconditionally (not a nice hack)

Change-Id: I4946b01cce7c305e901b912b4c81d61fc8466b82

Android is using this script as well, so the iOS change
needs to be hidden behind a flag

Change-Id: Ica9064278f0b64ad3f078c7951eef15e39f2b6da

Change-Id: I86074b2bf6779834760e19cd206d469b93a1c480

Change-Id: I2af55a199106ae7ccc9ebe748b4295fd9f83e205

Removed object C and replaced with C to make lib pure.

Change-Id: Ie0f49f7e2f4577195dadfa0fdec70212af7c698a

Change-Id: Iee390bd5e241536d4f55743083468c433417f572

These names of variables correspond to German function names in Calc and were
translated to their English equivalents. For used translations, see, e.g.,
https://translations.documentfoundation.org/de/libo54_help/translate/#search=GDA&sfields=target&soptions=exact,case

Change-Id: I58be84b37e045ac15bcdf15032def7591be53de7
Reviewed-on: https://gerrit.libreoffice.org/43078Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: I75cbc6c40dfb4d558c3e09bac1a40805c4ade3e3

Change-Id: I3c60abcd73ce443c780deff2e3b9c79717e03a1e

...instead of implicitly next to the including file, in preparation of
loplugin:includeform

Change-Id: I81e3cd2dee707168064ff729f47e525b29bea43b

...that are included from various source directories.  Change done in
preparation of loplugin:includeform.

Change-Id: I9191e80aa721c376f17219e4d10eb83929e38e14

...instead of implicitly next to the including file, in preparation of
loplugin:includeform

Change-Id: I7649ea007d46102731893489bf3b5ff976a573f3

...instead of implicitly next to the including file, in preparation of
loplugin:includeform

Change-Id: Idcd561febdd4d788d4b63cb78b3304d1f33aa1ea

...instead of implicitly next to the including file, in preparation of
loplugin:includeform

Change-Id: If5025f2a91bf6f1ef5482a57dbfe4f02327cbdbc

Change-Id: Id9cf521f4ed79fa4b98794b40de7823c3a502537

...that are included from various source directories.  Change done in
preparation of loplugin:includeform.

Change-Id: I4c2160d1c682b37e93e1161796c67097866bf659

...that are included from both dbaccess/source/core/dataaccess and
dbaccess/source/core/misc.  Change done in preparation of loplugin:includeform.

Change-Id: I0572322810d8b4cd66a1b1f9e9deec893cafdbca

Artistic effects on bitmap images in OOXML files create a backup file
with the original image. These were not being saved into the proper
path for PPTX files because the `/word` directory was hardcoded in the
export code.

The path saved to the relations file was incorrect too because it was
not taking into account that the relations file is saved to a subdir
in PPTX and XLSX documents.

Finally, added a unit test.

Change-Id: I3e880ce763dc10dbc86ccf0e00871be5d36f6d88
Reviewed-on: https://gerrit.libreoffice.org/43338Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

...instead of implicitly next to the including file, in preparation of
loplugin:includeform

Change-Id: I4272c5e24eb887a36a6f3c296def375956f56499

...instead of implicitly next to the including file, in preparation of
loplugin:includeform

Change-Id: Ie7ea504e6c7d7fbe1ae5f1f3b6996ad03feaee76