We probably don't need salbtype.hxx include, but if we do we can
now change it with a more specific one - namely BitmapPalette.hxx
in most cases. This doesn't yet touch the includes in VCL.

Change-Id: Ie3067ccb2eec425650b41ce7fca48e368215f489
Reviewed-on: https://gerrit.libreoffice.org/70761
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Commit 6ff263b8 added a check in
SwUndoSaveContent::DelContentIndex() to avoid moving the anchor of a
FLY_AT_PARA if its new position would be a table node, because
SwFlyAtContentFrame::Modify() requires a SwTextNode to be the anchor.
However, that doesn't actually avoid moving the anchor - later,
SwNodes::RemoveNode() relocates the anchor to the next node regardless
of type!

It's probably better to just delete the fly in the situation when the
end position is a SwTableNode, which fixes the reported crash.

Unfortunately on Redo, the SwUndoDelete::UndoImpl() does not recreate
the nodes correctly, hence the fly then is inserted on the wrong node,
which later crashes again.

The problem is that due to the table node, a dummy SwTextNode is inserted,
which should be at the end of the range, but ends up at the start due to
an erroneous ++aPos.nNode; - the result is that the fly is inserted on
the dummy node and is immediately deleted again, triggering another
assert.  If there is a dummy node, it also doesn't make sense to call
SplitNode().

Yet another problem is that in SwUndoDelete::UndoImpl(), the frames for
the moved text nodes are not created, because the first node is skipped
with the wrong assumption that it already has frames.

Reportedly this started to crash with commit
e07feb94, previously it was just wrong.

Change-Id: I5094638e34c6ed52c836e57691d377b8cd1608f9
Reviewed-on: https://gerrit.libreoffice.org/70683
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I81917d697adf79b1bd0de4cc262d3cd6bc8eb36f
Reviewed-on: https://gerrit.libreoffice.org/70710
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

This had the same problem as the list node widget, fixed in commit
fb9c7e31 (tdf#97822 vcl opengl gtk2: fix
missing list node widget, 2019-04-12). Render output was missing in the
GL / SAL_GTK_USE_PIXMAPPAINT=1 case.

Change-Id: I24252c697523214a93f715759e242d47352c8341
Reviewed-on: https://gerrit.libreoffice.org/70760Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: I42a773e2d5b8e4deeafa8eeb2785913db36a47d7
Reviewed-on: https://gerrit.libreoffice.org/70688
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: Idb3a4dee104b2df0283852efcecbd0b25a765d5a
Reviewed-on: https://gerrit.libreoffice.org/70276
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: I530b81b3258a6e1c1456da53bfe1285f14aee712
Reviewed-on: https://gerrit.libreoffice.org/70734
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ia6d98985f2abf6733d54f49f448a2ce6d4e3572d
Reviewed-on: https://gerrit.libreoffice.org/70758Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

* basing on provided conn alg params
* also moved setting arrow direction from getConnectorType() to algorithms

Change-Id: I76898a4ccad961edd389677c31e7d8c05bcdf5fe
Reviewed-on: https://gerrit.libreoffice.org/70598
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: Iab32f67f911157c5d7c0db8f36ea638576cfd0bf

In combined charts, now X category axis crosses the Y axis at the right
place, all data series are attached to the right Y axis, and the
Y major grid isn't lost.

Note: Let's check which axis is attached to the first charttype
(in case of combined chart, the first one is a column chart) and create
that axis first. In OOXML standard, the first CT_valAx tag contains the
axID of the primary axis and the second CT_valAx tag contains the axID
of the secondary axis. 


Change-Id: Ib123f95ec41ef5dbbf0599efd7a646f4640a9b70
Reviewed-on: https://gerrit.libreoffice.org/70464Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>

Unused after 3df141b2

Change-Id: I2612b60db69fcd2f502388d37a21cf35f1394207
Reviewed-on: https://gerrit.libreoffice.org/70675
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I7ce2e8ab0bdc4b6799cd351828b7b3c24ebb1a96
Reviewed-on: https://gerrit.libreoffice.org/70757Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I41028c704eca08b71746c3c87e38926b95449775
Reviewed-on: https://gerrit.libreoffice.org/70735
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

to find stuff like
   OUString s = OUString("xxx")

Change-Id: Ie7ed074c1ae012734c67a2a89c564c1900a4ab04
Reviewed-on: https://gerrit.libreoffice.org/70697
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I0fff9ee06225d4ff2e9c0611b1b11f1d3b896be2
Reviewed-on: https://gerrit.libreoffice.org/70733
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I3a6c5807c3262dde6756551e9e955c4ceae09b4f
Reviewed-on: https://gerrit.libreoffice.org/70732
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This should prevent the crash - at least it did for me AFAICS.

Change-Id: I489264d8054e6577b948b0ab307c863d3140788a
Reviewed-on: https://gerrit.libreoffice.org/70755
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

completely outside allocated area.

Prevents crash in spell checker when scrolling into unallocated area, where
first visible column number is greater than maximal allocated column number.
The crash happened when std::vector::reserve threw std::length_error, and
Scheduler::ProcessTaskScheduling abort()ed catching that in std::exception
handler.

Change-Id: Id74706f4a5fedfcc5e4e316c7aea7f5a4fe110be
Reviewed-on: https://gerrit.libreoffice.org/70756Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

These tests are already ported to C++ in ScEditFieldObj_Header.

Change-Id: I548a50b6e717f706ff89dce530542a0a710185a7
Reviewed-on: https://gerrit.libreoffice.org/70754
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I43f7e328b45d0058f867f3296c5a34740d51b4da
Reviewed-on: https://gerrit.libreoffice.org/70752
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

As mentioned i#84653 ScPageObj and ScDrawPageObj are supporting the same
service and the later one was convert to C++ with commits
ed6a71ea,
f897e80d,
eb0653ee,
ee503c36
and b99ea0ff.

Change-Id: Icb05b2a03893f47e5f3816366cb9f3c94fd6faeb
Reviewed-on: https://gerrit.libreoffice.org/70751
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: Ie7578a8f1693d69ef5208659375968e43cb15aec
Reviewed-on: https://gerrit.libreoffice.org/70750
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I5d2751276497b0da8f50be21804ab6dd624b55ba
Reviewed-on: https://gerrit.libreoffice.org/70746
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I0eb72d26be05c5ce937f72930f2c16fce69c85e5
Reviewed-on: https://gerrit.libreoffice.org/70747
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I90a02374666929aed5ae00b08af3faa187f09a5b
Reviewed-on: https://gerrit.libreoffice.org/70749
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I0e9d0b444d9cb122c0e02cbf521ba8a8ff1bb52c
Reviewed-on: https://gerrit.libreoffice.org/70748
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

...and make Navigate By Page wrap

Change-Id: Iec45d87f665f75e90378c302b8c3098bb5cbe7d1
Reviewed-on: https://gerrit.libreoffice.org/70640
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

But still keep salbtype where all of them are included for now.

Change-Id: I54cdf7a8872ad5bb592402a4bce0f3b8f869c6b2
Reviewed-on: https://gerrit.libreoffice.org/70737
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

ImpNodeCache is specific to Octree so it's best that it lives
near the source.

Change-Id: I35e937343312b0ab18ed1a4dcaa067ea01a0191f
Reviewed-on: https://gerrit.libreoffice.org/70736Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I1dacc900707758d83a8cc31b107511bf926f72a6
Reviewed-on: https://gerrit.libreoffice.org/70738Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Idaf6df71470d2a838ac793bb992f979a51b1c581
Reviewed-on: https://gerrit.libreoffice.org/70739Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I23e3617274c1c17b9c3792f95eaf28d9554dc2b3
Reviewed-on: https://gerrit.libreoffice.org/70740Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I3f4a60a977c20b2e5d380fe9dd26d80a20099c05
Reviewed-on: https://gerrit.libreoffice.org/70741Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I7d52aea1917503a37cdc7d1ae16d7d2377397f30
Reviewed-on: https://gerrit.libreoffice.org/70714
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

V581 The conditional expressions of the 'if' statements situated
     alongside each other are identical.

Change-Id: I18562d60e33c7ecff14807976dde4cbcae3f665b
Reviewed-on: https://gerrit.libreoffice.org/70731
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I79ec1d0176f523d16c53220de9b0a0d9819729ea
Reviewed-on: https://gerrit.libreoffice.org/70729
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I4f142586ceedb8f51610139db914845892f65d2c
Reviewed-on: https://gerrit.libreoffice.org/70728
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Need to do this so it is at least somewhat formatted sanely before
refactoring to the data structures.

Change-Id: I136a539a190c2f53aa05cc9a26872a5606f81888
Reviewed-on: https://gerrit.libreoffice.org/70727
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Octree is a tree, that's used for color quantization, so it's
better to move it there. Headers are also moved to bitmap
subfolder so it's better organized.

Change-Id: I2b84a5469c1479cf0a060ba8eb46591dabab2883
Reviewed-on: https://gerrit.libreoffice.org/70726
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>