Change-Id: I4108cc3ec98796f6d5e2e5ba139f20f00a692d30
Reviewed-on: https://gerrit.libreoffice.org/39486Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

regression from
commit 8ccbc16b
"convert SvxFrameDirection to scoped enum"

Change-Id: I2063ddf4344fb41b54f2ad96a471df4d3205406d
Reviewed-on: https://gerrit.libreoffice.org/39478Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This reverts commit 28a03248 (and removes a
stry empty line).  There is no more need for our own /app/bin/xdg-open, as
xdg-open in the freedesktop.org (and thus also GNOME) runtime (see
<https://github.com/flatpak/flatpak-xdg-utils/blob/master/src/xdg-open.c>) by
now knows to ask the Desktop portal, too.

Change-Id: Ie4141d02ba5f43c0264afcfae9edfc2d3a8cdb16

Use Command instead of ActiveCommand
which delivers only SQL statements while expected
command type should be table, query or sql

Change-Id: I824a02cf5dab7b59f70b3a0ae9ba9f874e86733b

Change-Id: I390ba8851bb16ca37c2af97d2fa0ab6bdf4a9a14
Reviewed-on: https://gerrit.libreoffice.org/39481Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Tables-in-sections were already split across multiple pages, but not
secions-in-tables. To be safe still don't allow
sections-in-tables-in-sections, so you can combine these in both orders
now, but not recursively.

To achieve this, relax two "not in table" conditions to just require
"not in a table that is already in a section", and define that in case a
section-in-table is to be split, the follow section frame should be
inserted under the follow of its cell.

With this, finally the section frame in the bugdoc is split into two,
and the second section frame is moved to the second page as expected.

This restores commit f991b842, but this second
take makes sure that we do not crash while laying out ooo61225-1.sxw.
GetNextSctLeaf() used to assume that SwTableFrame::Split() created the
follow cell frames; and when that wasn't the case, it crashed. Still
don't attempt to create the cell frame in GetNextSctLeaf(), but handle
when the cell follow frame is missing, and return early, as it used to
be the case before this commit.

Change-Id: I9dcc76b4c61b39b9d23b140b84420e89cf274cf3
Reviewed-on: https://gerrit.libreoffice.org/39471Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I74d5a4b8cfc4b18267f99648a3112b163c91fd8c
Reviewed-on: https://gerrit.libreoffice.org/39474Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

write-only since GetIsMarked was removed in

commit 06ea347b
"loplugin:unusedmethods svtools"

which in was unused since introduced by

commit b755fb8c
Author: Steve Yin <steve_y@apache.org>
Date:   Mon Nov 25 16:15:58 2013 +0000
Integrate branch of IAccessible2

Change-Id: I1342d4c020e53380f4c52fadcbf36ff520efaad4
Reviewed-on: https://gerrit.libreoffice.org/39470Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Icf9da6a24d72c073338f6fbb513d7250b3898015
Reviewed-on: https://gerrit.libreoffice.org/39469Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ic5e4dac2626474dd3d44ef5097522bc7e2207cd1

Change-Id: I26dca32ba03c7fe163886ebcd4a6a8bc4871b065

Change-Id: I0459978c2cfb61cd7251f0e8d9a30f1f19c02c11

Change-Id: I6670c2fd0c5897939b16874ed2106475fa948d2d

Change-Id: I594596f27aa6f223d2294586357b11595377e1fe

Change-Id: Ib43dd6f8c96274d251bbf5935888789964ba3f9b

Change-Id: I13e11f07a8022b315ffa80282575472bcb0c3acc

Change-Id: I70cac146d09f015db3f7889f3cdd46c00c45c41a

Change-Id: Icc9d01b46975505c54a6395edfbeb15cf25c8700

Change-Id: I2ec41f641f3784ef86322c25481e6794e29eb889

Change-Id: I76dcc99c29302b49a1d66fa22db8b28714421a98

Change-Id: I0fde86dbaa4bfa9377445800db176a82211aad17

Change-Id: I0da74386a01c9a2db6436c9cd30aac204eb2ce73

I'd accidentally developed it against a Clang built without
LLVM_ENABLE_ASSERTIONS=ON, so only saw issues with
containsPreprocessingConditionalInclusion() now.

Change-Id: I5da6775a06de748e78b34a42f63b0543c3893124

Change-Id: I9edef3138964d3f43745be39956bc6bb66d0cc4d
Reviewed-on: https://gerrit.libreoffice.org/39403Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Johnny_M <klasse@partyheld.de>
Reviewed-by: Eike Rathke <erack@redhat.com>

...as had been done in sal/textenc/tcvtlat1.tab, in
5034e821 "Translate German comments and debug
strings (leftovers in dirs sal to sc)".  What those comments actually want to
say is that, despite being the ASCII control character region, those encodings
contain some graphic characters there.

Change-Id: Iefad9c45341891c3e91e6b9fb265d3070d1220ad

Change-Id: I427b15b35ef6e7c803cb8a00c961d35175ae8cb2

Lets assume the functionality will actually be implemented and the parameters be
used.

Change-Id: I8500b0f8cbd336132a357423b3e1651d52e605cc
Reviewed-on: https://gerrit.libreoffice.org/39455Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...ever since the code's introduction with
ef7f35db "#i107439# BIFF export: write
external link data correctly".

(There's already a StoreCellRange overload that would then have the same
signature as the one from wich the rToken parameter is removed, so rename
these functions with a trailing "_".)

I added two "TODO: remove?" comments at places where it's unclear to me whether
things should be cleaned up further.  This needs reviewing.

Change-Id: I2d69c8a21a219481e64a7f62757618d79ef32b81
Reviewed-on: https://gerrit.libreoffice.org/39456Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

std::unary_function is deprecated since C++11 and removed in C++17

90% done with regexp magic.
removed obsolete <functional> includes.

The std::unary_function base class was used in 3 places:
* chart2/source/tools/DataSeriesHelper.cxx: lcl_MatchesRole
   is used in a std::not1 function helper who uses the members
   return_type and argument_type.
   - replace deprecated std::not1 with a lambda
* chart2/source/tools/ModifyListenerHelper.cxx:
   lcl_weakReferenceToSame used the argument_type member in the
   operator() parameter.
   - inline the parameter type.
* xmloff/source/chart/SchXMLExport.cxx: lcl_SequenceToMapElement
   used result_type and argument_type in operator().
   - inline the types

Also fix compile error with gcc about finding std::for_each.

Change-Id: I073673beb01410c3108e7d0346d9e7d6b9ad2e2f
Reviewed-on: https://gerrit.libreoffice.org/39358Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Translates leftovers found using a custom regex and manually checking
the rest of the affected file.

Additionally:
- A few spelling fixes

Change-Id: I2b83bd11adf520b90bb29c8ea624990759dad3c6
Reviewed-on: https://gerrit.libreoffice.org/39427Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Iaf63c488f895c446bb54119d8c9f15e0adcd1eff
Reviewed-on: https://gerrit.libreoffice.org/39454Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Icf25b22857abd97e8b6a72d3d546fd1eed882049
Reviewed-on: https://gerrit.libreoffice.org/39385Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Translates leftovers found using a custom regex and manually checking
the rest of the affected file.

Additionally:
- A few spelling fixes

Change-Id: If54a0ecc58a429ee1c63abd43411c50304dab176
Reviewed-on: https://gerrit.libreoffice.org/39450Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I7792ccb06d25a532605ff8eee1bffe17d41c6ad5

...that causes

> clang/lib/AST/Type.cpp:1878: bool clang::Type::isConstantSizeType() const: Assertion `!isDependentType() && "This doesn't make sense for dependent types"' failed.

compilation failure in PCodeBufferWalker in basic/source/comp/codegen.cxx

>    static T readParam( sal_uInt8 const *& pCode )
>    {
>        short nBytes = sizeof( T );
>        T nOp1=0;
>        for ( int i=0; i<nBytes; ++i )
>            nOp1 |= *pCode++ << ( i * 8);
>        return nOp1;
>    }

with loplugin:oncevar.

Change-Id: I25417076549ea538adf013282f3657e0d642d776

Change-Id: I027b70ee92ab07eb68452457c3ee45de3ad22c8b
Reviewed-on: https://gerrit.libreoffice.org/39412Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I807f93757bfddf17f71568f1e3c174229f169f18
Reviewed-on: https://gerrit.libreoffice.org/39409Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

instead of long which has platform-dependent bitlength

Change-Id: I888458d7807027e237772940d4b2cc15c2971243
Reviewed-on: https://gerrit.libreoffice.org/39434Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

instead of long, which has platform-dependant length
(32bits on windows, 64bit on everything else)

Change-Id: I9b5a950f56dad99a016b481c221bfd103ffa3911
Reviewed-on: https://gerrit.libreoffice.org/39433Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ibc258a02ddb6385fb50206a6cc694f169432bd22