Kayıtlar (commit) · 902698412183e93a1bd018200c63054a422f2636 · LibreOffice / core

24 Ock, 2018 40 kayıt (commit)

Stephan Bergmann Ock 24, 2018 yazdı

Change-Id: I8ddf764f9e155c037e25855b7d6efc49eb494179
Reviewed-on: https://gerrit.libreoffice.org/48483Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

90269841

sal_Bool -> bool (remaining uses of css::uno::Any::has) · 9c8ae146

Stephan Bergmann Ock 24, 2018 yazdı

Change-Id: I041540307d48083955a74d20f73219ac458037fe
Reviewed-on: https://gerrit.libreoffice.org/48482Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

9c8ae146

gtk3: single click with selection set doesn't unselect · a283847a

Caolán McNamara Ock 24, 2018 yazdı

this is a safe backportable fix, the unconditional

nFlags |= SelectionEngineFlags::CMDEVT

looks the real dubious thing to me, but only the gtk3 backend has swipe support
so just returning immediately on a swipe definitely ok

Change-Id: Iade26d0d9260ce76dfb2766ac9e5ca9fa9275bf4
Reviewed-on: https://gerrit.libreoffice.org/48527Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

a283847a

tdf#114913 Use master if char size wasn't set · 1fe4f041

Paul Trojahn Ock 20, 2018 yazdı

The size returned by insertAt falls back to the master size if needed.

Change-Id: I741b48616c6c848fc641c597cc72bf8b17e3cad4
Reviewed-on: https://gerrit.libreoffice.org/48456Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

1fe4f041

tdf#115153 the missing test document · b7f12d8f
Michael Stahl Ock 24, 2018 yazdı
```
Change-Id: I74724ba61aadfad19501a87ab548219ea0a1f236
```
b7f12d8f

tdf#115153 writerfilter: RTF import: fix vert orient of Word 6 shapes · dc16cc04

Michael Stahl Ock 24, 2018 yazdı

The bugdoc is affected by the change of default vertical alignment;
apparently it's not even possible to set the vertical alignment of a
Word 6 drawing object (\do) so we have to set the Word default.

(regression from c79467ba)

Change-Id: I4084a7a7e2a55f864cb569e04632e034d59eefdb

dc16cc04

Remove old comment left over · 31531796
Eike Rathke Ock 24, 2018 yazdı
```
Change-Id: I5f6d47afc2f27b1033201b3fa280359a215f38b5
```
31531796

tdf#115129 change customize function tree expand collapse behavior · bf5739d7

Jim Raykowski Ock 22, 2018 yazdı

Change-Id: I6c20957fe3f95a8e63b30e5c733b99f71c193972
Reviewed-on: https://gerrit.libreoffice.org/48290Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>

bf5739d7

This presumably always wanted to check for SAL_MAX_UINT16, not USHRT_MAX · 1bf5b5b7

Stephan Bergmann Ock 23, 2018 yazdı

The check against USHRT_MAX was introduced with
9c034462 "INTEGRATION: CWS cmcfixes30: #i72614#
crash in loading corrupt .doc", apparently to ensure the static_cast<sal_uInt16>
in the call to ShortToSVBT16 below (which already was that same
static_cast<sal_uInt16> back tehn) is OK.

Change-Id: Ie385f0f490cab1c59bce07fa25bd9b92e3ad286a
Reviewed-on: https://gerrit.libreoffice.org/48439Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

1bf5b5b7

update credits · 3475b95a
Christian Lohmaier Ock 24, 2018 yazdı
```
Change-Id: I50973ddb45ec9269eac4954026ff25e28289dc5d
```
3475b95a

Remove presumably dead < USHRT_MAX checks · 06cfd5a9

Stephan Bergmann Ock 23, 2018 yazdı

...which are proably obsolete since 17e2497b
"INTEGRATION: CWS tl39: #i77024# chart2 with more than 26 columns" changed the
members of SwRangeDescriptor from sal_uInt16 to sal_Int32.

Change-Id: Ic383bc2d5f686af5b19a5ec2cd0351607958f672
Reviewed-on: https://gerrit.libreoffice.org/48470Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

06cfd5a9

[Pardus] tdf#108989 Add contextual validity command. · 844c9279

Gulsah Kose Ock 17, 2018 yazdı

When cursor is in a cell has following validity attributes
SC_VALID_WHOLE, SC_VALID_DECIMAL, SC_VALID_DATE,
SC_VALID_TIME,SC_VALID_TEXTLEN, SC_VALID_LIST,
SC_VALID_CUSTOM, Validity command appears on context
menu.

This patch is sponsored by ULAKBIM/Pardus project.

Change-Id: I47c0de7b62befdf02c343c1419cf32441d8f4df2
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/48067Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>

844c9279

Updated core · 2adf8113

Christian Lohmaier Ock 24, 2018 yazdı

Project: translations  5634878ae8bfcd66bdf403e9ae009eab7312c611

update translations for 6.0.0 rc3

Change-Id: I4f1d4959997ff3e5522b8947985937a372cb96f0

2adf8113

-Werror=parentheses (upcoming GCC 8) · 7ca9619d

Stephan Bergmann Ock 23, 2018 yazdı

Change-Id: I4522dc7929030c5da59f2ab030a806ebe7516bd1
Reviewed-on: https://gerrit.libreoffice.org/48403Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

7ca9619d

Use a more conventional way of zero-initializing class members · dc9e271c

Stephan Bergmann Ock 23, 2018 yazdı

...to avoid upcoming GCC 8 -Werror=class-memaccess ("clearing an object of non-
trivial type ‘class SalVisual’")

Change-Id: Id9c5a6fa7e084b5abd549c99d07f05f183d56a52
Reviewed-on: https://gerrit.libreoffice.org/48402Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

dc9e271c

Make ImplColorSet default ctor zero-initialize all members · 797ae3d3

Stephan Bergmann Ock 23, 2018 yazdı

...allowing to simplify creating the pColorSet array (which might want to be
improved even further, turning it into a unique_ptr or vector)

Change-Id: Ic05bd987057a0844885ccfc6ca52700770a27282
Reviewed-on: https://gerrit.libreoffice.org/48401Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

797ae3d3

Remove presumably dead < USHRT_MAX checks · 1dcc7efc

Stephan Bergmann Ock 23, 2018 yazdı

...which are probably obsolete since 93cb1f8b
"INTEGRATION: CWS swwarnings" changed the parameters of lcl_CreateXCell from
sal_Int16 to sal_Int32 (even though the < vs. <= and unsigned USHRT_MAX vs.
signed sal_Int16 inconsistencies are suspicious).

Change-Id: I14511cb7df1aa92630bf03d89d54609e7a440256
Reviewed-on: https://gerrit.libreoffice.org/48469Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

1dcc7efc

Add wiki header and footer to the output · a09958dd

Xisco Fauli Ock 23, 2018 yazdı

Change-Id: Iec0be65f57cac06756f2e8101d3edb89b126e92f
Reviewed-on: https://gerrit.libreoffice.org/48430Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

a09958dd

Natvis: update SfxItemSet visualizer (m_pItems is now unique_ptr) · 59ef7485

Mike Kaganski Ock 24, 2018 yazdı

Change-Id: I862f6399a9a065ef725211b44f77400927db9a8f
Reviewed-on: https://gerrit.libreoffice.org/48496Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

59ef7485

lokdialog: Convert the Table -> Properties... to async exec. · c3a085d2

Jan Holesovsky Ock 23, 2018 yazdı

Change-Id: Iac937f5032ddaa614f8364a85b0b8db2a0828cbd
Reviewed-on: https://gerrit.libreoffice.org/48454Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

c3a085d2

Adapt solenv/flatpak-manifest.in · 3bbf8d0a

Stephan Bergmann Ock 24, 2018 yazdı

...to e1026e26 "pdfium: update to 3312"

Change-Id: I319b00d13d8657849967e08e605d6428f30c5c2e

3bbf8d0a

writerfilter: use WW8 name for StyleId · 9dfd46ef

Justin Luth Ock 17, 2018 yazdı

The sStyleIdentifierD for the default style is "Normal".
FindStyleSheetByISTD uses sStyleIndentifierD for its comparison.
SetCurrentParaStyleId() is used to save the WW8 provided name.
Thus, the default style should do the same.

The SetCurrentParaStyleId was added here by
commit 4abb20ee
Author: Miklos Vajna
Date:   Tue Jun 19 17:36:28 2012 +0200

Also removing the static variable, since it serves no purpose.

Change-Id: I58659e9d809c32dd799fb46217971707991b2803
Reviewed-on: https://gerrit.libreoffice.org/48034Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

9dfd46ef

USHRT_MAX -> SAL_MAX_UINT16 · 7e15b28b

Stephan Bergmann Ock 23, 2018 yazdı

...presumably forgotten when the following cast of nTmp in the SetPosFromLeft
call was changed from USHORT to sal_uInt16 in
7f33ed41 "removetooltypes01: #i112600# Remove
tools types from sw"

Change-Id: I42d93aeb86473d6ff69251035dc22bbadcd5ae0f
Reviewed-on: https://gerrit.libreoffice.org/48466Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

7e15b28b

Fix documentation for osl_executeProcess_WithRedirectedIO · cca67d26

Milian Wolff Ock 23, 2018 yazdı

The file handle arguments are out parameters, not input parameters.

Change-Id: Iad604e4df9e89a8f83c4cb6a3faa35ee20cd80aa
Reviewed-on: https://gerrit.libreoffice.org/48450Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

cca67d26

This presumably always wanted to check for SAL_MAX_UINT16, not USHRT_MAX · 1438c84a

Stephan Bergmann Ock 23, 2018 yazdı

...ever since 84a3db80 "initial import", where
the code read

+    if( nIndex < USHRT_MAX)
+    {
+        const SwFmtRefMark* pMark = GetDoc()->GetRefMark( (sal_uInt16) nIndex );
+        if(pMark)
+        {
+            xRef = SwXReferenceMarks::GetObject( GetDoc(), pMark );
+            aRet.setValue(&xRef, ::getCppuType((uno::Reference<XTextContent>*)0));
+        }
+    }

and already contained the cast to sal_uInt16 in the call to GetRefMark

Change-Id: Ifd4c3ca0bd89a521c3eecda22435705396f61e16
Reviewed-on: https://gerrit.libreoffice.org/48464Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

1438c84a

ofz#5621 Integer-overflow · f50e94a3

Caolán McNamara Ock 23, 2018 yazdı

Change-Id: I98f93101dc287b2ef285f3d9547d44dd06d2fe01
Reviewed-on: https://gerrit.libreoffice.org/48429Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

f50e94a3

tdf#115080 menu id collision · 897dd277

Caolán McNamara Ock 23, 2018 yazdı

21 collides with the pattern field menu id

Change-Id: Ia90995861adabbe1615e24ee10defe25cee76c56
Reviewed-on: https://gerrit.libreoffice.org/48461Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

897dd277

Fix some IWYU warnings · fc2d155f

Miklos Vajna Ock 23, 2018 yazdı

Change-Id: I4b6e799c1afc2a762a3729ee89f3226c59a6eef8
Reviewed-on: https://gerrit.libreoffice.org/48462Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

fc2d155f

scripting: add missing vim modelines to python files · a7d67762

Miklos Vajna Ock 23, 2018 yazdı

Change-Id: Iedc3a8ab37deeb7a686fa709afb0cf350f815ec6
Reviewed-on: https://gerrit.libreoffice.org/48418Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

a7d67762

Avoid upcoming GCC 8 -Werror=class-memaccess on css::util::DateTime · 13a1a7e1

Stephan Bergmann Ock 23, 2018 yazdı

...whose ctor already zero-initializes all members, so the first two memsets are
unnecessary.  And spell the third memset as explicit assignments.

Change-Id: Ie5079711b152bac7f0a8d52d7889879157a35b5d
Reviewed-on: https://gerrit.libreoffice.org/48390Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

13a1a7e1

fix kde4 vclplug build · 025c58f7

Noel Grandin Ock 24, 2018 yazdı

by reverting parts of

    commit de8f6b25
    loplugin:unused-returns in vcl

and reverting

    commit 78bb1a2a
    Fix --enable-kde4 codeHEAD

<noelgrandin> sberg, is that safe ^^ ? I was just about to push a partial revert of the commit that caused the breakage
<sberg> noelgrandin, oops, I'd naively assumed that all impls of Dispatch had just always returned true

Change-Id: Icbca450a76de30a04bc90a2887066840191c9d5f

025c58f7

Fix --enable-kde4 code · 78bb1a2a

Stephan Bergmann Ock 24, 2018 yazdı

...after de8f6b25 "loplugin:unused-returns in
vcl"

Change-Id: I82414b20b7dbb9e7ba361c0f4d9451c74ea4d4f2

78bb1a2a

Remove presumably dead < USHRT_MAX checks · ab6d3b37

Stephan Bergmann Ock 23, 2018 yazdı

The original code of 84a3db80 "initial import"
read

+        long nBoxOffset = lcl_GetLongBoxNum( sGetName ) + nSttBox;
+        long nLineOffset = lcl_GetLongBoxNum( sGetName ) + nSttLine;
+
+        if( nBoxOffset < 0 || nBoxOffset >= USHRT_MAX ||
+            nLineOffset < 0 || nLineOffset >= USHRT_MAX )
+            return 0;
+
+        if( nLineOffset >= long(pLines->Count()) )
+            return 0;
+
+        pLine = (*pLines)[ USHORT(nLineOffset) ];
+
+        // dann suche die Box
+        pBoxes = &pLine->GetTabBoxes();
+        if( nBoxOffset >= long(pBoxes->Count()) )
+            return 0;
+        pBox = (*pBoxes)[ USHORT(nBoxOffset) ];

casting nBox/LineOffset to USHORT, while the current code looks like it should
work fine for larger values.

Change-Id: I47bdf3963be6e84568a589711ce688b66f325db8
Reviewed-on: https://gerrit.libreoffice.org/48451Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

ab6d3b37

iOS, allow orientations for all devices · e0e19de6

jan Iversen Ock 22, 2018 yazdı

Info.plist is no longer limited to ipad

Change-Id: Ibe807183fab7e2820e5234fa7fa773fda2c32926

e0e19de6

loplugin:useuniqueptr in OOo2OasisTransformer · 747d36d2

Noel Grandin Ock 17, 2018 yazdı

Change-Id: I6c1cabbf233e6d3d9fd37cdb5c66ffa17df2dd9c
Reviewed-on: https://gerrit.libreoffice.org/48425Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

747d36d2

loplugin:useuniqueptr in Oasis2OOoTransformer · ee5882b4

Noel Grandin Ock 17, 2018 yazdı

Change-Id: I7636bb09bfa728ae8031d57e52d2903f711e9cca
Reviewed-on: https://gerrit.libreoffice.org/48424Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

ee5882b4

loplugin:useuniqueptr in ImageListsDescriptor · cfb59817

Noel Grandin Ock 17, 2018 yazdı

Change-Id: I165af348b6d8863a4b1e5dd164d92c29f49d09c0
Reviewed-on: https://gerrit.libreoffice.org/48423Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

cfb59817

loplugin:useuniqueptr in LayoutManager · 570786e7

Noel Grandin Ock 17, 2018 yazdı

Change-Id: I93383fcb5f0093416914722e25cd0faf70c040eb
Reviewed-on: https://gerrit.libreoffice.org/48422Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

570786e7

loplugin:useuniqueptr in SvxBoxItem · 8eab42dd

Noel Grandin Ock 17, 2018 yazdı

Change-Id: I0702a25c765fc8781b65320f44c0e0c3c56269a7
Reviewed-on: https://gerrit.libreoffice.org/48408Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

8eab42dd

loplugin:useuniqueptr in SfxCommonTemplateDialog_Impl · 3199d25a

Noel Grandin Ock 16, 2018 yazdı

Change-Id: I484cb863c054c71cb22b30d108c95692213c8451
Reviewed-on: https://gerrit.libreoffice.org/48407Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

3199d25a