and fix the fallout

Change-Id: I15bc5d626f4d157cbc69a87392078b41e621d14e
Reviewed-on: https://gerrit.libreoffice.org/54882Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

"Err:###" instead of just "Err:" in the status bar for default
unspecific message.

Change-Id: Ic1a07e29e1f5eed4ce1ed9300c1f848c7380002e

Change-Id: Ibbac74cdbc25ffb0a922d602000ae716adf2fd9b

...to 7d275e3a "Implement NewWorkbook and
WorkbookOpen Automation callbacks in Calc"

Change-Id: I1ae8c3873a4832e2b4e9fdc43506b1a5e98d9dd4

This was added in commit ebd1b95b
(INTEGRATION: CWS xmlsec08 (1.1.2); FILE ADDED; 2005-03-10) without any
real commit message to explain why this is necessary.

system-xmlsec (not containing this patch) works fine for our XML signing
purposes with software certificates, and just recently I learned that
even hardware-based certificates work fine without this patch, so it can
go away.

I assume this was a refactor to allow some new feature as a next step,
but that feature was never implemented.

Change-Id: I31639230483cd34b14b35fd41b4fcd8284476138
Reviewed-on: https://gerrit.libreoffice.org/55296Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

...first drag is done from all categories content view

Change-Id: If76b8fa02a60009e2b60b2b57bae6e0519bf8e2d
Reviewed-on: https://gerrit.libreoffice.org/53832Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

Use FormulaError::NestedArray for now to be able to backport
without new string resources. Introduce a more specific error in
another change.

Change-Id: I49bf731f0b17c81dc6a125718bf104e218e508cc
Reviewed-on: https://gerrit.libreoffice.org/55300Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: Ib920ae6d6a3ced06ffe9f1fc4adba67d95f99a17
Reviewed-on: https://gerrit.libreoffice.org/55207Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I3a150761a401caf1e76b5ec0ee36e537c14df8e0
Reviewed-on: https://gerrit.libreoffice.org/52612Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

Project: help  83d31a088aac0ed11189afb26d818f7fb56c9b2e

Try to correct some visual glitches in online help

Change-Id: I6b5cf5c95b01c0ba6be259d93425b7349df7578f
Reviewed-on: https://gerrit.libreoffice.org/55154Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Project: help  1b112c0bedae14d3c242d8662d16230acf8c333e

tdf#94121 Give code paragraphs a different background, again

The old wikihelp had this, but this time it won’t look as tawdry.

Change-Id: I709b94c512cb15d6c1b5ef5b76b9e1bb13b6f09b
Reviewed-on: https://gerrit.libreoffice.org/55301Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Change-Id: Ide912b1c3323520a0d83a5e505fba1ff87fa694a
Reviewed-on: https://gerrit.libreoffice.org/55291Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: I3fc6d8baf9dfb7270eedd7ce0d473a56241c10d5
Reviewed-on: https://gerrit.libreoffice.org/55285Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Caller of ImpSvNumberformatScan::GetKeyWord() needs to know if
English or locale's keyword was found and act on it.

Pointed out by an assert when attempting to copy "STANDARD" length
characters (8) from "General" (7), which doesn't harm because when
not in debug it copied the terminating 0-character. However, the
keyword name also needs to be replaced for the locale's resulting
format code.

Change-Id: Ia5211b307ea44c1ba9c2b86786368355c570d4a2
Reviewed-on: https://gerrit.libreoffice.org/55293Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I8b5badc7ad6493b9268d6d141885a6f0bff1baa1

Change-Id: I7f88333a74f7c523030ab55b896c316b3aa73cce
Reviewed-on: https://gerrit.libreoffice.org/55282Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

ever since it was introduced in
    commit cd361fde
    Date:   Thu Apr 3 13:45:13 2008 +0000
    INTEGRATION: CWS presenterview (1.1.2); FILE ADDED

Change-Id: I480ca64d6c02b69f7a738ec1f914267fa4ea9e7a
Reviewed-on: https://gerrit.libreoffice.org/55283Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

When the URL encoded in the vnd.sun.star.pkg URL's authority contains a "@"
(e.g., because it is a file URL denoting a pathname containging a "@" in one of
the segments), that "@" need not be encoded (cf. the grammar at the top of
tools/source/fsys/urlobj.cxx) and INetURLObject::GetHost would only return the
part following the "@".

When constructing sBaseURI in ODatabaseContext::loadObjectFromURL
(dbaccess/source/core/dataaccess/databasecontext.cxx), the path part shall
obviously not be decoded (but which the original code erroneously did).
However, when obtaining sStreamRelPath in ODBFilter::implImport
(dbaccess/source/filter/xml/xmlfilter.cxx), it isn't clear to me whether the
path should be decoded, so I left that in (and added a TODO).

(Caused `make CppunitTest_sw_uiwriter
CPPUNIT_TEST_NAME=SwUiWriterTest::testEmbeddedDataSource` to fail when SRCDIR
is such a pathname containing a "@" in one of the segments.)

Change-Id: I6ffd842f3f3d37d2682e7cf14399fb3dbfa0a2aa
Reviewed-on: https://gerrit.libreoffice.org/55286Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Project: help  3e5bd012ebefd160ff4d7070b6e1794e44d91ae5

Better use of embed for similar contents

Save translation work for 'IFS functions

Change-Id: I7e9c9fa9d84419f4faf28622be818eb7f2fe6d2a
Reviewed-on: https://gerrit.libreoffice.org/55211Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

The deadlock happened as the main thread wanted to join
SearchAndParseThread (while owning the solar mutex), but
SearchAndParseThread wanted to take the solar mutex to import a graphic.

Fix the deadlock by checking for the termination flag earlier, so we
don't take any new mutexes if termination was requested already.

Change-Id: Idddaadadc693610d9f31a14300b22aff8d452756
Reviewed-on: https://gerrit.libreoffice.org/55284Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

-Werror,-Wnon-virtual-dtor: made various dtors virtual

-Werror,-Winconsistent-missing-override in END_COM_MAP: silenced the same way as
in other places across the code base

loplugin:unreffun in BEGIN_COM_MAP and END_COM_MAP: silence with
-Wunused-function

various -Werror in atlbase.h and atlcom.h: silenced the same way as in e.g.
embedserv/source/inc/stdafx.h

-Werror,-Wshadow
-Werror,-Wunused-function
loplugin:casttovoid
loplugin:cstylecast
loplugin:nullptr
loplugin:salbool
loplugin:subtlezeroinit

Change-Id: Ifefdc930a1d3ecf5366523dea509bfaca1f4e001
Reviewed-on: https://gerrit.libreoffice.org/55186Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

thanks Sergei Reznikov for pointing this out

Change-Id: Ib07d144bb50b178ee7b36f2c7b2eaede27ed10bc
(cherry picked from commit e56c81cc996747e3768cf171d0d6e94753b7d2af)

Change-Id: I6b04b943bb5a62e35a7dd0dc8749652312488435
Reviewed-on: https://gerrit.libreoffice.org/55253Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: Id8565b07e612bff77009322a9b82a7800d748384
Reviewed-on: https://gerrit.libreoffice.org/55203Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

its gb_SYMBOL not gb_SYMBOLS

Change-Id: Ia719d37d280498c856747d2806ec5a8a2c598a99
Reviewed-on: https://gerrit.libreoffice.org/55206Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ib7cb462720d13c31f0946a9c8b721d05ce7c9dfe
Reviewed-on: https://gerrit.libreoffice.org/55267Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I088a8521231283e4c9d4c8ee08677496bd244141
Reviewed-on: https://gerrit.libreoffice.org/55229Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Found with bin/find-unneeded-includes
Removal proposals are dealt with, and necessary fallout management

Change-Id: Ibf30bb929d2530572bbfee7ebeaad8a7fea7b3c2
Reviewed-on: https://gerrit.libreoffice.org/55208Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Without a visible sheet name, these absolute ranges
become relative after a round-trip.

Another way to handle this would be to ensure that ODS
(and other text-based formats) export Absolute in a
way that can be properly imported. But handling
it on import is safer and ensures UI consistency.

The InitRange default is for !IsFlag3D and !IsTabRel().
Since the range already imports as absolute, just add
the appropriate 3D flags.

Change-Id: Ia664e6f87e235096e1c2e5b702e18505e375e2ad
Reviewed-on: https://gerrit.libreoffice.org/54725Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

...since 25d6789e "sc: disable test that fails
on Windows"

Change-Id: I730495fe9b6d648c75a374b2cd15024e56c85126

Change-Id: Ibb0f883353b6d172275744eaa59d27ba39930623
Reviewed-on: https://gerrit.libreoffice.org/55264Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

...to 7d275e3a "Implement NewWorkbook and
WorkbookOpen Automation callbacks in Calc"

Change-Id: Ic12e1cc162411dd31862bee3c710791925b6308e

Also remove Light/Dark Violet variants
Place Magenta into the Standard colors list
and Violet into the Tonal colors list

Change-Id: Id27bb5fe62b7c69af39158680ae07d4f1f2efc95
Reviewed-on: https://gerrit.libreoffice.org/55257Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

Change-Id: I99b95cec1985ea5b89d705df1a22a95b2b072008
Reviewed-on: https://gerrit.libreoffice.org/55228Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ia60c396fd4f9fda7c5a2fc6bef4a2a2be01d8bcf
Reviewed-on: https://gerrit.libreoffice.org/55233Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7ca28487f780e8d28198f98dc3702aa6cbdb1a11
Reviewed-on: https://gerrit.libreoffice.org/55262Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ibb7bec9ede8045a6cea42c02f61f14ad36d2b434
Reviewed-on: https://gerrit.libreoffice.org/53730Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I626a1d8055bf2e3d835cd340b095b59e0ec7195b
Reviewed-on: https://gerrit.libreoffice.org/55261Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I9f3dbe393844e4fca5637f23d3da5ddf591e487c
Reviewed-on: https://gerrit.libreoffice.org/55235Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6cbfd9c78b5bb5626a3db9ca0b6e3b51a91859a7
Reviewed-on: https://gerrit.libreoffice.org/55234Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>