- 19 Eyl, 2018 40 kayıt (commit)
-
-
Samuel Mehrbrodt yazdı
This bug caused signature line IDs in OOXML to be written with an appended "_x0000_". Change-Id: If219279a5d5177ec5fac2d9dd747dc015c16b6bc Reviewed-on: https://gerrit.libreoffice.org/60736Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
-
Noel Grandin yazdı
Change-Id: I97b9c143bf5e1aefc4324609b6c69e2fb07b8d00 Reviewed-on: https://gerrit.libreoffice.org/60739 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: Ic9fcefd3a2d64aa01349ae6eec81d3ae49c5e069 Reviewed-on: https://gerrit.libreoffice.org/60741 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Tor Lillqvist yazdı
Change-Id: I5ef5c1ce2be3de7390322a4f4f7b78a484fd7396
-
Tor Lillqvist yazdı
Change-Id: I4b3cb1d696adb7f9a6f35b8529e49d55bd5d957b
-
Tor Lillqvist yazdı
Change-Id: Ic41be9447a8ac068d9616252ad3b17451234956e
-
Tor Lillqvist yazdı
Also, I don't see why we would want to use -miphoneos-version-min=12.0 just because we build against the 12.0 SDK. Use 11.0 as the minimum runtime iOS version for now. Change-Id: I36b9696ce367249e7e8d0a51ee61791e32972390
-
Michael Stahl yazdı
The bCalcFrame is only evaluated if a pPoint is given; this is surprising and should be more visible in the interface, so people don't go on a goose chase to find places that may do formatting in inappropriate places. So put these parameters into a pair instead, which doesn't have particularly good ergonomics in C++, particularly since compilers warn about taking the address of a temporary object... Change-Id: I101c6eeb5bd6baf83c2bd9a6cb91ccaa04036cc3 Reviewed-on: https://gerrit.libreoffice.org/60695 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
-
Adolfo Jayme Barrientos yazdı
Change-Id: I7181e07f8d817dd402eec8bd98e8526503455f5e
-
Noel Grandin yazdı
Change-Id: Ic40e4034b30ec527a3a3dbb0d74506478d2dd0a5 Reviewed-on: https://gerrit.libreoffice.org/60740 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Caolán McNamara yazdı
Change-Id: I8c3b3c0f6c0cfe133e1ec8eda8c10bbbaee5f010 Reviewed-on: https://gerrit.libreoffice.org/60584Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Christian Lohmaier yazdı
menubar definitions using menu:style="radio" attribute were introduced with df4017a8 / the other commits of that cws, but the dtd wasn't adjusted accordingly Change-Id: I7c7e1b8116800ee20cfede431ed90ef8f213cce0 Reviewed-on: https://gerrit.libreoffice.org/60276 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
-
Christian Lohmaier yazdı
Change-Id: Ibed6f899ad0219bf0211ac50c0595484ddba8c92 Reviewed-on: https://gerrit.libreoffice.org/60696 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
-
Serge Krot yazdı
Change-Id: If47a2e4953e4b98f41c9115779522a755eea8192 Reviewed-on: https://gerrit.libreoffice.org/56522 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
-
Noel Grandin yazdı
and add some unit tests Change-Id: I9a01c9fa2fbbf3a553663a980ee6e958f9819645 Reviewed-on: https://gerrit.libreoffice.org/60737 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Michael Stahl yazdı
So we can get more testing & many bug reports. Change-Id: I34fe456a58670baecf4fdf1a87da77aceab43891
-
Michael Stahl yazdı
Both reading & writing. Change-Id: I301bc80549e25c21961b8e79db420e81ab40f8f7
-
Michael Stahl yazdı
It's called from SwEditShell::GetSelectedText() :-/ Change-Id: Ie26c7abd1bc0714bb4c1d49eecb7c869d947c276
-
Michael Stahl yazdı
Move SwTextNode::GetCurWord() to SwTextFrame, this was the only caller. Change-Id: Id26cea92e1ca507fd82c5c75bc5a6eedb531d78d
-
Michael Stahl yazdı
Change-Id: Iaa67b9a0134971917c18c9d6f678f6d2913db666
-
Michael Stahl yazdı
Pass in ExpandMode::HideDeletions to get the same effect (hopefully) from the model code as from the merged text frame. Change-Id: I546f51388bc7bd0d1740167062ef9171a37d1797
-
Michael Stahl yazdı
... to make call sites both more readable and more flexible. Change-Id: I28932290799cb3c354cdcaad8e426050bcfede50
-
Michael Stahl yazdı
Change-Id: Idb7bdc139e501dfbd7e7d3b2d4598d211fa11591
-
Michael Stahl yazdı
This is pretty silly, the only caller is actually interested in the position of the cursor, not any text at all. Change-Id: Ibf016d5526e18775c0e6e365b9823723267e76d5
-
Michael Stahl yazdı
It's really not obvious *what* you can get here. Change-Id: I1f14b851a127847206f8eb5fd2da778d0acece9b
-
Michael Stahl yazdı
This is used by Ctrl+Up/Down. Just iterate movement in SwCursorShell::MovePara() until the point is at the start (or end) of a frame. Change-Id: I8abab57f1b549a3d585a385181cf734d73a0286a
-
Michael Stahl yazdı
E.g. Ctrl+Left/Right, Ctrl+Shift+Del/Backspace, double-click to select word... These are all implemented in SwCursor, so they need a layout passed to them from the SwViewShell. There was a bug in the while loop in SwCursor::GoSentence() case NEXT_SENT that triggered assert in the mapping code when the endOfSentence() returned the length of the SwTextNode but then it was incremented once more. Change-Id: Ic3866860a8c07774dce35952271c207eb6e7d182
-
Michael Stahl yazdı
Actually it already works, this is just a clean up to pass in the SwCursorShell's layout... Change-Id: I1a90bbe9966c7f4d5b5e959122ca1f995df93a45
-
Michael Stahl yazdı
Just put a loop in SwCursor::LeftRight() to repeat a movement if it didn't actually advance the text frame index; the SwContentNode::GoPrevious()/GoNext() take into account hidden text attributes from SwScriptInfo, so this ought to result in end positions that are neither hidden by attributes nor by redlines. This requires passing the layout to SwCursor. Change-Id: Ieb623840f6390fa6f1c78b7458ad8dc6523a2744
-
Michael Stahl yazdı
This never splits or joins nodes, so it needs yet another different code to keep the merged text frames up to date. Change-Id: I151edcec9db34c64bf3a29ecad4396d95669d1c9
-
Michael Stahl yazdı
This needs to recreate the frames on the node preceding the deleted one, in case the second node of the join wasn't merged like the first was, but is merged afterwards... Change-Id: I001ba3af118614c1cce891cf6faec7e829576d21
-
Michael Stahl yazdı
There is a special case where the redline that is inserted doesn't have a valid range and then it's split up inside AppendRedline(), in SwRedlineTable::InsertWithValidRanges(). This happens for example with a selection that includes a section start node but not its end node (or vice versa). This breaks the UpdateFramesForRemoveDeleteRedline() / UpdateFramesForAddDeleteRedline() because they assume that the given range is one SwRangeRedline; the result is duplicate text frames. This could be worked around by iterating the SwRangeRedline in the given PaM, but for the Remove case there is the additional complication that the redlines are actually removed by the time the function is called. So rework the implementation of DeleteAndJoinWithRedlineImpl() to call the part of InsertWithValidRanges() that does the splitting into multiple redlines (extracted into new sw::GetAllValidRanges()) and create multiple SwUndoRedlineDelete actions, each of which now updates the frames properly. Also clean up the horrible group-undo code to group before inserting, instead of after-the-fact cleanup. Change-Id: Ia279910e0c74edabe56b0c4cf87dbbad688179da
-
Michael Stahl yazdı
If there's a table or section affected by the editing operation, then it has to be ensured that the table node / section node has its flag reset on Undo; also the next text node following the table, as CheckParaRedlineMerge() isn't called for table nodes. Change-Id: Ic1b085619adbeba69fa641a3a7492b71966fee6e
-
Michael Stahl yazdı
Other callers need this too, particularly Undo, so move this into the function so it's done once. Change-Id: I58e89899127650157fe2889929c1c6b47c00649b
-
Michael Stahl yazdı
Re-use some code that is already used elsewhere; for the UpdateFramesForAddDeleteRedline(), the same code as for switching the layout to Hide mode should work, for UpdateFramesForRemoveDeleteRedline() use the code that is used for SwTextNode::SplitContentNode(). Change-Id: I97601bfb63478cc999cf7017da0225b2dc62ad37
-
Michael Stahl yazdı
This is called in 2 situations, from ClearDoc() and from SwDoc dtor. In the latter case, there is no window any more, and in the former case, surely something else must have invalidated it already. Change-Id: Ideecdeb145171a4dafbec50a04d4ec5aa2acab82
-
Michael Stahl yazdı
* test more than 1 paragraph, by calling SplitNode() * enable Undo, because that's the more usual situation * remove one mode that is identical to the previous one * use SwUnoCursor because plain SwCursor isn't corrected when nodes are deleted * create a selection before calling Delete functions Change-Id: If406bd8c37b005e431fbaebe82f297b051da1ed3
-
Michael Stahl yazdı
At least with the randomised test, it can happen that deleting one redline will recursively delete other redlines that are located in the hidden content section of the redline, or at least try to and crash because those have already been deleted before. The callers will either delete 1 redline, or delete all of them via DeleteAndDestroyAll(), so put a safer loop into DeleteAndDestroyAll() and have DeleteAndDestroy() only delete 1. Change-Id: I9c4225544a43a4a03f4eb7b6f56e7fe848c8ca54
-
Michael Stahl yazdı
... it's at the end of the node already, similar to CanGrouping(). Change-Id: Ic7c6f5caa6e69e9414112cb245db97fd5d79e87d
-
Michael Stahl yazdı
... characters; if the character is inserted at the end of the node, the aPam end position will have an invalid index Len()+1 and the DeleteRedline() will correct existing redlines onto that index, which will assert later. Change-Id: Ia31cd1937385fb10fd284e7add61c39f96b917ab
-