- 07 Kas, 2014 40 kayıt (commit)
-
-
Riccardo Magliocchetti yazdı
Change-Id: Ib68bf02ef7065c76ff25f36b8c29a9a4b028b2e0 Reviewed-on: https://gerrit.libreoffice.org/12268Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
-
Andrea Gelmini yazdı
Change-Id: I3fe3227967e07b6b0c82dccf3c9400bfe6e1d729 Reviewed-on: https://gerrit.libreoffice.org/12292Reviewed-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
-
Riccardo Magliocchetti yazdı
Don't require vcl.unx component on headless build Change-Id: I33c3d90b67dd4ef3fc52ae2555b41ca2deb191de Reviewed-on: https://gerrit.libreoffice.org/12267Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
-
Zolnai Tamás yazdı
Image loss indicator is the "empty" URL. Change-Id: I0f8b037dc23bae3d7342d73cfafa4ecc55090ab6
-
Takeshi Abe yazdı
Change-Id: I6c25988497208d9ae652feb1f9c37032f22ae376 Reviewed-on: https://gerrit.libreoffice.org/12295Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
-
Miklos Vajna yazdı
Currently these values are ASCII, but it's better to convert it to OUString from the string literals directly than trying to guess their encoding later. Change-Id: I2629329a84c89410bd6d81d871b564988394e74e
-
Caolán McNamara yazdı
Change-Id: I66e6905237307f177fadfef2ffc13f04ffc43921
-
Zolnai Tamás yazdı
Change-Id: I6b9f5f9c4a0bc87376a469835a50dc2cf598479e
-
Zolnai Tamás yazdı
Store used size as a member so we don't need to recalculate it all the time and no need to use a size map. Change-Id: I1f929c5d3a56f545cef123bda087ecaf8ca0be4a
-
Zolnai Tamás yazdı
Plus remove some useless call of them. Change the tests accordingly. Change-Id: I47a50b5734d799ac02ee7221c95f82415afb9497
-
Zolnai Tamás yazdı
Change-Id: I4cd2677197c7a6cff71e2966c2b2dd2285032c07
-
Zolnai Tamás yazdı
Change the filter test accordingly. Change-Id: Ide3043f2f245c097a7b4c07ba2e0713510296b3e
-
Zolnai Tamás yazdı
Change-Id: Ia599644ff1f7591ac84bdca988883eaf5860297e
-
Zolnai Tamás yazdı
This means more things: * Graphic won't swap out itself, so those classes which uses Graphic without GraphicObject won't need to deal with swapping. * When a Graphic is queried from GraphicObject the caller won't need to deal with swapping, because GraphicObject swaps it in before return. * GraphicObject will swap in the Graphic always when a swapping dependent data is queried (e.g. whole graphic, transformed graphic or AnimationNotifyHdl) Change-Id: I2bf6e37291ec94146f10aac4a35084682437ed16
-
Zolnai Tamás yazdı
Change-Id: Iaff7e86a8e11e9befc6feacdafd3a78a1971bbcd
-
Zolnai Tamás yazdı
Change-Id: I70dd00d5f82c5f4f622805e1d6ee1dfc30900b31
-
Zolnai Tamás yazdı
Change-Id: Ie56584c03af8a6d3ea8f8d4294f5492a841933b7
-
Zolnai Tamás yazdı
Change-Id: I5bc6cf097e61d65007dde531af4a213b19e8ca5b
-
Zolnai Tamás yazdı
Change-Id: I4a979dd09418df4526409d9026d6abb98c6bf954
-
Zolnai Tamás yazdı
They are called only by themselves recuirsively, but not from outside. Change-Id: I1cde392c95bbc60ac7937d0bf3cd4b0fd062568b
-
Zolnai Tamás yazdı
Change-Id: I0e61aeb0705ed13872d252ee1594f9ab4aab4f8a
-
Zolnai Tamás yazdı
This thing seems a good optimization to me, but it would be good to hide all of this swapping thing inside GraphicObject class, to make our code more robust (e.g. no image loss because of missing manual swap in / swap out call). Auto swapping mechanism will take care of that, anyway. Change-Id: I933dafd95597ffff038dc6aeb0a64fcaa3941bd8
-
Zolnai Tamás yazdı
Tested with importing large *.rtf and *.docx test documents with lots of images -> auto swapp out works. Change-Id: Ib040edaa89c9bcb966c58b75f0392e6d9f7a165e
-
Zolnai Tamás yazdı
Change-Id: I2b6d6eaa072d9948eb5734e978d68d3bc37701b2
-
Zolnai Tamás yazdı
Change-Id: Ib295bd71b5cf16fd75d04818dfd415ff24cb2655
-
Zolnai Tamás yazdı
Painting via GraphicObject is obsolete. See fdo#68927 where the problem was the quality of svg graphics, it seems a good idea to extend this improvement to all graphic type. Change-Id: I57a26d4fcfea8e4f666504a90281365e8a9a7e1d
-
Zolnai Tamás yazdı
Change-Id: If09aa23768f73bbf659966e4e5aac82dca83d1b6
-
Zolnai Tamás yazdı
Change-Id: I7a8ad7814231f129d5d1146ceb36eb2c22b2aff1
-
Zolnai Tamás yazdı
Change-Id: I75f17ab5e55119965fcede2b220979cefc1e26ab
-
Zolnai Tamás yazdı
Change-Id: I09b8d11027f4a1e8470b81677388d4a573b372a6
-
Zolnai Tamás yazdı
Before an image data is used GraphicObject should be swapped in. When a GraphicObject is swapped in auto swapping mechanism is triggered which can swap out some of the images. We should avoid to swap out the same image on which the swap in method was called before because the caller code assumes that the image data is there. Change-Id: Ia4addc370742aea5fbf185cf87e3c062a5ebf5be
-
Zolnai Tamás yazdı
It's a Writer specific problem, that images lost during export because of not swapped in graphic data. Other components (Impress, Calc...) use SdrGrafObj to get the graphic and SdrGrafObj calls swap in before retrun with the graphic. Change-Id: I7398d8e3f6535199b10de048acd58543bdb42531
-
Zolnai Tamás yazdı
Related to the bug fdo#52226. The problem was that the images were somehow swapped out but were not swapped in during export. Test the main Calc formats: ODS, XLS, XLSX, HTML. Conflicts: sc/qa/unit/subsequent_export-test.cxx Change-Id: I4835ff2960fbd11cc9750ed3da20df26cd6cbaba
-
Zolnai Tamás yazdı
Related to the bug fdo#52226. The fix in *.rtf and *.docx export was this commit: 9dd5caac The problem was that the images were somehow swapped out but were not swapped in during export. Test the main Writer formats: ODT, RTF, DOC, DOCX.
-
Zolnai Tamás yazdı
Related to the bug fdo#52226. The problem was that the images were somehow swapped out but were not swapped in during export. Test the main Impress formats: ODP, PPT, PPTX Change-Id: I97ba98d0eb05ef2c1de3fbeaa527bc9f6f54d742
-
Zolnai Tamás yazdı
So we can be sure it is always called when user data changed. Change-Id: If107907afffb85a7a57817f5807847a5c028416c
-
Zolnai Tamás yazdı
No reason to swapout the image directly after the import because it will be used for rendering just a second later. Change-Id: I78c8ef9225c55f306182dc5efd7bcaf0e88521c0
-
Zolnai Tamás yazdı
We have some good auto mechanisms for that. Change-Id: I487dbf4a5fc69c7563dfbc5c21f9ebdb05ba6b9e
-
Zolnai Tamás yazdı
We have a good auto swapout mechanism which will prevent excessive memory use. Change-Id: I362f51c724ac31704561abe8b961910f5d490f04
-
Zolnai Tamás yazdı
When ImpGraphic::ImplSwapOut() is called with null pointer it was assumed that it is becase the graphic is a link and so we don't need to swap out it actually (we can load it anytime using the link), only clear the graphic's internal data. The problem with that it can happen that ImplSwapOut() is called with null pointer accidentally on a non-link graphic object which leads to that we loose the graphic. Seems more robust to use an explicit indicator (GRFMGR_AUTOSWAPSTREAM_LINK) for links swapout. indicator Change-Id: Icf31524a192c7866278ba6a13eb85648aa69f554
-