- 04 Mar, 2019 40 kayıt (commit)
-
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iec1ca76e9b3a0896a732ab2b7fd34dd5a7f219fb Reviewed-on: https://gerrit.libreoffice.org/68367 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.com>
-
Katarina Behrens yazdı
Change-Id: I1492423fe6110bdc79aa68c715e968770f6767ab Reviewed-on: https://gerrit.libreoffice.org/68672 Tested-by: Jenkins Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de>
-
Stephan Bergmann yazdı
For one, it that way matches reality (as it returns sal_uInt16, not short or sal_Int16) and its SVBT32ToUInt32 counterpart. For another, I plan a follow-up commit of introducing an additional SVBT16ToInt16 to explicitly return sal_Int16. Change-Id: I28915e6593ccdca0c11d7b2fa593e96e359a9532 Reviewed-on: https://gerrit.libreoffice.org/68686 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Stephan Bergmann yazdı
...so that running those tests with a read-only SRCDIR succeeds. (Needed to move sc/qa/uitest/calc_tests/data/tdf76731.ods to fit the changes made to sc/UITest_statistics.mk; all documents used by that test need to be at the same place.) Change-Id: I5c4a28539b9bacde3ca8983502ceed8e4688c787 Reviewed-on: https://gerrit.libreoffice.org/68683 Tested-by: Jenkins Reviewed-by:
-
Adolfo Jayme Barrientos yazdı
* Update helpcontent2 from branch 'master' - Revert "Improve donation link in Help online" This reverts commit bd26e706b30dccecdeba24ba8b697ddf2fc7a615. Change-Id: Id45b4ef2bacae444be070a03fbc0e10a4992f85c Reviewed-on: https://gerrit.libreoffice.org/68699Reviewed-by:Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by:
-
Olivier Hallot yazdı
* Update helpcontent2 from branch 'master' - tdf#123803 Add relelase info in Calc functions Patch is for REGEX function available since release 6.2 To add release information to other functions look at the diff in func_regex.xhp and adjust the release. It should be straightforward: <embed href="text/scalc/00/avail_release.xhp#M.N"/> where M is version and N is release. Patch tweaked to minimize translation effort (only one string) Change-Id: I4f5f826c936e65c1050a4d3b71379b53d50e0984 Reviewed-on: https://gerrit.libreoffice.org/68688 Tested-by: Jenkins Reviewed-by:Olivier Hallot <olivier.hallot@libreoffice.org>
-
Olivier Hallot yazdı
* Update helpcontent2 from branch 'master' - Some optimizing bits in XSLT Change-Id: I27c29677cbf9c704d64b5ed49acc56b7a22432bd Reviewed-on: https://gerrit.libreoffice.org/68646 Tested-by: Jenkins Reviewed-by: -
Olivier Hallot yazdı
* Update helpcontent2 from branch 'master' - Improve donation link in Help online redmine#2815 Addressed responsiveness: for screen width < 960px the button goes to the bottom of the screen and the header is not fixed anymore. Artists are invited to improve button rendering. Button max width is 300px, the en-US text and the translated text should fit in 2 lines of 300px each. Text is centered. Change-Id: I51860be2ad998e85f247118e44b21af3e2efa060 Reviewed-on: https://gerrit.libreoffice.org/68644 Tested-by: Jenkins Reviewed-by: -
Stephan Bergmann yazdı
...in Windows-only code that has recently been brought back to life with db8a2a56 "tdf#39625 make sal/qa/systools/test_comtools.cxx work with CppUnit" Change-Id: Ia93e84f5719c2320789aec5f711067f9174acb55 Reviewed-on: https://gerrit.libreoffice.org/68682 Tested-by: Jenkins Reviewed-by:
-
Katarina Behrens yazdı
Fix of tdf#41996 is a workaround of kde4-specific condition and has been since disabled on OS X (as tdf#51023). kde5 comes with a new implementation of DnD and slide sorter in Impress now exhibits exactly the same symptoms as on OS X in tdf#51023 Since kde4 is unsupported and remaining platforms (gtk[23], Win) never had issues with DnD in slide sorter, kill the workaround with fire (= disable it globally) Change-Id: Ib9482dd5371ce73cdb86c3e5bbc5e46af65b9905 Reviewed-on: https://gerrit.libreoffice.org/68674 Tested-by: Jenkins Reviewed-by:
-
Katarina Behrens yazdı
Regression from 67b0fcea (which implements external DnD). QMimeData of internal DnD is never null, it always contains internal MimeType (but empty byte array) Change-Id: Ie12e9c3b7a3c7cebfd98064bb2fafec27c20a442 Reviewed-on: https://gerrit.libreoffice.org/68673 Tested-by: Jenkins Reviewed-by:
-
Mark Hung yazdı
This will allow to round trip the test case for the slide transition and the animation effect audio. Change-Id: Iac524e6bbcdb0a29491cfeba63121c845685fd11 Reviewed-on: https://gerrit.libreoffice.org/68540 Tested-by: Jenkins Reviewed-by:
Mark Hung <marklh9@gmail.com>
-
Serge Krot yazdı
Change-Id: I25bc3b3ec42ef5b026c2cd9572e8ff1863ed8c2d Reviewed-on: https://gerrit.libreoffice.org/68492Reviewed-by:
Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by:
-
Stephan Bergmann yazdı
At least during CppunitTest_sd_misc_tests, when bReplace is true the value initially calculated for nSdPageEnd (and later overwritten) was -1, so caused a warning with Clang's implicit-signed-integer-truncation. Change-Id: I69be2649e431590fc79808908470c9c2e3cf3c74 Reviewed-on: https://gerrit.libreoffice.org/68663 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
At least during CppunitTest_sw_uwriter, some m_nStrResId is read so that Clang's -fsanitize=implicit-signed-integer-truncation warned that an "implicit conversion from type 'int' of value 74752 (32-bit, signed) to type 'sal_uInt16' (aka 'unsigned short') changed the value to 9216 (16-bit, unsigned)". Change-Id: I39f12d931bb18eea909494c8d7c9c0348fb71f27 Reviewed-on: https://gerrit.libreoffice.org/68664 Tested-by: Jenkins Reviewed-by:
-
Tomaž Vajngerl yazdı
Change-Id: Ic00d090e0aa85d451a50be52794606546021be38 Reviewed-on: https://gerrit.libreoffice.org/68671 Tested-by: Jenkins Reviewed-by:
Tomaž Vajngerl <quikee@gmail.com>
-
Tomaž Vajngerl yazdı
Change-Id: Ie70d1050a58d96443fe5df9c743ba201fca9d25f Reviewed-on: https://gerrit.libreoffice.org/68670 Tested-by: Jenkins Reviewed-by:
-
Tomaž Vajngerl yazdı
Change-Id: I5cd861714a98ede80ab46e41d6d3638bdd5da97e Reviewed-on: https://gerrit.libreoffice.org/68669 Tested-by: Jenkins Reviewed-by:
-
Tomaž Vajngerl yazdı
Change-Id: Ib146426b0f1b15571b41f2b64c1b0ea0ce71c94d Reviewed-on: https://gerrit.libreoffice.org/68657Reviewed-by:
-
Tomaž Vajngerl yazdı
Change-Id: Iec4694344d324b4d4d7e55efdedf8520dd914d63 Reviewed-on: https://gerrit.libreoffice.org/68656 Tested-by: Jenkins Reviewed-by:
-
Tomaž Vajngerl yazdı
Change-Id: I392289f0ab284aec2ed0fb039a03fb93bf0b4aad Reviewed-on: https://gerrit.libreoffice.org/68654Reviewed-by:
-
Tomaž Vajngerl yazdı
Change-Id: I04fde55661f81d3d230cda3eb5cc2dcec72a1309 Reviewed-on: https://gerrit.libreoffice.org/68655 Tested-by: Jenkins Reviewed-by:
-
Tomaž Vajngerl yazdı
Change-Id: I5bc4aa44174a89fd3003ee032f65d9d02a87a969 Reviewed-on: https://gerrit.libreoffice.org/68653 Tested-by: Jenkins Reviewed-by:
-
Tomaž Vajngerl yazdı
Change-Id: Iee130a48a5ea671962d15d84ec56ac2f16227749 Reviewed-on: https://gerrit.libreoffice.org/68652 Tested-by: Jenkins Reviewed-by:
-
Tomaž Vajngerl yazdı
Change-Id: Ie5830b1b2675d1254fc0b489cff5646ede6f72dc Reviewed-on: https://gerrit.libreoffice.org/68647 Tested-by: Jenkins Reviewed-by:
-
Tomaž Vajngerl yazdı
This adds FileDefinitionWidgetDraw which extends the WidgetDrawInterface and is responsible to draw the widgets from the definition gathered from an external file. The file must be (currently) in the user folder named definition.xml. It instantiates the WidgetDefinitionReader to get the definitions and sets the style colors when updateSettings is called. Later more definitions will be implemented. Change-Id: Id02111e8aed4648e5a306b0f5dbc9a02c9b2fcb0 Reviewed-on: https://gerrit.libreoffice.org/68645 Tested-by: Jenkins Reviewed-by:
-
Tomaž Vajngerl yazdı
WidgetDefinitionReader is responsible to read the definitions from an xml file. The first implemented definitions are style colors. They are read from the file and stored into class fields. This also adds the unit test which tests that the reader is functioning as expected for a small certain subset of colors. Change-Id: Icd44cb465b084c32db8323e2f2f7dfa57823d559 Reviewed-on: https://gerrit.libreoffice.org/68642 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
we have been able to iterate over a sequence for a long time now Change-Id: Ie7ed6ec25682f631e01170029f7c9f0089448836 Reviewed-on: https://gerrit.libreoffice.org/68666 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Takeshi Abe yazdı
No functional change offered, but this reduces some amount of confusion. Japanese word "Katakana" ("kata" + "kana") does not undergo Rendaku [1] while "Hiragana" ("hira" + "kana") does. [1] https://en.wikipedia.org/wiki/Rendaku Change-Id: I07824147d72397c312a0774eca1fdcc7549abc59 Reviewed-on: https://gerrit.libreoffice.org/68661Reviewed-by:Julien Nabet <serval2412@yahoo.fr> Tested-by:
-
Aron Budea yazdı
Similar fix to b38065ea Only rely visibility setting for now, but properly: visible means also printed, hidden means not printed. Ie. import visible property also as printable, and only output visible property in DOCX format (DOC shapes have no such property). Change-Id: Ifc3c36f90aa16ded1a9f31197612a5c85fde5d87 Reviewed-on: https://gerrit.libreoffice.org/68239 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
not adding any value Change-Id: I8e7bc1150b4bf7e9431e522be3807007a52f65c4 Reviewed-on: https://gerrit.libreoffice.org/68667 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
At least during CppunitTest_sw_odfimport, Clang's -fsanitize=implicit-signed-integer-truncation warns (for nB) that an "implicit conversion from type 'long' of value -181 (64-bit, signed) to type 'const sal_uInt16' (aka 'const unsigned short') changed the value to 65355 (16-bit, unsigned)". Change-Id: I91bd1413fca248f5f05331980d8ac92753d366ab Reviewed-on: https://gerrit.libreoffice.org/68665 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
Change-Id: Ibdc93b2afb3949fd25f14666f6eb3a4c1462f791
-
Michael Stahl yazdı
The problem is that when ToX is updated, CrossRefHeadingBookmarks will be created for the heading nodes, and SwUndoInsBookmark will be created at that time, but then nodes will be created for later entries in the ToX and if the heading is below the ToX then the node index in SwUndoInsBookmark will not match the node index of the CrossRefHeadingBookmark. Thus SwHistoryBookmark::IsEqualBookmark() will cause the mark to be skipped during Undo instead of deleted, and then it can cause trouble. Work around that by having SwHistoryBookmark::IsEqualBookmark() not check the position if it's a CrossRefHeadingBookmark. Change-Id: I9277978844837accdda35195a863c6163a839b6e Reviewed-on: https://gerrit.libreoffice.org/68596 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de>
-
Michael Stahl yazdı
After fixing the infinite loop, the content of the merged table cell with rowspan 3 is invisible, because its SwCellFrame and the SwRowFrame containing it both have a height of 0. This is due to funny code in SwTabFrame::Split(), which checks the bRet flag before setting it to its final value, thus skipping the lcl_AdjustRowSpanCells() call. Change-Id: I96f9e9efdd5cae3a61da07995b8c31042fc59125 Reviewed-on: https://gerrit.libreoffice.org/68403 Tested-by: Jenkins Reviewed-by:
-
Michael Stahl yazdı
The bugdoc loops on calculating the follow of SwTextFrame 560, the one containing "Hiermit nehme ich das Angebot an" in a cell with rowspan 3, while the table is being split and its first row (also now its last i.e. split row) is being formatted. Loop in CalcFollow() because the follow is in the same upper frame as its master and cannot move forward, so the 2nd call to pMyFollow->Calc() after pMyFollow->Prepare() always sets the SetPrepWidows() flag on the master and in that case the loop never terminates. The problem is that the check in WidowsAndOrphans::FindWidows() of GetThisLines() uses stale cached data - the value returned is 4, but the frame contains fewer lines at that point and doesn't have lines to spare for the follow; the cached value is only updated at the end of SwTextFrame::Format(). Fix it by calling ChgThisLines() here. But this fix only helps for the first SwTextFrame in a cell; the next one with id 561 loops in a similar way. The problem then is that SwTextFrame::PrepWidows() always calls SetPrepWidows(), even if the Orphan-rule of the frame prevents it from giving lines to the follow. Fix this by calling SetPrepWidows() only if lines are removed. This also helps for the 2 attachments of tdf#118104. (regression from commit 18765b9f particularly the change in SwFrame::IsMoveable() in the sense that it didn't loop before but there isn't anything obviously wrong with this commit) Change-Id: Ia1e5928a6510e68520b29eb265e26ffd0627c52e Reviewed-on: https://gerrit.libreoffice.org/68402 Tested-by: Jenkins Reviewed-by:
-
Regina Henschel yazdı
The patch covers several errors, see comments in the bug report. Change-Id: I6cdaf3e8951dab21b314ef61e12ffa3b3ee481dc Reviewed-on: https://gerrit.libreoffice.org/68029 Tested-by: Jenkins Reviewed-by:
Regina Henschel <rb.henschel@t-online.de>
-
Miklos Vajna yazdı
Change-Id: I993ee72f9e162a72b1d4e89d98763fe0d2dee4d4 Reviewed-on: https://gerrit.libreoffice.org/68662Reviewed-by:
-
Katarina Behrens yazdı
most of the time shapes have generated names such as 'Shape 42', those have ~no added value so let's not include them in Alt text Change-Id: I30314d5e901e11722e609dbf7ceddf74c5ed9707 Reviewed-on: https://gerrit.libreoffice.org/68520 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Ia8b07edec54527fb4904536fabb03a18e8452550 Reviewed-on: https://gerrit.libreoffice.org/68659 Tested-by: Jenkins Reviewed-by:
-
