no need to access them via methods

Change-Id: If0d1a65d6f56ce2fc585749d974ba13c9f2749b2
Reviewed-on: https://gerrit.libreoffice.org/47245Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I2b367a451c03b42120c7599158cc05b8c99e1697
Reviewed-on: https://gerrit.libreoffice.org/47216Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>

in document to open Go to Page dialog

Change-Id: I9782fa9a2d9c3d541e09bad4f721c9b2417f29d5
Reviewed-on: https://gerrit.libreoffice.org/47247Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>

Change-Id: I3f7f4b7ecfd53a918318c2091a0756ba327c98ba
Reviewed-on: https://gerrit.libreoffice.org/47057Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: If8f042c6ef02c204f8946900e9ea8b99f06a631c
Reviewed-on: https://gerrit.libreoffice.org/47240Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ie151389d318e39757b4050a2949281613fc521f6
Reviewed-on: https://gerrit.libreoffice.org/47239Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Matthias Freund <matti_lx@secure.mailbox.org>

Change-Id: I1e8b8ae65d9989683dde8f642f3c19355d10a571
Reviewed-on: https://gerrit.libreoffice.org/47238Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

remove default-able copy-ctors/assignments

Change-Id: I40255393899275a5825ffef4df3f08c6ce5348c2
Reviewed-on: https://gerrit.libreoffice.org/47140Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

* use line spacing also for the first line
* correct spacing in case of > 100% proportional spacing

* impedit2.cxx only code readability change

Change-Id: I24832e7dc2fa8cfbb2f9cdfe7062eaaaa63f1729
Reviewed-on: https://gerrit.libreoffice.org/46925Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>

There's no TINYINT or equivalent so let's do the same as setShort

Change-Id: Ia1154ee068b02f40e7efa21571036d8b49844859
Reviewed-on: https://gerrit.libreoffice.org/47234Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I5dc9c66ce17f6401fbc9683cf8b10bf62755a166
Reviewed-on: https://gerrit.libreoffice.org/47236Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I487cfe96e9fe65f9be39b2488880410bc7b4baea
Reviewed-on: https://gerrit.libreoffice.org/47228Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ibf8285efae7c570452954feb41a1a36bf44504a4
Reviewed-on: https://gerrit.libreoffice.org/47235Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The maximum size of a VARCHAR column in Firebird is 32765 bytes [sic].
We use the UTF8 character set and that means 8190 characters as each
character might take four bytes. The maximum size of a row in Firebird
is 64 KB [sic].

Avoids errors when creating sample tables using the wizard using just
the default values. If the varchar column lengths are under 8190 but
the total row size is too large you do get a relatively helpful error
message "new record size of <N> bytes is too big", but if you try use
a too large size for a varchar column, just some "SQL error code =
-204", "Impmentation limit exceeded", etc.

Change-Id: I17c2bed4fc098f4e159822f6f81242aae274da7b
Reviewed-on: https://gerrit.libreoffice.org/47232Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Readd comment explaining why we allocate a large buffer for
GetEnvironmentVariableW which was removed in commit
f78a2bcc:

    re-base on ALv2 code. Includes:
        Patch contributed by Herbert Duerr:
        #i118662# remove berkeleyDB from module xmlhelp (author=orwitt)
        http://svn.apache.org/viewvc?view=revision&revision=1213188
        #i119141# remove ISCII converter for now
        http://svn.apache.org/viewvc?view=revision&revision=1306246
        make exceptions for cppunittester verbose
        http://svn.apache.org/viewvc?view=revision&revision=1174831

        Patches contributed by Pedro Giffuni:
        Avoid some uses of non portable #!/bin/bash in shell scripts.
        http://svn.apache.org/viewvc?view=revision&revision=1235297

        Patch contributed by Oliver-Rainer Wittmann
        88652: applied patch, remove unicows deps
        http://svn.apache.org/viewvc?view=revision&revision=1177585

    drop OS/2 code, remove in-line assembler ARM atomics,
    and obsolete armarch header.

Change-Id: I75a222393e202e40d78f10fc97f5eb4aad2df743
Reviewed-on: https://gerrit.libreoffice.org/47018Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

It's the length of the OUString that we just made from the
OUStringBuffer that we want.

Fixes a problem where the code would try to execute an erronoeus SQL
statement like:

')EATE TABLE "Tasks" ("Notes" VARCHAR(32765),"TaskID" INTEGER,"EndDate" DATE,"StartDate" DATE,"Description" VARCHAR(65000),'

Too lazy to file a bug for this, the error should be obvious by just
reading the code.

Change-Id: I473cd8a7a9791700ca8b6467a84f4bad5dee4d55
Reviewed-on: https://gerrit.libreoffice.org/47230Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Idcc291dba5cb6d86e29d00f6b34905f6693f7540
Reviewed-on: https://gerrit.libreoffice.org/47207Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

see bt https://bugs.documentfoundation.org/attachment.cgi?id=138757

Change-Id: I493bf47b1541262a5ea78b541bc1f47f93cc73df
Reviewed-on: https://gerrit.libreoffice.org/47219Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>

Change-Id: Iabd06fbda15d2f83f6ee0cdd37b268910d380476

mostly to make my passstuffbyref loplugin happier

Change-Id: I148b6b418100de860dfc49aaec6c544d0fe14c72
Reviewed-on: https://gerrit.libreoffice.org/47225Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I2e4103bb496ed3d0677d036e2f8cec76d001d682
Reviewed-on: https://gerrit.libreoffice.org/47222Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ie92d9f6cafd0b0af7db9cdb846073762bd4ba7b9
Reviewed-on: https://gerrit.libreoffice.org/47204Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

from SELECT block of INSERT INTO <> SELECT <>

Change-Id: Ibe3c3f5f2fbc15388c716ae262e87137958c1a7e
Reviewed-on: https://gerrit.libreoffice.org/47218Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I237936d62d0f1b17574dd88b5c9de932dc03238e
Reviewed-on: https://gerrit.libreoffice.org/47214Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I632aca7e3f59b7edf48c8c35eff4abf1946af652

Change-Id: Ifb6a56783ce02a12f5fa5dfae4c815e963dcfe3c

Change-Id: I80c01fbf839c6980bc8dab40267d1407ca8e1398

Change-Id: I816e2a2e2c21bf999c261e59c860fd142ba59f76

Change-Id: Ic8b48d3b3e3f87e9ac3e8a6bb832f8e8dfe8ab7d

Change-Id: Ifb17c8a7b6f2d5cd4616256bbec08b9c51007be0
Reviewed-on: https://gerrit.libreoffice.org/47201Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

CreateUndoAttrObject() create extra undo steps when using
table paint brush on table cells. Undo action for each selected
cell is processed individually in
SvxTableController::ApplyFormatPaintBrush().

Change-Id: I65034a2b510898db26a7a8ddc4b5f3b742fd9b88
Reviewed-on: https://gerrit.libreoffice.org/46729Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>

It should had overwritten the connector data when the
connector attach to a different glue point of the same
object. Let’s always overwrite it, though it waste a
little bit time.

Change-Id: Ib4cc4bf105e5ef17289e027dcddd0110f7297190
Reviewed-on: https://gerrit.libreoffice.org/46559Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>

Change-Id: I1fc91911844f86572b102fe0dfb8ccdcd42fce0d
Reviewed-on: https://gerrit.libreoffice.org/47186Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: I8a45d4e620b1865dda28eb56a89207226eeac9b2
Reviewed-on: https://gerrit.libreoffice.org/47202Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ie6e2fb9f2e16e021a4719c418f52ce074c359904
Reviewed-on: https://gerrit.libreoffice.org/47199Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...as finding uses of variables in arguments to expand-to-nothing assert macros
is just not implemented not implemented.

Change-Id: Iacb3bd25d03eca13ac8ff3942f98e46dee3286b9
Reviewed-on: https://gerrit.libreoffice.org/47200Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I1193ff91ccd548acf9492d9701b6411a24d6763e
Reviewed-on: https://gerrit.libreoffice.org/47194Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Patch based on suggestion from jon Nermut.

Change-Id: I91244ad839b2a7f532b45c0ca8b37228c2ff27b1

Scaled bullet points aren't centered in PPT, so padding needs to be added
to get them to the correct position.

Change-Id: I61509dd43ef9cd697dcbc3cabbf58a21d625ddec
Reviewed-on: https://gerrit.libreoffice.org/46994Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

It's fixed in:
05f72a2a

Change-Id: I5f82b1bd5dc0b2155398e4fc74da21f1a96e1d56
Reviewed-on: https://gerrit.libreoffice.org/47193Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>