Change-Id: Id5c7e66b8f8bc324f097dd739ce683d74fc6491b
Reviewed-on: https://gerrit.libreoffice.org/65953
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I99f1611f41378a0baa7688db5a5f78e0169f0d5b
Reviewed-on: https://gerrit.libreoffice.org/65649
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

lcov points out this was uncovered previously.

Change-Id: I831b7e6c2b475d2b3ddd64fb21714c3b6667832a
Reviewed-on: https://gerrit.libreoffice.org/65944
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I20aa503bb011d7222ecc29cb87bb72c0f3ee7539
Reviewed-on: https://gerrit.libreoffice.org/65949
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I7f67b4c9a157d7a1a5992174397c061b14c8a674
Reviewed-on: https://gerrit.libreoffice.org/65952
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ie628d666f3f8d8bf0cfefd212706d5ce4e76dfe0
Reviewed-on: https://gerrit.libreoffice.org/65946
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

like the other smart pointer types

Change-Id: I3ac1888c84fc1411cdfc3357b005afbb3b7d8bbe
Reviewed-on: https://gerrit.libreoffice.org/65926Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

In my testing on Windows, the crashing scenario was this:
1. FileDialogHelper_Impl::updateVersions() creates storage calling
   comphelper::OStorageHelper::GetStorageFromURL;
2. Content::openStream() calls isDocument first;
3. Content::isDocument() indirectly initiates WebDAV session,
   creating a NeonSession;
4. All operations of NeonSession call Init() first; its first call
   initializes m_pHttpSession using ne_session_create, and then
   adds auth callbacks using ne_add_server_auth/ne_add_proxy_auth
5. Then NeonSession performs the rest of PROPFIND task, calling
   ah_post_send and auth_challenge; the latter fails, then
   ah_post_send calls clean_session, which cleans m_pHttpSession's
   auth_session's sspi_host;
6. NeonSession::HandleError throws DAVException for NE_AUTH error;
7. Content::isDocument() returns true to Content::openStream(),
   which proceeds to execute the command, which in turn re-uses
   the NeonSession and its m_pHttpSession;
8. NeonSession::OPTIONS then indirectly calls continue_sspi, which
   tries to dereference the m_pHttpSession's auth_session's
   sspi_host which is nullptr at this point.

So in case NeonSession detects the NE_AUTH error condition, let's
set a flag indicating that the next Init() should reinitialize its
m_pHttpSession.

Also fixed a case when xProps was used before initialization in
Content::getPropertyValues.

Change-Id: Ifc9eec4fe0333ff6be17c5089068441b4a6eb78c
Reviewed-on: https://gerrit.libreoffice.org/65950
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

It explains better, what this button is.

Change-Id: I93b78c7907686179ec4fe6b3f45daa15c846c316
Reviewed-on: https://gerrit.libreoffice.org/65942
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

To draw any shape with EMF+ the shape needs to be created
and next the transformation matrix needs to be applied.
Unfortunately for Ellipse, Arc and Pie only position and ratio
was transformed. The rotation was not handled correctly.
With this patch the transformation matrix is applied after
creation of the shape.

Change-Id: I63a797e7cddfd304f94e7e5c8e2ce15063dc55e5
Reviewed-on: https://gerrit.libreoffice.org/65898
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

It's yet unclear whether
ECMA-376-1:2016 OOXML 18.17.7.127 FREQUENCY
"A call to FREQUENCY shall be an array formula."
indicates that the entire formula expression should be in array
mode as well, see
https://bugs.documentfoundation.org/show_bug.cgi?id=122301#c8

If so, that will need a follow-up change.

Change-Id: Ic302d25631fb870b46989b922c95912ab5d123df
Reviewed-on: https://gerrit.libreoffice.org/65940Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Just like bug 121374 for DOCX, which was just fixed in LO62,
DOC apparently also sometimes can miss out on headers and footers.

It wouldn't be terrible to duplicate headers/footers
unnecessarily, but it is terrible to have them disappear.
If the last SectPr has no idea about the section start,
it can't know whether it is continuous or started with
a page break. In that case, just ensure that the
header and footer are explicitly written out.

RTF continues to work without this in all known cases.

Change-Id: I93f2b08535a3548c0a9e9bcdb6ee2cd965dc8367
Reviewed-on: https://gerrit.libreoffice.org/65840
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: Id7c8d5eb7f865db5db82beffe96dab605d8ae36f
Reviewed-on: https://gerrit.libreoffice.org/65941Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Put various preps into place, that enable us to read txbxContent from
group shape children via the writerfilter parser, which gets us much
more features

Also:
- store shapecontexthandler on wrapper class in writerfilter
- move adding children shapes to ctor, not dtor
- remove RuntimeException in Writer's XShapes::add(), aligns this
  with Draw/Impress API semantics, and helps here when trying to
  add the same shape a 2nd time (which we then simply ignore)
- make oox's Shape notion of 'inside group' less ad-hoc
- make SwTextBoxHelper::getTextRectangle() cope with more than
  CustomShape - so passing in a group shape will also yield some
  sensible bounding box
- have SwTextBoxHelper handle group content, too
- derive WpsContext from ShapeContext, so we can later substitute it
  for that inside WpgContext
- keep WpgContext::onCreateContext() _for the moment_ with the old
  delegation to ShapeContext (needs to use WpsContext to enable
  writerfilter text input)

Change-Id: I2b0f0583e21137f3321a8dc13823058b14d19773
Reviewed-on: https://gerrit.libreoffice.org/65914
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

createStyleMatrixContext() assumed that <dgm:style> contains
<dgm:fontRef>, but it contains <a:fontRef> instead.

This resulted in a 0 mnThemedIdx, which meant that since commit
89206c47 (bnc#862510: PPTX import: Wrong
text color inside shape, 2014-12-21) we ignored the theme color in
oox::drawingml::Shape::createAndInsert().

Change-Id: I81045fa58df5cb9e31a4ed3f1b1625224bcd06ad
Reviewed-on: https://gerrit.libreoffice.org/65938Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

  * Creates one GDIMetaFile from each Writer page
  * Inserts them as Shapes into the newly created Draw doc
  * Has some 'magic' numbers needs to be figured out
  * Tried with a 100-page Writer doc, seems okay
  * Seems slow, might need to be optimized
    * Seems like getDocumentSizeInPixels() and getDocumentSizeIn100mm()
      are consuming most of the cycles. Will look into this at the end.

Change-Id: Ie40cd64b69fad3e66d74b6b05600cb9f52f1021b
Reviewed-on: https://gerrit.libreoffice.org/65847
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

Change-Id: Id068f1c1b70c3db3d3a0faa5ebe7706f205fe4da
Reviewed-on: https://gerrit.libreoffice.org/65932
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: If1559d3ea1205c314f25c6d346fe344adebe7f96
Reviewed-on: https://gerrit.libreoffice.org/65915
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Update url according to LODE current version (4.2.1) because
the previous one does not support mkdir -p, which is used
by libcdr and libqxp now.

Change-Id: I7e50e46d2101a3cbd757d683f2d3550f896fc750
Reviewed-on: https://gerrit.libreoffice.org/65882
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Set the TextBreak value automatically true, only if the X axis labels
rotation is 0 degree. The MS Office using a similar method because
there is no any XML tag in the OOXML standard which refer to this setting.

Change-Id: Ie84a95935f0d5c4c1f9a30803e22572141385960
Reviewed-on: https://gerrit.libreoffice.org/65853
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

Change-Id: I2b99cd30b151eaa0302abaa9fdfa92fe8300a4d5

Change-Id: I6ea90be5736982422aaa45c7147beec1cfd5430b
Reviewed-on: https://gerrit.libreoffice.org/65918
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I49ae12639d1a5adab25407115cf65ebcfe3936c9
Reviewed-on: https://gerrit.libreoffice.org/65920
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I85b2d9333e1a5f157dddfb9e250a306f10df2503
Reviewed-on: https://gerrit.libreoffice.org/65933Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I5c6e27d210efad26cfa0f4f67cfc51dfb07f577e

Change-Id: I49bf3ddebb45269e803bf2672d29b9337fa99cb3
Reviewed-on: https://gerrit.libreoffice.org/65899
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I9fe2a1267f05bcf1dd5bb6f1a553a45b14cee079
Reviewed-on: https://gerrit.libreoffice.org/65849
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I68223a70c2fb937e32b22b1f3131eef074c22de6
Reviewed-on: https://gerrit.libreoffice.org/65921
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

test case is exporting ooo55266-3 (contains data grouped in numerical
intervals) to xlsx and without closing the document, opening filter on
1st pivot table (kaboom!)

ClearGroupFields corrupts the cache bc it resets Field.mpGroup items
for all dimensions, not just the one present in ScDPDimensionSaveData
(all this happening in ScDPCollection::SheetCaches::getCache).
Consequently, accessing or rebuilding pivot cache may crash bc mpGroup
now points nowhere.

I split and renamed ScDPCache::ClearGroupFields into 2 parts, one of
them clears maGroupFields, the other resets mpGroup ptrs in maFields.
When adding data to cache, the former is used (bc group ptrs get reset
almost immediately afterwards)

Change-Id: I96e8d234a17da0f3cc65c0625aa47b12284b98b8
Reviewed-on: https://gerrit.libreoffice.org/65329
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I008c3e93d40ee4b6ad7a75ba8ad730e74cafede7
Reviewed-on: https://gerrit.libreoffice.org/65622
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I417c5b75206627b84c748ec5ef58c84c80e82683
Reviewed-on: https://gerrit.libreoffice.org/65879Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

starmath/source/dialog.cxx needs vcl/combobox.hxx to use
COMBOBOX_ENTRY_NOTFOUND define.

vcl/virdev.hxx is needed to know VirtualDevice ancestors to allow
assignments to pointers to OutputDevice.

Change-Id: Iafd33081ef33f28697e9a03bd4892a781fb2eb27
Reviewed-on: https://gerrit.libreoffice.org/65925Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I81d56ab0f0ee0780cd0f73635874f467ac5c8758

Correct query of the foreign key constraint name is required for
dropping foreign keys.

Change-Id: Id98b0672ec5a8a06039667a06cb0afd97b3ee205
Reviewed-on: https://gerrit.libreoffice.org/65861
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

Change-Id: I0bb794f500793f6d248186b683e0adb88b3e5a33
Reviewed-on: https://gerrit.libreoffice.org/65922Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: Idc9d728e711f70cc11974020aa507552f31d4c9c
Reviewed-on: https://gerrit.libreoffice.org/65919
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I98f49765c6b74808dcbd692e0f375dd2848fcfd4
Reviewed-on: https://gerrit.libreoffice.org/65614
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Use range-based loop or replace with STL functions

Change-Id: Ia8a8cfb71047e5612aa62c817c76ae0dfb7b3fa2
Reviewed-on: https://gerrit.libreoffice.org/65903
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I52e1156bf67fa098346d0016a0f8b55a1fbacbdc
Reviewed-on: https://gerrit.libreoffice.org/65912
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Iee30bc0f916f31ef60e8dbaa9aa6947c12f2852e
Reviewed-on: https://gerrit.libreoffice.org/65911
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>