Change-Id: Iaba95e2cfb6b34ab3ad04f96dd2c8e2c12115d95

Change-Id: I32056d860dfb6dd5683d13de86705c3d70f51d46
Reviewed-on: https://gerrit.libreoffice.org/44215Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I722ba0ab1e056904c55b4ad6cdec6f26fa3b723d

Change-Id: I1314e37315450ead3bf131ed3fabd9351a88a4e5
Reviewed-on: https://gerrit.libreoffice.org/44191Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I936f681b835cca62fc14a326b7ae5cb062b3f1df
Reviewed-on: https://gerrit.libreoffice.org/44197Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Id7be2fdd497b3c49005c50d4e990b0dd44e86d12
Reviewed-on: https://gerrit.libreoffice.org/44192Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I931f0d95cad0a63d344c84d89ba7c80f14be8ec9

...between "error: unannotated fall-through between switch labels
[-Werror,-Wimplicit-fallthrough]" (in some builds, for the original code) and
"error: fallthrough annotation in unreachable code
[-Werror,-Wimplicit-fallthrough]" (in other builds, after adding
SAL_FALLTHROUGH).

Change-Id: I75bbefd69c81f43f22117f8ad110237de24e18af

CellStoreEvent remembered the original ScColumn* and corresponding
ScColumn::mnBlkCountFormula, hence after inserting a column to the
left the quick check of ScColumn::HasFormulaCell() whether there
are any formula cells worked on the swapped in column (originally
the one to the right) that happens to be empty in the scenario.
Things worked correctly by accident if the next column to the
right already contained a formula cell.

Regression from

    commit e57a5905
    Date:   Sat Jul 16 20:01:48 2016 -0400

Change-Id: If993856ceee657736f516a81c293506041a6b7eb

Change-Id: I004bcba518ead9c149f1671d62aa94986a38945d

Change-Id: I2822b8c5a91feaf47466356c01728d32a85bbae9
Reviewed-on: https://gerrit.libreoffice.org/44190Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I96636cbff097af77bc0ccd669b6a973c282f7360

This aligns the translation of the "Zins" argument of the financial
functions to "Rate", as used in the function documentation in English.
The original translation was done by the same author recently in
the commit 8ba9dfe2.

Compare (as in MS Excel):
German: https://help.libreoffice.org/Calc/Financial_Functions_Part_Two/de#RMZ
English: https://help.libreoffice.org/Calc/Financial_Functions_Part_Two#PMT

Change-Id: Ifa125d94a639c91c454d7b540f86feeecea250ff
Reviewed-on: https://gerrit.libreoffice.org/44021Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: I0f849fd104699e2861aaba2d4be38168e80703b0
Reviewed-on: https://gerrit.libreoffice.org/44189Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

...after 0b413caa "loplugin:constantparam in
sal,sax"

Change-Id: Idf000bd1e0a261eac9ec0afbd2fb6f4c4ef8c7dc

lots of little fixes to make the logic less pessimistic

Change-Id: If368822984250b11b98c56f5890177a1402e8660
Reviewed-on: https://gerrit.libreoffice.org/44168Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ib69b72f64e8cbaef75ec88aa6b6c49383e5fa1cb
Reviewed-on: https://gerrit.libreoffice.org/44187Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I089af1a67044ab9cfd767e767a15d1a66014ce2f
Reviewed-on: https://gerrit.libreoffice.org/44178Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: I7f57ad4f4294df43c3b9c8b3e6deb1641b102637
Reviewed-on: https://gerrit.libreoffice.org/44056Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I38b8c1da096c2b38f52defd8bb9a522e32fb881c
Reviewed-on: https://gerrit.libreoffice.org/44188Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: If85024b144f9d13da35b1f548100cf5860f3c75f

Change-Id: I289f61fe7e9d6b8c37b70a8fce56090c72af9abf

Change-Id: I974b48ddb54b954a512c3eb8949c6db0ff74c353

Change-Id: I0672f55c1d5ec14324b0d0589e2507c759b95911
Reviewed-on: https://gerrit.libreoffice.org/44186Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Ic060a8ec60c1209511c376f31e2dc45a48973294
Reviewed-on: https://gerrit.libreoffice.org/44166Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I1ec96ddbb4bba76b82d32a09fd2f47e46c64fc16
Reviewed-on: https://gerrit.libreoffice.org/44185Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I0d4a821935ef29b020409a34259a0c1fc487388f
Reviewed-on: https://gerrit.libreoffice.org/44183Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Ic084104b28dbcc439d98cd08a89a7ddc6f291878
Reviewed-on: https://gerrit.libreoffice.org/44158Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

This implements the reading and writing of the recently used
content in the advanced classification dialog. The recently used
content is stored to a xml file in the user profile folder under
"classification" folder - filename "recentlyUsed.xml". The content
is just a reflection of the resulting ClassificationResult vector
in a simple xml form.

Change-Id: If148ae123a6c826874b86dc1f374cdaab6e8fea9
Reviewed-on: https://gerrit.libreoffice.org/44150Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I4284ed8e59477e508cec3f02a6d1bf2aa3978dd8
Reviewed-on: https://gerrit.libreoffice.org/44177Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: Id0215a1044f330ffe6d09875d2f0ed6d4aa0b4f0
Reviewed-on: https://gerrit.libreoffice.org/44179Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

HRESULT's "success" value S_OK is 0; they are failed when their values are
negative. So, the incorrect check resulted in false failures.

Change-Id: I56560ced73e335af49c66d58201d5455e555e431
Reviewed-on: https://gerrit.libreoffice.org/44180Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Fixup after 74ab2a68

Change-Id: I57492bdee7cc4d3676b476a2a867211e5aa0bd13

In opencl we read and writer the profile xml with custom classes
XmlWriter and XmlWalker for reading. This classes are useful in
other places (very similar XmlWriter is used in test), so extract
the code from opencl and move it to a more common place - tools.

Refactoring of other usages will follow.

Change-Id: I8363e87b7c30083d299080adec3f99cb33ebe4cc
Reviewed-on: https://gerrit.libreoffice.org/44149Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

...at least in com_GCC_class.mk (com_MSC_class.mk will be addressed in a follow-
up commit), after the recent loplugin:includeform clean-up.

Two static libraries built from external sources needed adjustment, two
compilerplugin tests needed adjustment (which wasn't found by
loplugin:includeform, by design), and one more adjustment in
sal/textenc/generate/.

Change-Id: Idad5ae355a02ae130369a9a45b5f5925ab48ffef
Reviewed-on: https://gerrit.libreoffice.org/44174Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...but itself includes sw/source/core/docnode/cancellablejob.hxx, which only
happens to work because of -I$(dir $(3)) in gb_CObject__command_pattern (in
solenv/gbuild/platform/com_{GCC,MSC}_class.mk).  Clean that up by moving the
file.

Change-Id: I69dfb80460edc66309cdb6f08427a47cc2420f34
Reviewed-on: https://gerrit.libreoffice.org/44173Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...but itself includes svx/source/dialog/page.h, which only happens to work
because of -I$(dir $(3)) in gb_CObject__command_pattern (in
solenv/gbuild/platform/com_{GCC,MSC}_class.mk).  Clean that up by moving the
file.

Change-Id: I9f5f4b6884d9ec7357caaffa050c7b516762d71a
Reviewed-on: https://gerrit.libreoffice.org/44172Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...but itself includes svl/source/passwordcontainer/syscreds.hxx, which only
happens to work because of -I$(dir $(3)) in gb_CObject__command_pattern (in
solenv/gbuild/platform/com_{GCC,MSC}_class.mk).  Clean that up by moving the
file.

Change-Id: I7a04f757becf8113d1dccae9b78870e57ad3fbe5
Reviewed-on: https://gerrit.libreoffice.org/44171Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...but itself includes sc/source/filter/starcalc/collect.hxx, which only happens
to work because of -I$(dir $(3)) in gb_CObject__command_pattern (in
solenv/gbuild/platform/com_{GCC,MSC}_class.mk).  Clean that up by moving the
file.

Change-Id: I55db90a7039e6c1e3fdaa28c1df58347e117a87f
Reviewed-on: https://gerrit.libreoffice.org/44170Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

+ use loop ranges

Change-Id: I0ae81e3c10a6382d3f5719b2824a70d6e72b1462
Reviewed-on: https://gerrit.libreoffice.org/44169Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>