- 19 Ara, 2018 13 kayıt (commit)
-
-
Jan-Marek Glogowski yazdı
Just merges some common code into setdefaults. Change-Id: I2ba2c06425bcfe569fa147af713a064a145a2018 Reviewed-on: https://gerrit.libreoffice.org/65367 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
-
László Németh yazdı
OLE objects by importing their VisibleArea settings This also reverts commit 5c1a6c9adb5ccfbb869a0a7ac730d8860a1bf405 "tdf#99631 DOCX import: set 1:1 scale in embedded XLSX". Change-Id: I73dc945c86d0200e72767810b2ff39f233729080 Reviewed-on: https://gerrit.libreoffice.org/65343 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
-
Zdeněk Crhonek yazdı
Change-Id: I9f9b92096ce2e59b3fe546ab67f9c664c837d585 Reviewed-on: https://gerrit.libreoffice.org/65370 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
-
Aleksei Nikiforov yazdı
Change-Id: Id3a5879f661a6fa51b9f9dc40af73687a8f624df Reviewed-on: https://gerrit.libreoffice.org/65310Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Jenkins
-
Arkadiy Illarionov yazdı
Use range-based loop or replace with STL functions Change-Id: I29ccc94be73ec3ab22c4915f4a18ad0247038cc4 Reviewed-on: https://gerrit.libreoffice.org/65204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
we don't own this memory, belongs to svl module Change-Id: Ief12408e4254ab3fc2069a8490ecf062a728b3d3 Reviewed-on: https://gerrit.libreoffice.org/65349 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
no need to store a ref-counted thing like OUString using the heap Change-Id: I372417f1a60d120e867f4f4b3b9335b73693accb Reviewed-on: https://gerrit.libreoffice.org/65348 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
no need to store small objects separately on the heap Change-Id: If51b936eb0c2a4b721a1b2e5ccdf785f7e2b762b Reviewed-on: https://gerrit.libreoffice.org/65346 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
fixing a leak in PipeAcceptor::accept Change-Id: Id47da5e2a2c4060958aee9233feec859aebc69c7 Reviewed-on: https://gerrit.libreoffice.org/65345 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I6c0f07f0dc4a7f6bfa15c0ea720f349894559429 Reviewed-on: https://gerrit.libreoffice.org/65340 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: Ib2f00c10b91ced44c7476290360485c8550ec718 Reviewed-on: https://gerrit.libreoffice.org/65339 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Adolfo Jayme Barrientos yazdı
Change-Id: Ibe5c344a45b96cd92591ce721c24009a646313d5
-
Eike Rathke yazdı
That is a programming error if precondition is not fulfilled. Change-Id: I9eb04cc99d10c27f193321ecaee74cc1b41ce531 Reviewed-on: https://gerrit.libreoffice.org/65359Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
-
- 18 Ara, 2018 27 kayıt (commit)
-
-
Jens Carl yazdı
Move XIndexAccess Java tests to C++ for ScTableRowsObj. Change-Id: I90dc592ba7901dab9c402b56e9e992fe7593c71c Reviewed-on: https://gerrit.libreoffice.org/65371 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
-
Jens Carl yazdı
Change-Id: I4d8fb95af78330d488e4b782eb8cdff5b83f1cc2 Reviewed-on: https://gerrit.libreoffice.org/65369 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
-
Michael Stahl yazdı
The new mode would consider a fly anchored at a node that contains the start or end of a redline but has no visible text displayed to be hidden, while the old move-code would move it to the merged SwTextNode and therefore keep it visible. Change this to give the same result both on layout creation AppendObjs() and switching AddRemoveFlysAnchoredToFrameStartingAtNode(). Reproduces with ooo108073-2.odt, tdf104735-1.odt Change-Id: Ibac795dcf7848d78e8a2200124bc2557f35ba434 Reviewed-on: https://gerrit.libreoffice.org/65366 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
-
Jens Carl yazdı
Change-Id: I4bc3f2743b2d57308e687eb37f78c625c2bdc184 Reviewed-on: https://gerrit.libreoffice.org/65364 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
-
Katarina Behrens yazdı
otherwise Desktop::Main will do it and soffice will crash w/ empty error msg Change-Id: I56768909227a6ff158ae353e1eff9b249d6ba9d4 Reviewed-on: https://gerrit.libreoffice.org/65357 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
-
Lionel Elie Mamane yazdı
not only executeQuery. Change-Id: I2ee72078c48f622484dba46436f53990a45da364
-
Lionel Elie Mamane yazdı
note that we implement it in a very limited way, since we will always return only a single result. Change-Id: Idc7927d1a6896b78f6de8627ba857982821ac629
-
Caolán McNamara yazdı
Change-Id: I3426df04b938487844e471c4cd34bcd72a1b3dfc Reviewed-on: https://gerrit.libreoffice.org/64617 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
don't need it anyway, the width req is already set by SvxNumberPreview::SetDrawingArea Change-Id: Ic5b03a13a98c76c5ce927b13fc295510b6d8686d Reviewed-on: https://gerrit.libreoffice.org/65353Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I1bb4ee9354914db21d0440f83c156069a5efd9f9 Reviewed-on: https://gerrit.libreoffice.org/65355 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Thorsten Behrens yazdı
No need to suggest showing redlines beyond 250 changes anymore. Change-Id: Ia219a4eb3af64079979538b8ab4aaf2a94ec19c8 Reviewed-on: https://gerrit.libreoffice.org/65294 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
-
Michael Stahl yazdı
...able to be triggered by the UI, so the performance problem should be gone. The SwXTextDocument "ShowChanges" property allows API clients to call SetRedlineFlags() and change the model; this API should be retained as-is for now, because there is no way currently (outside of the rather specialised a11y API) to get a "merged view" of the paragraphs in the document, so API clients may want to (temporarily) toggle this property to then retrieve properties from the model. In case we later find that there are no API clients that want to do such things, the property can be removed. A run with assert() instead of SAL_WARN_IF() found only 2 tests that explicitly call SetRedlineFlags() to clear ShowDelete. Change-Id: I44aee90f7727948ca0bbaaff9d04f8dd6b97cbd1 Reviewed-on: https://gerrit.libreoffice.org/65350 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
-
Aleksei Nikiforov yazdı
Allow setting Qt5Object's position and size Change-Id: I9f70b68ff402a3975e36baca4d81103603110d82 Reviewed-on: https://gerrit.libreoffice.org/65309Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins
-
Jens Carl yazdı
Move XNameAccess Java tests to C++ for ScScenariosObj. Change-Id: I73dd65e672e1e98a6839cea03c30cfafb7da4ff4 Reviewed-on: https://gerrit.libreoffice.org/65313 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
-
Jens Carl yazdı
Move XElementAccess Java tests to C++ for ScScenariosObj. Change-Id: Ic1592746f99f685375e5b96c5b51c221d48ab07f Reviewed-on: https://gerrit.libreoffice.org/65308 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
-
Michael Stahl yazdı
remove ExperimentalMode checks Change-Id: Ie098eda0840bbd3231696cae43cc572ad61379fc
-
Michael Stahl yazdı
This assert is wrong, because there may be a legimate need to query a position that is currently hidden. However, oddly enough, we haven't found a legitimate document yet that triggers this, and it has pointed us to several interesting functions that needed adapting to merged frames... so keep it a little while and remove it (and return something other than COMPLETE_STRING from mapping functions) later... Change-Id: Ide2abf0c2ce054b75c917063a5d5aa8d13430426
-
Michael Stahl yazdı
There's a test for that, testRedlineFlags() in sw_globalfilter Change-Id: I9c821732910298d74271d95f0bfd0e902af84dbd
-
Michael Stahl yazdı
Change-Id: Ief227f3f5b03ec186178f4d68c3a415969d65507
-
Michael Stahl yazdı
nullpointer in ~XMLRedlineImportHelper in SwUiWriterTest::testThreadedException() Change-Id: Ic4a79ceffa831aced4db47836333a15a13773887
-
Michael Stahl yazdı
Change-Id: I78cfca1cd629bf518f8294450a34ee228a360ef9
-
Michael Stahl yazdı
* rename the only user, some UpdateFields() overload, to UpateOneField() * restrict it to search for non-formatting hints; the FindAttrsImpl() should be used for formatting hints instead Change-Id: I15002610a287fcdcd76777733a277d2ce64904bc
-
Michael Stahl yazdı
Iterate over merged nodes, and iterate over extents in them, so the complex attribute-finding logic doesn't need to be changed. Change-Id: Id72ca9247165a0c93f0cf2a38b7a0249771ca2eb
-
Michael Stahl yazdı
When redlining is enabled, the result will be a delete redline for the existing text, and an insert redline for the new text; that much is obious (and ReplaceRange can deal with a selection larger than one SwTextNode easily, since it mostly adds redlines). For the case when redlining is disabled, there are 2 options, and i don't really know which is preferrable from UX point of view: One approach is to reuse GetRanges() to ignore delete redlines in the replace range; move its declaration to different header. Another approach is to DeleteAndJoin() the existing delete redlines, which is the same as the previous model based Hide mode, which calls DeleteRedline() to remove the hidden redlines. Also change ChgAutoCorrWord() to call DeleteSelImpl() directly. Change-Id: I5974409d09eb39e04cc0b5dfc20d4db510e1cf58
-
Michael Stahl yazdı
Generally speaking, the find functions should find the strings that are visible in the document view. However, they may also be called from SwXTextDocument functions, where they ought to find the strings that are actually in the document model. So concoct some funny helper types and adapt this so it can handle both cases; it's not pretty but maybe it even works. Change-Id: I1917398ff928e922673353e75e8fb724dc042031
-
Michael Stahl yazdı
Also, some of these don't really make much sense as member functions of SwPaM, so make them plain functions instead. Also, some pointer parameters are never null, but there is code to handle that case in MakeRegion(); simplify that. Change-Id: I822e814b0cab14f7f31cfa33478ed15774405a61
-
Michael Stahl yazdı
... so use it only once. The problem is that the second time it will call DelFrames() on every non-first node, which then empties the first frame's newly created MergedPara instance. This can be reproduced by toggling Edit->Tracked Changes->Show in tdf99766-2.odt. Also change some function parameters on e.g. SwTextFootnote::DelFrames() to SwRootFrame to make it obvious that these don't actually need a particular SwTextFrame. Change-Id: I129be5db4a30546905c24c5e8820a5f105a33109
-