found by PMD

Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Doing this ahead of time eliminates the need to update script types of
all replicated cells after the paste.  This makes significant performance
impact.

Change-Id: Ic4f7d7b2fe152bd5640ddb1dae01cc2ed757657e

The signature should be in DER-encoded PKCS#7 format and what CryptSignHash()
produces is nothing like that. Luckily CryptSignMessage() is actually almost
easier to use and is capable of doing what we need. This also means that we
won't need any HCRYPTPROV or HCRYPTHASH after all so all the code related to
that can be removed. CryptSignMessage() handles both calculating the hash and
signing it.

One less than ideal issue with CryptSignMessage() is that it needs all the
data to be hashed and signed at the same time, so we need to keep both buffers
around for signing.

It also turns out that we don't need to look up the certificate anew from the
user's certificate store after all.

Now Adobe Reader doesn't complain any longer about the signature's format and
contents.

Change-Id: I25cfb93b516ffa723c6228d068d9ffa8e7cc4790

There was one details that I had missed in my initial coding:
CryptAcquireContext() doesn't give you a HCRYPTPROV key container that
would contain the private key of a public key certificate. For that
you need to use CryptAcquireCertificatePrivateKey(). When the hash has
been created using such a HCRYPTPROV, the CryptSignHash() call
succeeds.

The certificate in DER encoding that is passed in from the caller,
obtained in the certificate chooser (in xmlsecurity), is possibly not
good enough to be used for the other things. So look the same (?)
certificate up in the user's key store instead. At least more
properties are present in the certificate when looked up like that.

Add more SAL_INFO logging, with cleartext dumping of certificate
context property names and list of algorithms supported by the CSP.

Unfortunately, even if all the WinCrypt API calls now succeed, the
signatures we produce still are not good enough for Adobe Reader... A
lot of information must be missing, they are quite short, just 256
bytes.

Change-Id: Ifa4dd37b6d40932fcdcbb07e00c9eb52d54a5477

Change-Id: Icdb68af83a0b208f9a427ee61ae18020c8835a41

Change-Id: I769ee8ed75a9691ab6cd54619b3fd9f2852f8baa

This fixes a regression introduced at 43941d9a.

Change-Id: If73883569049f0f3ae8a2d40f6704f74e63eecb2
Reviewed-on: https://gerrit.libreoffice.org/13401Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

So that this is always wrong (on this platform) to write:

reinterpret_cast<foo>(reinterpret_cast<long>(bar))

it should be:
renterpret_cast<foo>(reinterpret_cast<sal_uIntPtr>(bar))

Change-Id: Ia286246ee1616988f755c2d2054b26efacc51af0
Reviewed-on: https://gerrit.libreoffice.org/13366Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Id2957f1cb68fc4b2fef9966abeb6745b548bcb75

partially reverts ff17c5a2

Change-Id: I413fe859f7691d36334b68ad0862f3c100c72264

Change-Id: I4ca19e6efed8ba1ef724136c577a3dcac80f7d62
Reviewed-on: https://gerrit.libreoffice.org/13365Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I7a5babe494bdb09a71164ea74d7be3f6bf985ff6
Reviewed-on: https://gerrit.libreoffice.org/13215Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Idf9ea17b485ab07323a895e7e3f1eca1e198747c
Reviewed-on: https://gerrit.libreoffice.org/13047Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

9df0e4a709735e5fb5c0e87779b0694c512f0de7 moved ct2n to AutoInstall,
but missed to add dependency in  scp2/InstallModule_extensions.mk.

Change-Id: Ibfc30f1efa494996e832c8039fde69420f0ad5ee
Reviewed-on: https://gerrit.libreoffice.org/13398Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Ic376a4e03cafbba65ec78723de188bd627c0ef4f

Contextclasses implement XFastContextHandler
Importclasses implement XFastDocumentHandler
Tokens for BlockList.xml are defined in BlockListTokens.txt
Tokens for content.xml are defined in TextBlockTokens.txt
A perfect hash table is generated with gperf and used by the tokenhandlers

This is corrected version of c1e90457
(Also pushing again follow-up c940d4d3
"loplugin:saloverride" and 5f0f3d4e
"Work around -Werror,-Wdeprecated-register")
The commits were reverted in 7ef4457b

Change-Id: I08cd852fa751f98fd0ac6a55dda22f82a869b4d8

Change-Id: Ib04880eee7ffed621a97ca0f6c6f9896eb54df0d

...introduced when https was added in c21b8a16
"INTEGRATION: CWS tkr05_SRC680: #31053# HTTPS WebDAV support"

Change-Id: Id7c361a078008d66391771f26b9c35999404091f

Change-Id: I30bf474fc44b122c8b7218e187c822a8784783fd

It was only checked by our own code, and only DirectX 9 is supported.

Change-Id: I03035f87969301624df011cb4d76c6a9532f3c99

Change-Id: I661949a8635a2ed1a1efda77ced48a0fa9f6722e

Change-Id: I30657eb609a9d02217238dd37a3f23e05168569c

Since MSVC 2012 the Windows SDK includes DirectX as well; the last
release of standalone DirectX SDK was in 2010.

Change-Id: I4236421e7abd7a4a7201ef5913dc21c76945ea53

Change-Id: I5106593ad5472992e3607665849fb35802b6e266

Change-Id: I3ae51b8c57e70593153805e5c7c139573c543b5a

Change-Id: Ia94f490c0ad8c392bd8bbfbe889f5333c13e0022

i.e.

commit af64f430
Date:   Mon Dec 8 16:11:41 2014 +0000

    writer won't allow us to enter multiple CrossRefBookmarks on the same node

    e.g. fdo63164-1.docx and loads more like that, and the .docx genuinely has
    multiple bookmarks at the same place, so just allow the first one and discard
    the following ones

in favour of

commit 7a12360e
Date:   Wed Dec 10 14:56:27 2014 +0100

    sw: don't assert when SwXBookmark creates duplicate CrossRef*Bookmark

    The bugdoc of fdo#87110 has a couple such duplicates.  Check for it and
    let SwXBookmark throw an IllegalArgumentException.

but leave test doc in place

Change-Id: Ib0bfc991684b2c9c4f1959a17c49bf1c0179be79

(similar to our CPPUNITTRACE hook)

Change-Id: Iec4e8d4246ba7fca0afe5f9be6f6bcd9e0289e49

Change-Id: I68f7d4e2d91d37013018fc3cc185c46eb81fcb7d

regression from introduction of boost::ptr_vector originally one had to Remove
and delete the return to delete it, while now the Remove automatically delete
it. This bare Remove to just "release" it seems to have been overlooked

Change-Id: I175f7c95862ce47402993e5e3b8feaa93af43e75

Change-Id: I884aca0e49f424823201a69f03c6bba4e816f3c1

For example,
1. echo -e "5,6\n7,8"
2. select the lines and copy them to clipboard
3. select an area in Calc, starting from bottom right
4. paste
5. select comma as data separator in the CSV import dialog

I think most people would expect the data to appear in the selected
area, but currently it would be inserted starting from active cell
(which is the bottom right cell of the selection).

Change-Id: Ief0e05deda18928a832dca2a261f8493ac9a03a9
Reviewed-on: https://gerrit.libreoffice.org/13410Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

It doesn't win us much performance-wise (as it turned out), and causes
weird crashers with large documents.

Change-Id: I0566ce850b8f6656e6f9821c653b7a825a7874a3

When exporting the .DOC bugdoc of fdo#87110 to ODF, the auto-styles
export will iterate over the fieldmarks in the page header and add the
attributes for them but not export the elements, so the first auto-style
gets a bunch of duplicate attributes.

Change-Id: I3fcf39f03e3d9ae5fca661efa7eb4bbb3eab9f5c

The bugdoc of fdo#87110 has a couple such duplicates.  Check for it and
let SwXBookmark throw an IllegalArgumentException.

Change-Id: I460dc3a8d9c554c194a32a73526e13422ddd1c52

There are at least 2 callers of InsertTextContent() that have
non-trivial catch handlers for this exception, which aren't called now.

(regression from bebf8ccf)

Change-Id: I085b710dfd5877e9b7e71610951543eddf6a6e46

Reviewed on:
	https://gerrit.libreoffice.org/13413
Conflicts:
	sw/qa/extras/uiwriter/uiwriter.cxx

Change-Id: I26a8707046d7f30381fb51c41e49f8dee4796ba7

The problem was that in case the bookmark range points to a number of
characters in a text node, where neither the start or the end is the paragraph
start and end, and in case there is an at-char anchored object at the beginning
of the paragraph, then lcl_CreatePortions() never ended.

It is assumed that the loop in lcl_CreatePortions() will end at some stage, as
every iteration moves the cursor forward. But this wasn't true in the above
situation: the first frame was anchored at char pos 0, the range was char
positions 1..7, and we failed to ignore frames which are anchored before start:
so position was constantly 1.

Fix the problem by explicitly ignoring frames before the current position, so
lcl_ExportFrames() properly returns -1 when there are no anchored objects in
the current range. Testcase is in the next commit.

Change-Id: I73662e09cd09ee7e0ea4575b1150beb40f1ccc3a

...they just "happen" to have the same name

Change-Id: Ia602f9a62e07c3af6fba2ffb84a858e1fb4b09ce

the 8.1 one is the only where it is installed to in a plain install of
VS2013 (update 4)

Change-Id: I797c3d1501d6ee87e5f662279221c4d285933f2d