Objectives:

- Reduce copy-paste, by defining the list of commands
  only once, and reusing everywhere (menubar, context
  menu, toolbar button).

- Kill SwTbxAnchor. Once we have separate popupmenu,
  we can just load it with the generic controller.

Change-Id: I5a8b47892471e293ee2331915361f8ce256dc76c

Change-Id: I2114436f4bef3ac71a3035a206186cefaf88bca1
Reviewed-on: https://gerrit.libreoffice.org/23023Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I531dcf0861ab5a545eec16bf4aa92ac92eb9626e
Reviewed-on: https://gerrit.libreoffice.org/23022Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Now that we can have the one element error matrix we can't blindly call
ExecuteOperation() on it that would access elements out of bounds.

Change-Id: Ib6e5525f685c9324235f128a943dd716ea7a3fca

Change-Id: Icbb9e2590f1b8b18c021b978baf7f79c838c4c9c

Regression from commit e2b260fc (sw: let
layout not mark embedded object as modified, 2014-06-03), an infinite
loop was caused by:

1) SwDoc::SetOLEObjModified() triggering the maOLEModifiedIdle Idle
2) which at the end called SwWrtShell::CalcAndSetScale()
3) which at the end called chart::ChartModel::setModified()
4) where chart code called back into SwDoc::SetOLEObjModified() via the
modification listener, and this happened again and again.

The original fix wanted to avoid marking the document as modified
without a user interaction, so fix the bug by only calling setModified()
if it prevents a not-modified -> modified transition. This keeps the
original bug fixed, but prevents the infinite loop, that is always a
modified -> modified transition.

Change-Id: I3b56a91afaacd3e0b7cb646a492fd15f1b5168ee

Change-Id: I5cac6fb0278e3952e2538f06188ed510644fcaa0

Change-Id: I343844aca956a1ce05c733f60a28d51115574ef8

Change-Id: I62ec68ed2ff67ac62137de2fcd7106ada90721ae

Change-Id: Iae7967bd5f161ecbe888824a4bcb9b87ec8d947a

...in LibreOfficeKintInit.h's lok_loadlib, now that RTLD_GLOBAL isn't only
needed for UBSan (62b124b2 "Ensure RTTI symbol
visibility for Linux Clang -fsanitize=function,vptr") but also for
-stdlib=libc++ on Linux (see
<https://whatofhow.wordpress.com/2016/03/01/libclibcabi-on-linux/>).

Change-Id: I24ed6612c3d922eba695423d46af5635c77f7077

finds parameters that are only ever being called with a single value

Change-Id: Ibd0c9b6e6dbc1d1b5d5a005eaa19959560a6e50f

Regina posted comment on 22363, that this change was needed.

Change-Id: I9021d40ee7c1ca7ca74d67c61fe58ce976da38c0

Change-Id: Ie9bfc6a5f3e1862acbd1bb08c6f2bb0b63f2587e

Change-Id: I86c268f49f44bd1e208a9de781a16bf19450c64c

Change-Id: I5303caf69128a0a6d28fccfcf2ab63ed466e3853

Change-Id: I8ff9f61475fddb475fe08e867c5446c825abb7dc

Markus did half of this, and I simply carried the torch.

Change-Id: Icd3ee1e4b5bd562faee06dfd9dce52a4bed49a71
Reviewed-on: https://gerrit.libreoffice.org/22943Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>

For reasons beyond human understanding, the many-tentacled horror that
openssl calls its build system puts headers in "inc32" directory on
Windows and "include" on other platforms in 1.0.2g.

Change-Id: If03c80f5a31bb6e378cd187051b020579af7f7bd

Change-Id: Ibc922d84aeaba4e2dbfac3a23f253db76408db45

Change-Id: I57f4dc90bc2ad8488af8cd42515b195f4320a9d9
Reviewed-on: https://gerrit.libreoffice.org/22939Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I4a9f6c07204f2784ac6cac28bed9dfa700950c09

Change-Id: I81f7b278ba75abca6db59ab12dd1cf79dda15d20

Change-Id: Iaac45af141220f5a7460b7313507d3927a2b2581

Change-Id: Ia3ea04d15ce73526e87dfb5670eedff983daa40e

... to distinguish from other errors, and really, errStackOverflow
should mean exactly that.

Change-Id: I3d2bfbd38b056c7d0a346797db560717312de069

Change-Id: I0a1426f81e5ece30c4ca416716b5ada2d53a0412
Reviewed-on: https://gerrit.libreoffice.org/22881Tested-by: Yousuf Philips <philipz85@hotmail.com>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>

Change-Id: Ib9d0d59845270152c2a8233d81b9cfac96259141
Reviewed-on: https://gerrit.libreoffice.org/22974Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

... which also prevents a (theoretical?) overflow of size*size.

Change-Id: I11e27718c9750ad1b17f6f16bb1b293aa4a2f574

It fails in Tinderbox Linux-rpm_deb-x86@71-TDF
This reverts commit 3c465c25.

Change-Id: I20fc69dd785354cc6567b73251ee9161a811bdf0
Reviewed-on: https://gerrit.libreoffice.org/22987Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Xisco Faulí <anistenis@gmail.com>

... not into the source one as that will likely fail with EXDEV if
source and target are on different mounts => osl_File_E_EXIST.

This broke the xmlsecurity test SigningTest::testOOXMLAppend().

Change-Id: I07ada1d5564fd72a059d588e127a5906a499aca4

... which it doesn't, currently.

Change-Id: I0280a11006afb08b95ff643e8b999b4e5a733d2d

i.e. the position provided is the location where the popover is to be drawn,
not the bounds of the thing to be pointed to, so adapt them so gtk will point
to the desired place.

e.g. the slide names/numbers in the presentation slide view sidebar

Change-Id: I8c87d5dba32e27f9e627b3282f34d87a8ee460ca

Change-Id: Ibe52933faa6b13e2d89ab296c1cc15b70f5835af

Change-Id: I73a673de54c0cff77a00a21f8a4c87766f956256

Change-Id: I5445837ec4f647e91fe2aeab1251e48628f5e7f1

Change-Id: I2ef0b873a58710de399889cee3abf6b6ecf4fb1e

Change-Id: I5ddf0ba5fc289a124b39b9c14b7f5fdd3d7b54a4

Change-Id: Id35caa8b8ed0c2f7e4d868f5c87a2a0f331cb352

Change-Id: I13afaa9d0c7c9b46b3ebaedf299de41bed551e7c