Change-Id: I859b77319f551eabd19dae54bd69c212221112a8
Reviewed-on: https://gerrit.libreoffice.org/39938Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6ff24f048bd8f75bf87a78b718f37b57855d4781
Reviewed-on: https://gerrit.libreoffice.org/39932Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I8bc5c925f940283bc54698bbcba77efcca883273
Reviewed-on: https://gerrit.libreoffice.org/39937Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...after e3f3b3b7 "pdfium: update to 3151"

Change-Id: Ie8646b4f1a132e8be6da10e9919e17865bc3e571

...which showed that checking the parent statement (which may be too large to)
in OnceVar::VisitDeclRefExpr is inadequate.

Change-Id: I07fb8ba9e2dfbd0c65a2723737d14abcddcefec4
Reviewed-on: https://gerrit.libreoffice.org/39757Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

...as found by an improved loplugin:oncevar (to be pushed later).  The code's
effectively been like that ever since its introduction in
a41687b6 "New files from
xlsx-shared-oox-chart-export-part1.diff", and (as Bubli states) is apparently a
poor copy/paste from xmloff/source/chart/SchXMLExport.cxx.  The equally-unused
[m]sTableNumberList had previously been removed with
f9cd73eb "remove a few more unused variables".

Change-Id: I1e0e14b4d79cd34437b0061fc9ea3ce4d5636b31
Reviewed-on: https://gerrit.libreoffice.org/39756Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Put all the UI content in UI XML file.

Unfortunately, lots of boilerplate code because
G_DECLARE_* macros are available only since glib 2.44

Change-Id: Idc74ba8565d482c28abd00b6f6f75646ab3d40b9
Reviewed-on: https://gerrit.libreoffice.org/39913Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>

This reverts commit 1b08f129. The
change was Jenkins-verified, but just rebasing it on top of latest
master (without getting conflicts) broke the test added in the commit.

So let's revert it for now to have time to find out why does the test
fail on top of latest master.

Change-Id: I3bce24e54fb07df2dd460fb0f01d44516b3fcd0d

Change-Id: I1a7691fe59e5e93c15bd812f03366da814f9f3db
Reviewed-on: https://gerrit.libreoffice.org/39900Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Idcfec3e33031eea311377a51f51c65dd3c4d25dc

...after 3f204714 "use std::unique_ptr in
FlatFndBox: and extend o3tl::make_unique to cope with arrays"

Change-Id: I17a07d0be677aa4a5427be4a5c2f05ed8b675726

According to the OOXML standard the default value is true, so for
the export of gradients and blips it has to be set explicitly to
false.

Change-Id: I3c9f67787cb11d6d9b58f07377b03167df669ed8
Reviewed-on: https://gerrit.libreoffice.org/39725Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Convert tests:
- test_marks1
- test_marks2
- test_marks3
- test_frame_mark1
- test_frame_mark2
- test_frame_mark3
- test_frame_mark4
- test_frames1
- test_frames2
- test_frames3
- test_frames4
- test_frames5
- test_ruby_hyperlink1
- test_ruby_hyperlink2

Change-Id: I3ee495cdd88cffefd3980184bac0a72bae6a749f
Reviewed-on: https://gerrit.libreoffice.org/38976Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

And a few other similar small cleanups.

Change-Id: I91c992f33f2166d1cf27cbc9def1b69965040658
Reviewed-on: https://gerrit.libreoffice.org/39928Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

ScXMLTrackedChangesContext
ScXMLChangeInfoContext
ScXMLBigRangeContext
ScXMLCellContentDeletionContext
ScXMLDependenceContext
ScXMLDependingsContext
ScXMLChangeDeletionContext
ScXMLDeletionsContext
ScXMLChangeCellContext
ScXMLPreviousContext
ScXMLContentChangeContext
ScXMLInsertionContext
ScXMLDeletionContext
ScXMLMovementContext
ScXMLRejectionContext

Change-Id: I13b657efa47bd037e9f83c39ba8fd0f6b7edba1c
Reviewed-on: https://gerrit.libreoffice.org/39927Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

as in VBA-compatibility mode.

Change-Id: If263183fc1fa5742235213a8617fdf412d2a245e
Reviewed-on: https://gerrit.libreoffice.org/39893Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

regression from 00aa0892

Change-Id: I840391573ae52be6ba4a34b2a802b637578afa40

When binding a GDI device context to D2D we need to provide a
rectangle where the surface will have effect. When we just need
some font information we need to bind the DC too, but we aren't
really interested what the rectangle is, so we just provided a
0,0,0,0 rectangle in that case. This sometimes fails with a
"out of memory" result and is dependent on the renderer.

Instead of 0,0,0,0 rectangle we rather define a 0,0,1,1 rectangle
which should never fail. This is not problematic as for actual
rendering we later rebind with an actual rectangle.

Change-Id: I79c7f0cf4d69f213370ed26a811a908ed16070ff
Reviewed-on: https://gerrit.libreoffice.org/39901Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

The intention is to filter out text frames directly inside tables; since
tables in general reflow by moving all of the content to the first page,
then moving not fitting content to the next pages.  Section frames are
different, there we explicitly move content backwards, similarly to page
body frames.

Teach SwFlowFrame::MoveFwd() that a text frame inside a section-in-table
is the section situation, not the table situation, since what matters
here is the direct parent. To be on the safe side allow this for follow
section frames only.

This is necessary, but not enough to address the sub-problem described
in comment 12 of the bug. At least SwFrame::GetPrevSctLeaf() is invoked
to consider a precede section frame, though.

Change-Id: Ic88602cffefbbc81ecc90e3880be2a098f60fb04

Change-Id: I0c4c2f3389cae243dbbfd16667d44d3ab8851860
Reviewed-on: https://gerrit.libreoffice.org/39914Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>

seems wasteful to be allocating a single int for this

Change-Id: I8e1122fec8c8dc90805a38b677a1e08cd89a66ff
Reviewed-on: https://gerrit.libreoffice.org/39917Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

ever since commit 12191a4f
"make loplugin constantparam smarter about string params"

Change-Id: Ifb8cfd8542596a826142547cd2dd90e2b5d682f8
Reviewed-on: https://gerrit.libreoffice.org/39910Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id4738462b62d78fa48c937928a01b293cefdfabc
Reviewed-on: https://gerrit.libreoffice.org/39720Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Iaee7f4f038000c7009c9c74b822b7599559f09ca

Change-Id: Icf576c08b3502ea3e24fa4b3685b55f794e844db
Reviewed-on: https://gerrit.libreoffice.org/39650Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This serves two purposes. It helps to prevent regressions
and it allows focusing on features that still don't export properly.

Also created rtfexport3 since the other two are already very full.

Change-Id: I7d580f575c1debe344275869fefcbba6e29cbad6
Reviewed-on: https://gerrit.libreoffice.org/39842Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: Idb198f0121ac9c6b4083b157af07c5eb1cda66cb
Reviewed-on: https://gerrit.libreoffice.org/39265Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ifa62b1ce2aefa939cfceb2e110d126b785cb6e26
Reviewed-on: https://gerrit.libreoffice.org/39032Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iadde719a024c5fce97aa0f4c58947a5012639a84
Reviewed-on: https://gerrit.libreoffice.org/39918Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ia6cbe829f94b3f27e4ea633c02d6b1ec6e98e984
Reviewed-on: https://gerrit.libreoffice.org/39860Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

...updating references during a block move, for formula cells
that are in the target range of the move operation.

The fix is for formula cells that are not grouped. For the
grouped case, it was already doing correctly.

Added two unit tests in ucalc_formula.cxx for grouped formula
and non-grouped formula cases.

Change-Id: I9f4d988f5e154f56670bd1c0cc366ee6704fb858
Reviewed-on: https://gerrit.libreoffice.org/39883Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

Use Command property i.o. ActiveCommand
because Command is additionally valid when form opened in Design mode

Change-Id: I0c9e545419ec99d444ac15b20466c838d53f738f

Simplified version of commit
  3e20ce80

Since we're missing g_source_get_ready_time in our baseline, this
can't change the complex implementation, but still drops the timer
array and uses a single-shot timer, like all other backends.

Change-Id: I0641da8d0db71785c505957533a9069924808cd4

Change-Id: If8e0d3e7205737a1e15c563527d3845c7ae93dc1

We need to call it once because we have no other way to detect whether
it's working or not.
But if we receive an error the first time, we disable it from now on.

Change-Id: I67dba8b65660ff7e05bdf2ddc18b565550901cd1
Reviewed-on: https://gerrit.libreoffice.org/39885Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

This reverts commit 34612139.

upstream fix is to fix configure to do a link check instead of
compile-only for getrandom.
See f78ed1ec

Change-Id: Ia9a3f1c2091048778e2bf4773f9e31ae4700ce0c

https://github.com/libexpat/libexpat/issues/52

fixes /usr/include/sys/random.h:37:22: error: expected ')'
misdetection of random.h feature, already fixed upstream:
https://github.com/libexpat/libexpat/commit/602e6c78ca750c082b72f8cdf4a38839b312959f

Change-Id: I65e4aebaa838d2931a60cb34806d87b88861c4d8

Change-Id: I70d7e50f8c1e019524ccad915f0cca912c5035dc
Reviewed-on: https://gerrit.libreoffice.org/39899Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Current LO baseline doesn't have g_source_get_ready_time,
so we keep the old stuff.

This reverts commit 3e20ce80.

Change-Id: I32c39fa70c8d52cbb78620f528d60a986087dfd0

Change-Id: I0bb25a89ddc76c91d01d1cee785be0337eb1f1d0
Reviewed-on: https://gerrit.libreoffice.org/39897Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>