...so consistently use the latter instead of the former

Change-Id: I144d5e7c472632f93b2258461510346bc85892d9
Reviewed-on: https://gerrit.libreoffice.org/48135Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

> Jan 18 15:18:25 <sberg> tml__, do you remember anything about
>  e3a07b8a ? looks odd to add configure
>  KEY=VALUE args to the environment
> Jan 18 15:18:27 <IZBot> core - Include environment variables already in
>  autogen.sh's environment -
>  http://cgit.freedesktop.org/libreoffice/core/commit/?id=e3a07b8a6cc03b6d5063e4da5a474d8c91a84b0a
> Jan 18 15:22:54 <tml__> sberg: not really any recollection, sorry
> Jan 18 15:23:09 <tml__> sberg: are you sure this isn't what makes it possible
>  to have CC=clang etc in autogen.input?
> Jan 18 15:24:07 <tml__> or maybe this is related to propagating stuff when
>  make re-runs autogen.sh?
> Jan 18 15:24:28 <sberg> tml__, configure already takes care itself of its
>  KEY=VALUE command line arguments
> Jan 18 15:24:36 <tml__> sad that I didn't write a better commit message
> Jan 18 15:24:55 <tml__> feel free to revert it, and see if anybody notices;)
> Jan 18 15:25:04 * cloph_away used it for CC/CXX and devtools repo
> Jan 18 15:26:11 <tml__> cloph_away: yes, but I think sberg says that should
>  work anyway, even without that commit

The only reading from ENV after that code in autogen.sh (both today and at the
time of e3a07b8a) is the

  if (defined $ENV{NOCONFIGURE}) {
      print "Skipping configure process.";

check, which would now no longer work if you pass NOCONFIGURE= as an argument
to autogen.sh (in autogen.input or on the command line) instead of as an
environment variable.

Change-Id: If50639978190d219b063ff39f81e29d2054c0443
Reviewed-on: https://gerrit.libreoffice.org/48133Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...which allows to align --enable/--disable switches on the part being en-/dis-
abled, as in

> --disable-assert-always-abort
>  --enable-avahi
>  --enable-breakpad
>  --enable-build-unowinreg
> --disable-ccache

for better readability

Change-Id: I490402c74ea1ee535deee6ef79274b588b614820
Reviewed-on: https://gerrit.libreoffice.org/48130Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I8c4cc4ab212409bce54b64d59d07d77a924ed11c

Change-Id: Ic8b02f5c6582a992b64f31435332ee37d826ad48

Change-Id: I788ec594589d9708e12db83a7371b5a8d9fed38c

Change-Id: Ic66d817746de423549c87f58068e47f9942d04fd

Change-Id: Ibeae1754a18152c3a17379c95e3caa536a8822db

Change-Id: I0ebec3193b4369039f90be4223ebdf6d048b8478

Change-Id: I20525bd69c91ff35c9e569525a0d4556bc184982

Change-Id: I86622a13583137605bf2b6468113da2eb5e4ee0b

Change-Id: I2c3c7be4bc3b43f03c45724e7a002e862b50f24b

Change-Id: I3d25a50ed7ebf78214c0d358243f7e286503b8f8

Change-Id: I73005afdaf20efe15321a2a073beb3ae4f7a63e3

Change-Id: I00d1772732075848b25eb34d7c4b0386551c7e5f

Change-Id: Icc50b2ff1d6c7490b67d39aed7c3621b74c03bac

Change-Id: I19107173318180ec08864e523f4065181eac00cc

Change-Id: I17fc33cfd7c15734fd961fa76c676424900a4373

Change-Id: Id276015425ea7de3cf55b9ef21b4e7ce54c2ce47

Change-Id: I3681d119dda85400dbb33c96fab736c262f7ce8a

Change-Id: Iafaaafdabf9fb7947fa0b03cd38d3b4a567a41b9
Reviewed-on: https://gerrit.libreoffice.org/48110Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I853a949e68d192c48a90321a8b3b75a5d443638b
Reviewed-on: https://gerrit.libreoffice.org/48111Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>

...as the UNO_QUERY_THROW above would already have caused an exception

Change-Id: Ie0453b67716c64ddaddfa6becd498952a497be63
Reviewed-on: https://gerrit.libreoffice.org/48106Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

A condition was added in order to not make subtotal
functions if category was not checked.

Change-Id: I56f11330fa16bf0d3199576ce2545cbc8d13e864
Reviewed-on: https://gerrit.libreoffice.org/48099Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: I634c1132265295f90f624a53b93dddb2b18eabd5

Change-Id: I74b57cd510b1babbb4a537d307a6ffc9ee1d9ce5

Change-Id: I4b37be72ebec86b9360ea2594b26815ddaab60cd

Change-Id: Ib9595b1e0fe888a6698c3c508a24390d3798b3e4

...instead of having to add it to more and more individual .cxx files, as the
need arises.

Change-Id: If1e893c79abf1c1bb7fb7b89dcb9bd423a7f1b94
Reviewed-on: https://gerrit.libreoffice.org/48108Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: If7942ec9d4cd40f29fae2b9a8f76df1ef08bfc17
Reviewed-on: https://gerrit.libreoffice.org/48120Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

current android-gradle plugin creates the apk in dimension/flavor/variant
(whatever you want to call it) specific directory

Change-Id: I5514fe53c5c8c556d194a0f06ad6167b0b1cc98e

Change-Id: I5af76b87c3793c7ec7ac41ab25bb4de5d81fc3cf
Reviewed-on: https://gerrit.libreoffice.org/48123Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...by giving each test its own mxComponent.

At least my Windows builds started to fail CppunitTest_sc_tabviewobj with

> C:/lo/core/test/source/sheet/xviewsplitable.cxx:36:sc_apitest::ScTabViewObj::testSplit
> equality assertion failed
> - Expected: 1
> - Actual  : 0
> - Wrong column

after 95307f2c "tdf#45904 Move
_SpreadsheetViewSettings Java tests to C++" added the call to
testSpreadsheetViewSettingsProperties ahead of the call to testSplit.  (And
allowing multiple tests to work on shared state and interfere like they
apparently do here seems rather brittle in general.)

Change-Id: I73a60ae3c703e59852c8e16b09f5897849f5bdf4
Reviewed-on: https://gerrit.libreoffice.org/48070Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

as floating toolbars aren't movable there.

Change-Id: I543344946f02d5a336ff738b4d6d9f9b21c595e9
Reviewed-on: https://gerrit.libreoffice.org/48096Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

and remove the one from ImplPopupFloatWin. Implemented using
the FloatWinTitleType::TearOff case, which was unused otherwise.

Change-Id: I82a86e5f5897ce1f2e76a2404bb382cbc007700c
Reviewed-on: https://gerrit.libreoffice.org/48095Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

ImplPopupFloatWin draws the window title and frame directly on the client
window, which is incompatible with .ui layouts, as they try to occupy the
whole available space. Instead just use a plain FloatingWindow whenever
possible, and change the border window code to mimic the behavior of
ImplPopupFloatWin, wrt removing part of the frame of toolbar popups w/o a
title.

Change-Id: If72ea89e31f913470faad7fcb8083f9b9787c9a8
Reviewed-on: https://gerrit.libreoffice.org/48094Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Maxim Monastirsky <momonasmon@gmail.com>

since...

commit 84392651
Date:   Wed Jan 3 23:27:16 2018 +0100

    tdf#114173 Preserve size of chart legend during xlsx export

Change-Id: Iebc936a0f490d6b707dfee0343732753f56728e7
Reviewed-on: https://gerrit.libreoffice.org/48147Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I3c0b0603d1e03f1cc19af4324dd2b909320d9d4a
Reviewed-on: https://gerrit.libreoffice.org/47687Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>

Also adjust to dynamic permissions after bumping target-SDK.

There still is some confusion about the concept of "external storage" in
the code. LocalDocuments already is "external storage" - clean that up a
little and use AppCompat function instead of using a legacy class for
ExternalDocuments provider.
Doesn't help for broken ROMs though, that would need guessing pathname
for a mounted SD (in addition to separate storage partition of builtin
storage).

Also c6e8c96d incorrectly changed the
conditional around, making the whole ExternalDocumentsProvider useless/a
copy of the Local one (i.e. the primary, first returned by the system).
Real fix for tdf#99539 likely was 66be4fee

Change-Id: I88ca7742c0f2e89d63c338c8852ad88be0a46e4b
Reviewed-on: https://gerrit.libreoffice.org/45572Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

see 90d21559 for boost fix and
see effe6b3d for bridges fix for mac

Change-Id: Ic6209ce0927dafd39763ef0b2fabbcaa7abf743f
Reviewed-on: https://gerrit.libreoffice.org/46002Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins <ci@libreoffice.org>