- 25 May, 2018 24 kayıt (commit)
-
-
Noel Grandin yazdı
partial revert part of commit fa135fd0 remove unused SID constants and associated code noticed by Julien Nabet Also document some more of that array to make the usage more obvious Change-Id: I4d76034df32bc85b58e4a845b246e5e28dcea49f Reviewed-on: https://gerrit.libreoffice.org/54799Reviewed-by:
Julien Nabet <serval2412@yahoo.fr> Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
(*) if we are already throwing a Wrapped*Exception, get the exception using cppu::getCaughtexception. (*) when catching and then immediately throwing UNO exceptions, use cppu::getCaughtException to prevent exception slicing (*) if we are going to catch an exception and then immediately throw a RuntimeException, rather throw a WrappedTargetRuntimeException and preserve the original exception information. Change-Id: Ia7a501a50ae0e6f4d05186333c8517fdcb17d558 Reviewed-on: https://gerrit.libreoffice.org/54692Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I785e96599bbda029adf4698d11d7f981750dec07 Reviewed-on: https://gerrit.libreoffice.org/54802Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Samuel Thibault yazdı
Change-Id: I63d67709ab50e86b138fecd814b4dee7e2f2a755 Reviewed-on: https://gerrit.libreoffice.org/53925Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Thorsten Behrens <Thorsten.Behrens@CIB.de>
-
Keith Curtis yazdı
Git commit: ae37972c added some logic at the bottom to call Toolbox::SetItemImage to trigger the bitmap doubling code. This is no longer needed and is faster without. Change-Id: I0fb0538000d5616cb8d8a0ae35e15fb09cdf2c59 Reviewed-on: https://gerrit.libreoffice.org/54654Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Thorsten Behrens <Thorsten.Behrens@CIB.de>
-
Tamas Bunth yazdı
Change-Id: I6a1dcba0afda88eaf083f0d4c73c1e74b0c78f56 Reviewed-on: https://gerrit.libreoffice.org/54297Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Tamás Bunth <btomi96@gmail.com>
-
Mike Kaganski yazdı
Since commit db04be03, empty Database fields are hidden. But since Labels wizard generates a single paragraph with line breaks for the label's text, the hiding feature cannot be used efficiently. Let the individual lines be in individual paragraphs. Change-Id: I27430d54baea88461c2ea9de38baa95d6b7e9e62 Reviewed-on: https://gerrit.libreoffice.org/54800Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
Noel Grandin yazdı
if we're going to write "unhandled" messages, at least what is being unhandled Change-Id: I570183c92876d553f4344b979def653cbd5bb55d Reviewed-on: https://gerrit.libreoffice.org/54793Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Armin Le Grand yazdı
Change-Id: I837b20b3334dbb7f241af31c5fa5b702f1df8742
-
Noel Grandin yazdı
Change-Id: I00f336ee4eced431155c79bee6e2373e145ae95c Reviewed-on: https://gerrit.libreoffice.org/54780Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Armin Le Grand yazdı
Also simplify parent/child relationships, get rid of double data (SdrPage/Parent infos in SdrObjects, also in SdrObjList). This is all not needed - when a SdrObject is inserted to a SdrPage, get SdrPage by traveling over parents (no double info, member as soon as inserted, ...). More cleanups/reworks included, will need some more cleanups, too. Stabilizing: SetRectsDirty/DefaultStyleSheet Had to correct the SetRectsDirty stuff for 3D due to going down the hierarchy while the 2D implementation goes the other direction -> endless loops. Added special handling for 3D stuff for now (will be chnaged again when SnapRect is no longer needed at SdrObject level). Also had to adapt how the DefaultStyleSheet is set at incarnated SdrObjects - better: their properties. Since we now always have a SdrModel, it is possible to correctly initialize with the correct default StyleSheet from that SdrModel. This needs to be done after ForceDefaultAttributes and in a way that again deletes Items that are set in the StyleSheet. This leads to an error in CppunitTest_sd_import_tests where I checked tdf100491 - it is okay and thus I change the control instance of the imported, XML-dumped file. The less hard attributes, the better for Styles in general. Cleanup of comments for last two commits Corrected SvxShape::getParent() Needed to get the direct parent, so test for SdrObject first (to get SdrObjGroup/E3DScene), for SdrPage second Fixed CppunitTest_sc_subsequent_export_test Several problems arose. The used SdrCaptionObj was Cloned, but the clone not inserted to a SdrPage. This leads to not being able to access a UNO API imlementation of the SdrPage (SvxPage) on lower levels. It worked before due to SdrObject having a SdrPage* additionally to being added to a SdrPage - this is exactly the main cleanup this change does. Looked for why it is cloned, could see no reasons. The SdrCaptionObj exists during all im/export, not difference to other SdrObjects (that do not get cloned). It is not changed in any way. It *might* be to suppress a crash that happened due to UNO API Service emfio/emfio not being available in the UnitTest scenario. Interestingly it did not crash with the cloned SdrCaptionObj, but the Graphic exported was probably wrong. Fixed by no longer Cloning the SdrCaptionObj and adding emfio/emfio UNO API Service. d139f821a5b39535a3e7b9c6261df7e18f8ae8ac 910e7f4bc628a715fda7545dffaf3369d5e76ea0 ca1de01b723051e09ac37d7ec7bba978beea41c5 3a76da1471dfe75e69847f64a6a3519ad21c8c9c Change-Id: I986586e326b563acebf00d931a7084c6eb09e5f8 Reviewed-on: https://gerrit.libreoffice.org/54689Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Armin Le Grand <Armin.Le.Grand@cib.de>
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Simple removal proposals are dealt with here and a bit of fallout management Change-Id: Ia6f8d4ca46d7b218f5827052ced5641367bd4478 Reviewed-on: https://gerrit.libreoffice.org/54683Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk>
-
Tor Lillqvist yazdı
Change-Id: I53ef86a997f4ae1c0ad84bb381327cba3143dd4c
-
Olivier Hallot yazdı
Project: help 0affb71917d215b6d76eb5983a39c726fed53f29 Add GDPR in online help Change-Id: Ic752beee3901bd9963deb4782702a1de745b5406 Reviewed-on: https://gerrit.libreoffice.org/54785Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Olivier Hallot <olivier.hallot@libreoffice.org>
-
Tor Lillqvist yazdı
Change-Id: Ib22583a45c03a4b7c3b4ff73e9d28f47ab31bc4f
-
Tor Lillqvist yazdı
Our convention is to just have the name of the abstract base class in a comment before the declaration of the concrete overrides of its abstract member functions. No need to say "Abstract struct" there. Change-Id: I2b9bdf0555af5280771370a6df56fd4c8623661a
-
Justin Luth yazdı
This is specifically for the benefit of DOCX import, but it also makes sense in general. If a SwXCell is given char/para properties, then apply those properties (without overwriting) to the cell's contents. This allows ANY paragraph or character properties that are applied to a table style to become the "default" for the table. This fixes a number of things: -remove one-off hack to get PROP_PARA_LINE_SPACING to work. -works for all character and paragraph properties (except those shared with tables like borders). -works in multi-paragraph cells. Previously those could return AMBIGUOUS state, in which case the style wasn't applied at all. Change-Id: Ia98c129879575c1aa8ca1fe2a64f4991c0a264e8 Reviewed-on: https://gerrit.libreoffice.org/54511Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Justin Luth <justin_luth@sil.org> Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk>
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here A bit of fallout management was necessary as well find-unneeded-includes gave no proposals for chart2/inc Change-Id: Id382586f575cf45da758da453df9340b28e9ddd0 Reviewed-on: https://gerrit.libreoffice.org/54778Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk>
-
Miklos Vajna yazdı
This is really similar to commit 4c2172a3 (tdf#106702 PDF export: fix missing images from Writer headers/footers, 2018-05-22) just this one is about the size of the output rectangle for JPG content, while the previous problem was about the position of them. Also extract PdfExportTest::exportAndParse() from the last two tests to avoid duplication. Change-Id: I9812924d505e9fdaca2a95b4990e7aaa5e44fd7f Reviewed-on: https://gerrit.libreoffice.org/54773Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk>
-
Miklos Vajna yazdı
Change-Id: Id2b59887fcd69e294a6d9db17ec0446615054ecc Reviewed-on: https://gerrit.libreoffice.org/54779Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk>
-
László Németh yazdı
ie. ordinal, ordinalText and cardinalText DOCX numbering styles. DOCX export/import was added in commit 1501df41. Change-Id: Ica2d63aab3d7c89392e0c72210e6018c288aaec6 Reviewed-on: https://gerrit.libreoffice.org/54776Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
László Németh <nemeth@numbertext.org>
-
Tor Lillqvist yazdı
Change-Id: I7633648dc0398d2c1b6f04e6db9b18638a7451f5 Reviewed-on: https://gerrit.libreoffice.org/54781Reviewed-by:
Tor Lillqvist <tml@collabora.com> Tested-by:
Tor Lillqvist <tml@collabora.com>
-
Andrea Gelmini yazdı
Project: help e35e77e62e90d709633304a45bdc0d430595a01a Fix typos Change-Id: I50e06c9bc42c1e5529074e944b9f1ed37f0a7385 Reviewed-on: https://gerrit.libreoffice.org/54784Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Julien Nabet <serval2412@yahoo.fr>
-
Justin Luth yazdı
The other function, setPropertyValues already has this variable, so for consistency and flexibility, add it here as well. Plus, this is prep work for another patch. Change-Id: I16c5b1cbb9fd99a11be99a59005bd856d787a6ca Reviewed-on: https://gerrit.libreoffice.org/54510Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Justin Luth <justin_luth@sil.org>
-
- 24 May, 2018 16 kayıt (commit)
-
-
Eike Rathke yazdı
Change-Id: I56658a7f6eb277fabf8ff4782c86fabac5f14e81
-
Eike Rathke yazdı
Change-Id: I8d2c4bb95ae50e7d23a89db1dd6bb197d3af65c0
-
Stephan Bergmann yazdı
Its use has been removed with e161e35f "installer: Remove packager.pl" (and changes to the file itself also stopped in 2013). Change-Id: I3bf18849a80abd5b774f1a6030c514e5891e0350 Reviewed-on: https://gerrit.libreoffice.org/54769Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Noel Grandin yazdı
and the modeline should be on the last line Change-Id: I6032fdee6fc29d11cac1e4b8ec9c36e004258e73 Reviewed-on: https://gerrit.libreoffice.org/54752Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Michael Meeks yazdı
As agreed at the ESC - lets see how this goes for 6.1 This reverts commit 4696d372. Change-Id: Ic2be53c53dd7573972cd54c390443dc136739b6c Reviewed-on: https://gerrit.libreoffice.org/54774Reviewed-by:
Michael Meeks <michael.meeks@collabora.com> Tested-by:
Michael Meeks <michael.meeks@collabora.com>
-
Tor Lillqvist yazdı
Using the system ("native") menubar works fine since a long time surely. No reason to keep a fallback possibility. Change-Id: I0d9ed86c28b0d832c8123b18980740dbf895ec1c Reviewed-on: https://gerrit.libreoffice.org/54775Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Tor Lillqvist <tml@collabora.com>
-
Tor Lillqvist yazdı
Can happen at least when LibreOffice is started from the command line using the 'open' command line and passed a file name. Change-Id: I93145974a56e124550579cae8fd69ccb4a7d3bda Reviewed-on: https://gerrit.libreoffice.org/54758Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Tor Lillqvist <tml@collabora.com>
-
Christian Lohmaier yazdı
Change-Id: Id6f2b9036832e581aa6ccb45fd3f7a56191db980
-
Luboš Luňák yazdı
Change-Id: I53b7f514be2e015445eb9cb0471c22d41c464e4e Reviewed-on: https://gerrit.libreoffice.org/54767Reviewed-by:
Michael Meeks <michael.meeks@collabora.com> Tested-by:
Michael Meeks <michael.meeks@collabora.com>
-
Luboš Luňák yazdı
Since ScEditUtils::GetString() requires EditEngine, which is probably not completely thread-safe. Change-Id: Ie3d64f56b76a5861fa4b0a1f9cb683cd26806b35 Reviewed-on: https://gerrit.libreoffice.org/54766Reviewed-by:
Michael Meeks <michael.meeks@collabora.com> Tested-by:
Michael Meeks <michael.meeks@collabora.com>
-
Mark Hung yazdı
Also removes dead code because SwTabFramePainter::Insert() is always called with a cell frame and IsTabFrame() always returns false. Change-Id: I2505d876d20e44ded1faf760bc3b7b1d34b0fd8d Reviewed-on: https://gerrit.libreoffice.org/54684Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk>
-
Noel Grandin yazdı
mistake in commit commit f6063153db8951ca21ac3a2e36973f1d73eda4d1 tdf#117706 Multi-select copying rows between sheets broken noticed by erack Change-Id: Ia5ed3726c8f02750eec3551f7dd908120edb2553 Reviewed-on: https://gerrit.libreoffice.org/54765Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Caolán McNamara yazdı
a linear loop builds a recursive structure, if it gets too deep then later processing, e.g. releasing the tree, can exhaust stack Change-Id: I4421b9bae62ac2b6ffe32531d1167a482103bfde Reviewed-on: https://gerrit.libreoffice.org/54762Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
Tor Lillqvist yazdı
Also tdf#76476, and probably more. Make it so that when a window is in full-screen mode from LibreOffice's point of view, it is also full-screen from the system's point of view, and vice versa. All three ways to enter and leave full-screen mode can now be used with the same end result: The Ctrl-Cmd-F shortcut, the "View > Full Screen" menu entry, and the green bubble on the title bar. Don't disable/deactivate/etc menus while in full-screen mode. The menu auto-hides so there is no harm in having it function normally. Don't display the floating toolbar with a single "Full Screen" button in it as the way to leave full-screen mode. Instead, the same three ways that can be used to enter full-screen mode work to leave it, too. Sadly I could not figure out a way to set a window properly to full-screen at the point where a document window is created and set to be the same size as that kind of document window was the previous time it was open in LibreOffice. Thus don't save state for full-screen windows as we can't properly restore them. At least not for macOS. It is not good to just restore them as non-full-screened but still at the size they had when full-screen. One irritating glitch remains, and I was unable to fix that properly: I now prevent closing the document window that is in full-screen mode. Otherwise, if it is closed, the full-screen mode remains even if no window is open there; the desktop is completely black. Moving the cursor to the top edge, the LibreOffice menu is there, though. I tried to fix that but with no fully satisfying result. (Some attempts even lead to crashes, so just disabling closing is better than crashing at least.) Change-Id: Id909077ef9de9f19d48c8b9ad10d748a65b2417f Reviewed-on: https://gerrit.libreoffice.org/54760Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Tor Lillqvist <tml@collabora.com>
-
Olivier Hallot yazdı
Project: help 31d3025c0610319fd545b52f41211f86530eedec tdf#117752 HID for table background in Writer Change-Id: Iba29f40457261d833c01c53ca3d9f530887fb0b6 Reviewed-on: https://gerrit.libreoffice.org/54714Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Olivier Hallot <olivier.hallot@libreoffice.org>
-
Christian Lohmaier yazdı
Project: translations ed31445a5c607b49bf71cd37055578de6785cb85 update translations for master/6.1 beta1 Change-Id: Ib85491aac55698f0db45945f3fbaa332e8ec25dc
-