Change-Id: Ibab8db1c798312f34a5b8e0178b10c21299a5c7c

in some diagrams there are two shapes for the same node - tx and sp
sp should be just space, so remove text from it

Change-Id: I832651918294bd458148a23d6cc1e59c545adc13
Reviewed-on: https://gerrit.libreoffice.org/40913Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

In standard mode the text grids are rectangle and do not have
dedicated space for ruby text. The ruby text either overlap
with base text of the last line or clipped ( after scrolling ).
Move ruby text inside the grid in standard mode as if there
is no grid, and algin text to the center to keep the original
text-to-text alignment behavior.

Change-Id: Ia75ee016f9d492e4e73da6d7245aaeff40cbe1f3
Reviewed-on: https://gerrit.libreoffice.org/40632Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>

this was meant to go to a feature branch *sigh it must be Friday

this is largely based on jmux's work

Change-Id: I5897f3ecb90f83a29e0824bfe7a0ea875347e360

Currently only tests SUMIFS.

Yes, it would be nice if some of the already existing unit tests would
work for this need, too. But there are various reasons wny not. Also,
don't want to interfere in ongoing work by others.

Change-Id: Ie9008a4a1a8c26eff4f2ab0bc91294b2239f0ae1

New icons and updated links.txt.

Change-Id: Ibdc0ba550b07e88bfd7798da028cf59315295c89
Reviewed-on: https://gerrit.libreoffice.org/41024Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

Change-Id: Iec685588ef7a1d5284072ebc8fcadc07dae67364
Reviewed-on: https://gerrit.libreoffice.org/40999Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

OSL_ENSURE -> SAL_WARN_IF forgot to invert the condition in commit
6abe9cfa (refactor out to limit scope:
RES_PARATR_OUTLINELEVEL, 2016-03-11).

Change-Id: Ie0272e7e178e1065d4b619deafbb4e33fcd5d14d
Reviewed-on: https://gerrit.libreoffice.org/41018Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>

And the return in the default case, which could cause the UI element to
stop updating

Change-Id: I29d35818b015f71890f615a02ea215034c048326
Reviewed-on: https://gerrit.libreoffice.org/41020Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I2663f84c28721f61c1ed7c8d92a228cafa8f1177
Reviewed-on: https://gerrit.libreoffice.org/41036Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ief8bd59c903625ba65b75114b7b52c3b7ecbd331
Reviewed-on: https://gerrit.libreoffice.org/41019Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

couldn't even find a proper ctor beside copy-ctor

since commit e19c00ed
Date:   Wed Jul 13 13:30:48 2011 +0200
    callcatcher: remove unused TextAttrib stuff

Change-Id: Ia7f0bd1dcc725beb8cc53bb82372a4cce3ec68b0
Reviewed-on: https://gerrit.libreoffice.org/41012Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I434739024afa97d05b5cf6e959973d845fdb2dfe

Tolerated in EPUB3, and some readers not yet fully supporting EPUB3
(just EPUB2) actually need it.

Change-Id: I8b52d081a939c74052f3945cc21c834c2af8bb7d

Change-Id: Ie2e86852f7c4754070d3eb7e8981d674f04a6d80

Its last code pieces using it were dropped in 2011:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=a564531ea35bd859a74703a4330ba4149295d0cc

Change-Id: I9ad68a442b3e6c3b29002e677ec0e99edb181ffe
Reviewed-on: https://gerrit.libreoffice.org/40857Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

which is considerably less verbose

Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b
Reviewed-on: https://gerrit.libreoffice.org/40978Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9300b2ec1e1dcedbcbfe793e1450166af1bf1944
Reviewed-on: https://gerrit.libreoffice.org/40944Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ia36c8abe91e8c2ac46498e88def59a9887711ba1
Reviewed-on: https://gerrit.libreoffice.org/41014Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Id479c77335c7c4d8dd959a70ebc382a8448077e1
Reviewed-on: https://gerrit.libreoffice.org/41000Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

The loop in SwTextNode::Update() that reassigns bookmark end positions
away from the node to a temporary SwIndexReg can stop prematurely in a
particular situation where there is a bookmark that is expanded and with
both mark positions at the critical "rPos" insertion position, and also
both their SwIndexes consecutive in the SwIndexReg::m_pFirst
linked-list.

What happens then is that the iteration gets to the first of the 2
consecutive positions of the bookmark, then calls GetMarkEnd() on the
mark, which happens to return the other position, which is already
stored in the "next" local variable.

That other position is then moved to aTmpIdxReg, and in the next loop
iteration GetNext() is null as it is the last one in aTmpIdxReg and the
loop terminates.

Thus various bookmark end positions don't get preserved, or the
bAtLeastOneExpandedBookmarkAtInsertionPosition doesn't get set, either
of which can cause the bookmark array to lose its sort order.

This was found playing around with Zotero 4.0.29.10, while switching
between different citation styles.

(regression from 6a5dbe73)

Change-Id: Ia35ce0656bcb2d6af7ea189458af3942ff83e4da

Change-Id: I7c07750e131060fb8ba796e7dcdc5f5bafcb1d74
Reviewed-on: https://gerrit.libreoffice.org/40916Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>

* correct watermark position
* insert also on left and right pages if headers are different

Change-Id: Ibacfa6ea14bd8e9c1fd0d0b15de020b30d0a109f
Reviewed-on: https://gerrit.libreoffice.org/40891Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

Before writerperfect::exp::XMLImport grows into a God object. Also, if
I'm at it, recurse into text:h to include heading text.

Change-Id: Iede56d00dbede40186b6484d0be92a2ac2e4768e
Reviewed-on: https://gerrit.libreoffice.org/41005Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

SvxPostureItem& rWeight is confusing at best.

Change-Id: I70a7e94151f49bf3539af77160cd4a68b8753464
Reviewed-on: https://gerrit.libreoffice.org/41006Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I61323f36922842ddc45b2a63a9ba7334c847a8fd

Entity ref and decl was disabled since 2014, let's remove it now.

Change-Id: I35dac78b8530bab99e955bf68dfe3f8951a63f99
Reviewed-on: https://gerrit.libreoffice.org/40998Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I9cefadba78688aebbf93e63f0bf29dbe96839fea
Reviewed-on: https://gerrit.libreoffice.org/38408Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: I5f6753645452b578d30909614cb3cc36ae3d7e64
Reviewed-on: https://gerrit.libreoffice.org/40983Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I6047920ef5860f0f3535467d6af1d1bf0aa250af
Reviewed-on: https://gerrit.libreoffice.org/40988Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

EditView on Overlay visualization needs to handle
selection change when e.g. FontSize attribute of
a selected text portion changes. Changed handling
so that selection overlay is an integral part of
text visualization overlay and refreshing text
visualization always refreshes selection visuals,
but not the other way around. Both anyways check
for real change, so just extra testing is avoided
which is still the better solution

Change-Id: I3ce6570fd9a18a7c1d7ced4bc4ca9aeda57538e0
Reviewed-on: https://gerrit.libreoffice.org/40993Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

Change-Id: I9db61ed54b59b142d5198ec977044f7f52ba6b4d
Reviewed-on: https://gerrit.libreoffice.org/40981Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ic5e44527eb821b42b607cc805d6f2e6883a74755
Reviewed-on: https://gerrit.libreoffice.org/40982Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I0f05373d76435341ab2fbbf93840686a3f702308
Reviewed-on: https://gerrit.libreoffice.org/41004Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Clearing mItemList at the begin of insertItems is a bad idea
because it prevents ImplDeleteItems (called by updateItems,
itself called at the end of insertItems) from clearing
correctly mItemList
See comments from bugtracker for more info

(Thank you Alex for the precious info attached with memleak reports! :-))

Change-Id: I04976dbb065d1369562649fc97c33f7fd599b107
Reviewed-on: https://gerrit.libreoffice.org/40995Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I56e0fb1716d38471682084569d48907520922b26
Reviewed-on: https://gerrit.libreoffice.org/40991Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Prepare UpdateAutoFilterFromMenu to handle more entries.

Filter items can be hold by more than one entries. In that case we have
to remove all the old entries before updating.

E.g. setting AutoFilter from vba script results in more than one
entries.

Change-Id: I4f18f26281d0b8e689cd331f9a66f4c344fb6c6b
Reviewed-on: https://gerrit.libreoffice.org/40967Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

If AutoFilter created with vba macro, it should always use a header
(because Excel does the same), regardless of the type of cells in the
first row.

Change-Id: I586e092ac62c893b9873cc4b988566d8f00636cc
Reviewed-on: https://gerrit.libreoffice.org/40969Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

Change-Id: I3222033fadd688959fd55e3f335540054fc418f4
Reviewed-on: https://gerrit.libreoffice.org/40612Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>