and

coverity#1321597 Resource leak in object

Change-Id: I6e9e517a394bea60c1f0550b17bacd653eee5cbc

Change-Id: I5a2e61200333ca57af990d3d7be3899da836472a

Change-Id: I909c225dd9bd92763ae24b62854a9217fc2e2a0e

Adapt to 1ba1a21a (tdf#73071 Enable
styles content panel in calc and fix spacing issue), but the second
assert should be ideally 100 and not 99 what it is actually, so comment
that out for now.

Change-Id: I551640c9db57285942a897eeb57515939ed3510d

Project: dictionaries  03a4a7b13f28c2c8df08cf6d5049fde97d6b4244

tdf#93514 remove Czech thesaurus

Change-Id: I40ebd1ca223fe7950ed3280c43a51a3dfbd0070e

Change-Id: Idb24848ecd15d3970cdec3e080eb0f8ead0358ed

Change-Id: Idaf322c53cb8955bb88e18a6d79fd800dc48621d

with the variadic variants.

Change-Id: I663029b736489b81ed4ccb5f7bd657fbaf091bdf
Reviewed-on: https://gerrit.libreoffice.org/18206Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Regression from http://cgit.freedesktop.org/libreoffice/core/commit/?id=5d8ecad569fd7a254902da154ed8057ec61f3a83
Thank you Matthew Francis for having found the root cause!

Change-Id: I4128368a5f5df6a9fc5f7668fb1f8f330b5795b9
Reviewed-on: https://gerrit.libreoffice.org/18210Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

9a6cdce3 was trying to fix the problem
with exposing deprecated vars and functions in system's error_code.hpp
include file by patching bundled boost version.  This approach would
only make sense, when upstream version is going to be fixed ASAP. Apply
another approach, and follow the same pattern as applied in external
libraries, by defining

  -DBOOST_ERROR_CODE_HEADER_ONLY \
  -DBOOST_SYSTEM_NO_DEPRECATED

instead of patching bundled boost version.  This way, the code would
work with unpatched system boost 1.59 final as well.

Change-Id: I8684ca458ea4a5b7d7c3c3acfe7c14a6d19bc665
Reviewed-on: https://gerrit.libreoffice.org/18201Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Tested-by: David Ostrovsky <david@ostrovsky.org>

...as happens in CppunitTest_sw_filters_test with
sw/qa/core/data/ww8/pass/CVE-2015-2467-1.doc, first at:

> filter/source/msfilter/msdffimp.cxx:1477:17: runtime error: load of value 8193, which is not a valid value for type 'MSO_Anchor'
>  DffPropertyReader::ApplyCustomShapeTextAttributes(SfxItemSet&) const filter/source/msfilter/msdffimp.cxx:1477:17
>  DffPropertyReader::ApplyAttributes(SvStream&, SfxItemSet&, DffObjData&) const filter/source/msfilter/msdffimp.cxx:2694:9
>  SvxMSDffManager::ImportShape(DffRecordHeader const&, SvStream&, void*, Rectangle&, Rectangle const&, int, int*) filter/source/msfilter/msdffimp.cxx:4332:21
>  SvxMSDffManager::ImportGroup(DffRecordHeader const&, SvStream&, void*, Rectangle&, Rectangle const&, int, int*) filter/source/msfilter/msdffimp.cxx:4119:39
>  SvxMSDffManager::ImportGroup(DffRecordHeader const&, SvStream&, void*, Rectangle&, Rectangle const&, int, int*) filter/source/msfilter/msdffimp.cxx:4106:39
>  SvxMSDffManager::ImportGroup(DffRecordHeader const&, SvStream&, void*, Rectangle&, Rectangle const&, int, int*) filter/source/msfilter/msdffimp.cxx:4106:39
>  SvxMSDffManager::ImportGroup(DffRecordHeader const&, SvStream&, void*, Rectangle&, Rectangle const&, int, int*) filter/source/msfilter/msdffimp.cxx:4106:39
>  SvxMSDffManager::ImportObj(SvStream&, void*, Rectangle&, Rectangle const&, int, int*) filter/source/msfilter/msdffimp.cxx:4033:16
>  SvxMSDffManager::GetShape(unsigned long, SdrObject*&, SvxMSDffImportData&) filter/source/msfilter/msdffimp.cxx:6210:23
>  SwWW8ImplReader::Read_GrafLayer(long) sw/source/filter/ww8/ww8graf.cxx:2502:17
>  SwWW8ImplReader::ReadChar(long, long) sw/source/filter/ww8/ww8par.cxx:3634:17
>  SwWW8ImplReader::ReadChars(int&, int, long, long) sw/source/filter/ww8/ww8par.cxx:3436:27
>  SwWW8ImplReader::ReadText(int, int, ManTypes) sw/source/filter/ww8/ww8par.cxx:3974:22
>  SwWW8ImplReader::CoreLoad(WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:5175:9
>  SwWW8ImplReader::LoadThroughDecryption(WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:5773:19
>  SwWW8ImplReader::LoadDoc(WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:6045:19
>  WW8Reader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) sw/source/filter/ww8/ww8par.cxx:6167:20
>  SwReader::Read(Reader const&) sw/source/filter/basflt/shellio.cxx:175:18
>  SwDocShell::ConvertFrom(SfxMedium&) sw/source/uibase/app/docsh.cxx:258:22
>  SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:790:23
>  SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20

Change-Id: Iafc548b5ba21a985521790770732f7f03e2485c9

This reverts commit 6fd71992. Kendy says the
original problem can't be reproduced anymore, and most unexpected flickering
goes away with this for my nvidia card.

Also, it's a good idea in general to keep PFD_DOUBLEBUFFER and
WGL_DOUBLE_BUFFER_ARB in sync, which is now the case.

Change-Id: I7a809d1c85be4206c01720d5de9b0a5617a59c87

...as happens in CppunitTest_sw_filters_test with
sw/qa/core/data/ww8/pass/CVE-2015-2431-1.doc:

> sw/source/filter/ww8/ww8par4.cxx:294:76: runtime error: reference binding to null pointer of type 'const SfxItemSet'
>  SwWW8ImplReader::ImportOle(Graphic const*, SfxItemSet const*, SfxItemSet const*, Rectangle const&) sw/source/filter/ww8/ww8par4.cxx:294:23
>  SwWW8ImplReader::ReadChar(long, long) sw/source/filter/ww8/ww8par.cxx:3611:35
>  SwWW8ImplReader::ReadChars(int&, int, long, long) sw/source/filter/ww8/ww8par.cxx:3436:27
>  SwWW8ImplReader::ReadText(int, int, ManTypes) sw/source/filter/ww8/ww8par.cxx:3974:22
>  SwWW8ImplReader::CoreLoad(WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:5175:9
>  SwWW8ImplReader::LoadThroughDecryption(WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:5773:19
>  SwWW8ImplReader::LoadDoc(WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:6045:19
>  WW8Reader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) sw/source/filter/ww8/ww8par.cxx:6167:20
>  SwReader::Read(Reader const&) sw/source/filter/basflt/shellio.cxx:175:18
>  SwDocShell::ConvertFrom(SfxMedium&) sw/source/uibase/app/docsh.cxx:258:22
>  SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:790:23
>  SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20

Change-Id: I4482bc5d8e0c2646e7c8667a231a78311b557e89

Change-Id: If882d49c3abe236c8ca5af502a38947b98e34d5e

SubdivideBezier creates polygons which are more exact for drawing
in opengl when drawing hairline PolyLines - so let's use that with
AA line drawing.

Change-Id: I490fd0f19361b5fc9e1f4e03851c1ae1a1f75f71

Change-Id: Idf8c958161a92ba73dfb60da9a10ab9d59be7c2d

... during token string creation, as an empty column specifier is the
last thing we want to see.. which still can happen though if the stored
name was synced with the existing cell data and copying the older
original name was not possible, for example due to name clashes.

Change-Id: I6a0d313a02efafc092f0bbf7725fb3b3e77e486f

Change-Id: I7fc96e3b7754bb3f4718f9142c75ee82aef0a22c

Change-Id: I744ff8be96bda2fff61c8fc23a067fdd9b2d4930

Change-Id: Ieab07fcd9bc89d81829d636bb854db37ad2ba9e0

Change-Id: I9ad88c0f7f935a247f0f21c7aa206312435ecafc

Change-Id: I7321d35bcc1f287ef85331ed8c8e43bdf846c1ce

... to match reality and be able to re-load structured references in
range names once we save TableRefs as well.

Change-Id: I5f8fc858be2a773d7841816c3e4bf21590d37e64

Change-Id: Iee85958a6589624bc9a61242fca41214bdd1df85

CppunitTest_libreofficekit_tiledrendering hangs because the soffice_main
exits due to the unrecognized command line arg --target.

Use a -env:VARIABLE argument instead, which is filtered out by
rtl_getAppCommandArg() so does not reach the soffice_main code.

(regression from 87514b09)

Change-Id: I2c801305398dccfb447e4e5c44726f42bf2a72ef

This reverts commit 93cd7b78.

We need to generate project files for unnamed projects as they seem to
correspond to libraries. If that causes problems for the msvc
integration (which seems strange) then we need to handle these problems
in the MSVC generator and not in the parser.

It also includes:

Revert "Clean trailing whitespace"

This reverts commit 7d92b27a.

Change-Id: Idfc691a92d0cba72289699609cb99bce35aaade9

Change-Id: Icaa5fb197f3fa234da4538a2a7b21131cab89277

Also start gl tests in vcldemo:
    $ SAL_FORCEGL=1 vcldemo --gltests

Change-Id: I8f0022770d57cd60c830659e3f7fcc0721320a10
Reviewed-on: https://gerrit.libreoffice.org/18132Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I43f5d8ef5ca7c5fbd598d866622e6cbb1159f2a0
Reviewed-on: https://gerrit.libreoffice.org/18176Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Maxim Monastirsky <momonasmon@gmail.com>

Change-Id: I31f7ac6783ab9bb32f2423cc7f80d5ddcf827ba9

Change-Id: I81aec0e6f8db57905826c54c3442528be6068700

Change-Id: I52158729d240ca3cb9e7977bc6d1f5acb14437ad

When an array of EMF+ has extra bytes in the end, that are less than 12,
they should not be  treated as another EMF+ record, but simply ignored.

Change-Id: I34701c00916812c8a6a4b69730f602da81719b35
Reviewed-on: https://gerrit.libreoffice.org/18110Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: I8f84bb5f4a988b5fb2b688e3c5be321c39818259

... actually we're already able to import that. Needs more work for the
filter settings export if applied.

Change-Id: I4fc596f6a69c7729fc6ca488e5f596fdbe9a79b8

Change-Id: I535f2dc600f3b4fdac2c7fa817eb8430848bbae6

Change-Id: I9102e23e347226ac82d2e806a293bfaf2727f194

...as happens in CppunitTest_sd_filters_test with
sd/qa/unit/data/ppt/pass/hang-16.ppt:

> sd/source/core/sdpage.cxx:1101:57: runtime error: division by zero
>  SdPage::GetTitleRect() const sd/source/core/sdpage.cxx:1101:57
>  CalcAutoLayoutRectangles(SdPage&, Rectangle*, rtl::OUString const&) sd/source/core/sdpage.cxx:1323:26
>  SdPage::SetAutoLayout(AutoLayout, bool, bool) sd/source/core/sdpage.cxx:1595:5
>  ImplSdPPTImport::Import() sd/source/filter/ppt/pptin.cxx:1025:21
>  SdPPTImport::Import() sd/source/filter/ppt/pptin.cxx:161:12
>  ImportPPT sd/source/filter/ppt/pptin.cxx:2744:17
>  SdPPTFilter::Import() sd/source/filter/sdpptwrp.cxx:108:32
>  sd::DrawDocShell::ConvertFrom(SfxMedium&) sd/source/ui/docshell/docshel4.cxx:453:16
>  SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:790:23
>  SdFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) sd/qa/unit/filters-test.cxx:75:20

Change-Id: Ic6a339c0315e9bc3f28de8c26c3d9f2767c3509d

Change-Id: Ic1083fdb566de0b5487b92197f33070ef42146f7