Kayıtlar (commit) · 5923df69b46295c5686e5c91ea2a8fc7b46d8357 · LibreOffice / core

22 Şub, 2019 4 kayıt (commit)

loplugin:unusedfields in writerfilter · 5923df69

Noel Grandin Şub 21, 2019 yazdı

Change-Id: Icce42e5db6d8ac51bf8b7d40cb497c6c365099d2
Reviewed-on: https://gerrit.libreoffice.org/68152
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

5923df69

uitest for bug tdf#123508 · 3114e187

Zdeněk Crhonek Şub 21, 2019 yazdı

Change-Id: Iab59789ce57295d204ad475cd5405bcdd1f5b9ef
Reviewed-on: https://gerrit.libreoffice.org/68164
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

3114e187

Update git submodules · b1ede813

Andrea Gelmini Şub 21, 2019 yazdı

* Update helpcontent2 from branch 'master'
  - Fix typo
    
    Change-Id: I3946d4ed9f9c38d0d30f89427b44bb6696b85f8a
    Reviewed-on: https://gerrit.libreoffice.org/68182
    Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

b1ede813

Sifr icon theme update · f90e2a32

andreas kainz Şub 21, 2019 yazdı

Change-Id: I8855806918cc3ab55212364b783b65f3ae466a3a
Reviewed-on: https://gerrit.libreoffice.org/68184
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

f90e2a32

21 Şub, 2019 30 kayıt (commit)

Revert "Simplify: getToken+comparison ==> startsWith" · a9de98d3

Matteo Casalin Şub 21, 2019 yazdı

Not equivalent to original code, may cause problems in the future.

This reverts commit 4d341228.

Change-Id: Ie91e43496c3ff67d31a0fc363638dde41fffa550
Reviewed-on: https://gerrit.libreoffice.org/68175
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

a9de98d3

'--enable-kde5' for Jenkins CI builds · 7d2afd1c

Michael Weghorn Şub 21, 2019 yazdı

As discussed in ESC call of 2019-02-21, enable kde5
for the Jenkins CI builds to detect build issues *before*
the changes get merged.

Change-Id: I44b0e611348a22b390b6ec89d3ed1d7eb7bddd63
Reviewed-on: https://gerrit.libreoffice.org/68165
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

7d2afd1c

wrong "to-page" reported in split notebooks · 35701e73

Caolán McNamara Şub 21, 2019 yazdı

and when switching decks we need that notification to occur too

Change-Id: Ica3c83ad34e072faf044c6d4667f34756688de09
Reviewed-on: https://gerrit.libreoffice.org/68171
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

35701e73

menu of currency combobox in format-cells is too narrow · 7bc3ac14

Caolán McNamara Şub 21, 2019 yazdı

we want the combobox to be narrower than it wants to be.  To make that happen
we have only the option of shrinking the cell renderer of the combobox area.
And that is also used by the menu.

Setting a small value of e.g. 1 works to let the combobox not request more
width than that, and the combobox will correctly render within the wider size
it actually gets. But then the menu is a min width menu, which is undesirable,
we want the menu to be as wide as it can be.

So calculate what part of the combobox belongs to the cell area and set
the widest cell area we can within the overall combobox width, resulting
in the widest menu we can get.

Change-Id: Ie3e9960a320a70471ac21d2a88f32632cafa951f
Reviewed-on: https://gerrit.libreoffice.org/68167
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

7bc3ac14

missing standard border-width · e0a8803f

Caolán McNamara Şub 21, 2019 yazdı

Change-Id: I4aa1fd132e3d6e153bdc03a51bf81469301eb1fb
Reviewed-on: https://gerrit.libreoffice.org/68169
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

e0a8803f

tdf#123534 Impress collapse/expand animation maintains selection · d3fdd9f1

Brian Fraser Şub 18, 2019 yazdı

- Expandened a selected bulleted list's animations now
  selects children (maintaining the selection behaviour).
- Collapsing a bulleted list's animation no longer
  clears the current selections
- Deselecting animations now refreshed the UI correctly

Change-Id: I3a3ca0eb0efe841784d96d5dc8e1b760dea4f777
Reviewed-on: https://gerrit.libreoffice.org/67947
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

d3fdd9f1

xmloff: create XMLImpressContentExportOasis instances with an uno constructor · 50a73ae6

Miklos Vajna Şub 21, 2019 yazdı

Change-Id: I75301ca29794dd42a966faa36add3078c8c55211
Reviewed-on: https://gerrit.libreoffice.org/68166Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

50a73ae6

weld RecoveryDialog · a9eb7df6

Caolán McNamara Şub 21, 2019 yazdı

Change-Id: Iaa755aca2468a23465a3ab8d8115ee19e3b05f6d
Reviewed-on: https://gerrit.libreoffice.org/68155
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

a9eb7df6

Update git submodules · 47e03f30

Alain Romedenne Şub 20, 2019 yazdı

* Update helpcontent2 from branch 'master'
  - Python: Help pages on opening dialogs
    
    Change-Id: Ib71ad229ff908c1bb7c426f2242729d53cb01ff8
    Reviewed-on: https://gerrit.libreoffice.org/68100
    Tested-by: Jenkins
Reviewed-by: LibreOﬃciant <OpenOfficiant@sfr.fr>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

47e03f30

uitest Chart Area dialog · a1866fe5

Zdeněk Crhonek Şub 20, 2019 yazdı

Change-Id: I192020fefbe42db1040b92c95b49d00b81f44bc5
Reviewed-on: https://gerrit.libreoffice.org/68107
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

a1866fe5

Set maLayoutSize also for non-RES_FLYFRMFMT, like RES_DRAWFRMFMT · b0a421d6

Stephan Bergmann Şub 21, 2019 yazdı

Running CppunitTest_sw_ww8export2's testTdf111480 under Clang's
-fsanitize=implicit-signed-integer-truncation fails in
SwWW8WrGrf::WritePICFHeader (sw/source/filter/ww8/wrtww8gr.cxx) when the passed-
in nHeight, where both nWidth and nHeight are zero, is reduced to below zero
when subtracting nThick for the borders.  In turn, nWidth and nHeight being zero
is caused by SwWW8WrGrf::Insert (sw/source/filter/ww8/wrtww8gr.cxx) calling
rFly.GetLayoutSize(), and that ww8::Frame::maLayoutSize being left initialized
to zero in the

  Frame::Frame(const SwFrameFormat &rFormat, const SwPosition &rPos)

ctor (sw/source/filter/ww8/writerhelper.cxx) unless it is a RES_FLYFRMFMT (while
in this scenario it is a RES_DRAWFRMFMT).

The additional maLayoutSize, and SwWW8WrGrf::Insert calling GetLayoutSize()
instead of GetSize(), were added with CWS ww8export01_SRC680 commits in 2007
(e.g., a79a54b2 "INTEGRATION: CWS
ww8export01_SRC680"), to fix <https://bz.apache.org/ooo/show_bug.cgi?id=43447>
"export to .doc of images with captions if image had been resized".  It looks
like those commits didn't take into account that GetLayoutSize() could also be
called for non-RES_FLYFRMFMT while it would erroneously be left initialized to
zero for those.

Change-Id: I7455ab43268d132dc23958185a48a1e73214c7ca
Reviewed-on: https://gerrit.libreoffice.org/68151
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

b0a421d6

Fix code formatting, typos and grammar in comments, follow-up of · 1f0206d9

Andras Timar Şub 21, 2019 yazdı

Change-Id: Ia5fa581936e33be1d163dca349ddbe006a79d5db
Reviewed-on: https://gerrit.libreoffice.org/68145Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins

1f0206d9

Make sure that mark does not exceed the length of the text · a1deb4f6

Mike Kaganski Şub 21, 2019 yazdı

Change-Id: I685d3ac7f7038ef91463b2a0f012e23f0d6a422e
Reviewed-on: https://gerrit.libreoffice.org/68147
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

a1deb4f6

Update git submodules · 9cc4302f

Adolfo Jayme Barrientos Şub 21, 2019 yazdı

* Update helpcontent2 from branch 'master'
  - More CSS tweaks…
    
    • Ever-so-slightly brightened link color
    • Made most tables centered; I think they look much better
    • Removed some pointless spacing
    • Made all dropdown options consistently align to the left
    • Finally found out why pagination had extra 40px to its left
      and it’s a shame the normalizer doesn’t account for it
    • Correctly made disabled pagination links unsensitive
    • Gave styling to the search bar for consistent appearance
      in Gecko- and Blink-based browsers
    
    Change-Id: Idcb488160aa97ec0c4adb5202aed7f194dfac7c9

9cc4302f

sw: fix warning in SwTextShell::GetState() · 6415b0c4

Miklos Vajna Şub 20, 2019 yazdı

warn:sw.core:31398:31398:sw/source/core/bastyp/index.cxx:322: SwIndex::operator--() wraps around

Change-Id: I5c37a6b5e1fe24bc3b6b84e762bad6577583f3d8
Reviewed-on: https://gerrit.libreoffice.org/68127
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

6415b0c4

weld HangulHanjaConversionDialog · b1f4bc27

Caolán McNamara Şub 19, 2019 yazdı

Change-Id: Ia41f1a03581a0a48d59706ac5b3c569fc39c7f4d
Reviewed-on: https://gerrit.libreoffice.org/68099
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

b1f4bc27

Update the reference rdbs to libreoffice-6.2.0.3 · 3d31e57f

Stephan Bergmann Şub 21, 2019 yazdı

LD_LIBRARY_PATH=.../master/instdir/program \
 .../master/workdir/LinkTarget/Executable/unoidl-read --published \
 .../libreoffice-6.2.0.3/instdir/program/types.rdb \
 >.../master/udkapi/type_reference/udkapi.idl

* no changes

LD_LIBRARY_PATH=.../master/instdir/program \
 .../master/workdir/LinkTarget/Executable/unoidl-read --published \
 .../libreoffice-6.2.0.3/instdir/program/types.rdb \
 .../libreoffice-6.2.0.3/instdir/program/types/offapi.rdb \
 >.../master/offapi/type_reference/offapi.idl

Change-Id: I16c8cc9edafa81570f43197a1f1e78ff1eaee1ee
Reviewed-on: https://gerrit.libreoffice.org/68141
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

3d31e57f

Update git submodules · 07568f4d

LibreOﬃciant Şub 21, 2019 yazdı

* Update helpcontent2 from branch 'master'
  - Copying/Pasting sample code results in compiler error.
    Embed tags in place of link within relatedtopics
    
    Change-Id: I05d899e77a51c15d69e066bc94bd5bbb9ed69c8f
    Reviewed-on: https://gerrit.libreoffice.org/68142
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

07568f4d

loplugin:unusedfields in xmlhelp,xmlsecurity · 6ed5464a

Noel Grandin Şub 21, 2019 yazdı

Change-Id: Id3858365a54e6ae96bf9e6c3e27a777441ab56ae
Reviewed-on: https://gerrit.libreoffice.org/68133
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

6ed5464a

loplugin:unusedfields improve write-only when dealing with operators · 5febdea1

Noel Grandin Şub 20, 2019 yazdı

Change-Id: I3a060d94de7c3d77a54e7f7f87bef88458ab5161
Reviewed-on: https://gerrit.libreoffice.org/68132
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

5febdea1

tdf#42949 Fix IWYU warnings in sc/source/ui/[a-c]* · e5c3d5f3

Gabor Kelemen Şub 18, 2019 yazdı

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I5e810ed15cc33900d106b64353584d21f081517f
Reviewed-on: https://gerrit.libreoffice.org/67992
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

e5c3d5f3

tdf#123090 unit test for handling gridSpan · 00e89430

Gülşah Köse Şub 20, 2019 yazdı

Change-Id: Id2782a16d6118676b0638727b368e4628335e055
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/68128
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

00e89430

tdf#123434 FILEOPEN: RTF: missing content in cells · 4d32ad37

László Németh Şub 20, 2019 yazdı

Revert "tdf#122424 RTF import: ignore table row text outside the cells"

This reverts commit dc8fa612.

Change-Id: Id68dc7ae55df013de64fb2d4955a412e4c046781
Reviewed-on: https://gerrit.libreoffice.org/68086Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>

4d32ad37

recovery dialogs legitimately don't have parents · 30e7c7f2

Caolán McNamara Şub 20, 2019 yazdı

Change-Id: I853a4471723c39bbdb8cf71409f518640b54cb83
Reviewed-on: https://gerrit.libreoffice.org/68110
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

30e7c7f2

sifr icon theme update and writer tabbed compact toolbar update · d0cc649b

andreas kainz Şub 21, 2019 yazdı

Change-Id: I031f7ce7e63c9bf7ebda55c2742004f642ba8e5a
Reviewed-on: https://gerrit.libreoffice.org/68129
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

d0cc649b

Don't use the non-public fdatasync() API when sandboxed on macOS · 47c49841
Tor Lillqvist Şub 21, 2019 yazdı
```
Change-Id: I9e36cb78e3e945f6531a31e0ddf73d9c8d655f7d
```
47c49841

loplugin:indentation (macOS) · 6333dcf6

Stephan Bergmann Şub 20, 2019 yazdı

* Some .m/.mm files that still contained tabs instead of spaces have been
  cleaned up with Emacs' untabify (and
  apple_remote/source/HIDRemoteControlDevice.m needed further manual adaptions):

  apple_remote/source/GlobalKeyboardDevice.m
  apple_remote/source/HIDRemoteControlDevice.m
  apple_remote/source/KeyspanFrontRowControl.m
  apple_remote/source/RemoteControl.m
  vcl/osx/a11yrolehelper.mm

* Some of the changes predate 0626e66d "Avoid
  loplugin:indentation after preproc conditional inclusion lines" and would
  likely have no longer been flagged since.

Change-Id: Ibf5faffa743c7f79b36109d9879eb79d63c8c40f
Reviewed-on: https://gerrit.libreoffice.org/68090
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

6333dcf6

CppunitTest_filter_textfilterdetect: use CPPUNIT_TEST_FIXTURE() · 07f24df0

Miklos Vajna Şub 20, 2019 yazdı

Change-Id: I0af7233d13223c4d1114d4f92a24e381ef81b5d5
Reviewed-on: https://gerrit.libreoffice.org/68126
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

07f24df0

tdf#123090 Handle removed column with gridSpan. · 48ef20f2

Gülşah Köse Şub 20, 2019 yazdı

Change-Id: If477845972ce4c8e7bf09ea8718c58851a5b9740
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/68102
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

48ef20f2

Fix typo · ffc59a0c

Andrea Gelmini Şub 11, 2019 yazdı

Change-Id: Ibd7c52137674eb07c35c951260a8102d06a436cc
Reviewed-on: https://gerrit.libreoffice.org/68130
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

ffc59a0c

20 Şub, 2019 6 kayıt (commit)

createInstanceWithContextAndArguments->createInstanceWithArgumentsAndContext · dbd3be90

Caolán McNamara Şub 20, 2019 yazdı

Change-Id: Ie22398eb42f61e50177f88672a1407d9dda58f8a
Reviewed-on: https://gerrit.libreoffice.org/68106Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

dbd3be90

weld SaveDialog · 45980b72

Caolán McNamara Eyl 30, 2018 yazdı

Change-Id: Iaef35328c0657a4538d4b4a44734146baee0346b
Reviewed-on: https://gerrit.libreoffice.org/61153
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

45980b72

weld SaveProgressDialog · e3294b1b

Caolán McNamara Şub 20, 2019 yazdı

Change-Id: Iad1786962dedb6cae0cf8720022498bfd793feb1
Reviewed-on: https://gerrit.libreoffice.org/68105
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

e3294b1b

get better optimal size for a radiobutton with an image in it · b3452d3d

Caolán McNamara Şub 20, 2019 yazdı

(not an image used as the indicator, which is already covered,
but if an image follows the indicator

Change-Id: I9e3f9c466d997f91f54912660f8c54eea6deb721
Reviewed-on: https://gerrit.libreoffice.org/68097Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

b3452d3d

extract empty test as method · 0f3b53a1

Caolán McNamara Şub 20, 2019 yazdı

Change-Id: If383e2f1542ffb57415f8138077013dbafa0fc69
Reviewed-on: https://gerrit.libreoffice.org/68095
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

0f3b53a1

drop unused argument · 6bcb9e1c

Caolán McNamara Şub 20, 2019 yazdı

Change-Id: I5d229a0afb822c9e7b81d3d8f27962c52d27d815
Reviewed-on: https://gerrit.libreoffice.org/68094
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

6bcb9e1c