macosx_getLocale (via getProcessLocale, both sal/osl/unx/osxlocale.cxx) obtains
from the system a locale string like "en-DE".  (Whether that is even a sane and
recommended way to obtain the system locale on macOS I don't know; but lets
leave it at that for now.)

However, setting a locale env var (LANG, LC_ALL) to such a value causes a
constructor call std::locale("") to throw a std::runtime_error
"collate_byname<char>::collate_byname failed to construct for ", at least on
macOS 10.14.4.  And libdivvun (which might be bundled with a LO extension) is
known to be hit by that, see <https://github.com/divvun/libdivvun/issues/28>
"locale("") gives 'collate_byname<char>::collate_byname failed to construct
for ' on LO on mac".

The code setting LC_ALL/LC_CTYPE/LANG was there ever since
8737d183 "INTEGRATION:
CWS geordi2q14: #111934#: merge CWS ooo111fix2", but for unclear reasons.  Lets
assume that it had no purpose (any longer).

Change-Id: I0b519ad567a713d61f662aa984791db1a91c708c
Reviewed-on: https://gerrit.libreoffice.org/70918
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I0938894681e73aaadf8bd353185dc4c6a125e0e2
Reviewed-on: https://gerrit.libreoffice.org/70920
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: If6a50542e8e2c4899b1d89ba6456e0f39b4cf39a

Same thing as in commit e5efd197

Change-Id: I84faa989387cefef18aa25fa813890d04858f7f2
Reviewed-on: https://gerrit.libreoffice.org/68987
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ia778edadc6ca4cf56868e250f0c29efeeef3ca9f
Reviewed-on: https://gerrit.libreoffice.org/70909Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Id0222c9f6a7ef04ed46dc5ceacd814619b4d7c21
Reviewed-on: https://gerrit.libreoffice.org/70912Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I4166a7aa9067907e563a98d76bd7f21c63370ce4
Reviewed-on: https://gerrit.libreoffice.org/70910
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: If0104ebab265a98982808fa5003a499deae542b6
Reviewed-on: https://gerrit.libreoffice.org/70908
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ia0c79c2455a3b40384332c8c35215671e257a07f
Reviewed-on: https://gerrit.libreoffice.org/70847
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I1021d7cfc2b27924e3a30d0f0d6a936e2bec99f9
Reviewed-on: https://gerrit.libreoffice.org/70907
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ief0343a128ae45ee62f7965a6ea77b2dcbd0ae49
Reviewed-on: https://gerrit.libreoffice.org/70911
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

... to guarantee that e.g. getXPath will always fail for non-empty
non-existing attribute

Change-Id: I22cf932eda020abf16608341fcd1769b35478883
Reviewed-on: https://gerrit.libreoffice.org/70891
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I169612264ef713027b38d1218ba71c86732da7f5
Reviewed-on: https://gerrit.libreoffice.org/70900
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

since
    commit 7282014e
    Date:   Fri Feb 1 15:15:16 2019 +0100
    tdf#50916 Makes numbers of columns dynamic

Change-Id: I858e61b3a1158bf47b5855e56d63c77cc87aa09b
Reviewed-on: https://gerrit.libreoffice.org/70902
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

since
    commit 7282014e
    Date:   Fri Feb 1 15:15:16 2019 +0100
    tdf#50916 Makes numbers of columns dynamic

Change-Id: Ib8dc06b80beed81a2543f343483599c425e87369
Reviewed-on: https://gerrit.libreoffice.org/70901
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...if there is no selection found

Change-Id: Ie4857e8d1bb98e41565aef47d3a794dcbe9bbd66
Reviewed-on: https://gerrit.libreoffice.org/70645
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

Move SetSearchLabel definition to srchdlg.cxx
Set control foreground to red on failed search and reset on text input
modification.
For the find & replace dialog, use set_entry_error for the same.
Reset "not found" search label on modification of search term.

Change-Id: Ia89d2e8d3ca35e2c184d5b7048af8267b57f2c17
Reviewed-on: https://gerrit.libreoffice.org/70662
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

Handle %7c with small letters.
Make sure that the output parameter's content is not
affected by decoding.

Change-Id: Ie3faad2461815497c0edfb04a589fc57aeb7d66b
Reviewed-on: https://gerrit.libreoffice.org/70873
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

* Update helpcontent2 from branch 'master'
  - Fix PRODUCTNAME
    
    Change-Id: I11a5ac0e5c1a33eb6f28c32024dab0fceec91e14
    Reviewed-on: https://gerrit.libreoffice.org/70888
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: I71f479c00e47c277fe08329b4abd20dba8d68224
Reviewed-on: https://gerrit.libreoffice.org/70840
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: I83b3559e9ba434bf32bd21608a591bd346779a33
Reviewed-on: https://gerrit.libreoffice.org/70882
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I68811d64ed340f3b5f86d7c13289455009eea74e
Reviewed-on: https://gerrit.libreoffice.org/70890
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I6a428b6515bffb69b6890ddcf8990c2c773b506c
Reviewed-on: https://gerrit.libreoffice.org/70889Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I74b1569fe378f42c1cc78ca8d9b758c6e585c979
Reviewed-on: https://gerrit.libreoffice.org/70845
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...to find more bugs like the one addressed in
6340daac "Revert broken
loplugin:sequentialassign change".  What it does is:  "Warn when a variable is
referenced from its own initializer.  This is not invalid in general (see C++17
[basic.life]), but is at least suspicious."  It found one false positive
(addressed with 884ad0d1 "Split
localProcessFactory function into class with setter and getter") and five true
positives (addressed with e0ccbe72 "Fix use of
variable before its lifetime begins" and
0e335af4 "Fix uses of variables before their
lifetimes begin").

Change-Id: I4c45cceaa042e93b37ad24a54784c027f6ca1f87
Reviewed-on: https://gerrit.libreoffice.org/70897
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

The second case is very likely mistaken though.

Change-Id: I6bfc55800a6b26ce0ae6d3645e4179dc5f683205

..."Revert broken loplugin:sequentialassign change"

Change-Id: Icb6f27be6bab35db02fc67ce5478e47bb8faa68b
Reviewed-on: https://gerrit.libreoffice.org/70883
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

All of those have been broken with recent loplugin:sequentialassign changes (and
have been found with a new plugin to be commited).

The code in SbUnoClass::Find (basic/source/classes/sbunoobj.cxx) looks
suspicious, but has been effectively like that ever since at least
c25ec060 "initial import", so just marked it
with a TODO comment for now.

Change-Id: I0d691cb55ef317cf2b16b0490169de7ec97375cf
Reviewed-on: https://gerrit.libreoffice.org/70874
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I72ac69f9cbea34f69d828f55468fb630ca8290fe
Reviewed-on: https://gerrit.libreoffice.org/70885
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Two use-cases here in kde5backend
1) kde or qt vclplug has already started qt event loop => just use this
loop to read KDE settings
2) no qt event loop runs (we're most likely in gtk3_kde5 vclplug) =>
start a new event loop, read the settings and stop it

In case 2) letting qt event loop run means subsequently all UI ops
need to happen in main thread. This is problematic to enforce in
non-qt-based vclplugs

In both cases, cache those settings for future use - the assumption is,
most of them are static during a session anyway.

Change-Id: Ifa203f4cdb9a753db808f945762fb131ee83393c
Reviewed-on: https://gerrit.libreoffice.org/70808
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I3fe30de8140dce3d81cdfae7d41e0bd465b1d5f4
Reviewed-on: https://gerrit.libreoffice.org/70879
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

mbCurVisible is immediately read in ImplPrepForDraw, which inits some more
members but not mnStyle which is then read in ImplCursorInvert.  Regression
introduced with b9c10ee9 "weld
ClassificationDialog", found when valgrind'ing UITest_classification.

Change-Id: I986af0531e250953b8e45c914997b31c53a9ba91
Reviewed-on: https://gerrit.libreoffice.org/70876
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...which avoids a false positive from an upcoming loplugin that finds suspicious
uses of variables during their own initialization (as happened with xReturn in
getProcessServiceFactory).

Change-Id: I40e90e2e74cde84a3425b014d87584f4a56c0e22
Reviewed-on: https://gerrit.libreoffice.org/70877
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Commit 3e009203 (tdf#112318 sd opengl:
fix lack of initial animation, 2019-04-05) enabled processing of idle
events between two updates of the slideshow to help OpenGL, which
uncovered a problem with media shapes.

On one hand,
slideshow::internal::ViewMediaShape::implInitializePlayerWindow() calls
EnablePaint(false) on the media window. OTOH,
vcl::Window::ImplCallPaint() handles mbPaintDisabled by invalidating the
relevant area of the window, which causes a paint<->invalidate loop.

Fix the problem by nominally still enabling paints on the media window:
nothing will change in practice (since the actual media overlay will be
on top of it), but this way the loop goes away.

mbPaintDisabled is handled like this since the initial import, the media
window flag was added much later, so it makes more sense to adapt the
later.

Change-Id: Ib89b68d93aa9d09dbcad33eb6e75a8a25ef1b752
Reviewed-on: https://gerrit.libreoffice.org/70869Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Follow-up fix for 6f43902b

Also remove calling to super class (doesn't work and those methods return void anyway)

Change-Id: I1aa927e373e6d19e4060daba1f34ef72428ead59
Reviewed-on: https://gerrit.libreoffice.org/70878Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

This has been broken with 48314f25 "improve
function-local statics in basic..cui" (and has been found with a new plugin to
be commited).

Change-Id: I518360e3273af9db4a8560a89bc8a789410c8033
Reviewed-on: https://gerrit.libreoffice.org/70875
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

regression from
    commit 7282014e
    Date:   Fri Feb 1 15:15:16 2019 +0100
    tdf#50916 Makes numbers of columns dynamic.

Change-Id: I5ecc52dd709455718a2f3e245b1d41e0c30e7f80
Reviewed-on: https://gerrit.libreoffice.org/70862Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I41a9ff0d281d9032ddaafbbcb55352254a809efe
Reviewed-on: https://gerrit.libreoffice.org/70824
Tested-by: Jenkins
Reviewed-by: Henry Castro <hcastro@collabora.com>

Also fix tdf#123833 and tdf#123837.

In combined charts, now axis types are exported in the right order
(catAx[1], valAx[1], catAx[2], valAx[2]). The Y axes are exported
correctly with the correct axIDs of the chart types: the first one with
the primary axId, the second one with the secondary axId. X category
axis crosses the Y axis at the right place, all data series are attached
to the right Y axis, and the Y major grid doesn't disappear.

Note: don't export the CrossoverPosition/CrossoverValue, if the axis
is deleted and invisible, because MSO will show the secondary X axis,
even if the axis doesn't exist. The problem was the unnecessary export
of the axis with the default css::chart::ChartAxisPosition_END
CrossoverPosition value.

Change-Id: Id429e654ff0ba45b5f9db877b7c4dd6e65433408
Reviewed-on: https://gerrit.libreoffice.org/70814Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>

NB. outside of the often contended SolarMutexGuard.

Change-Id: Ieb651e2ed4349e692010a7588721f461af7d2b5b
Reviewed-on: https://gerrit.libreoffice.org/70848
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>