Kayıtlar (commit) · 56a9903a0047c4ec130e43248cf37a16e7dea084 · LibreOffice / core

10 Agu, 2018 40 kayıt (commit)

OUString: avoid getTokenCount to only get last token · 56a9903a
Matteo Casalin Agu 05, 2018 yazdı
```
Change-Id: I68529076a6a6c2b23842c41d3e9099083a78d3c6
```
56a9903a
OUString: avoid getTokenCount · f96e78a7
Matteo Casalin Agu 05, 2018 yazdı
```
Change-Id: Icceff0aeb5c6fb70513786366416c2d86b60602a
```
f96e78a7

Matteo Casalin Agu 05, 2018 yazdı

OUString managed inside this class either is empty or has 8 tokens,
simplify check.

Change-Id: If576187c6e4800e85f1cebb1ed3e1ae87a4315d1

1f85149f

OUString: use optimized concatenation · 989a4ab7
Matteo Casalin Agu 05, 2018 yazdı
```
Change-Id: Ibaaa29568fe46148baa47422853ef2e627f4045b
```
989a4ab7
OUString: use indexed getToken and convert to proper integer types · 20d50d13
Matteo Casalin Agu 05, 2018 yazdı
```
Change-Id: I39210971a65e62cc22b384ebf090a987747c57af
```
20d50d13
Avoid getTokenCount · f18b7955
Matteo Casalin Agu 05, 2018 yazdı
```
Change-Id: Ib1b6c354184b9379ebafb15ac4a1c789e1c3c1a2
```
f18b7955
Use ASCII literals in indexOf and compare result against 0 · 266c73eb
Matteo Casalin Agu 05, 2018 yazdı
```
Change-Id: I3bea0f3d0566d46c9f92e74f452b6c5a009adcd6
```
266c73eb
Reduce OUString operations · d20dc73b
Matteo Casalin Agu 04, 2018 yazdı
```
Change-Id: I379cc523587da41ee270ac90e8cfdc00526a2745
```
d20dc73b
Fix whitespaces · 227f52f0
Matteo Casalin Agu 04, 2018 yazdı
```
Change-Id: I4d64e537fe6eacf8481479604ee34272073d9aae
```
227f52f0
Avoid getTokenCount/getToken to get last token · aa116a17
Matteo Casalin Agu 04, 2018 yazdı
```
Change-Id: I19de49e64746a6632c56c0ddb0a0c455c97be414
```
aa116a17

cleanup tdf#106062 writerfilter: use new GetAnyProperty function · f13a7100

Justin Luth Tem 31, 2018 yazdı

Change-Id: I88945bbaaf07e3b068c63f17c654c5f7fee9d20a
Reviewed-on: https://gerrit.libreoffice.org/58828
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

f13a7100

vcl: separate SalLayout from the rest of sallayout.hxx · a4f80a3a

Miklos Vajna Agu 10, 2018 yazdı

This way SalLayout can be created separately (and potentially reused)
outside vcl as well. Don't reformat the moved code, so git blame keeps
working.

This is a first step towards the goal of
<https://wiki.documentfoundation.org/Development/Budget2017#Text_layout_performance>,
in the context of code outside vcl.

Change-Id: I8b40313b5fa531d3b56c153cbc4b5ca3cec8f8df
Reviewed-on: https://gerrit.libreoffice.org/58851Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

a4f80a3a

vcl text layout: return early for empty strings · 2f383611

Miklos Vajna Agu 10, 2018 yazdı

It seems the only side effect of GenericSalLayout::LayoutText() is
push_back() calls on m_GlyphItems, which doesn't happen for an empty
string input, so it's safe short-circuit this case.

Change-Id: Ia6e2865117bca60573e2874f11d3742413e9df4b
Reviewed-on: https://gerrit.libreoffice.org/58850Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

2f383611

tdf#119169 impress, crash when editing bulleted list · 36a2af00

Noel Grandin Agu 10, 2018 yazdı

regression from
    commit e278df1a
    tdf#108608 Draw file unresponsive on large text pasted into textbox

Somewhere up in the accessibility code it has a stale paragraph index.
Judging up other code in this class, that is fairly common, so just add
similar safety checks.
The old code (pre-regression) only worked because it iterated over all
paragraphs, and it just ignored the paragraph index.

Change-Id: I51c573b95f976fa87228e4f7e9f33bd6ea0dc3c8
Reviewed-on: https://gerrit.libreoffice.org/58836
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

36a2af00

vcl statusbar: fix last non-use of pre-calculated layout · d7c3f012

Miklos Vajna Agu 10, 2018 yazdı

Use it in the offscreen rendering case as well. Layout calls are visible
by logging the invocations of GenericSalLayout::LayoutText().

Change-Id: I9157aa56d22b6c0cee71cdaeca4d61d1c673c79e
Reviewed-on: https://gerrit.libreoffice.org/58831
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

d7c3f012

shrink scrtf fuzzer · e80214b4

Caolán McNamara Agu 10, 2018 yazdı

Change-Id: I977636eff8a2962ca248287f8733422d635f8559
Reviewed-on: https://gerrit.libreoffice.org/58833
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

e80214b4

tdf#119160 remove fill from all fontwork shapes · b348f1a0

Szymon Kłos Agu 10, 2018 yazdı

Change-Id: I66cd5ab39c3f3b8635eb4e9b5261e100a8037abf
Reviewed-on: https://gerrit.libreoffice.org/58817
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

b348f1a0

vcl statusbar: store calculated layout in StatusBar::SetItemText() · e14ce86a

Miklos Vajna Agu 10, 2018 yazdı

Otherwise we calculate the layout of the text multiple times, which is a
waste of resources. This effectively reverts commit
a4ed3d9a (tdf#115353 Status bar: no
cache in settext, 2018-03-01).

That seems to be safe, given that I can't reproduce tdf#115353 after
this change, and reading through the comments the bug was reported fixed
after both the mentioned commit and
commit 8d42909c (tdf#115353 layout fix,
2018-02-23). So either the first one was not necessary, or it just
worked around an underlying problem that has been fixed in the meantime.

Change-Id: I79c014e9ce41be0c06dae65b5195a23d0d88c2aa
Reviewed-on: https://gerrit.libreoffice.org/58830
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

e14ce86a

Translate German variable names · c707aad5

Johnny_M Agu 04, 2018 yazdı

This is a follow-up to commit 48806ad2
for the rest of the variables in the same files.

Change-Id: I2d95f73be4cf3d91315ed4f7fac80484a7cb29b0
Reviewed-on: https://gerrit.libreoffice.org/58698Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>

c707aad5

tdf#91999 export/drawingml: shape rotate 180 is not special · ab296726

Justin Luth Agu 01, 2018 yazdı

This commit reverts the first (LO 4.3ish) regression commit
60635557 and most of the two commits
that tried to fix that: commit 9ae1e094
and commit ee45d881 in LO6.0/6.2.

The ooxmlexport6 unit test shows that there is nothing special
about 180degrees. So, all transformations need to be avoided in
docx format - not just 180 degree ones.

I removed IsInGroupShape() since it is no longer being used - as
per standard procedures.

Change-Id: Id2bba5bc542875a10ac21fbb67f29b2d59705493
Reviewed-on: https://gerrit.libreoffice.org/58434
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

ab296726

Avoid -Werror=deprecated-declarations with recent Clang trunk · 3cc5149a

Stephan Bergmann Agu 10, 2018 yazdı

...which first added alternative names to and then deprecated getLocBegin/End

Change-Id: Iaefb8ce259057abfa6cd20f0b63c0ef2949a96b2
Reviewed-on: https://gerrit.libreoffice.org/58820
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

3cc5149a

tdf#42949 Fix IWYU warnings in include/salhelper/* · d1a19ef6

Gabor Kelemen Agu 10, 2018 yazdı

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Iaef3e980a96e8a831458e42540795b922bec5ab4
Reviewed-on: https://gerrit.libreoffice.org/58810
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

d1a19ef6

tdf#111856 Playing video in impress is considered a modification · 1da9b165

Nickson Agu 08, 2018 yazdı

Change-Id: If7a2db2d37dc6230a76b79c79e6163a1b33be7d2
Reviewed-on: https://gerrit.libreoffice.org/58713
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>

1da9b165

Resolves: rhbz#1614419 FIPS mode PK11_ImportSymKey failure · 53eda574

Caolán McNamara Agu 10, 2018 yazdı

use rhbz#1461450 style workaround

Change-Id: I9e3b17deb9bac6af76ac253634c91d5e8ccd4963
Reviewed-on: https://gerrit.libreoffice.org/58816
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

53eda574

Revert "uitest for bug tdf#79569" · bc634e9d

Stephan Bergmann Agu 10, 2018 yazdı

This reverts commit 5bd027e1.  It kept failing
in the Jenkins ASan+UBSan build (see below) but wasn't reproducible/debuggable
by anybody else.  So as discussed with vmiklos on #libreoffice-dev, lets
disable/revert this test for now.

This also includes reverts of the follow-up commits that unsuccessfully tried to
track down and fix the issue:
* c57191e0 "Try to make
  test_tdf81457_table_merge_undo deterministic"
* 88d82b7d "Temporarily sprinkle test code with
  debug print statements"
* a94a481c "One last attempt at fixing
  UITest_writer_tests for Jenkins ASan+UBSan build"

With the above follow-up commits still enabled, the latest failure of the
ASan+UBSan Jenkins bot was <https://ci.libreoffice.org//job/lo_ubsan/998/>

[...]
> warn:vcl.gdi:26099:26099:vcl/headless/svpgdi.cxx:235: non default depth bitmap, slow convert, upscale the input
> WPSDocument::isFileFormatSupported()
> warn:i18nlangtag:26099:26377:i18nlangtag/source/languagetag/languagetag.cxx:1388: LanguageTagImpl::convertLocaleToLang: with bAllowOnTheFlyID invalid 'xx-XX'
> warn:legacy.osl:26099:26798:sw/source/core/table/swnewtable.cxx:222: Didn't find wished box
> warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2164: Different Line Widths: first: 9894 current [1]: 8393
> warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2167: Line width differs from table width: 9894 current [1]: 8393
> warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2137: Wrong position/size of overlapped table box
> warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2164: Different Line Widths: first: 9894 current [2]: 1982
> warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2167: Line width differs from table width: 9894 current [2]: 1982
> warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2164: Different Line Widths: first: 9894 current [1]: 8393
> warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2167: Line width differs from table width: 9894 current [1]: 8393
> warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2137: Wrong position/size of overlapped table box
> warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2164: Different Line Widths: first: 9894 current [2]: 1982
> warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2167: Line width differs from table width: 9894 current [2]: 1982
> warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2164: Different Line Widths: first: 9894 current [1]: 8393
> warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2167: Line width differs from table width: 9894 current [1]: 8393
> warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2137: Wrong position/size of overlapped table box
> warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2164: Different Line Widths: first: 9894 current [2]: 1982
> warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2167: Line width differs from table width: 9894 current [2]: 1982
> warn:legacy.osl:26099:26798:sw/source/core/table/swnewtable.cxx:222: Didn't find wished box
> warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:216: Possibly wrong box found
> soffice.bin: /home/tdf/lode/jenkins/workspace/lo_ubsan/sw/source/core/layout/findfrm.cxx:1702: const SwCellFrame &SwCellFrame::FindStartEndOfRowSpanCell(bool) const: Assertion `pRet && "SwCellFrame::FindStartRowSpanCell: No result"' failed.
>
>
> Fatal exception: Signal 6
> Stack:
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/soffice.bin(backtrace+0x41)[0x44f821]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libuno_sal.so.3(+0x457429)[0x2b7859768429]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libuno_sal.so.3(+0x456c25)[0x2b7859767c25]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libuno_sal.so.3(+0x45452a)[0x2b785976552a]
> /lib64/libpthread.so.0(+0xf6d0)[0x2b785b78b6d0]
> /lib64/libc.so.6(gsignal+0x37)[0x2b785bff1277]
> /lib64/libc.so.6(abort+0x148)[0x2b785bff2968]
> /lib64/libc.so.6(+0x2f096)[0x2b785bfea096]
> /lib64/libc.so.6(+0x2f142)[0x2b785bfea142]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0xbd5c735)[0x2b792487d735]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0xc74058b)[0x2b792526158b]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(_ZN7SwFrame6ShrinkElbb+0x1502)[0x2b7925218cb2]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0xc710bb2)[0x2b7925231bb2]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(_ZN13SwContentNode9DelFramesEb+0x2a10)[0x2b79237ff1e0]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(_ZN7SwNodes9MoveNodesERK11SwNodeRangeRS_RK11SwNodeIndexb+0x12d4d)[0x2b79238848ed]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0xa0168ea)[0x2b7922b378ea]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0xdd5f2f2)[0x2b79268802f2]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0xdebd7b4)[0x2b79269de7b4]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0xdc6c87c)[0x2b792678d87c]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsvllo.so(_ZN17SfxListUndoAction15UndoWithContextER14SfxUndoContext+0x5cc)[0x2b78774690fc]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsvllo.so(_ZN14SfxUndoManager8ImplUndoEP14SfxUndoContext+0x1b2d)[0x2b787744829d]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsvllo.so(_ZN14SfxUndoManager15UndoWithContextER14SfxUndoContext+0x106)[0x2b78774496d6]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0xdb2a648)[0x2b792664b648]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0xdb2bac7)[0x2b792664cac7]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(_ZN11SwEditShell4UndoEt+0x15b6)[0x2b7923f7cde6]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(_ZN10SwWrtShell2DoENS_6DoTypeEt+0x635)[0x2b792b4e14e5]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0x1168a394)[0x2b792a1ab394]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0x11688002)[0x2b792a1a9002]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsfxlo.so(+0x326de37)[0x2b787042be37]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsfxlo.so(+0x3227341)[0x2b78703e5341]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsfxlo.so(_ZN13SfxDispatcher8Execute_ER8SfxShellRK7SfxSlotR10SfxRequest11SfxCallMode+0x1a40)[0x2b7870401c50]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsfxlo.so(+0x3196242)[0x2b7870354242]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsfxlo.so(+0x3795206)[0x2b7870953206]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsfxlo.so(+0x3798e6f)[0x2b7870956e6f]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libcomphelper.so(_ZN10comphelper15dispatchCommandERKN3rtl8OUStringERKN3com3sun4star3uno8SequenceINS6_5beans13PropertyValueEEERKNS7_9ReferenceINS6_5frame23XDispatchResultListenerEEE+0x163a)[0x2b78628adb0a]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libvcllo.so(_ZN6UITest14executeCommandERKN3rtl8OUStringE+0x78d)[0x2b789fac7fbd]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libvcllo.so(+0x87b6b72)[0x2b789fae5b72]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libgcc3_uno.so(+0x134616)[0x2b78e0997616]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libgcc3_uno.so(+0x12dedb)[0x2b78e0990edb]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libgcc3_uno.so(+0x12aaef)[0x2b78e098daef]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libbinaryurplo.so(+0x38ae9c)[0x2b78e63f5e9c]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libbinaryurplo.so(+0x381e87)[0x2b78e63ece87]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libbinaryurplo.so(+0x4b213d)[0x2b78e651d13d]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libuno_cppu.so.3(+0x254191)[0x2b78641a1191]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libuno_cppu.so.3(+0x286a8e)[0x2b78641d3a8e]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libuno_cppu.so.3(+0x298567)[0x2b78641e5567]
> /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libuno_sal.so.3(+0x48bc3d)[0x2b785979cc3d]
> /lib64/libpthread.so.0(+0x7e25)[0x2b785b783e25]
> /lib64/libc.so.6(clone+0x6d)[0x2b785c0b9bad]
> DEBUG.1
> DEBUG.2
> DEBUG.3
> DEBUG.4
> DEBUG.5
> DEBUG.6
> DEBUG.7
> DEBUG.8
> DEBUG.9
> DEBUG.10
> DEBUG.11
> DEBUG.12
> DEBUG.13
> DEBUG.14
> DEBUG.15
> DEBUG.16
> DEBUG.17
> DEBUG.18
> DEBUG.19
[...]

showing that soffice.bin hit the assert at
sw/source/core/layout/findfrm.cxx:1702 during the second .uno:Undo (after the
.uno:Redo).

Change-Id: I24a4ae379a1589f6d762dc3979f963eb543ba6b6
Reviewed-on: https://gerrit.libreoffice.org/58813
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

bc634e9d

tdf#116549 docx export: write "nil" to uninherit a border · ae74abcd

Justin Luth Agu 09, 2018 yazdı

If styles would provide a border, then non-borders need
to be explicitly written out.

Unit tests prove this out for both styles and pragraphs.

Change-Id: I4195d38622adc09831f6dad64840a92a42c494b5
Reviewed-on: https://gerrit.libreoffice.org/58803
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

ae74abcd

tdf#119194: save deprecated argument early · 5ccf8264

Mike Kaganski Agu 10, 2018 yazdı

Change-Id: I4b5001e1f71ac536ac0c3bda4b8c1955020ab40d
Reviewed-on: https://gerrit.libreoffice.org/58815
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

5ccf8264

$U-Vladimir\Vadim's avatar$

tdf#113853 fix keeping visible selected items jumping by tab · 8055f402

U-Vladimir\Vadim Agu 05, 2018 yazdı

Calc range of window, check if item is inside that range, calc scroll offset

Change-Id: I5ce7c95b167fe18e20f81bb4656093c15309d1c7
Reviewed-on: https://gerrit.libreoffice.org/58633
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

8055f402

sw: document Extent and MergedPara · e07fe249

Miklos Vajna Agu 06, 2018 yazdı

Change-Id: Ia0c3bba156b644cb78187999fc48b6cdc2cd1aaf
Reviewed-on: https://gerrit.libreoffice.org/58642
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

e07fe249

Qt5 disable native draw via SAL_VCL_QT5_NO_NATIVE · e7a9e653

Jan-Marek Glogowski Agu 09, 2018 yazdı

Primary as a debugging measure to compare output for Qt5Graphics.
Checks mpToolkitName, so we just disable it for qt5 not kde5.

Change-Id: Ib7a67c4bec16d81dd87b6351ba106f655d37948b
Reviewed-on: https://gerrit.libreoffice.org/58790
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

e7a9e653

Qt5 fix nTransparency handling · 3e52c651

Jan-Marek Glogowski Agu 09, 2018 yazdı

So nTransparency is actually also in percent, i.e. max is 100,
instead of the full byte range, like alpha colors in Qt and VCL.

Fixes "SAL_USE_VCLPLUGIN=qt5 ./bin/run vcldemo --show poly"
transparency.

Change-Id: I723cbb2d6b5af4a37b18d3e6a5e0c5b81421221a
Reviewed-on: https://gerrit.libreoffice.org/58789
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

3e52c651

Qt5 also move color setting handling from kde5 · 0927c5b3

Jan-Marek Glogowski Agu 09, 2018 yazdı

This is all QStyle based. Font handling still to do.

Change-Id: I784e64aa88d013146e2c9a07051a0a76a1369ff0
Reviewed-on: https://gerrit.libreoffice.org/58788
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

0927c5b3

tdf#117058: Simplify calls to Menu::CheckItem · 0b73990b

Arnold Dumas Agu 09, 2018 yazdı

Change-Id: I2a8375eb35c86c445d04f71755aef0cdbb051024
Reviewed-on: https://gerrit.libreoffice.org/58802
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>

0b73990b

tdf#41425 XLS/XLSX export: workaround for style and validation loss · 99b9ea63

László Németh Agu 03, 2018 yazdı

of cells of blank rows.

This workaround is probably a fix for problems of most users, but for
a full solution it needs to extend the workaround for all rows with not
default settings, also avoiding of the possible performance problems.

Note: the number 1000 of the extra rows came from a similar workaround used in
XLSX export of Google Spreadsheets, but instead of listing extra empty 1000
rows in OOXML, this fix writes only the cells with not default settings from
the extra 1000 blank rows.

Change-Id: Icac9441b7eb1520dcd20fc04337e070d070591c7
Reviewed-on: https://gerrit.libreoffice.org/58575
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

99b9ea63

test apparmor profile parsing (see tdf#114915) · d0841a18

Rene Engelhard Haz 13, 2018 yazdı

idea taken from
https://salsa.debian.org/apparmor-team/apparmor-profiles-extra/commit/7fbcc4788d0e94764eeeff2f080796601241f986#546c1096cd506dbb01a47ed87a636a8e94d83b8c

Change-Id: I7e5bda9224d69530af4d30422c2fd3d60c9929d6
Reviewed-on: https://gerrit.libreoffice.org/55770
Tested-by: Jenkins
Tested-by: Rene Engelhard <rene@debian.org>
Reviewed-by: Olivier Tilloy <olivier.tilloy@canonical.com>
Reviewed-by: Rene Engelhard <rene@debian.org>

d0841a18

oox: create FilterDetect instances with an uno constructor · 2963e0c6

Miklos Vajna Agu 09, 2018 yazdı

Change-Id: Ic9baba6a4ca37af18c5f5175aadcc59bf47c7b64
Reviewed-on: https://gerrit.libreoffice.org/58798
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

2963e0c6

unnecessary null check before dynamic_cast, in various · d977e02e

Noel Grandin Agu 09, 2018 yazdı

Change-Id: I76ad0b3152030c29ee28f6a6cc80d0832188d02b
Reviewed-on: https://gerrit.libreoffice.org/58774
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

d977e02e

unnecessary null check before dynamic_cast, in sc · 76dd6bb9

Noel Grandin Agu 09, 2018 yazdı

Change-Id: I442dee456ccb419642e6cedee7c3ca99ce214de6
Reviewed-on: https://gerrit.libreoffice.org/58773
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

76dd6bb9

unnecessary null check before dynamic_cast, in sd · 4e63c00f

Noel Grandin Agu 09, 2018 yazdı

Change-Id: I91579ece17b85b1ae9926b7a05eb641672e8ecbd
Reviewed-on: https://gerrit.libreoffice.org/58772
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

4e63c00f

unnecessary null check before dynamic_cast, in svx · 7fdd5a12

Noel Grandin Agu 09, 2018 yazdı

Change-Id: I5174c9530d18e5d88ad8a41cc2bb02c6d090f3cf
Reviewed-on: https://gerrit.libreoffice.org/58771
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

7fdd5a12