Change-Id: If59ecb4ea92d9daf423aef870e79248f5bc93e6d

Change-Id: Ifcce63b975fb7c4ac7e7545e3eadcc6f7f12e466

Change-Id: I6e68a6728eed108c7670ebef6073394de3f53e6b

Change-Id: Ie261d5412c510c045b4d93a6bf1a3d4cf4371897

Change-Id: I39d443e582a6e82947f9c833b157f137a082a358

Change-Id: I8bd752814994fedac17fe0d002b415902c276b20

Change-Id: Ib64d5b5fa1bf13a484adb296b969d1b96387f0c6

Only on macOS, the SDK used to expect javac etc. in a Commands sub-dir (which
Apple's JDK 1.6.0 has but Oracle's JDK 1.8.x don't).  However, at least both
Apple's latest JDK 1.6.0 (as available via <https://support.apple.com/kb/DL1572>
"Download Java for OS X 2015-001") and any recent Oracle JDK 1.8.x (like
jdk1.8.0_121.jdk) have a Home sub-dir that contains a "standard" sub-tree with
bin sub-dir etc., like on other platforms.  So consistently make the SDK use
that instead.

This removes the JAVABIN Make variable from settings.mk.  It is assumed to not
be used by client code.

Change-Id: Ie0ad647f489528444dfd399c2f00500b772d3288

The problem in callnk.cxx was that when selecting 1 char to the right
using keyboard, and exiting field boundary, nCmp pointed to previous
position (inside field), and then compared to position to the left
(which also may be inside field), thus missing call change link (and
read-only state change). Seems that this was a mistake in commit
740efbb1.

In pam.cxx, if cursor was to the left of field, and then selected
1 char to the right to cross field's boundary, then both PaM's point
and mark had same fieldmark, but point was outside, and mark inside,
and as code didn't check this condition, so read-only state wasn't
properly set.

Unit test is augmented to check the second problem.

Change-Id: I7323e53eeb261b4ccdc0f9e36cc0956b373f104d
Reviewed-on: https://gerrit.libreoffice.org/33790Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I391554dff6f92d7639d0a391f4b00437c7648a6b

The #include was introduced in
96c1ae1d with an #if on
HAVE_FEATURE_OPENGL, but that #if was later removed.

Change-Id: I70f839d5224e0a77a1640a5e23cbe64656c9cb1b

This reverts commit 4739b31d.

Apparently, passing a param of type css::uno::Exception to Any
will record precisely a css::uno::Exception in that Any, losing
any subtype information, which this commit changed.

Change-Id: Idc5fbdcd6d1a11b7607995c1d492ffc829879566
Reviewed-on: https://gerrit.libreoffice.org/33718Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Add missing recommended formatting options in Compatibility.xcs
Correct ConfigItem rootnode path for SvtCompatibilityOptions_Impl

Change-Id: I1e56b276bf4a0801ab724baaecda53168783b27f
Reviewed-on: https://gerrit.libreoffice.org/33786Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

so that e.g. the xor cursor in csv dialog can be seen when moving
the mouse across the ruler

Change-Id: Ia2f367d5f610d486a8e10b6bc278cbc8029cf2a1

since the latter is rather slow

Change-Id: Ib73cdb923585580777c2265b561c1808e93b2baa
Reviewed-on: https://gerrit.libreoffice.org/33585Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I0d913699c3aac84f2bdfe50f9dec6e6921242744
Reviewed-on: https://gerrit.libreoffice.org/33776Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

all the call sites are passing an uno::Exception subtype

Change-Id: I6de1f00810e063e75ef620314561d7e2d6445ada
Reviewed-on: https://gerrit.libreoffice.org/33657Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

So add to them instead of just assigning. In the bugdoc the initial
values were zero, but maybe in some other cases they aren't.

Change-Id: I3d399fe4aab9260817f171d4e69388a19eb85d21

just the simple and obvious case for now, of a local var being allocated
and deleted inside a single local block, and the delete happening at the
end of the block

Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625
Reviewed-on: https://gerrit.libreoffice.org/33749Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I22af89b920d43f3fc5f0fff02070f288bfa59fb4
Reviewed-on: https://gerrit.libreoffice.org/33702Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Text portion level background in Writer text was working already, as
Writer paints its background explicitly, and then uses no text fill
color in the metafile (that is turned into a PDF later).

However, text fill color is used for Writer shape text and also in
Impress. The rectangle is not just the text itself, but also the ascent
/ descent region, this matches the desktop rendering result.

Change-Id: I644007ade43a8b9e663890643b826ae12c427ea5
Reviewed-on: https://gerrit.libreoffice.org/33781Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I2d3b6f22deee0f2b9ec39592b89e0e4742659593
Reviewed-on: https://gerrit.libreoffice.org/33782Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Id713460036331fd9f98fd1eca85ca61f57cf5afe
Reviewed-on: https://gerrit.libreoffice.org/33779Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I419e44d72f594fab0774152720f55c1d7d5366e6
Reviewed-on: https://gerrit.libreoffice.org/33723Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

...as seen in the scenario described in 5997121a
"Support signal handlers registered with SA_SIGINFO", first

> src/client/linux/minidump_writer/directory_reader.h:82:19: runtime error: member access within misaligned address 0x7f3f8235c2cc for type 'struct kernel_dirent', which requires 8 byte alignment
> 0x7f3f8235c2cc: note: pointer points here
>   10 02 00 00 d8 f8 3b 00  00 00 00 00 01 00 00 00  00 00 00 00 18 00 2e 00  00 00 00 04 02 c7 3b 00

and then

> src/client/linux/minidump_writer/linux_dumper.cc:382:19: runtime error: member access within misaligned address 0x7f96c225d7bc for type 'google_breakpad::MappingInfo', which requires 8 byte alignment
> 0x7f96c225d7bc: note: pointer points here
>   20 0a 32 30 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00
>               ^

Change-Id: I7f739567879093a404bee3e351ce9e8257676183

...as is the case for external/breakpad's
google_breakpad::ExceptionHandler::SignalHandler (though that one appears to be
careful to check that its additional arguments are not garbage, cf. the
"Sometime, Breakpad runs inside a process where some other buggy code..."
comment in
workdir/UnpackedTarball/breakpad/src/client/linux/handler/exception_handler.cc).

Seen when JunitTest_framework_complex run under ASan/UBSan happened to trigger
an assert,

> soffice.bin: vcl/source/app/dbggui.cxx:47: void ImplDbgTestSolarMutex(): Assertion `ImplGetSVData()->mpDefInst->CheckYieldMutex() && "SolarMutex not locked"' failed.
> sal/osl/unx/signal.cxx:349:13: runtime error: call to function google_breakpad::ExceptionHandler::SignalHandler(int, siginfo_t*, void*) through pointer to incorrect function type 'void (*)(int)'
> (instdir/program/libsofficeapp.so+0xb7eab0): note: google_breakpad::ExceptionHandler::SignalHandler(int, siginfo_t*, void*) defined here
>     #0 0x7f6cefc21693 in (anonymous namespace)::callSystemHandler(int) sal/osl/unx/signal.cxx:349:13
>     #1 0x7f6cefc1f3e1 in (anonymous namespace)::signalHandlerFunction(int) sal/osl/unx/signal.cxx:422:9
>     #2 0x7f6cedbc95bf  (/lib64/libpthread.so.0+0x115bf)
>     #3 0x7f6ced20491e in __libc_signal_restore_set /usr/src/debug/glibc-2.24-33-ge9e69e4/signal/../sysdeps/unix/sysv/linux/nptl-signals.h:79
>     #4 0x7f6ced20491e in __GI_raise /usr/src/debug/glibc-2.24-33-ge9e69e4/signal/../sysdeps/unix/sysv/linux/raise.c:55
>     #5 0x7f6ced206519 in __GI_abort /usr/src/debug/glibc-2.24-33-ge9e69e4/stdlib/abort.c:89
>     #6 0x7f6ced1fcda6 in __assert_fail_base /usr/src/debug/glibc-2.24-33-ge9e69e4/assert/assert.c:92
>     #7 0x7f6ced1fce51 in __GI___assert_fail /usr/src/debug/glibc-2.24-33-ge9e69e4/assert/assert.c:101
>     #8 0x7f6cb60cdad5 in ImplDbgTestSolarMutex() vcl/source/app/dbggui.cxx:47:5
>     #9 0x7f6cbd337fb9 in DbgTestSolarMutex() tools/source/debug/debug.cxx:74:9
>     #10 0x7f6cb3c98abf in vcl::Window::ReleaseGraphics(bool) vcl/source/window/window.cxx:900:5
...

Change-Id: I2625541e0b9e50f9723e61e0cbff0e6c77d0fb9f

lets just leave the toolbar active the whole time, seems
to make more sense anyway wrt being allowed to keyboard
into it to paste/insert special character

Change-Id: I174fb707c4c7fd21d95461cc93323eb6d8970818

Makes it easier to push various infobars without specifiying the
colors manually.

Change-Id: I0f861ba02409a42ba2ae767a1ca7634eaf0e7aef
Reviewed-on: https://gerrit.libreoffice.org/33777Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I43716332ab916e5ec7b8ab7a4d14895d060a9bd4
Reviewed-on: https://gerrit.libreoffice.org/33692Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I73a4e7894e33dd95ca50ea25f5f95bf94a43531e

because root entries have UserData of type SwContentType while children have
UserData of type SwContent (both inherit from SwTypeNumber)

Change-Id: Iab7a4caaca5dfdae16aa4f6ede565e26aa4c73c9

Change-Id: I413f195bb5571eb536e948a7e9ffb982b3619e65

Change-Id: I50619d94c7bebeb99b5dbb9e21f0eefa3fd39482
Reviewed-on: https://gerrit.libreoffice.org/33778Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ia3a30936fadde10275a964d09150a3b6e4f3e16f

To be used in layout tests.

Change-Id: I551b87786a4ad4ab34a22c458561109270fb4a31

Change-Id: I4e19a9d976c28f5e6649bdbb3dd609e03a4c03a8
Reviewed-on: https://gerrit.libreoffice.org/33770Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: Ide9148a908bef46ba14640dfa6f556beaf6e3f60
Reviewed-on: https://gerrit.libreoffice.org/33772Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

for copy ctor/assignment and dtor.
inline MEMBER_CONSTRUCTOR_LIST macro

Change-Id: I50296cebca3bc1aa43376ccd538c84df68a232a2
Reviewed-on: https://gerrit.libreoffice.org/33771Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

move static arrays to anonymous namespace
try creating the SotAction arrays at compile time with constexpr

Change-Id: If0d0563b35936574beea617da08880a6c32569d9
Reviewed-on: https://gerrit.libreoffice.org/33750Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>