Since commit 18828273, an attempt to
install UCRT will be performed regardless there is an evidence that it's
present on the system, to workaround some cases where the existing UCRT
is broken (tdf#115405, tdf#119910).

But that made other errors to emerge: on systems where users disable WU
service using some exotic ways, installer is unable to enable the
service, and fails. [1][2] Examples of such hard-disables are using
`sc delete` [3] and associating WU service with a guest account. Many
such cases are reported for Windows 10, where installation of the UCRT
is not required.

So the solution (imperfect, but possibly the best possible here) is to
allow installer to continue in case of failure enabling the service.
This will automatically eliminate all problems related to Win10; and
also for cases where users are advanced enough (the majority of such
hard-disable cases should be those), it might be enough to add a
relevant FAQ entry.

[1] https://ask.libreoffice.org/en/question/172227/cannot-install-631/
[2] https://ask.libreoffice.org/en/question/175571/installation-failed-unknown-error-win10x64/
[3] https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/sc-delete

Change-Id: Ie85016eb6f0667f39412a3089fe1b1855cb1fc73
Reviewed-on: https://gerrit.libreoffice.org/64825Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I413fa17ee0fc264526133eca12ee747d40d6ac6a
Reviewed-on: https://gerrit.libreoffice.org/64412
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

Change-Id: I7c34dfb5a83b14afc740772cffe407d4773b07e5
Reviewed-on: https://gerrit.libreoffice.org/64818
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I1db02a4eff2d6f16bfb18bda2155d8a26c4a9335
Reviewed-on: https://gerrit.libreoffice.org/64814
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ic7d194bd256cc573c4081bb82619e42abf2dda90
Reviewed-on: https://gerrit.libreoffice.org/62842
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

... which is the to be used function parameter separator here. The
current document's grammar (from which the separator is obtained
in ScRangeList::Format() if not specified) may differ from the
forced English grammar later when compiling the formula, and all
formula expressions to be inserted use the language independent
';' semicolon function parameter separator.

Change-Id: I7a3deb6d50fc57ed434ede1f00bbe8c5c1361e0f
Reviewed-on: https://gerrit.libreoffice.org/64819Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Change-Id: Iac45bd7f50e9f9e82c5dad25983f4b32515c4816
Reviewed-on: https://gerrit.libreoffice.org/64815
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

which benefits LOOL since we can delay creating the image until
we know the dpi setting of the display we are going to write to.

Achieved by

    perl -pi -w -e "s/\bImage\s*\(\s*BitmapEx\s*\((\w+)\s*\)\s*\)/Image\(\1\)/g" $( git grep -lw "BitmapEx" )

followed by

    git grep -nP '\bImage\s*\(\s*BitmapEx\s*\('

followed by commenting out the BitmapEx(OUString) constructor and seeing
what needed adjusting.

Change-Id: I3224e11937d720fa484b0d659d25673a9e809267
Reviewed-on: https://gerrit.libreoffice.org/64760
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I4cb2ff5393822c6ec982126b3e0a676374cce033

Change-Id: I141c003bead8eda9bdfa8a7fd286f76390cf77ac
Reviewed-on: https://gerrit.libreoffice.org/62843
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: I53951eee14e028365967615c0eb017ca43dfd891
Reviewed-on: https://gerrit.libreoffice.org/62845
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: I98b2d90c8345f07010f6defd82557188d5cd35c7
Reviewed-on: https://gerrit.libreoffice.org/64808
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I34d2078e13119291efde85636d7c62555f10a55f

Change-Id: I6ace9eb6d13c13da0aaf2919c8846fa3cf5fe4c1
Reviewed-on: https://gerrit.libreoffice.org/62837
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: I60aa1f4b8a168fa692f0f151f69400eec749fb02
Reviewed-on: https://gerrit.libreoffice.org/64360
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: Icd7ac2d10e9d28d563f964cb144bbe94027617c1
Reviewed-on: https://gerrit.libreoffice.org/64788Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

no idea why this wasn't found on my (incremental) build

Change-Id: I78079d4c3196584b171d7566245a7f71b9d43649

* Update helpcontent2 from branch 'master'
  - Fix contents after translators review.
    
    Change-Id: I3bd4a18872f9634de245503f239d777fcb66ec87
    Reviewed-on: https://gerrit.libreoffice.org/64809
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

...but for safety, leave the configure.ac check in for some longer.

Also, save removing now-redundant SAL_WARN_UNUSED_RESULT in internal code for a
follow-up commit.

Change-Id: Ibe30b51c5cc4abc270f955c7c40b59f268986672
Reviewed-on: https://gerrit.libreoffice.org/64771
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

* Update helpcontent2 from branch 'master'
  - Fixes in Help page after translators review
    
    Change-Id: I8ad08be0881d10bbe3ca8eac4647118cf5d4fa18
    Reviewed-on: https://gerrit.libreoffice.org/64806
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: Iec673ea13aba85ac8070a639722359f821cc5cdd

In file included from /data/rene/git/LibreOffice/master/tools/source/generic/fract.cxx:33:
/usr/include/boost/math/common_factor_rt.hpp:13:63: note: #pragma message: This header is deprecated. Use <boost/integer/common_factor_rt.hpp> instead.
 BOOST_HEADER_DEPRECATED("<boost/integer/common_factor_rt.hpp>");

the BOOST_HEADER_DEPRECATED(..) was done in boost 1.67 so make it conditional
on that one.

Change-Id: I10cb0e4c25e1fa1497dea35c0fc3e5e719142123

...after 7ffdd830
"HAVE_CPP_ATTRIBUTE_FALLTHROUGH is always true now"

Change-Id: I54e5ff4e036a6bb3e5774d1c0524158aae18e937
Reviewed-on: https://gerrit.libreoffice.org/64800
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

since...

commit 0cc70223
Date:   Tue Dec 4 15:00:43 2018 +0200

    use unique_ptr in SfxObjectShell_Impl

    Change-Id: I3f3b0514bdb87f59d9c5f34d2d36dc63e8b1e33d
    Reviewed-on: https://gerrit.libreoffice.org/64527

Change-Id: I00e2cd2bcbb9a252a45d31da650e327506d2990d
Reviewed-on: https://gerrit.libreoffice.org/64780
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

$ file compilerplugins/clang/singlevalfields.results -i

Before:
    compilerplugins/clang/singlevalfields.results: application/octet-stream; charset=binary

After:
    compilerplugins/clang/singlevalfields.results: text/x-c; charset=iso-8859-1

Then converted to UTF-8, to avoid troubles reading it with Python/Editors without
forcing latin-1, like this:

UnicodeDecodeError('utf-8', b'    SwWW8ImplReader::Read_F_DocInfo aName41
    ZULETZTGEDRUCKT
sw/source/filter/ww8/ww8par5.cxx:1569
    SwWW8ImplReader::Read_F_DocInfo aName42
    DERNI\xc8REIMPRESSION
', 155, 156, 'invalid continuation byte')

See here:
https://stackoverflow.com/questions/5552555/unicodedecodeerror-invalid-continuation-byte

Change-Id: Ie54c25e069b3f12b6a28e3724f5b2d323f26f737
Reviewed-on: https://gerrit.libreoffice.org/64786
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Just as is already done in 'Qt5Menu::InsertMenuItem',
the text needs to be converted in 'Qt5Menu::SetItemText'
as well.

Change-Id: I03c8f2e6fe0e926a3f7e4be5b7eac70f1bd9850f
Reviewed-on: https://gerrit.libreoffice.org/64796
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

As part of documenting source code for easier code reading by newbies,
because of the word "Box" in IDE is used not only for drop-down lists,
but also for other interface elements with limited boundaries

Change-Id: Ie9e1949cc9ac474bffe8201d12b9ce7dc2276076
Reviewed-on: https://gerrit.libreoffice.org/64713
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I04c55d196a26a5f3319bac08b2f406397335ee32
Reviewed-on: https://gerrit.libreoffice.org/64797
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: If391c86c9b2c94eed9b95c692f290449a241ed4e
Reviewed-on: https://gerrit.libreoffice.org/64790
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...between adjacent switch labels without any intervening statements

Change-Id: Ieb8a0d9f71ea4382b5f7d005cdf7111d06aeb5d0
Reviewed-on: https://gerrit.libreoffice.org/64789
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Move XEnumerationAccess Java test to C++ for ScCellFieldsObj.

Change-Id: I09e7c6be401bb54e1314da95d6797790aedefbe1
Reviewed-on: https://gerrit.libreoffice.org/64795
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XElementAccess Java tests to C++ for ScCellFieldsObj.

Change-Id: I140cb1f1d5f9cbccfd4dbb43d37c9cd48b7346e8
Reviewed-on: https://gerrit.libreoffice.org/64794
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XRefreshable Java tests to C++ for ScCellFieldsObj.

Change-Id: Ic5679c32669b1368a702c9b132e6789fb828330f
Reviewed-on: https://gerrit.libreoffice.org/64793
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: Ibf55f02eccdcadb2d42f5aff8d72bff20ada3b3a
Reviewed-on: https://gerrit.libreoffice.org/64792
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: If9d0a0539002c013f077b8fb692de4c29ca032b7
Reviewed-on: https://gerrit.libreoffice.org/64791
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

to ensure that the commit

Find actual data area inside the main-range...
24b1827309e7fe4d77108da5732f7f4eddad3ae6

does not change results by its optimizations.

Change-Id: I07113359cac9c653f692e84a7b79b06621142aaf
Reviewed-on: https://gerrit.libreoffice.org/64658
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: I08a4494ca249dbbb444643052bcff1740e089e26
Reviewed-on: https://gerrit.libreoffice.org/64785
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

...(according to
<http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1579> it is fixed
in C++14), but for safety, leave the configure.ac check in for some longer.

Change-Id: Ibd2f0cac228117e35ac299e2fe74207394c900cd
Reviewed-on: https://gerrit.libreoffice.org/64773
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...but for safety, leave the configure.ac check in for some longer.

Also remove now-redundant SAL_INLINE_VARIABLE again (which was
LIBO_INTERNAL_ONLY).

Change-Id: Id049e0cb84b4f97f5859f1b16b867b39b448dec0
Reviewed-on: https://gerrit.libreoffice.org/64772
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...but for safety, leave the configure.ac check in for some longer.

Also, save removing now-redundant SAL_FALLTHROUGH for a follow-up commit.

Change-Id: I9bf42d237aea4c09459f28275568cf340e588607
Reviewed-on: https://gerrit.libreoffice.org/64770
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>