- 29 Agu, 2016 40 kayıt (commit)
-
-
Yousuf Philips yazdı
Change-Id: If8afd7af6bb3c69ac9a3e0c4bdae3dab127cbc2a Reviewed-on: https://gerrit.libreoffice.org/28409Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
-
Tor Lillqvist yazdı
Sure, lots of them left. And actually, I don't know, maybe there is some deeper reason why such are used in the sw coding style. Feel free to revert these commits. Change-Id: I5a1c31fe32b3bdf6d40489d029be165c38a8ba05
-
Tor Lillqvist yazdı
Change-Id: Ia77a8ee055b5d29490b863a7792edda995a3faa6
-
Tor Lillqvist yazdı
Change-Id: Ic8eddec51d59b531ae22421b796a148267b9f3c1
-
Stephan Bergmann yazdı
Change-Id: Ibc5128df8bcf8cb5f2f09551c0de6dfdb46bdee0 Reviewed-on: https://gerrit.libreoffice.org/28447Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Stephan Bergmann yazdı
...not merely an ASCII character Change-Id: Id2b381b35fe3a15574728ed973d60263dfef7249 Reviewed-on: https://gerrit.libreoffice.org/28446Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Stephan Bergmann yazdı
The long-term benefit will be support of C++11 char16_t string literals (for cases of string literals with non-ASCII content) once we drop any compilers that don't support those yet. The short-term benefit is support for an improved OUStringLiteral1 that accepts any sal_Unicode value, not just ASCII ones (see next commit). Change-Id: I3f8f6697d7eb62b5176b7e812b5a5113c53b83a4 Reviewed-on: https://gerrit.libreoffice.org/28445Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Stephan Bergmann yazdı
...Except[Const]CharArrayDetector, under RTL_STRING_UNITTEST Change-Id: Ib185fb8406c4afcff1c854a2b74dae02a0ee2b3f Reviewed-on: https://gerrit.libreoffice.org/28444Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Giuseppe Castagno yazdı
Change-Id: Ifa588c37added377d753cb7b32a6f1e6a3672c94 Reviewed-on: https://gerrit.libreoffice.org/28453Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
-
Miklos Vajna yazdı
This doesn't work out of the box via SwRangeRedline::SetStart/End, because the range of the redline is adjusted when redlining is disabled by sw::DocumentRedlineManager::AppendRedline() when it compresses the insert and delete redlines into a single reduced insert redline, and then the redline is updated implicitly via SwIndex. Change-Id: I4b652348b256df75e4c774ea5f3fdd78f59deb01 Reviewed-on: https://gerrit.libreoffice.org/28454Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
-
Jan-Marek Glogowski yazdı
Doen't make much sense to store undo information for all merge based progress. Actually it even prevents crahes when undoing a merged ODT document. Change-Id: Ic3a3982f3e5eb4f6de9f027a6a5e376c2833e8a5
-
Jan-Marek Glogowski yazdı
We already treat the StartOfContent node special in the CopyRange function to prevent merging of SwTextNodes. For trailing sections, we have to expand the code to treat EndOfContent special too, because the supplied SwPaM range is handled as [mark, point[, so it previously missed the section end node, which resulted in "unhiding" the last section, if it was the last node in the document. Change-Id: Ie094e2a0182647a49c9ba45d08a7dd2cabe667c6
-
Jan-Marek Glogowski yazdı
We don't need any background idle jobs for the generated documents, like spell checking, statistics etc. This can be done when (or even if) the document is presented to the user as a background task. Change-Id: I4c72ed6e0d2f90d43e7f04cd0ea4418cbffe1206
-
Jan-Marek Glogowski yazdı
Debug area name is "sw.pageframe". Change-Id: I136cc8192137a8c682900a6ce2c557f6b6b3a6cd
-
Jan-Marek Glogowski yazdı
For the first case of dropping "wrong" empty pages,look ahead and pre-validate the next page, if it needs this empty page, to prevent case three for the next page. This prevents destruction and re-insert of the empty page. Change-Id: I475aa98a2693f814afcc41bd4bc73f04e742c105
-
Jan-Marek Glogowski yazdı
This is a workaround to create correct SwPageFrm objects for layouting, so the page break is actually visible when copying nodes, so we create the correct SwPageFrm. This is especially problematic for mail merge after the fix in commit 60d34e1c, which - correctly - checks all later SwPageDesc for every fix done by CheckPageDescs(). Change-Id: Ie6ea2e9a0587199be4dbaf3ed63a94c29b318ce2
-
Jan-Marek Glogowski yazdı
AssertFlyPages used its own code to insert pages. It had two flaws: 1. It used the SwPageDesc of the previous page, unaware of changed page description of a new page, which would later be fixed by CheckPageDescs, eventually requiring re-layout. 2. The Code has an of-by-one error when setting the initial bOdd, which would also insert wrong / inverse left and right pages. So this changes AssertFlyPages to use InsertPage, which has a little more overhead for inserts, but prevents later expensive corrections, especially when CheckPageDescs() inserts or removes "early" pages, which need to evaluate and move all page bound flys. Change-Id: I8806cebb26db60602d8438f117e0416e07228b3b
-
Jan-Marek Glogowski yazdı
Change-Id: Iff9a78cf2f5e6ded4d1b03a8303529aa324ddad9
-
Jan-Marek Glogowski yazdı
Helps understanding the code, especially CheckPageDescs(). Change-Id: I53e7d0ea65d6c6ae3da98acba4d366a47d2c4210
-
Jan-Marek Glogowski yazdı
nCheckPageNum is set to USHRT_MAX, if all SwPageDesc were checked. Code manipulating SwPageFrm objects checks the pages via CheckPageDescs(). If this is currently forbidden, CheckPageDescs() sets nCheckPageNum to the first page to check. I guess the !pPage check is there to check the pages - at the end, if someone has missed the CheckPageDescs call. And we have to run the check, if the current page is unchecked AKA pPage->GetPhyPageNum() >= nCheckPageNum to do correct layouting. Change-Id: Ib67878115cde04b7161c919a67131a1e1dc67d8d
-
Jan-Marek Glogowski yazdı
Change-Id: I39500424c79040b1887ea74081fdf0ea0bc5f009
-
Jan-Marek Glogowski yazdı
Since we already have isTextBox to identify a text box, this just adds a call to SwFrameFormat::GetOtherTextBoxFormat() to actually return the corresponding SwFrameFormat. This gets rid off all the remaining occurences of the SwFrameFormat / Textbox sets and maps. Change-Id: Id5f05a1ff71e604658e7d8a0d0825f5671335b3f
-
Jan-Marek Glogowski yazdı
This replaces all possible occurences of the text box format maps, which just want to know, if a SwFrameFormat is part of a text box to use the direct lookup via the isTextBox, which is now a cheap call. Change-Id: I3b4e2301f816aead1b719cd70a8ef118e685ccfc
-
Jan-Marek Glogowski yazdı
Currently we have to rebuild the list of text boxes for every lookup. Instead of a managed set, or a per-document list etc., this introduces direct pointers between the corresponding SwDrawFramFormat and SwFlyFrameFormat of a text box. Change-Id: Iefba2d153d9d8b3f1185aa305e9f463a50e78f89
-
Jan-Marek Glogowski yazdı
Drops all using statements and the namespace aliases. This is more in the spirit of tdf#75757. Change-Id: Id7c81baea0e2d1af151b7b9bdce8d9fe5f7a2089
-
Jan-Marek Glogowski yazdı
This is almost the same situation as SwPageDescs. What makes this more complicated is the fact, that actually duplicated draw objects are allowed, in regard to the key values "type" and "name". And actually for some types, duplicate names are not allowed, e.g. SwDoc::FindFlyByName( const OUString& rName, sal_Int8 nNdTyp ) expects a single result! Change-Id: I6e0ea1099c1c1e6cfe90926170e27179722e88b8
-
Jan-Marek Glogowski yazdı
Page descriptions are exported via XIndexAccess, so they need a stable array, currently a vector. On the other hand they are referred by a unique name, so the lookup in the unsorted array is O(n), not taking into account the amount of string comparisons. The multi index container adds an ordered unique index, which gets the lookup time down to O(log(n)) at the cost of a bit more management overhead for most operations, which is largely outweighted by the amount of lookup calls. These anyway have to be done on insert to guarantee the unique naming. Change-Id: I3fb892ff524f6a9804d9572c1825074c0810649e
-
Jan-Marek Glogowski yazdı
Fixes the Boost::Tuple header used by Boost::MultiIndex. Change-Id: I98eb047e699e04934ee09323633e28cecef84e70
-
Maxim Monastirsky yazdı
... if based on MenuBarManager, because unlike context menus, we reuse the same menu instead of creating from scratch each time, so that it suffers from the same "double activation" problem as in tdf#97665. Note that for GtkSalMenu the problem is only for the top level popup menu, as the Deactivate callback is properly called when sub menus are closed. The non-native case also had this problem, but only when closing the menu by selecting one of its items, and was fixed already in b41deb2e. Change-Id: Iee037f7baba0f80c32fb3a45f16511f8585c203e
-
Eike Rathke yazdı
Change-Id: If408305564b1fddbef371f32d2b91b6a1e44a2b0
-
Justin Luth yazdı
.doc and .docx do not have a setting for "do not split table" so it was being emulated by "keep paragraph with next" for all but the last table-row. That means that a single-row table with lots of content might be split. There is a setting to prevent a row from splitting, so use that instead in this corner case. It needs to be separate from the other function in order to be set in time for docx to write w:cantSplit w:val="true" before the row contents. For some reason it did not work to move the whole function here. Change-Id: Idc11626e0e2cf1706b87a83f2bd4a802348cb633 Reviewed-on: https://gerrit.libreoffice.org/28352Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
-
Caolán McNamara yazdı
and coverity#1371211 Change-Id: I65e277c4af70a86f1513749de4eb116d929e858f Reviewed-on: https://gerrit.libreoffice.org/28448Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Miklos Vajna yazdı
Change-Id: Ifecf64e10833e2ede87e304db095c2480db64c81 Reviewed-on: https://gerrit.libreoffice.org/28452Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
-
drazil yazdı
Clean up OSL_ASSERT in basegfx/source/tools/b2dclipstate.cxx Change-Id: I4107980aa079b0e0e8605de34ecfd01587647af6 Reviewed-on: https://gerrit.libreoffice.org/28417Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
-
Noel Grandin yazdı
Change-Id: Ia58dda7eaadf6a91b7af67e011a6f44a4e7a3c0b
-
Noel Grandin yazdı
Change-Id: I26f46ddac3d7d810ebfa1c3e7f1a77427369828e Reviewed-on: https://gerrit.libreoffice.org/28451Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
-
Tor Lillqvist yazdı
Work in progress, not all modifications to a redline record cause notifications yet. Change-Id: I01614cd6ede9576e9cc329889fef86342567325f
-
Stephan Bergmann yazdı
...(ever since c5bcf0e5 "convert sw pos/size page to .ui"), leading to out-of-bounds reads, but which should be harmless, as all they could do is add bad StringIds inot aFrames, but the only use of those IDs in SvxSwFramePosString::GetString (svx/source/dialog/swframeposstrings.cxx) guards against bad IDs. Change-Id: I7a50230c12bcf8a197f787201442c503fe5974e7
-
Noel Grandin yazdı
Change-Id: I986b94df4aa8158f3e0623ab6cb392c178a820ce
-
Noel Grandin yazdı
Change-Id: If5fc8d783211a131711b5961d6b076c24dd64412
-