Change-Id: I81bcf4f56599146536ba8d66cc86fa5a08737298
Reviewed-on: https://gerrit.libreoffice.org/41556Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

In documentbuilder.cxx added code to call XErrorHandler::warning and XErrorHandler::error functions (from DOM::warning_func and DOM::error_func)
In domtest.cxx added try {} catch () block to BasicTest::validInputTest, BasicTest::warningInputTest and BasicTest::errorInputTest and to SerializerTest::serializerTest. Also uncommented lines CPPUNIT_TEST(warningInputTest); and CPPUNIT_TEST(errorInputTest);

Unit tests are now working
(FatalError test removed, as lib2xml doesn't distinguish between error and fatal error and counts everything as error).

Change-Id: I27c5036df6a1cc5bef5dbb8171c201d81bae2ccd
Reviewed-on: https://gerrit.libreoffice.org/41376Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I3eff2bdd5da3710bc130a5d9965a8c84c74ee55b

Those were the last remaining raw uses of osl_inc/decrementInterlockedCount.

Change-Id: I66d0d37a563106a0cc3edbd163462211893e3dae

Change-Id: Ibff41550f292da76c17238a9cd2856b6599e952a

When opening a file that triggers Dialogs (e.g. cannot
read/repair/FileType) the Frame from which it was
initialized gets blocked. This irritates quite some
people. Changed this to a non-modal Dialog so that
the user can continue to work with all opened docs,
open new ones, close and print/PDF/export these.

Change-Id: I048d3de3369527cec20d26396b87439254764b8a
Reviewed-on: https://gerrit.libreoffice.org/41534Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

The second cTn tag needs to have a dur="indefinite" attribute, otherwise
the last element is hidden immediately after being shown. Also the value
of all fill attributes with the value freeze needs to be hold, otherwise
only one animation node is shown at a time.

Change-Id: Ie4ecf69f5a3a1c56d8b3b489351dc2882efd6328
Reviewed-on: https://gerrit.libreoffice.org/41463Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: If7af0fc52b8684cca77fd3e85e15ef429801d6dd
Reviewed-on: https://gerrit.libreoffice.org/41542Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

Relative links were saved as:
file:///a/file.odt
instead of:
../a/file.odt

Relative path was based on source document, not target.

Unit test contains spreadsheet with relative link
to the "../xls/bug-fixes.xls" file.

Change-Id: I803b7b8936bde9644ae5760756ee7249677f2641
Reviewed-on: https://gerrit.libreoffice.org/41500Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

Change-Id: I02e2baec74f2b020ac1db2afb1b82928032ae036

Talking about names when those are numbers is confusing.

Change-Id: Icfeed8924daeb1d6f658118515f9d4a76229106e
Reviewed-on: https://gerrit.libreoffice.org/41540Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Similar to ODF, the spec mandates this, and recent enough epubcheck
validator asserts this.

Also backport 2 libepubgen commits that fix other validator errors
around missing mimetypes / malformed URLs.

Change-Id: I29f0524465a30d26585cea92ec27bd336f6a17d8
Reviewed-on: https://gerrit.libreoffice.org/41526Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

from AOO#32341
ODFF: OpCode 'ocUnion' to pass multiple ranges as one parameter

Change-Id: Ie718ccb43e7fac3b168ce56818c8b45cba51b94a
Reviewed-on: https://gerrit.libreoffice.org/41514Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: Iaaf9092ec4d6189492906648b84494d087fed81f
Reviewed-on: https://gerrit.libreoffice.org/41539Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iecf167f2018537476107d0850bef6f6e8ae344a4
Reviewed-on: https://gerrit.libreoffice.org/41494Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

the relevant usage sites already call GetRest() before comparing

Change-Id: I5e8ce3a3c2b6972810aa527356f6350c61b8bd63
Reviewed-on: https://gerrit.libreoffice.org/41470Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  b5d455e09862a98eba8209445f859de29c1e449e

tdf#112015 Spelling and Grammar -> Spelling

Valid for strings that refers to the menu, but not on
the descriptive pages, where the funcionality of spell check come
together with the grammar check.

Change-Id: If8a8e876782eed2da8f42d05726aa16e621fa062
Reviewed-on: https://gerrit.libreoffice.org/41548Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I5c07039e336de9362fdd92be29de516da0846998

Change-Id: Id5c3448b0cf82e5ed3aa9afabc5bfb093eddf2e9
Reviewed-on: https://gerrit.libreoffice.org/41524Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>

Thanks to infostud91@gmail.com for the document; unfortunately git
tells me that i can't set the commit author to just an email address.

Change-Id: I844e725d06cfa2a56adcd93aaa0a222fbb14028f

Previously SfxErrorHandler::CreateString() compared the entire error
code so >=/<= worked but now only the ErrCodeArea is compared,
so only </> works.

(regression from 15859554)

Change-Id: I8ac46de154f93a7109ec29d899c71bfb470d008c

The only value that ErrorHandler::GetErrorString() adds over
ErrorStringFactory::CreateString() is that it will delete the pInfo a
2nd time, because the ErrorInfo::GetErrorInfo() returns the same object
twice.

This may fix it, but it's generally hard to tell what this
brain damaged error handling code will do.

(regression from 1167df7d)

Change-Id: I22f446bee669cae8c5288bcc2f1e1d0299f5b384

Since we're already in #ifdef DBG_UTIL, we can also directly use SAL_WARN

Change-Id: Ic7c564f6c08e05eb9bd5928ef031f212def094aa
Reviewed-on: https://gerrit.libreoffice.org/41531Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Track ScHiddenRowsChanged collected cells and broadcast with ScDataChanged.

Change-Id: Id41d2731585f6749533319bf42ad655a845ecf30

Watermark was drawn under the page background.
It has to be placed on the upper layer to be visible.

Change-Id: I132a313eed6fb712aafdca14a38fe559aa4231c8
Reviewed-on: https://gerrit.libreoffice.org/41289Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

Fails with the writerperfect/source/writer/exp/txtparai.cxx part of
commit b6f39c47 (EPUB export: initial
index support, 2017-08-15) reverted.

Change-Id: I56457b3e3b312682e4c83ea08dbd459ca42152ef
Reviewed-on: https://gerrit.libreoffice.org/41518Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Two unit tests, which test the EMF+ records DrawString and DrawLine
independently.
To this end, a fixed view decomposition of metafiles is implemented.

The chosen primitives should be optimal, even for future extensions
of the EMF+ parser.

Change-Id: I12672d3b294ff0fdae63c7a5ce211517ef8f763c
Reviewed-on: https://gerrit.libreoffice.org/41425Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Renamed to just Spelling

Change-Id: I4433d75a8fd697e8d4dd25fa5d26411ed15b6c1b
Reviewed-on: https://gerrit.libreoffice.org/40717Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>

... when editing there, so the SvxAutoCorrect behaviour is synchronized.
Depends on commit 06d14411 that disentangles
the stateful SvxAutoCorrect instance.

Change-Id: Ic6aac1f2acc36b500144be50a20a4784a3ba62dc
Reviewed-on: https://gerrit.libreoffice.org/41521Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Shapes were deformed because flipping wasn't considered when removing
the rotation. Also WriteShapeTransformation needs information about
flipping to convert the angle correctly.

Change-Id: I7d485e93c00e02b9ec6c73ad6ae2876e5bc6360a
Reviewed-on: https://gerrit.libreoffice.org/41462Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I483fa998d140c8458948fe19c5338e7af0d32527
Reviewed-on: https://gerrit.libreoffice.org/41234Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Regression from:
acb2943c

Call this placeholder related code not only for
normal slide pages.

Change-Id: Iae185ac7e5d2505554692045516cc51dbdcd735b
Reviewed-on: https://gerrit.libreoffice.org/41517Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Columns tab is available in Format > Page and in Format > Section >
Options which makes this menu entry redundant

Change-Id: Ia637b7fe5c95ba075bad921cacb9d2e41e159cb8
Reviewed-on: https://gerrit.libreoffice.org/39017Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>

Change-Id: I4ef05b5bab1188cf349d1c7f5bbc9022bc79b21c
Reviewed-on: https://gerrit.libreoffice.org/41452Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: Iba249d4d8f7cc686941106983031bae53c7528e1
Reviewed-on: https://gerrit.libreoffice.org/41510Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

It's invalid input and also causes stack overflow.

Change-Id: Ie0b9dcaefcfcf254326151f345f4802ed66b994d

related to tdf#82173 and tdf#108949.
Write the footnote character properties now - otherwise they will
affect text incorrectly later on.

Change-Id: I33af1586a51f9028ef5b0d646e4ba3d746c77a2c
Reviewed-on: https://gerrit.libreoffice.org/40435Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

The relevant code has been moved to svl.

Change-Id: Id2b77c797745af21d3d5f954357a02d54fb67908
Reviewed-on: https://gerrit.libreoffice.org/41498Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

...after 9a7d2d72 "tell msvc our source code is
written using utf-8" did the equivalent for MSVC.  That should cause the C++
string literal u8"ßa" (in vcl/qa/cppunit/mnemonic.cxx) introduced with that
commit to reliably be interpreted as intended by all our toolchains.

Change-Id: Ibbda8588a3ca66d1c2764f70aa999fad243f1bb1

Change-Id: I89bcfaa605251912bd1f979b38f12e983dcaf76e
Reviewed-on: https://gerrit.libreoffice.org/41512Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>