Change-Id: I5b7cfaf602568d9254dfeafd6afe27b9b0895d37
Reviewed-on: https://gerrit.libreoffice.org/45722Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>

Change-Id: I76c567047b0033ae766ab6c5161c96416e478e8e
Reviewed-on: https://gerrit.libreoffice.org/45475Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ic2df4e402ce1e855fbf9d9f6d8a37e664d0110c7

Change-Id: Ia100a29aefaca81c5282f8077feb319f9d1809cb
Reviewed-on: https://gerrit.libreoffice.org/45850Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>

while variation 2 has two arguments

Change-Id: Ia2a9bd5e33b589b6e002da78d1a5b45d703565ef
Reviewed-on: https://gerrit.libreoffice.org/45926Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The previous code first tried the full tag and if not successful a
tag up to the first hyphen, which so far was the same as the
fallback chain but may differ for more sophisticated language tags
in the future.

Change-Id: I01dd8618c77c30e92a5fef6d01d0da56f70353f1

Change-Id: I6e5c7e644f26ca85a6c55ec5456add46a7b05404
Reviewed-on: https://gerrit.libreoffice.org/45927Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Fixed the a11y issue in layout AUTOLAYOUT_TITLE_2CONTENT_CONTENT
now the selection via keyboard works as requested

Change-Id: I034776393c8cca68d5cb3702f12111a057d4134b
Reviewed-on: https://gerrit.libreoffice.org/45907Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Multiplication of two B2DHomMatrix with operator* is very CPU expensive,
because 24 of double-precision floating point multiplication
needs to be performed.

With this patch I have reduced Multiplication of matrix,
by creating combined Scale and Transform matrix at once.
It allows to reduce matrix multiplication by one,
and improve import time.

Change-Id: I85fde6354e458659a0214514c6e05b8e2ee04185
Reviewed-on: https://gerrit.libreoffice.org/45704Reviewed-by: Patrick Jaap <patrick.jaap@tu-dresden.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

This class only has static member functions, nothing requires that
inheritance.

Change-Id: I31db802d0a9dcda01772b1e09a68af770868358d
Reviewed-on: https://gerrit.libreoffice.org/45924Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Project: help  c09e0355995d329cbd0c60ff7e6008c0f06b45df

Merge makelocal and makeonline into single script.

Scripts were identical; only difference is whether we pass
local yes/no to get_html.sh. Choice is now expressed via
first param to makehelp.sh; build local is default.

Change-Id: Icbe274fe6d9aeb86c7950aa69daf574e271e3b84
Reviewed-on: https://gerrit.libreoffice.org/45943Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Project: help  0b1c7e3c53f36b36f304270fd7aa455321dfd8fe

tdf#83269 Help page for Calc Data->Form...

Change-Id: If182e61aec29a912faa7af8e3d0791d03fcf1aca
Reviewed-on: https://gerrit.libreoffice.org/45937Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Project: help  9891e96d1d95c1921cba16c6339c15cf3613da0d

tdf#84675 Undocumented VBA function: MonthName

Change-Id: I3fa5e80dd94c281bdfd6e076f55e172c52be9ecb
Reviewed-on: https://gerrit.libreoffice.org/45757Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

since...

commit 3af8a4fa
Date:   Wed Nov 15 13:10:40 2017 +0300

    tdf#113861: Less aggressive expansion of chart headers.

In this example

nAllColCount is 3, nAllRowCount is 5, the columns available are 0, 1, 4 and the
rows are 20, 21, 22, 25, 26. So I assume, comparing to the original version,
that its not the actual row and column we want, but the index of the row/column
into the range provided

Change-Id: I568c561a8c5f0b2ee84590293bed8e302d5dda75
Reviewed-on: https://gerrit.libreoffice.org/45811Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

In the earlier approach, other state change events like SetText are
emitted which ends up in "else if !IsVisible()" block and tries to close
the floating window before it's even registered.

Interestingly, this is not the case every time. Anyhow, better safe than
sorry. Guard the floating window 'created', 'close' callbacks in a
StateChangeType::Visible event.

Change-Id: Ib997e11fd4a0f50b8911e9891918112e8ff8ef85

Change-Id: I92f60e717cd2a0695c8b86b103076d26c0c22cef

user config now needs it to collect user's private GPG keys

Change-Id: Ia4ad4133b621160cf37281750cafa9f3c5c3c231
Reviewed-on: https://gerrit.libreoffice.org/45562Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I53a967ab6ad5a6ed89dc807120dd1db540b26a92
Reviewed-on: https://gerrit.libreoffice.org/45894Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I6242f6028daaa0eb4d14134658e2eb50fd8f8275
Reviewed-on: https://gerrit.libreoffice.org/45932Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I853e2d6ec2e55c78894a9942aa201763a57fe195
Reviewed-on: https://gerrit.libreoffice.org/45900Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: I924713f360a41fa5b269468fdf771df6a50df44b
Reviewed-on: https://gerrit.libreoffice.org/45923Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: I35c34d427cc5440994fc16ed7e4d307bc95bc533
Reviewed-on: https://gerrit.libreoffice.org/45817Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Gülşah Köse <gulsah.1004@gmail.com>

At least recent libc++ has a std::string ctor overload without a (defaulted)
Allocator argument (which otherwise causes creation of a temporary Allocator
object and thus a ExprWithCleanups), so in C++17 mode (i.e., with no implicit
move CXXConstructExpr -> MaterializeTemporaryExpr -> CXXBindTemporaryExpr chain
in the way) CellInfo::toString (sw/source/filter/ww8/WW8TableInfo.cxx) has a
ReturnStmt of just

> ReturnStmt
> `-ImplicitCastExpr 'std::string':'class std::__1::basic_string<char>' <ConstructorConversion>
>   `-CXXConstructExpr 'std::string':'class std::__1::basic_string<char>' 'void (const char *)'
>     `-ImplicitCastExpr 'const char *' <NoOp>
>       `-ImplicitCastExpr 'char *' <ArrayToPointerDecay>
>         `-DeclRefExpr 'char [256]' lvalue Var 'sBuffer' 'char [256]'

that erroneously triggered loplugin:passstuffbyref.

Change-Id: I53c8911cb1356560692c003808280a103c399e25
Reviewed-on: https://gerrit.libreoffice.org/45916Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I7b09fb91f3d0d77851a84a015fc3e2fedc0153c7

Change-Id: Id3258a664c2ea740419331877f7ce6af5e2559e7
Reviewed-on: https://gerrit.libreoffice.org/45922Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

... with cppu::BaseMutex, because a member cannot ensure the life
cycle guarantees expected by WeakComponentImplHelper.

Change-Id: Iaa10c699abf69882d917487740db241ba1455e1c

Take a drawing rectangle in draw and cut and paste as bitmap to writer.  The
hairline border along the very right/bottom edge of the bitmap appear missing.

fallback to default handlers which can distort the hairline to be visible

Change-Id: Iedb580f65879628839c83e41092745ae7c11267c
Reviewed-on: https://gerrit.libreoffice.org/45902Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I434eebac395bbb53a0c586a43568f64ec3fb8448

Change-Id: I358b3c410bc7871c7184da4959b24b9f52b4a4d7
Reviewed-on: https://gerrit.libreoffice.org/45892Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I75ad9bcbc35ee2a0b9b7941cadc9b4bee79fb6c0
Reviewed-on: https://gerrit.libreoffice.org/45905Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I6df2ec0790e94008eba6a7d97256440db5a26ac7
Reviewed-on: https://gerrit.libreoffice.org/45870Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The classes ODatabaseDocument, ODatabaseModelImpl and
ODatabaseSource share a single mutex declared as
ModelDependentComponent::m_aMutex.

Commit 403eefe8 introduced
a new deadlock here: in case Yield is called, such as
when the user doesn't have a JRE and a dialog requesting
to install one is displayed, the SolarMutex is released
but the ModelDependentComponent mutex is still locked;
now another thread (such as the AsyncEventNotifier)
can lock the SolarMutex but not the other mutex,
while the main thread can't lock the SolarMutex again.

So the SolarMutex must be on the one hand be
locked before the other mutex, to ensure the behaviour
is the same whether the thread already holds it or not,
and locked after the other mutex, to prevent the Yield deadlock.

One option would be to revisit fca62934
and add back the SfxLibraryContainer mutex, but the code
there is a mess, naively assuming that locking the mutex on
UNO entry points is sufficient, taking no care to temporarily
release it while calling other UNO components or event listeners;
since there's about 5kLOC in all the related classes it
would take some time to rewrite all that.

An easier fix is to remove the ModelDependentComponent::m_aMutex.

This patch removes all locking of that m_aMutex, but it still
exists as a non-shared Mutex because it's needed for the
WeakComponentImplHelper base classes, which shouldn't cause issues.

Change-Id: I94aaa0ae8698188c98633c638100a309b20976cc
Reviewed-on: https://gerrit.libreoffice.org/45914Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I5c21f95f763f1491cc68087ecec0909493fd7f63

Change-Id: Ie3931deb3b39160a6f46dd744ea5b098904d55d2

Change-Id: Icf9309addd971c5d98d4057dba6619c4eef9ea6d

Change-Id: Iab95db31188ea2914a46d63a7ebef3d825e6ec42
Reviewed-on: https://gerrit.libreoffice.org/45851Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7e73878f263be57d91a1db2fc3d65d411bd49228
Reviewed-on: https://gerrit.libreoffice.org/45912Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...in various places, which is gone by default at least from recent libc++ in
C++17 mode.  So bring it back there for now, until Boost is fixed.

Change-Id: I0b3128d114ab2b5693a84bdc7d2b9b9b9b5c3c76
Reviewed-on: https://gerrit.libreoffice.org/45910Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

CXXFLAGS_CXX11 is for the compiler used to compile LO proper.  The plugin needs
to be compiled in a way compatible with compiling Clang, and the compiler and
any relevant flags can be controlled with COMPILER_PLUGINS_CXX.  (And at least
on macOS when compiling LO against a locally-built recent Clang trunk,
CXXFLAGS_CXX11 will now contain -std=gnu++17, but COMPILER_PLUGINS_CXX can still
point at Apple's Xcode clang++, which does not understand -std=gnu++17.)

Also, if COMPILER_PLUGINS_CXX is not set, simply default it to g++ instead of
trying to construct an acceptable CLANGCXX value from CXX (which would be
Clang).  (The problem with using Clang without CXXFLAGS_CXX11 is that Clang,
unlike GCC, typically defaults to C++03, but building compilerplugins requires
C++11 at least.  That would cause e.g. the Gerrit/Jenkins linux_clang_dbgutil_64
builds to fail---but which also needs COMPILER_PLUGINS_CXX to be explicitly set
to "g++ -std=c++11" as GCC on those machines is still 4.8.5 defaulting to
C++03.)

Change-Id: Id4ee4e54fa871cb6e621069cd050ae5b31922b34
Reviewed-on: https://gerrit.libreoffice.org/45856Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ie12a39dce136c78e786f805740d855a5d191082e
Reviewed-on: https://gerrit.libreoffice.org/45913Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>