Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b
Reviewed-on: https://gerrit.libreoffice.org/39737Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I4ee2df05ffceaea9d22ec7e2f78dc6e13061b5ef
Reviewed-on: https://gerrit.libreoffice.org/39714Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ie64ba38d607733b457d66ed1b9af84303c676e13
Reviewed-on: https://gerrit.libreoffice.org/39695Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and thus avoid crash when user clicks 'show signatures' button
in a window where signature bar shouldn't even be

Change-Id: I5eba8d1ddd8c76dd10acedfa03d732df586748de
Reviewed-on: https://gerrit.libreoffice.org/39699Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I53b5430d1563fcceae29418fd5907ac42ea856e7
Reviewed-on: https://gerrit.libreoffice.org/37626Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>

cowardly avoiding use of DrawViewShell in constructor

Change-Id: Ib40406d439403d0e2de270827bf5c2f06cfb18c2
Reviewed-on: https://gerrit.libreoffice.org/39368Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I2e57e9413f98de9a6d240c3c61c85fd7bd435498

Change-Id: Ia4517b01a39c02619ccae73e4c182ac8d7e6e22c

Change-Id: I6837937945749a0f44e4e50aae1267edb37921d7

Fun fact - CreateFileW returns INVALID_HANDLE_VALUE (-1_) because the
16-bit functions OPenFile, _lopen and _lcreat return -1, so the Win32
API function CreateFile function also returned INVALID_HANDLE_VALUE
to ease porting Win16 code to Win32.

CreateMutexW, on the other hand, had no corresponding function in
16-bit Windows so it returns NULL on failure.

cf. https://blogs.msdn.microsoft.com/oldnewthing/20040302-00/?p=40443
Raymond Chen is a gem who explains clearly why Win32 code is so
idiosyncratic.

Change-Id: I7888d46b048e5674ad776c8ac8070a1e57aa37a6

remove_copy_if copies entries for which predicate returns false.
since C++11 there is copy_if which copies entries for which
predicate returns true.

Change-Id: I3ade82f13d27364e2cd35f4286b18128f52f8a5b
Reviewed-on: https://gerrit.libreoffice.org/39727Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

Project: help  adc9f8c1cd429d2b3aea19efc8f5e7010a951240

Hyphenate compound adjective

Change-Id: I9114f0017335dff30a3273a55a4ac1610dcb1511

std::remove returns a past the end iterator which should be used
for the reallocation.

This makes the code more robust. Previously it only worked if
there was exactly one value with type XGeneratedResultSet in the
Sequence.

Change-Id: Ia2db1252ba8fe682dbc55d9722eaa62ed596e297
Reviewed-on: https://gerrit.libreoffice.org/39724Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ib530567df9cb487951d8dbf1b7824f78a7d150d9
Reviewed-on: https://gerrit.libreoffice.org/37581Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I766fedb34737a1a7815693bf496fa08c08f492b1
Reviewed-on: https://gerrit.libreoffice.org/39719Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Also simplify this class.

Change-Id: I7abccd19287101918a6d9b4636ce2faecf169123
Reviewed-on: https://gerrit.libreoffice.org/39446Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6e0e1a7f58873c012e0e8015ed69da38a32a44f4
Reviewed-on: https://gerrit.libreoffice.org/39323Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I5a3d64fd255fb8fd1f1caba572bc00a5399a6519
Reviewed-on: https://gerrit.libreoffice.org/39550Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Word appears to use negative z-indexes to indicate behind-text
zordering and positive numbers for in-front placement. This
was added for shapes in LO4.3, now applying to textboxes also.

Change-Id: I3b06fb231329f151ca978f3a68b4d4e89bc28515
Reviewed-on: https://gerrit.libreoffice.org/39671Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: Ieb89a2e69ae44fe1cfbe99e843239cf25e97463a
Reviewed-on: https://gerrit.libreoffice.org/39712Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: If1dd46643dc2ae9cc74ba94038609ae3445a416c
Reviewed-on: https://gerrit.libreoffice.org/39706Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

If DrawAspect is equal "Icon", show an icon not document preview
Document is opened in the separate window, not in-place.

Change-Id: I3a8d81e7340b29d247f8ac440c06b0420bb65644
Reviewed-on: https://gerrit.libreoffice.org/39440Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

As pointed out by sberg, either the issue is a programming error that
needs an assert, or the issue is unusual and should just generated a
warning, but never both.

Change-Id: I07ae1e99597cd6c342791aa268b2240db987ae91
Reviewed-on: https://gerrit.libreoffice.org/39514Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

See http://dbase.free.fr/tlcharge/structure%20tables.pdf

Change-Id: I68df30f73d2556a217f30d80d1d55ec93bca1564
Reviewed-on: https://gerrit.libreoffice.org/39710Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Iabc7293370c7a8b3fdccb00d6e1cdbfac4c46992
Reviewed-on: https://gerrit.libreoffice.org/39445Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

results are in the range of first_iterator to last_iterator.
If one of those is nullptr the algorithm would fail anyway.

This removes some impossible checks in
sw/source/core/unocore/unochart.cxx:
SwChartDataProvider::detectArguments.
A sorted range still holds the same values and has
the same length as the original range.
Replacing raw pointers eases reading this code.

Change-Id: If96bd11e9167488346a57e9e08507ac42338d3cd
Reviewed-on: https://gerrit.libreoffice.org/39683Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I99e3f1e1fe2f51c6c3891a6e508b468ec068cae0
Reviewed-on: https://gerrit.libreoffice.org/39539Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Whitespacing made consistent in function, and switch to more conventional
nullptr testing style.

Change-Id: I70921e9f79e8e0ebf4a74b84f73313aed033ec5b
Reviewed-on: https://gerrit.libreoffice.org/39538Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

I could not easily tell on first reading this function if Directory was
a pointer or not (it is), so changed name to pDirectory). The signature
was too long, so fixed this, whitespacing was inconsistent so small
change there. Also converted to more contentional testing of nullptr.

Change-Id: Ia8b1d33a4a4fbe3e050d63116997ef57a28d73b3
Reviewed-on: https://gerrit.libreoffice.org/39537Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

When I was reading this code, it wasn't entirely clear to me without
looking at the typedef of oslDirectory whether I was dealing with a
variable or a pointer, so I have changed this to pDirectory. I also
made a small tweak to the whitespace to help readability.

I also changed from explicit comparison to nullptr to the more
conventional style.

Change-Id: I4e9a69575733ab71a175d14a30c1976e6771ed5b
Reviewed-on: https://gerrit.libreoffice.org/39536Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

This should fix the issue, as well as restrict available
to return only non-negative values.

Change-Id: I198e226e945b9bd79dec32b1686c20e2a8dfaf3e
Reviewed-on: https://gerrit.libreoffice.org/39665Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

Add a constraint for bullet relative size to avoid too small
bullets which are hardly recognizable. Use the same 25% lower
limit what MSO uses.

Change-Id: Id956ecf3ec831c569188b944be58da03bf30a55e
Reviewed-on: https://gerrit.libreoffice.org/39696Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: If81d55aef96af4b764b62dc53a1986b5f0739d1e
Reviewed-on: https://gerrit.libreoffice.org/39698Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ia022f6cb1e9c91c9aa49025e54699a5c7718fc75

Commit b5e0a143 (tdf#108524 sw: attempt
to split section frames inside table cells, take two, 2017-07-03)
checked for tables in SwFrame::GetNextSctLeaf() when it considered
looking up the next "follow" cell frame.

But this is too general, in practice it is only necessary to look for
follow cell frames in case the frame in question is in a table, but not
in a table-in-section. This at the same time avoids a crash with tables
inside nested sections, as it happens in the bugdoc.

Change-Id: If648cb477be5492c7158f89934435ca7021a6a63
Reviewed-on: https://gerrit.libreoffice.org/39692Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

No longer need to compile with dbglevel=3 since
4dfa3161

Change-Id: I2dbc7ccd07abd191701c93534241ffd4dfef9df1

Half of these were around SAL_INFO which does its own checking of
OSL_DEBUG_LEVEL anyway, and the other half can check at runtime
the g_bDebugDisableCompression variable like PDFWriterImpl::MARK()
already does since commit 49968942.

Change-Id: Ic688eb643bde9253375e14e2e2233ece8dc7c18b

Change-Id: Ib5bdd594efd41eb881dfc4e2454b72e4739ffd56
Reviewed-on: https://gerrit.libreoffice.org/39693Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ica69cd4527f36edd7480d897a28ff814ecbe97a9

SwFltControlStack::SetAttrInDoc() will insert a RES_FLTR_ANNOTATIONMARK
without checking that there is actually a SwPostItField at that
position, which triggers the assertion "<AnnotationMark::InitDoc(..)> -
annotation field missing!" in AnnotationMark::InitDoc().

This happens when loading "crash-7.doc" which has a different kind of
field - a SwPageNameField - at that position.

In the WW8 filter, the SwPostItField is inserted in Read_And(),
the AnnotationMark in Read_AtnBook(), which look quite orthogonal.

Since it doesn't look like a valid document model to have the
AnnotationMark without its field, avoid inserting it in the filter.

Change-Id: I960d346601522b1a4d8644e538cde174763e99ff