Change-Id: Iba892694acb378887a1d15ab59104c55f591f0bd
Reviewed-on: https://gerrit.libreoffice.org/62498
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Found with bin/find-unneeded-includes after recent improvements
- remove UNO headers from blacklist
- remove newly found unneeded fw declarations
- fix up some not self contained headers

Change-Id: Ib262e361b62162d96ce8308500b1a41a971353df
Reviewed-on: https://gerrit.libreoffice.org/62258
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

* Update helpcontent2 from branch 'master'
  - tdf#118586 Base report 'Add field' Help page
    
    Change-Id: Ic76c408d3023bad5bc1eb8d7fd582965b83422b3
    Reviewed-on: https://gerrit.libreoffice.org/62461
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: I5b53e8d270f5b87cb3068943d35c17e1f041d1a5
Reviewed-on: https://gerrit.libreoffice.org/62497
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

bOn is implied when nCount is > 0

Change-Id: I77939668445603a22ae9ea56a7d272ca650c5c1c
Reviewed-on: https://gerrit.libreoffice.org/62499
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

The motivation for remembering the text glyphs was to avoid repeated layout
calls during one sw layout run, this still preserves that optimization.

Approximate numbers for memory usage after importing the bugdoc finished:

- old: 401MB

- new 366MB (91% of baseline)

Change-Id: Ie960c606a8246c9c696745b2dcc9a49c3c570c07
Reviewed-on: https://gerrit.libreoffice.org/62496Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: I90a2f05d40f79c005bec6b4bdb42cc6603521a80
Reviewed-on: https://gerrit.libreoffice.org/62495Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: I115d765bc781a926189605990e91c8e47f24d474
Reviewed-on: https://gerrit.libreoffice.org/62403
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

return value is ignored by call site, so just drop it

Change-Id: Ibba9b6b898d3277a44ccf864ba302d97282bffff
Reviewed-on: https://gerrit.libreoffice.org/62494
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ie40401e8706dda219b8578d180983811114cabed
Reviewed-on: https://gerrit.libreoffice.org/62208
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

No idea why this was initially commented out in
80d1ac7d "uitest findReplace; tdf#116242;
tdf#98417; tdf#39022".

Change-Id: Ic1357118080bc117158bf23cd7bb14038a19169e
Reviewed-on: https://gerrit.libreoffice.org/62493
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ibfdf92712264ad37aafed53db0fe8e8c4fea4699
Reviewed-on: https://gerrit.libreoffice.org/61913
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

new XCertificateCreator interface which can be used to create a
certificate and a associated private key, both in DER format

Change-Id: I24caf053f1f2b7357a836047b88b4ce418470eac
Reviewed-on: https://gerrit.libreoffice.org/61912
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

...as happens e.g. in
<https://ci.libreoffice.org/job/lo_daily_update_gandalf/515/>.  (Regression
introduced with d157e510
"check-elf-dynamic-objects: allow extending the whitelist via env-var".)

Change-Id: I93097d0bb7781b1bfac818872f40bbe38c5f5fea

Change-Id: Id0b1af277bd7ec367525663ec6d478d67cde0a40
Reviewed-on: https://gerrit.libreoffice.org/62431
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I9b63a515c407692f5632cb5e1f391593cfd68736
Reviewed-on: https://gerrit.libreoffice.org/62433
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

UITest_findReplace occasionally fails (esp. in slowly-executing builds like the
ASan+UBSan one, e.g., <https://ci.libreoffice.org/job/lo_ubsan/1084/>) because
the "Find" edit is re-filled with old content while the "Format..." sub-dialog
is executing:  The SfxBindings::NextJob timer fires from the main thread's
Application::Yield, calls SvxSearchController::StateChanged ->
SvxSearchDialog::SetItem_Impl -> SvxSearchDialog::Init_Impl, which goes into the

>       else if (!aSearchStrings.empty())
>       {
>           bool bAttributes =
>               ( ( pSearchList && pSearchList->Count() ) ||
>                 ( pReplaceList && pReplaceList->Count() ) );
>
>           if ( bSetSearch && !bAttributes )
>               m_pSearchLB->SetText(aSearchStrings[0]);

code re-filling the "Find" edit (despite it having been cleared
programatically), because bAttributes is false because the "Format..." sub-
dialog has not yet completed, so pSearchList has not yet been filled (as is done
by the handle_format_dlg code in test_find_writer in
sw/qa/uitest/findReplace/findReplace.py).  (This issue can be triggered rather
reliably by adding a sleep

> @@ -94,6 +94,7 @@ class findReplace(UITestCase):
>              xSizeFont.executeAction("BACKSPACE", tuple())
>              xSizeFont.executeAction("TYPE", mkPropertyValues({"TEXT":"16"}))    #set font size 16
>              xOkBtn = dialog.getChild("ok")
> +            time.sleep(1)
>              self.ui_test.close_dialog_through_button(xOkBtn)
>
>          self.ui_test.execute_blocking_action(format.executeAction, args=('CLICK', ()),

to sw/qa/uitest/findReplace/findReplace.py.)

So suppress executing SvxSearchController::StateChanged ->
SvxSearchDialog::SetItem_Impl while an SvxSearchDialog sub-dialog is in
progress.  The open TODO question is whether those state changes should be saved
and executed once the sub-dialog has been executed, or whether it is OK to just
throw them away (as happens now).

Change-Id: I20fb8c8d88c3d3fe8b604718bb289a7421471aa7
Reviewed-on: https://gerrit.libreoffice.org/62489
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Found while cleaning up unotools with IWYU
The same OStreamSection class is is implemented in comphelper
about since 2c23e695 (this was in 2000!)

Change-Id: I464ece9ff84536d5332caa0f285856d3fe358e5b
Reviewed-on: https://gerrit.libreoffice.org/62470
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I3ab2f3986955eb82451704fc2386b64f208da554
Reviewed-on: https://gerrit.libreoffice.org/61782
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I8c6917c63bbdcf0d9bb2eb1c89745186feb263f8
Reviewed-on: https://gerrit.libreoffice.org/61781Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I0516dc68cf7d451eafc044be8e50a66d2bddf15f
Reviewed-on: https://gerrit.libreoffice.org/62484
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

For the very last paragraph, if a header or footer was defined in
the section, then a dummy section was always being added, but that
should only happen if the section is different from the current one.
If they are the same, then the pageDesc will be created anyway, so
a dummy isn't needed to prevent it from getting lost.

Change-Id: I5e3a53e2810622c7232aa23575740bd775c5a595
Reviewed-on: https://gerrit.libreoffice.org/62430
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: I9def43c111adc877aeec9f1990f5dd76fabdbf8f
Reviewed-on: https://gerrit.libreoffice.org/62485
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

from datasource to spreadsheet

See bt here:
https://bugs.documentfoundation.org/attachment.cgi?id=146108

See related bugtrackers.

Change-Id: I2343e1468460b4e8036ce16060471763d344630a
Reviewed-on: https://gerrit.libreoffice.org/62482
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ib3344432a3fcf47a3c9704cc9603376e4754cb8f
Reviewed-on: https://gerrit.libreoffice.org/62480
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

A lot of signing code paths trigger a GUI dialog (to select the
certificate for example) which aren't acceptable when triggering
through the LOKit. This code paths needed to be duplicated and
reworked to not trigger any GUI action.

Change-Id: I2f0d6038fb1bcd00adcdf86e432f9df8858cc21c
Reviewed-on: https://gerrit.libreoffice.org/61780
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I5444e5076ca69e8f6f8d28e36f4e744721cf43ef
Reviewed-on: https://gerrit.libreoffice.org/62445
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: If7533650ae543f9d43a3a50fdfc137141fa64586
Reviewed-on: https://gerrit.libreoffice.org/62444
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I4b382271df21c58de0e102af6e0b07a88a1d9610
Reviewed-on: https://gerrit.libreoffice.org/62443
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

V547 Expression 'procHandle != nullptr' is always false.

The code was nonsensical overall. First, the launched process handle
was never returned by ShellExecuteExW, because SEE_MASK_NOCLOSEPROCESS
wasn't used, so GetProcessId couldn't succeed. Then, nullptr window
handle was passed to GetWindowThreadProcessId, thus never returning a
meaningful result.

This reimplements this to find the launched process' main window by
first waiting for process idle (up to 1-second delay is possible),
then enumerating all the top-level windows and checking their process.

Change-Id: I5fb4c04147b3f9414e27650a023f7844523c18bd
Reviewed-on: https://gerrit.libreoffice.org/62478
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Add back Ctrl+Shift+F10 undocking/docking handling. This regression was
introduced by me in tdf#115434 Fix key press misbehaviors in sidebar.

Change-Id: I29a563b2eb96be8a6b346454fddc1605dbc4aba6
Reviewed-on: https://gerrit.libreoffice.org/62268
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

* Update helpcontent2 from branch 'master'
  - The Bibliography Database window no longer has an Insert menu
    
    Change-Id: I07f85db5cd175c9941408c91ec68c70efcdba3da
    
  - Grammar
    
    Change-Id: I3d3bc317afd35bce5c941144417b7222e9063ae8
    

to allow working on packaging with epm without a baseline setup...

Change-Id: I9ab737cd52adf51c9eb23a4bc67f09c0ac06647e
Reviewed-on: https://gerrit.libreoffice.org/62454
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: Ib70cbcb392391c732f9d15a26722cf0dbdb8a56f
Reviewed-on: https://gerrit.libreoffice.org/62477
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I05f36d03acaabb92b212b8fc3ef30850e1179935
Reviewed-on: https://gerrit.libreoffice.org/62467Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Change-Id: Iaa1a1811b638aadfe6b06b3465a182cb675031b5
Reviewed-on: https://gerrit.libreoffice.org/62476
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Id71b22d81f6aee26239f7311031fc63523c7dec5
Reviewed-on: https://gerrit.libreoffice.org/62473
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Iae01c3e889ea38034332fc29e4cc397941930ac1
Reviewed-on: https://gerrit.libreoffice.org/62466
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I66a262953665cdb201bb06ddb3dc4bcd751119ed
Reviewed-on: https://gerrit.libreoffice.org/62468
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I2b2ea62ff4ed3e16cd4fa2a5e588d001d21121cb
Reviewed-on: https://gerrit.libreoffice.org/62465
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>