Change-Id: I58b7bb114864a9fdf901a92d54717964c6f1b68e
Reviewed-on: https://gerrit.libreoffice.org/71497
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Id130dd7739b9662541b50b7792da170da70a6a9b
Reviewed-on: https://gerrit.libreoffice.org/71496
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I51bd172cdd22d55a6800d1e74e38149874629f85
Reviewed-on: https://gerrit.libreoffice.org/71495
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Icce9c3c5fa826b6f5237d2d0e28fc51555a3e267
Reviewed-on: https://gerrit.libreoffice.org/71494
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I96113168d4ae8289cec3a5b0bbd6aa79faf97c48
Reviewed-on: https://gerrit.libreoffice.org/71493Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Ib851156da20528e7df5197ba96c35727af7bdbb6
Reviewed-on: https://gerrit.libreoffice.org/71492
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

* Update helpcontent2 from branch 'master'
  - Rename some menu-related help files for Impress and Draw
    
    The renamed files are in the process of heavy editing, so might
    as well move from obfuscated names to human-readable ones.
    
    Change-Id: I2df6470eefc3b8bb381de77471c688d9498854cf
    Reviewed-on: https://gerrit.libreoffice.org/71436
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: Ic0f143ea6871965a5d1e9db4b35db88f8adb5181
Reviewed-on: https://gerrit.libreoffice.org/71491
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

so use toggle and ignore toggle offs

Change-Id: Id6a9f3a7a9cf02d62ede00e4c246629406f9a64b
Reviewed-on: https://gerrit.libreoffice.org/71481
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I7aeca38c62c986041aab438e5d28bc8e6f0ccf2a
Reviewed-on: https://gerrit.libreoffice.org/71486
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: Iacaf5e19bb20dee471ebdc53977170312cf0fc5f
Reviewed-on: https://gerrit.libreoffice.org/71485
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: Ife3e99e0cf00d7d320eb8e403743d42fb8274df8
Reviewed-on: https://gerrit.libreoffice.org/71483
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Otherwise it can happen that the file is locked by someone
else during the saving method is running.
I just extended the scope of the existing DisableUnlockWebDAV()
calls a bit. In case of webdav it does not cause an issue to
avoid unlocking the file before locking it again with an other
SfxMedium.

Change-Id: I6ac4e3326c63c9e184a7710ce8994cac1ed79449
Reviewed-on: https://gerrit.libreoffice.org/71484
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

IMHO the old code was doing the opposite of the comment. But the
comment makes more sense then the code, so adjust the code
accordingly.

OTOH just this code was added in commit f89d70de ("INTEGRATION:
CWS vcl27 (1.30.48); FILE MERGED 2004/09/09 12:33:53 hdu
1.30.48.1: #116489# only apply asian kerning on default-formatted
text"). Maybe still a bug? Can't check the bug tracker, as this is
pre-Apache, and so can't verify the old bug :-(

Change-Id: I550d1524d3e82f7e853820d3e5ddab8cc62228f9
Reviewed-on: https://gerrit.libreoffice.org/71441
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

V595 The 'ustrFile' pointer was utilized before it was verified against nullptr.
     Check lines: 83, 107.

Change-Id: I874983508fb805b1f0a55b3a5b6d4d78ae1babdb
Reviewed-on: https://gerrit.libreoffice.org/71472
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

It's the same then

* (1 != c && 2 != c) || (3 != c)
* !(1 == c || 2 == c) || !(3 == c)
* !((1 == c || 2 == c) && (3 == c))

which is always true.

Change-Id: Ib63127319ff7e9c13877ac54aa92427637061812
Reviewed-on: https://gerrit.libreoffice.org/71477
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

This function is just used by ApplyAsianKerning, so move it there.
While at it drop the unused constant boolean. Same for the comment
referencing ImplCalcKerning, which is long gone since a huge
merge in commit 2f382d6c ("MWS_SRX644: migrate branch
mws_srx644 -> HEAD").

Also "const int"ify ApplyAsianKerning. No need for long, as the
lcl_CalcAsianKerning just returns int in the range [-2,+2].

Change-Id: I9b1b3351ab71219c8e2ee49ce441f5222e5c1c4b
Reviewed-on: https://gerrit.libreoffice.org/71476
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

to make it work under gtk3

Change-Id: I4c895181af233a16292ce16b194f0a60994446fb
Reviewed-on: https://gerrit.libreoffice.org/71478
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

See commit 60dca2de, which converted preceeding
OSL_ENSURE into asserts - so nullptr is considered impossible here.

Change-Id: Ia6d8f226d94c84a66bad67ce1b5f702864d61fdc
Reviewed-on: https://gerrit.libreoffice.org/71475
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V595 The 'pDoc' pointer was utilized before it was verified against nullptr.
     Check lines: 434, 460.

Change-Id: Iec92cbb8c4f5e47f7852015bf466b1f8ed195517
Reviewed-on: https://gerrit.libreoffice.org/71471
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V595 The 'GetMedium()' pointer was utilized before it was verified against nullptr.
     Check lines: 435, 455.

bURLChanged is only meaningful when GetMedium() is not nullptr;
otherwise bSaveDS could become true where no medium existed,
and dereferencing GetMedium() to find its URL would segfault.

Change-Id: I6f533acb3b1ca078803aa23bdece0ba2ee1d87c3
Reviewed-on: https://gerrit.libreoffice.org/71467
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V595 The 'pContact' pointer was utilized before it was verified against nullptr.
     Check lines: 1254, 1256.

Change-Id: I5d3d28b3c8a70924f329fde9f020f42d9eb5e9a1
Reviewed-on: https://gerrit.libreoffice.org/71459
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V595 The 'mpViewShell' pointer was utilized before it was verified against nullptr.
     Check lines: 96, 125.

Change-Id: I824c6cf8a5ed7f0ef20e99df36c83feec7fe54ea
Reviewed-on: https://gerrit.libreoffice.org/71468
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V595 The 'mpViewShell' pointer was utilized before it was verified against nullptr.
     Check lines: 193, 201.

Change-Id: I0d3cfee4d6f7bbb536c463b698361a1d299d2863
Reviewed-on: https://gerrit.libreoffice.org/71469
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V595 The 'GetActiveWindow()' pointer was utilized before it was verified against nullptr.
     Check lines: 544, 567.

Change-Id: I1ef45fa72542168ba88f24482973a1c660bcc1a8
Reviewed-on: https://gerrit.libreoffice.org/71470
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I92c83dcb9fd0fa3305aa2f40f6cc0d28fc0ad022
Reviewed-on: https://gerrit.libreoffice.org/71438
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I729d62520e9b59e96984f5d4b1aabd059f60d71d
Reviewed-on: https://gerrit.libreoffice.org/71437
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

V595 The 'pEndIdx' pointer was utilized before it was verified against nullptr.
     Check lines: 1328, 1347.

Change-Id: If9aff472e6ec7429ef2055b44dd11e62d4489ba4
Reviewed-on: https://gerrit.libreoffice.org/71458
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

pofs is guaranteed to be non-nullptr after getOutputStream, so no need
to check that. is_open() only matters to decide if close() is needed.

V595 The 'pofs' pointer was utilized before it was verified against nullptr.
     Check lines: 1033, 1057.
     Check lines: 1194, 1220.

Change-Id: I2dd22d29c465889269f2496f0964bee030cb5964
Reviewed-on: https://gerrit.libreoffice.org/71456
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

The result of GetDialogExampleSet is checked below.

Change-Id: Ic3f7820d6d6923e0ced518157ce41f6bc0de65a7
Reviewed-on: https://gerrit.libreoffice.org/71457
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V595 The 'pHdl' pointer was utilized before it was verified against nullptr.
     Check lines: 192, 197.

Change-Id: I52e1d1eadaded8616b8a27e0fcfaf6d1e6baa03e
Reviewed-on: https://gerrit.libreoffice.org/71455
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V581 The conditional expressions of the 'if' statements situated
     alongside each other are identical.

Change-Id: I99117fa7c04a5de565833be7bdc001d97e635d61
Reviewed-on: https://gerrit.libreoffice.org/71453
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

The strange implementation was there ever since commit
bd363380.

The other possibility is to just remove the block above the last
assignment to aRet

Change-Id: I5bd3bf1f518ab894e5df4cbc7d86a76d325e4600
Reviewed-on: https://gerrit.libreoffice.org/71447Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

V581 The conditional expressions of the 'if' statements situated
     alongside each other are identical.

Change-Id: I11fa13677c7980e6ac17fc4358406472ee784e41
Reviewed-on: https://gerrit.libreoffice.org/71446
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ia5809ac7ff74652e5d83ef2dbc176c4f586b7203
Reviewed-on: https://gerrit.libreoffice.org/71449
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Id6985abca7702039168381082da4e47603b9aaf3
Reviewed-on: https://gerrit.libreoffice.org/71451
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I8c928576919c9410eda0a7f33b2120d13c3bc6bf
Reviewed-on: https://gerrit.libreoffice.org/71450
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ic84773399c95d61f843e4388fe01d00cd4facc5a
Reviewed-on: https://gerrit.libreoffice.org/71425Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I95fd2d4e164bf04c4457b3e20401270227e21a8f
Reviewed-on: https://gerrit.libreoffice.org/71424Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I982a108b2241c049b595a13d6f39d24ef0266074
Reviewed-on: https://gerrit.libreoffice.org/71423
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>