Change-Id: I24c79c1a66ce2dc4cbb1736993643a8f4c14120c

Change-Id: I7ffe60d53f4c4b7690efc8bec9d29a4959740d9a

Change-Id: I36331a6caf560c7622f72c2fafa968522f44f5e9

Change-Id: I2daf0b0868d4bdfb412575b25dbe644e76607342

Change-Id: I1665228a622b18757951b725467933699f9871ae

Change-Id: I6faa8df32e57a846968423cfbe026ce96f6ca7e8

Change-Id: Ic6616f432178fe1f972c5f819302a4fb6b4154fd

Change-Id: I0a965f6957b74ff5db3aab54bef1fa05f3b594c7

Change-Id: If41080debabff46d849dbd6e7f29a941f294c6ad

Change-Id: I6dc7939f42aa1d1d62f8c71f5a5529becdffa704

Change-Id: I892498d323acd72757a05bac05d19c62f11f7cd3

Change-Id: Ia84473360333cb4905692a4d9d0358c93acebff8

and remove some dead ones

Change-Id: I6946d717d3c15dc5207489ed3d56d985dd953d59
Reviewed-on: https://gerrit.libreoffice.org/41746Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Idba9ad7a821cb33070cf5e5a0f79ae55db99b276
Reviewed-on: https://gerrit.libreoffice.org/41504Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>

For one, drop a spurious target="1.5" so that ant instead uses the passed-in
JAVA_TARGET_VER (which needs to be 1.6 for Java 9).

For another, the deprecated java.awt.Component.getPeer method finally got
removed, so bsh.util.AWTConsole would no longer compile.  But it looks like that
class is not used by us anyway, so just remove the problematic code.
(workdir/UnpackedTarball/beanshell/docs/manual/bshmanual.html: "Web Browser
Access:  After starting the server you can connect your web browser to the port
you specified.   BeanShell will respond by sending an HTML page offering you a
choice of the Swing based JConsole or the older AWTConsole.  You may choose
whichever is appropriate for your web browser.  [...]  The bsh.util.AWTConsole
is a legacy implementation of the GUI Console using AWT instead of Swing.  This
console does work, but it is not as slick or pretty as the JConsole.  The
primary reason it is still here is to support remote access from generic web
browsers using only Java 1.1.")

Change-Id: I9f1112caebae9a55e4eec7f9baa0114b2254ccda

Change-Id: I3c4d4f99b423f46136a79f3b06c5f0e1492872f1

...in 0660a30d "Avoid loplugin:constparam when
param is subject of cast to non-const pointer"

But turns out this whole avoidance is ill-advised and should eventually be
reverted:

Aug 31 09:09:26 <sberg> noelgrandin, the way you originally handled CastExpr in
 constparam's checkIfCanBeConst, your intent was if there's code like
 static_cast<T*>(p) and param p is found it can be made const, one would also
 need to change that cast to static_cast<T const *>(p) when fixing the loplugin
 warning, right?
Aug 31 09:09:43 <noelgrandin> sberg, correct
Aug 31 09:10:10 <sberg> noelgrandin, I messed the up with
 0660a30d
Aug 31 09:10:12 <IZBot> core - Avoid loplugin:constparam when param is subject
 of cast to non-const pointer -
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=0660a30d54eb6762302cf1afd43de01e137f6393
Aug 31 09:10:24 <noelgrandin> sberg, I probably should have had a test for that
Aug 31 09:10:41 <noelgrandin> tests are better at expressing intent
Aug 31 09:10:56 <sberg> I ran across it in a function that needed to have the
 param non-const for API reasons (callback fn), and it looked like the "obvious"
 fix there, not needing to add the fn to the blacklist
Aug 31 09:11:26 <sberg> I'll eventually get that fixed again (but want to first
 get the Mac and Windows builds to succeed)
Aug 31 09:11:44 <noelgrandin> fair enough

Change-Id: Idef0cfc417ec0597a26a29c8720e3e4051a68e00

and finds loplugin:constparams adapted to ObjCIvarRefExpr also

Change-Id: Ib803cd80b01ad7a0fa07bddb77a873bb323a50c0

Change-Id: I993ab0021d0a0bee8e78975bba180355d2bfb19c

Change-Id: I2d14eeea20d2622e06c7c34a1fa7e84439b3d224

Change-Id: I346a9760c0692449ce5301f5075b3de0271fdadf

Change-Id: I76f5702aad9b57f3031bc35b5271a5dde8ed4f28

since

    commit 990691b1
    Date:   Mon Nov 23 09:58:38 2015 +0200
    loplugin:unusedfields in sdext/

Change-Id: I89b7e59d37af8ba4093ca2e941219b29fd7bd726

moz1187869-1.doc crashes on export to ODF because an annotation
mark has been inserted that does not have a SwPostItField.

In fact, the SwPostItField exists, but the annotation mark is at
the wrong position.

There are 2 consecutive range annotations in the file, so when
Read_And() calls MoveAttrs(), the end of the both annotations
are moved 2 times, hence later SwFltControlStack::SetAttrInDoc()
will insert 2 annotation marks with the same end position,
and the 2nd one will overwrite the name that the 1st one set
on the 2nd SwPostItField, while the 1st SwPostItField remains
with an empty name.

Ensure that the end of an annotation mark is no longer moved
once it's on the position of the field inserted in Read_And().

Crash is a regression from 31c54fa7.

Change-Id: I0fd661e22e51701de67227f9145a13c62b10143e

... to specific 1899-12-30 vs. 1899-12-31 nulldate. Further check is needed to
do that only for OOXML transitional or dateCompatibility==true.

Change-Id: Ieecd3a5d061f900fbdec5bd9d1bf5ac61b966004

Change-Id: Ifbc2dffcb8db1511d5c08e51c972e822355f41c6
Reviewed-on: https://gerrit.libreoffice.org/41737Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I1c13392b4238fc8cdb1286b39c5eaaa62f7934cb
Reviewed-on: https://gerrit.libreoffice.org/41736Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

wrt widget heights and positions and other flakiness

take the natural combobox height as the line height, use a vclgrid
element for each row to get everything set to the same height

move the positioning code into Resize, etc.

Change-Id: I22de98ef91e39d1e7e45bbe62f68496d55c0c1cb
Reviewed-on: https://gerrit.libreoffice.org/41734Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Always write out a data layout name.

Change-Id: Ic0b43d9c0365eca5e417fe9f2fe4b77b538f3278
Reviewed-on: https://gerrit.libreoffice.org/41739Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I48518f26a3ccbe430d36fb6657bdeff0943492d3
Reviewed-on: https://gerrit.libreoffice.org/41263Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

...instead of adding something into the middle of the previous
external/rhino/rhino1_5R5.patch

Change-Id: I94a0e022776db67f50e785c45b0982977eec17f1

Change-Id: I76d7c8a41d64baae3591dd188a2d2e46f17622bb
Reviewed-on: https://gerrit.libreoffice.org/41735Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...as in entry_group_callback
(sd/source/ui/remotecontrol/AvahiNetworkService.cxx),

  AVAHI_GCC_UNUSED void *userdata

Change-Id: I494067878181c51b77d581a21ab1c9ef81e482e5

Change-Id: I4015a339ca18b214adca228b58319d897f0ad910

... and input doesn't match a date acceptance pattern, even if less than 3
digits in year.

Change-Id: Ib25aa8e813c06a224cfa95ead79c0f3bf2d2d672

...where at least <http://jdk.java.net/9/> "JDK 9 Early-Access Builds" 'java
-version' outputs a single-digit

  java version "9"

Change-Id: I7807f56593e5436418b49950ca6c2a178d6721f5

...which typically indicates that the param just has to be of the given type for
some reason

Change-Id: Ide30f514c5a849ae897c31c1744ece9df712a9fc

...as in WriteCallback (desktop/source/minidump/minidump.cxx), where

  void *ptr

is use in

  static_cast<char *>(ptr)

Change-Id: I0bd44329029cd793390d0744de3c839612e0b494

Change-Id: I0193ce3be582cb0a06cca17257b1e6587c5b3752

Change-Id: I8bc9fd2a3ad727f1a0f4b98254efdae085a2b8cd